<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195028] releases/WebKitGTK/webkit-2.10</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195028">195028</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-14 03:31:34 -0800 (Thu, 14 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/192513">r192513</a> - ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
https://bugs.webkit.org/show_bug.cgi?id=151025
Reviewed by Darin Adler.
Source/WebCore:
Negative margins could make RenderFlexibleBox compute negative
intrinsic sizes. Clamp intrinsic sizes to 0.
Test: css3/flexbox/negative-margins-assert.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
LayoutTests:
* css3/flexbox/negative-margins-assert-expected.txt: Added.
* css3/flexbox/negative-margins-assert.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCorerenderingRenderFlexibleBoxcpp">releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderFlexibleBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestscss3flexboxnegativemarginsassertexpectedtxt">releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestscss3flexboxnegativemarginsasserthtml">releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit210LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (195027 => 195028)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2016-01-14 11:30:20 UTC (rev 195027)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2016-01-14 11:31:34 UTC (rev 195028)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-11-17 Sergio Villar Senin <svillar@igalia.com>
+
+ ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
+ https://bugs.webkit.org/show_bug.cgi?id=151025
+
+ Reviewed by Darin Adler.
+
+ * css3/flexbox/negative-margins-assert-expected.txt: Added.
+ * css3/flexbox/negative-margins-assert.html: Added.
+
</ins><span class="cx"> 2015-11-16 Pranjal Jumde <pjumde@apple.com>
</span><span class="cx">
</span><span class="cx"> Checks for buffer-overflows when reading characters from textRun
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestscss3flexboxnegativemarginsassertexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt (0 => 195028)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt 2016-01-14 11:31:34 UTC (rev 195028)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASS if we don't assert
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestscss3flexboxnegativemarginsasserthtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert.html (0 => 195028)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert.html (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/css3/flexbox/negative-margins-assert.html 2016-01-14 11:31:34 UTC (rev 195028)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<!DOCTYPE html>
+<script>
+if (window.testRunner)
+ window.testRunner.dumpAsText();
+</script>
+<style>
+div {
+ display: flex;
+}
+
+.inner {
+ margin-left: -4em;
+}
+</style>
+
+<div>
+ <div>
+ <div class="inner">PASS if we don't assert</div>
+ </div>
+</div>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (195027 => 195028)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2016-01-14 11:30:20 UTC (rev 195027)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2016-01-14 11:31:34 UTC (rev 195028)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-11-17 Sergio Villar Senin <svillar@igalia.com>
+
+ ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
+ https://bugs.webkit.org/show_bug.cgi?id=151025
+
+ Reviewed by Darin Adler.
+
+ Negative margins could make RenderFlexibleBox compute negative
+ intrinsic sizes. Clamp intrinsic sizes to 0.
+
+ Test: css3/flexbox/negative-margins-assert.html
+
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
+
</ins><span class="cx"> 2015-11-16 Pranjal Jumde <pjumde@apple.com>
</span><span class="cx">
</span><span class="cx"> Fixes the buffer-overflow when reading characters from textRun
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCorerenderingRenderFlexibleBoxcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderFlexibleBox.cpp (195027 => 195028)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderFlexibleBox.cpp 2016-01-14 11:30:20 UTC (rev 195027)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderFlexibleBox.cpp 2016-01-14 11:31:34 UTC (rev 195028)
</span><span class="lines">@@ -123,6 +123,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // Due to negative margins, it is possible that we calculated a negative intrinsic width.
+ // Make sure that we never return a negative width.
+ minLogicalWidth = std::max(LayoutUnit(), minLogicalWidth);
</ins><span class="cx"> maxLogicalWidth = std::max(minLogicalWidth, maxLogicalWidth);
</span><span class="cx">
</span><span class="cx"> LayoutUnit scrollbarWidth = intrinsicScrollbarLogicalWidth();
</span></span></pre>
</div>
</div>
</body>
</html>