<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[195053] releases/WebKitGTK/webkit-2.10</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/195053">195053</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-14 05:54:53 -0800 (Thu, 14 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/192854">r192854</a> - Amazon.com Additional Information links aren't clickable
https://bugs.webkit.org/show_bug.cgi?id=151401
<rdar://problem/23454261>
Reviewed by Darin Adler.
Source/WebCore:
The cause of this issue is that the painting order is different from the hittest order so we can end up
with visible but unreachable content. To fix this, the executation flow of hittest has been reordered.
According to the paint system, which renders the webpage from the bottom RenderLayer to the top, contents
are rendered before floats. Hence, for the hittest, which determines the hitted location from top RenderLayer
to the bottom, should do it reversedly. Now, hittest will first test floats then contents.
Test: fast/block/float/hit-test-on-overlapping-floats.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
LayoutTests:
* fast/block/float/hit-test-on-overlapping-floats-expected.txt: Added.
* fast/block/float/hit-test-on-overlapping-floats.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCorerenderingRenderBlockcpp">releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlock.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsfastblockfloathittestonoverlappingfloatsexpectedtxt">releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsfastblockfloathittestonoverlappingfloatshtml">releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit210LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (195052 => 195053)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2016-01-14 13:53:18 UTC (rev 195052)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2016-01-14 13:54:53 UTC (rev 195053)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2015-11-30 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><ins>+ Amazon.com Additional Information links aren't clickable
+ https://bugs.webkit.org/show_bug.cgi?id=151401
+ <rdar://problem/23454261>
+
+ Reviewed by Darin Adler.
+
+ * fast/block/float/hit-test-on-overlapping-floats-expected.txt: Added.
+ * fast/block/float/hit-test-on-overlapping-floats.html: Added.
+
+2015-11-30 Jiewen Tan <jiewen_tan@apple.com>
+
</ins><span class="cx"> Null dereference loading Blink layout test http/tests/misc/detach-during-notifyDone.html
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149309
</span><span class="cx"> <rdar://problem/22748363>
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestsfastblockfloathittestonoverlappingfloatsexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt (0 => 195053)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt 2016-01-14 13:54:53 UTC (rev 195053)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+PASS document.elementFromPoint(450, 10) is document.getElementById('rightc')
+PASS successfullyParsed is true
+
+TEST COMPLETE
+foobar
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestsfastblockfloathittestonoverlappingfloatshtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html (0 => 195053)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html 2016-01-14 13:54:53 UTC (rev 195053)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <style>
+ #leftc {
+ float: left;
+ width: 500px;
+ background-color: silver;
+ margin-right: -100px;
+ }
+
+ #rightc {
+ float: right;
+ width: 400px;
+ background-color: rgba(0, 128, 0, 0.75);
+ padding-bottom: 1px;
+ }
+ </style>
+ </head>
+ <body>
+ <div style="width:800px">
+ <div id="leftc">foo</div>
+ <div id="rightc">bar</div>
+ <div style="height:0px; width:0px; clear:left;"></div>
+ </div>
+ <script src="../../../resources/js-test-pre.js"></script>
+ <script>
+ shouldBe("document.elementFromPoint(450, 10)", "document.getElementById('rightc')");
+ </script>
+ <script src="../../../resources/js-test-post.js"></script>
+ </body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (195052 => 195053)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2016-01-14 13:53:18 UTC (rev 195052)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2016-01-14 13:54:53 UTC (rev 195053)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2015-11-30 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><ins>+ Amazon.com Additional Information links aren't clickable
+ https://bugs.webkit.org/show_bug.cgi?id=151401
+ <rdar://problem/23454261>
+
+ Reviewed by Darin Adler.
+
+ The cause of this issue is that the painting order is different from the hittest order so we can end up
+ with visible but unreachable content. To fix this, the executation flow of hittest has been reordered.
+ According to the paint system, which renders the webpage from the bottom RenderLayer to the top, contents
+ are rendered before floats. Hence, for the hittest, which determines the hitted location from top RenderLayer
+ to the bottom, should do it reversedly. Now, hittest will first test floats then contents.
+
+ Test: fast/block/float/hit-test-on-overlapping-floats.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::nodeAtPoint):
+
+2015-11-30 Jiewen Tan <jiewen_tan@apple.com>
+
</ins><span class="cx"> Null dereference loading Blink layout test http/tests/misc/detach-during-notifyDone.html
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149309
</span><span class="cx"> <rdar://problem/22748363>
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCorerenderingRenderBlockcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlock.cpp (195052 => 195053)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlock.cpp 2016-01-14 13:53:18 UTC (rev 195052)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderBlock.cpp 2016-01-14 13:54:53 UTC (rev 195053)
</span><span class="lines">@@ -2472,12 +2472,12 @@
</span><span class="cx"> // Hit test descendants first.
</span><span class="cx"> LayoutSize scrolledOffset(localOffset - scrolledContentOffset());
</span><span class="cx">
</span><ins>+ if (hitTestAction == HitTestFloat && hitTestFloats(request, result, locationInContainer, toLayoutPoint(scrolledOffset)))
+ return true;
</ins><span class="cx"> if (hitTestContents(request, result, locationInContainer, toLayoutPoint(scrolledOffset), hitTestAction)) {
</span><span class="cx"> updateHitTestResult(result, flipForWritingMode(locationInContainer.point() - localOffset));
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><del>- if (hitTestAction == HitTestFloat && hitTestFloats(request, result, locationInContainer, toLayoutPoint(scrolledOffset)))
- return true;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Check if the point is outside radii.
</span></span></pre>
</div>
</div>
</body>
</html>