<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194996] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194996">194996</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2016-01-13 15:28:38 -0800 (Wed, 13 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>The StringFromCharCode DFG intrinsic should support untyped operands.
https://bugs.webkit.org/show_bug.cgi?id=153046
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The current StringFromCharCode DFG intrinsic assumes that its operand charCode
must be an Int32. This results in 26000+ BadType OSR exits in the LongSpider
crypto-aes benchmark. With support for Untyped operands, the number of OSR
exits drops to 202.
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::toUInt32):
LayoutTests:
* js/regress/ftl-polymorphic-StringFromCharCode-expected.txt: Added.
* js/regress/ftl-polymorphic-StringFromCharCode.html: Added.
* js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js: Added.
(o1.valueOf):
(foo):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGClobberizeh">trunk/Source/JavaScriptCore/dfg/DFGClobberize.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGFixupPhasecpp">trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGOperationscpp">trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGOperationsh">trunk/Source/JavaScriptCore/dfg/DFGOperations.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJITcpp">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJITh">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGValidatecpp">trunk/Source/JavaScriptCore/dfg/DFGValidate.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSCJSValueInlinesh">trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsregressftlpolymorphicStringFromCharCodeexpectedtxt">trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsregressftlpolymorphicStringFromCharCodehtml">trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode.html</a></li>
<li><a href="#trunkLayoutTestsjsregressscripttestsftlpolymorphicStringFromCharCodejs">trunk/LayoutTests/js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/LayoutTests/ChangeLog 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-01-13 Mark Lam <mark.lam@apple.com>
+
+ The StringFromCharCode DFG intrinsic should support untyped operands.
+ https://bugs.webkit.org/show_bug.cgi?id=153046
+
+ Reviewed by Geoffrey Garen.
+
+ * js/regress/ftl-polymorphic-StringFromCharCode-expected.txt: Added.
+ * js/regress/ftl-polymorphic-StringFromCharCode.html: Added.
+ * js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js: Added.
+ (o1.valueOf):
+ (foo):
+
</ins><span class="cx"> 2016-01-13 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Inspector should use the last sourceURL / sourceMappingURL directive
</span></span></pre></div>
<a id="trunkLayoutTestsjsregressftlpolymorphicStringFromCharCodeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode-expected.txt (0 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode-expected.txt (rev 0)
+++ trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode-expected.txt 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+JSRegress/ftl-polymorphic-StringFromCharCode
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsjsregressftlpolymorphicStringFromCharCodehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode.html (0 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode.html (rev 0)
+++ trunk/LayoutTests/js/regress/ftl-polymorphic-StringFromCharCode.html 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="../../resources/regress-pre.js"></script>
+<script src="script-tests/ftl-polymorphic-StringFromCharCode.js"></script>
+<script src="../../resources/regress-post.js"></script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsjsregressscripttestsftlpolymorphicStringFromCharCodejs"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js (0 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js (rev 0)
+++ trunk/LayoutTests/js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -0,0 +1,47 @@
</span><ins>+//@ runFTLNoCJIT
+var o1 = {
+ i: 65,
+ valueOf: function() { return this.i; }
+};
+
+result = 0;
+function foo(a) {
+ var result = String.fromCharCode(a);
+
+ // Busy work just to allow the DFG and FTL to optimize this. If the above causes
+ // us to speculation fail out to the baseline, this busy work will take a lot longer
+ // to run.
+ // This loop below also gets the DFG to compile this function sooner.
+ var count = 0;
+ for (var i = 0; i < 1000; i++)
+ count++;
+ return result + count;
+}
+noInline(foo);
+
+var iterations;
+var expectedResult;
+if (this.window) {
+ // The layout test doesn't like too many iterations and may time out.
+ iterations = 10000;
+ expectedResult = 10001;
+} else {
+ iterations = 100000;
+ expectedResult = 100001;
+}
+
+
+for (var i = 0; i <= iterations; i++) {
+ var resultStr;
+ if (i % 2 == 2)
+ resultStr = foo('65');
+ else if (i % 2 == 1)
+ resultStr = foo(o1);
+ else
+ resultStr = foo(65);
+ if (resultStr == 'A1000')
+ result++;
+}
+
+if (result != expectedResult)
+ throw "Bad result: " + result;
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2016-01-13 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><ins>+ The StringFromCharCode DFG intrinsic should support untyped operands.
+ https://bugs.webkit.org/show_bug.cgi?id=153046
+
+ Reviewed by Geoffrey Garen.
+
+ The current StringFromCharCode DFG intrinsic assumes that its operand charCode
+ must be an Int32. This results in 26000+ BadType OSR exits in the LongSpider
+ crypto-aes benchmark. With support for Untyped operands, the number of OSR
+ exits drops to 202.
+
+ * dfg/DFGClobberize.h:
+ (JSC::DFG::clobberize):
+ * dfg/DFGFixupPhase.cpp:
+ (JSC::DFG::FixupPhase::fixupNode):
+ * dfg/DFGOperations.cpp:
+ * dfg/DFGOperations.h:
+ * dfg/DFGSpeculativeJIT.cpp:
+ (JSC::DFG::SpeculativeJIT::compileFromCharCode):
+ * dfg/DFGSpeculativeJIT.h:
+ (JSC::DFG::SpeculativeJIT::callOperation):
+ * dfg/DFGValidate.cpp:
+ (JSC::DFG::Validate::validate):
+ * runtime/JSCJSValueInlines.h:
+ (JSC::JSValue::toUInt32):
+
+2016-01-13 Mark Lam <mark.lam@apple.com>
+
</ins><span class="cx"> Use DFG Graph::binary/unaryArithShouldSpeculateInt32/MachineInt() functions consistently.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=153080
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGClobberizeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGClobberize.h (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGClobberize.h 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/dfg/DFGClobberize.h 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -135,7 +135,6 @@
</span><span class="cx"> case GetScope:
</span><span class="cx"> case SkipScope:
</span><span class="cx"> case StringCharCodeAt:
</span><del>- case StringFromCharCode:
</del><span class="cx"> case CompareStrictEq:
</span><span class="cx"> case IsUndefined:
</span><span class="cx"> case IsBoolean:
</span><span class="lines">@@ -258,6 +257,20 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ case StringFromCharCode:
+ switch (node->child1().useKind()) {
+ case Int32Use:
+ def(PureValue(node));
+ return;
+ case UntypedUse:
+ read(World);
+ write(Heap);
+ return;
+ default:
+ DFG_CRASH(graph, node, "Bad use kind");
+ }
+ return;
+
</ins><span class="cx"> case ArithAdd:
</span><span class="cx"> case ArithNegate:
</span><span class="cx"> case ArithMod:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGFixupPhasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -602,6 +602,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> case StringFromCharCode:
</span><ins>+ if (node->child1()->shouldSpeculateUntypedForArithmetic()) {
+ fixEdge<UntypedUse>(node->child1());
+ break;
+ }
</ins><span class="cx"> fixEdge<Int32Use>(node->child1());
</span><span class="cx"> break;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGOperationscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -1313,6 +1313,15 @@
</span><span class="cx"> return JSC::stringFromCharCode(exec, op1);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+EncodedJSValue JIT_OPERATION operationStringFromCharCodeUntyped(ExecState* exec, EncodedJSValue encodedValue)
+{
+ VM* vm = &exec->vm();
+ NativeCallFrameTracer tracer(vm, exec);
+ JSValue charValue = JSValue::decode(encodedValue);
+ int32_t chInt = charValue.toUInt32(exec);
+ return JSValue::encode(JSC::stringFromCharCode(exec, chInt));
+}
+
</ins><span class="cx"> int64_t JIT_OPERATION operationConvertBoxedDoubleToInt52(EncodedJSValue encodedValue)
</span><span class="cx"> {
</span><span class="cx"> JSValue value = JSValue::decode(encodedValue);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGOperationsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGOperations.h (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGOperations.h 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/dfg/DFGOperations.h 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> extern "C" {
</span><span class="cx">
</span><span class="cx"> JSCell* JIT_OPERATION operationStringFromCharCode(ExecState*, int32_t) WTF_INTERNAL;
</span><ins>+EncodedJSValue JIT_OPERATION operationStringFromCharCodeUntyped(ExecState*, EncodedJSValue) WTF_INTERNAL;
</ins><span class="cx">
</span><span class="cx"> // These routines are provide callbacks out to C++ implementations of operations too complex to JIT.
</span><span class="cx"> JSCell* JIT_OPERATION operationCreateThis(ExecState*, JSObject* constructor, int32_t inlineCapacity) WTF_INTERNAL;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJITcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -1871,7 +1871,27 @@
</span><span class="cx">
</span><span class="cx"> void SpeculativeJIT::compileFromCharCode(Node* node)
</span><span class="cx"> {
</span><del>- SpeculateStrictInt32Operand property(this, node->child1());
</del><ins>+ Edge& child = node->child1();
+ if (child.useKind() == UntypedUse) {
+ JSValueOperand opr(this, child);
+ JSValueRegs oprRegs = opr.jsValueRegs();
+#if USE(JSVALUE64)
+ GPRTemporary result(this);
+ JSValueRegs resultRegs = JSValueRegs(result.gpr());
+#else
+ GPRTemporary resultTag(this);
+ GPRTemporary resultPayload(this);
+ JSValueRegs resultRegs = JSValueRegs(resultPayload.gpr(), resultTag.gpr());
+#endif
+ flushRegisters();
+ callOperation(operationStringFromCharCodeUntyped, resultRegs, oprRegs);
+ m_jit.exceptionCheck();
+
+ jsValueResult(resultRegs, node);
+ return;
+ }
+
+ SpeculateStrictInt32Operand property(this, child);
</ins><span class="cx"> GPRReg propertyReg = property.gpr();
</span><span class="cx"> GPRTemporary smallStrings(this);
</span><span class="cx"> GPRTemporary scratch(this);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJITh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -1409,6 +1409,10 @@
</span><span class="cx"> m_jit.setupArgumentsWithExecState(arg1);
</span><span class="cx"> return appendCallSetResult(operation, result);
</span><span class="cx"> }
</span><ins>+ JITCompiler::Call callOperation(J_JITOperation_EJ operation, JSValueRegs result, JSValueRegs arg1)
+ {
+ return callOperation(operation, result.payloadGPR(), arg1.payloadGPR());
+ }
</ins><span class="cx"> JITCompiler::Call callOperation(J_JITOperation_EJ operation, GPRReg result, GPRReg arg1)
</span><span class="cx"> {
</span><span class="cx"> m_jit.setupArgumentsWithExecState(arg1);
</span><span class="lines">@@ -1610,6 +1614,10 @@
</span><span class="cx"> m_jit.setupArgumentsWithExecState(arg1, arg2);
</span><span class="cx"> return appendCallSetResult(operation, resultPayload, resultTag);
</span><span class="cx"> }
</span><ins>+ JITCompiler::Call callOperation(J_JITOperation_EJ operation, JSValueRegs result, JSValueRegs arg1)
+ {
+ return callOperation(operation, result.tagGPR(), result.payloadGPR(), arg1.tagGPR(), arg1.payloadGPR());
+ }
</ins><span class="cx"> JITCompiler::Call callOperation(J_JITOperation_EJ operation, GPRReg resultPayload, GPRReg resultTag, GPRReg arg1)
</span><span class="cx"> {
</span><span class="cx"> m_jit.setupArgumentsWithExecState(arg1);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGValidatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGValidate.cpp (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGValidate.cpp 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/dfg/DFGValidate.cpp 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -264,6 +264,7 @@
</span><span class="cx"> VALIDATE((node), !!node->child2());
</span><span class="cx"> break;
</span><span class="cx"> case CheckStructure:
</span><ins>+ case StringFromCharCode:
</ins><span class="cx"> VALIDATE((node), !!node->child1());
</span><span class="cx"> break;
</span><span class="cx"> case PutStructure:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSCJSValueInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h (194995 => 194996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h 2016-01-13 23:11:02 UTC (rev 194995)
+++ trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h 2016-01-13 23:28:38 UTC (rev 194996)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">
</span><span class="cx"> inline uint32_t JSValue::toUInt32(ExecState* exec) const
</span><span class="cx"> {
</span><del>- // See comment on JSC::toUInt32, above.
</del><ins>+ // See comment on JSC::toUInt32, in JSCJSValue.h.
</ins><span class="cx"> return toInt32(exec);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>