<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194836] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194836">194836</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2016-01-10 19:25:57 -0800 (Sun, 10 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>B3 should reduce Trunc(BitOr(value, constant)) where !(constant & 0xffffffff) to Trunc(value)
https://bugs.webkit.org/show_bug.cgi?id=152955
Reviewed by Saam Barati.
This happens when we box an int32 and then immediately unbox it.
This makes an enormous difference on AsmBench/FloatMM. It's a 2x speed-up on that
benchmark. It's neutral elsewhere.
* b3/B3ReduceStrength.cpp:
* b3/testb3.cpp:
(JSC::B3::testPowDoubleByIntegerLoop):
(JSC::B3::testTruncOrHigh):
(JSC::B3::testTruncOrLow):
(JSC::B3::testBitAndOrHigh):
(JSC::B3::testBitAndOrLow):
(JSC::B3::zero):
(JSC::B3::run):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3B3ReduceStrengthcpp">trunk/Source/JavaScriptCore/b3/B3ReduceStrength.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3testb3cpp">trunk/Source/JavaScriptCore/b3/testb3.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (194835 => 194836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2016-01-11 01:38:36 UTC (rev 194835)
+++ trunk/Source/JavaScriptCore/ChangeLog        2016-01-11 03:25:57 UTC (rev 194836)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-01-10 Filip Pizlo <fpizlo@apple.com>
+
+ B3 should reduce Trunc(BitOr(value, constant)) where !(constant & 0xffffffff) to Trunc(value)
+ https://bugs.webkit.org/show_bug.cgi?id=152955
+
+ Reviewed by Saam Barati.
+
+ This happens when we box an int32 and then immediately unbox it.
+
+ This makes an enormous difference on AsmBench/FloatMM. It's a 2x speed-up on that
+ benchmark. It's neutral elsewhere.
+
+ * b3/B3ReduceStrength.cpp:
+ * b3/testb3.cpp:
+ (JSC::B3::testPowDoubleByIntegerLoop):
+ (JSC::B3::testTruncOrHigh):
+ (JSC::B3::testTruncOrLow):
+ (JSC::B3::testBitAndOrHigh):
+ (JSC::B3::testBitAndOrLow):
+ (JSC::B3::zero):
+ (JSC::B3::run):
+
</ins><span class="cx"> 2016-01-10 Skachkov Oleksandr <gskachkov@gmail.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Arrow function syntax. Get rid of JSArrowFunction and use standard JSFunction class
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3B3ReduceStrengthcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/B3ReduceStrength.cpp (194835 => 194836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/B3ReduceStrength.cpp        2016-01-11 01:38:36 UTC (rev 194835)
+++ trunk/Source/JavaScriptCore/b3/B3ReduceStrength.cpp        2016-01-11 03:25:57 UTC (rev 194836)
</span><span class="lines">@@ -418,6 +418,27 @@
</span><span class="cx"> m_value->child(0)->child(0), m_value->child(0)->child(1));
</span><span class="cx"> m_changed = true;
</span><span class="cx"> }
</span><ins>+
+ // Turn this: BitAnd(Op(value, constant1), constant2)
+ // where !(constant1 & constant2)
+ // and Op is BitOr or BitXor
+ // into this: BitAnd(value, constant2)
+ if (m_value->child(1)->hasInt()) {
+ int64_t constant2 = m_value->child(1)->asInt();
+ switch (m_value->child(0)->opcode()) {
+ case BitOr:
+ case BitXor:
+ if (m_value->child(0)->child(1)->hasInt()
+ && !(m_value->child(0)->child(1)->asInt() & constant2)) {
+ m_value->child(0) = m_value->child(0)->child(0);
+ m_changed = true;
+ break;
+ }
+ break;
+ default:
+ break;
+ }
+ }
</ins><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> case BitOr:
</span><span class="lines">@@ -779,6 +800,26 @@
</span><span class="cx"> m_changed = true;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><ins>+
+ // Turn this: Trunc(Op(value, constant))
+ // where !(constant & 0xffffffff)
+ // and Op is Add, Sub, BitOr, or BitXor
+ // into this: Trunc(value)
+ switch (m_value->child(0)->opcode()) {
+ case Add:
+ case Sub:
+ case BitOr:
+ case BitXor:
+ if (m_value->child(0)->child(1)->hasInt64()
+ && !(m_value->child(0)->child(1)->asInt64() & 0xffffffffll)) {
+ m_value->child(0) = m_value->child(0)->child(0);
+ m_changed = true;
+ break;
+ }
+ break;
+ default:
+ break;
+ }
</ins><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> case FloatToDouble:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3testb3cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/testb3.cpp (194835 => 194836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/testb3.cpp        2016-01-11 01:38:36 UTC (rev 194835)
+++ trunk/Source/JavaScriptCore/b3/testb3.cpp        2016-01-11 03:25:57 UTC (rev 194836)
</span><span class="lines">@@ -8869,6 +8869,80 @@
</span><span class="cx"> CHECK(isIdentical(compileAndRun<double>(proc, xOperand, yOperand), pow(xOperand, yOperand)));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void testTruncOrHigh()
+{
+ Procedure proc;
+ BasicBlock* root = proc.addBlock();
+
+ root->appendNew<ControlValue>(
+ proc, Return, Origin(),
+ root->appendNew<Value>(
+ proc, Trunc, Origin(),
+ root->appendNew<Value>(
+ proc, BitOr, Origin(),
+ root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR0),
+ root->appendNew<Const64Value>(proc, Origin(), 0x100000000))));
+
+ int64_t value = 0x123456781234;
+ CHECK(compileAndRun<int>(proc, value) == 0x56781234);
+}
+
+void testTruncOrLow()
+{
+ Procedure proc;
+ BasicBlock* root = proc.addBlock();
+
+ root->appendNew<ControlValue>(
+ proc, Return, Origin(),
+ root->appendNew<Value>(
+ proc, Trunc, Origin(),
+ root->appendNew<Value>(
+ proc, BitOr, Origin(),
+ root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR0),
+ root->appendNew<Const64Value>(proc, Origin(), 0x1000000))));
+
+ int64_t value = 0x123456781234;
+ CHECK(compileAndRun<int>(proc, value) == 0x57781234);
+}
+
+void testBitAndOrHigh()
+{
+ Procedure proc;
+ BasicBlock* root = proc.addBlock();
+
+ root->appendNew<ControlValue>(
+ proc, Return, Origin(),
+ root->appendNew<Value>(
+ proc, BitAnd, Origin(),
+ root->appendNew<Value>(
+ proc, BitOr, Origin(),
+ root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR0),
+ root->appendNew<Const64Value>(proc, Origin(), 0x8)),
+ root->appendNew<Const64Value>(proc, Origin(), 0x777777777777)));
+
+ int64_t value = 0x123456781234;
+ CHECK(compileAndRun<int64_t>(proc, value) == 0x123456701234ll);
+}
+
+void testBitAndOrLow()
+{
+ Procedure proc;
+ BasicBlock* root = proc.addBlock();
+
+ root->appendNew<ControlValue>(
+ proc, Return, Origin(),
+ root->appendNew<Value>(
+ proc, BitAnd, Origin(),
+ root->appendNew<Value>(
+ proc, BitOr, Origin(),
+ root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR0),
+ root->appendNew<Const64Value>(proc, Origin(), 0x1)),
+ root->appendNew<Const64Value>(proc, Origin(), 0x777777777777)));
+
+ int64_t value = 0x123456781234;
+ CHECK(compileAndRun<int64_t>(proc, value) == 0x123456701235ll);
+}
+
</ins><span class="cx"> void testBranch64Equal(int64_t left, int64_t right)
</span><span class="cx"> {
</span><span class="cx"> Procedure proc;
</span><span class="lines">@@ -10230,6 +10304,11 @@
</span><span class="cx"> RUN(testSelectInvert());
</span><span class="cx"> RUN_BINARY(testPowDoubleByIntegerLoop, floatingPointOperands<double>(), int64Operands());
</span><span class="cx">
</span><ins>+ RUN(testTruncOrHigh());
+ RUN(testTruncOrLow());
+ RUN(testBitAndOrHigh());
+ RUN(testBitAndOrLow());
+
</ins><span class="cx"> RUN(testBranch64Equal(0, 0));
</span><span class="cx"> RUN(testBranch64Equal(1, 1));
</span><span class="cx"> RUN(testBranch64Equal(-1, -1));
</span></span></pre>
</div>
</div>
</body>
</html>