<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194723] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194723">194723</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-07 14:11:33 -0800 (Thu, 07 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Add indicator that element has pseudo-class in DOM tree
https://bugs.webkit.org/show_bug.cgi?id=152680
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-01-07
Reviewed by Timothy Hatcher.
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement):
(WebInspector.DOMTreeElement.prototype._nodePseudoClassesDidChange):
Added an event listener to the node for when pseudo-classes change.
* UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline li.pseudo-class-enabled > .selection::before):
(.dom-tree-outline:focus li.selected.pseudo-class-enabled > .selection::before):
Used the hover/selected background style element to ensure that the indicator
is always positioned evenly with the first line of the opening tag.
(.dom-tree-outline li.hovered:not(.selected) .selection):
(.dom-tree-outline li .selection):
(.dom-tree-outline li.selected .selection):
(.dom-tree-outline li.elements-drag-over .selection):
Removed "display: none;" (as well as the "block" declarations) to allow
the ::before pseudo-element to display.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinecss">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (194722 => 194723)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-01-07 22:10:45 UTC (rev 194722)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-01-07 22:11:33 UTC (rev 194723)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2016-01-07 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Add indicator that element has pseudo-class in DOM tree
+ https://bugs.webkit.org/show_bug.cgi?id=152680
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement):
+ (WebInspector.DOMTreeElement.prototype._nodePseudoClassesDidChange):
+ Added an event listener to the node for when pseudo-classes change.
+
+ * UserInterface/Views/DOMTreeOutline.css:
+ (.dom-tree-outline li.pseudo-class-enabled > .selection::before):
+ (.dom-tree-outline:focus li.selected.pseudo-class-enabled > .selection::before):
+ Used the hover/selected background style element to ensure that the indicator
+ is always positioned evenly with the first line of the opening tag.
+
+ (.dom-tree-outline li.hovered:not(.selected) .selection):
+ (.dom-tree-outline li .selection):
+ (.dom-tree-outline li.selected .selection):
+ (.dom-tree-outline li.elements-drag-over .selection):
+ Removed "display: none;" (as well as the "block" declarations) to allow
+ the ::before pseudo-element to display.
+
+2016-01-07 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Make creating new rules in the Styles sidebar simpler
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=152726
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (194722 => 194723)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2016-01-07 22:10:45 UTC (rev 194722)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2016-01-07 22:11:33 UTC (rev 194723)
</span><span class="lines">@@ -44,6 +44,8 @@
</span><span class="cx">
</span><span class="cx"> this._nodeStateChanges = [];
</span><span class="cx"> this._boundNodeChangedAnimationEnd = this._nodeChangedAnimationEnd.bind(this);
</span><ins>+
+ node.addEventListener(WebInspector.DOMNode.Event.EnabledPseudoClassesChanged, this._nodePseudoClassesDidChange, this);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> isCloseTag()
</span><span class="lines">@@ -1523,6 +1525,14 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ _nodePseudoClassesDidChange(event)
+ {
+ if (this._elementCloseTag)
+ return;
+
+ this._listItemNode.classList.toggle("pseudo-class-enabled", !!this.representedObject.enabledPseudoClasses.length);
+ }
+
</ins><span class="cx"> _fireDidChange()
</span><span class="cx"> {
</span><span class="cx"> super._fireDidChange();
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinecss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css (194722 => 194723)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css 2016-01-07 22:10:45 UTC (rev 194722)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css 2016-01-07 22:11:33 UTC (rev 194723)
</span><span class="lines">@@ -40,12 +40,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .dom-tree-outline li.hovered:not(.selected) .selection {
</span><del>- display: block;
</del><span class="cx"> background-color: hsla(209, 100%, 49%, 0.1);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .dom-tree-outline li .selection {
</span><del>- display: none;
</del><span class="cx"> position: absolute;
</span><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><span class="lines">@@ -54,12 +52,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .dom-tree-outline li.selected .selection {
</span><del>- display: block;
</del><span class="cx"> background-color: hsl(0, 0%, 83%);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .dom-tree-outline li.elements-drag-over .selection {
</span><del>- display: block;
</del><span class="cx"> margin-top: -2px;
</span><span class="cx"> border-top: 2px solid hsl(209, 100%, 49%);
</span><span class="cx"> }
</span><span class="lines">@@ -98,6 +94,18 @@
</span><span class="cx"> word-wrap: break-word;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.dom-tree-outline li.pseudo-class-enabled > .selection::before {
+ display: inline-block;
+ position: absolute;
+ top: 4px;
+ left: 2px;
+ width: 5px;
+ height: 5px;
+ content: "";
+ background-color: hsl(212, 92%, 54%);
+ border-radius: 50%;
+}
+
</ins><span class="cx"> .dom-tree-outline.single-node li {
</span><span class="cx"> padding-left: 2px;
</span><span class="cx"> }
</span><span class="lines">@@ -106,6 +114,10 @@
</span><span class="cx"> color: white;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.dom-tree-outline:focus li.selected.pseudo-class-enabled > .selection::before {
+ background-color: hsl(0, 100%, 100%);
+}
+
</ins><span class="cx"> .dom-tree-outline:focus li.selected * {
</span><span class="cx"> color: inherit;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>