<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194731] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194731">194731</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2016-01-07 15:15:50 -0800 (Thu, 07 Jan 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove unused shouldAntialias parameter from GraphicsContext::computeLineBoundsAndAntialiasingModeForText()
https://bugs.webkit.org/show_bug.cgi?id=152859

Reviewed by Simon Fraser.

No change in functionality.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText):
(WebCore::GraphicsContext::drawLinesForText):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText):
(WebCore::GraphicsContext::drawLinesForText):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsContextcpp">trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsContexth">trunk/Source/WebCore/platform/graphics/GraphicsContext.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscairoGraphicsContextCairocpp">trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscgGraphicsContextCGcpp">trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (194730 => 194731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-01-07 22:59:43 UTC (rev 194730)
+++ trunk/Source/WebCore/ChangeLog        2016-01-07 23:15:50 UTC (rev 194731)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-01-07  Zalan Bujtas  &lt;zalan@apple.com&gt;
+
+        Remove unused shouldAntialias parameter from GraphicsContext::computeLineBoundsAndAntialiasingModeForText()
+        https://bugs.webkit.org/show_bug.cgi?id=152859
+
+        Reviewed by Simon Fraser.
+
+        No change in functionality.
+
+        * platform/graphics/GraphicsContext.cpp:
+        (WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):
+        * platform/graphics/GraphicsContext.h:
+        * platform/graphics/cairo/GraphicsContextCairo.cpp:
+        (WebCore::GraphicsContext::computeLineBoundsForText):
+        (WebCore::GraphicsContext::drawLinesForText):
+        * platform/graphics/cg/GraphicsContextCG.cpp:
+        (WebCore::GraphicsContext::computeLineBoundsForText):
+        (WebCore::GraphicsContext::drawLinesForText):
+
</ins><span class="cx"> 2016-01-07  Brady Eidson  &lt;beidson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Modern IDB: imported/w3c/indexeddb/idbcursor-continue.htm fails.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (194730 => 194731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp        2016-01-07 22:59:43 UTC (rev 194730)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp        2016-01-07 23:15:50 UTC (rev 194731)
</span><span class="lines">@@ -985,17 +985,13 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-FloatRect GraphicsContext::computeLineBoundsAndAntialiasingModeForText(const FloatPoint&amp; point, float width, bool printing, bool&amp; shouldAntialias, Color&amp; color)
</del><ins>+FloatRect GraphicsContext::computeLineBoundsAndAntialiasingModeForText(const FloatPoint&amp; point, float width, bool printing, Color&amp; color)
</ins><span class="cx"> {
</span><span class="cx">     FloatPoint origin = point;
</span><span class="cx">     float thickness = std::max(strokeThickness(), 0.5f);
</span><span class="cx"> 
</span><del>-    shouldAntialias = true;
</del><span class="cx">     if (!printing) {
</span><span class="cx">         AffineTransform transform = getCTM(GraphicsContext::DefinitelyIncludeDeviceScale);
</span><del>-        if (transform.preservesAxisAlignment())
-            shouldAntialias = false;
-
</del><span class="cx">         // This code always draws a line that is at least one-pixel line high,
</span><span class="cx">         // which tends to visually overwhelm text at small scales. To counter this
</span><span class="cx">         // effect, an alpha is applied to the underline color when text is at small scales.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (194730 => 194731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h        2016-01-07 22:59:43 UTC (rev 194730)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h        2016-01-07 23:15:50 UTC (rev 194731)
</span><span class="lines">@@ -599,7 +599,7 @@
</span><span class="cx"> 
</span><span class="cx">     void platformFillRoundedRect(const FloatRoundedRect&amp;, const Color&amp;);
</span><span class="cx"> 
</span><del>-    FloatRect computeLineBoundsAndAntialiasingModeForText(const FloatPoint&amp;, float width, bool printing, bool&amp; shouldAntialias, Color&amp;);
</del><ins>+    FloatRect computeLineBoundsAndAntialiasingModeForText(const FloatPoint&amp;, float width, bool printing,  Color&amp;);
</ins><span class="cx"> 
</span><span class="cx">     GraphicsContextPlatformPrivate* m_data;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscairoGraphicsContextCairocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (194730 => 194731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp        2016-01-07 22:59:43 UTC (rev 194730)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp        2016-01-07 23:15:50 UTC (rev 194731)
</span><span class="lines">@@ -648,9 +648,8 @@
</span><span class="cx"> 
</span><span class="cx"> FloatRect GraphicsContext::computeLineBoundsForText(const FloatPoint&amp; origin, float width, bool printing)
</span><span class="cx"> {
</span><del>-    bool dummyBool;
</del><span class="cx">     Color dummyColor;
</span><del>-    return computeLineBoundsAndAntialiasingModeForText(origin, width, printing, dummyBool, dummyColor);
</del><ins>+    return computeLineBoundsAndAntialiasingModeForText(origin, width, printing, dummyColor);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void GraphicsContext::drawLineForText(const FloatPoint&amp; origin, float width, bool printing, bool doubleUnderlines)
</span><span class="lines">@@ -671,8 +670,7 @@
</span><span class="cx"> 
</span><span class="cx">     Color localStrokeColor(strokeColor());
</span><span class="cx"> 
</span><del>-    bool shouldAntialiasLine;
-    FloatRect bounds = computeLineBoundsAndAntialiasingModeForText(point, widths.last(), printing, shouldAntialiasLine, localStrokeColor);
</del><ins>+    FloatRect bounds = computeLineBoundsAndAntialiasingModeForText(point, widths.last(), printing, localStrokeColor);
</ins><span class="cx"> 
</span><span class="cx">     Vector&lt;FloatRect, 4&gt; dashBounds;
</span><span class="cx">     ASSERT(!(widths.size() % 2));
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscgGraphicsContextCGcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (194730 => 194731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp        2016-01-07 22:59:43 UTC (rev 194730)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp        2016-01-07 23:15:50 UTC (rev 194731)
</span><span class="lines">@@ -1321,9 +1321,8 @@
</span><span class="cx"> 
</span><span class="cx"> FloatRect GraphicsContext::computeLineBoundsForText(const FloatPoint&amp; point, float width, bool printing)
</span><span class="cx"> {
</span><del>-    bool dummyBool;
</del><span class="cx">     Color dummyColor;
</span><del>-    return computeLineBoundsAndAntialiasingModeForText(point, width, printing, dummyBool, dummyColor);
</del><ins>+    return computeLineBoundsAndAntialiasingModeForText(point, width, printing, dummyColor);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void GraphicsContext::drawLineForText(const FloatPoint&amp; point, float width, bool printing, bool doubleLines)
</span><span class="lines">@@ -1344,8 +1343,7 @@
</span><span class="cx"> 
</span><span class="cx">     Color localStrokeColor(strokeColor());
</span><span class="cx"> 
</span><del>-    bool shouldAntialiasLine;
-    FloatRect bounds = computeLineBoundsAndAntialiasingModeForText(point, widths.last(), printing, shouldAntialiasLine, localStrokeColor);
</del><ins>+    FloatRect bounds = computeLineBoundsAndAntialiasingModeForText(point, widths.last(), printing, localStrokeColor);
</ins><span class="cx">     bool fillColorIsNotEqualToStrokeColor = fillColor() != localStrokeColor;
</span><span class="cx">     
</span><span class="cx">     Vector&lt;CGRect, 4&gt; dashBounds;
</span></span></pre>
</div>
</div>

</body>
</html>