<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194667] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194667">194667</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-01-06 14:08:43 -0800 (Wed, 06 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] Revert overflow:hidden on the body affecting viewport scale (<a href="http://trac.webkit.org/projects/webkit/changeset/186786">r186786</a>)
https://bugs.webkit.org/show_bug.cgi?id=152803
rdar://problem/22242515
Reviewed by Tim Horton.
Source/WebCore:
You can't assume that if an author uses overflow:hidden on the body, they have no
content outside the body that is important. Sites like Google Translate put
abspos elements outside the body.
So revert the change.
* page/FrameView.cpp:
(WebCore::FrameView::contentsSizeRespectingOverflow): Deleted.
* page/FrameView.h:
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView _contentsSizeRespectingOverflow]): Keep this function which is used
by UIKit, but change the implementation to just return the document size.
Source/WebKit2:
You can't assume that if an author uses overflow:hidden on the body, they have no
content outside the body that is important. Sites like Google Translate put
abspos elements outside the body.
So revert the change.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mainFrameDidLayout): Go back to using contents size.
LayoutTests:
Keep the tests, but update their expected results.
* platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt:
* platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt:
* platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorfastviewportioswidthisdevicewidthoverflowingbodyoverflowhiddenexpectedtxt">trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorfastviewportioswidthisdevicewidthoverflowingbodyoverflowhiddentallexpectedtxt">trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorfastviewportioswidthisdevicewidthoverflowingexpectedtxt">trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewh">trunk/Source/WebCore/page/FrameView.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/LayoutTests/ChangeLog 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-01-06 Simon Fraser <simon.fraser@apple.com>
+
+ [iOS] Revert overflow:hidden on the body affecting viewport scale (r186786)
+ https://bugs.webkit.org/show_bug.cgi?id=152803
+ rdar://problem/22242515
+
+ Reviewed by Tim Horton.
+
+ Keep the tests, but update their expected results.
+
+ * platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt:
+ * platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt:
+ * platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt:
+
</ins><span class="cx"> 2016-01-06 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Port blocking bypass issue using 307 redirect
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorfastviewportioswidthisdevicewidthoverflowingbodyoverflowhiddenexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> Viewport: width=device-width
</span><span class="cx">
</span><del>-scale 5.00000
</del><ins>+scale 1.00000
</ins><span class="cx"> maxScale 5.00000
</span><del>-minScale 5.00000
-visibleRect {"left":"0.00000","top":"0.00000","width":"64.00000","height":"96.00000"}
</del><ins>+minScale 1.00000
+visibleRect {"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"}
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorfastviewportioswidthisdevicewidthoverflowingbodyoverflowhiddentallexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> Viewport: width=device-width
</span><span class="cx">
</span><del>-scale 1.05263
</del><ins>+scale 0.46875
</ins><span class="cx"> maxScale 5.00000
</span><del>-minScale 1.05263
-visibleRect {"left":"0.00000","top":"0.00000","width":"303.99999","height":"455.99998"}
</del><ins>+minScale 0.46875
+visibleRect {"left":"0.00000","top":"0.00000","width":"682.66667","height":"1024.00000"}
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorfastviewportioswidthisdevicewidthoverflowingexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> Viewport: width=device-width
</span><span class="cx">
</span><del>-scale 0.31746
</del><ins>+scale 1.00000
</ins><span class="cx"> maxScale 5.00000
</span><del>-minScale 0.31746
-visibleRect {"left":"0.00000","top":"0.00000","width":"1007.99997","height":"1511.99995"}
</del><ins>+minScale 1.00000
+visibleRect {"left":"0.00000","top":"0.00000","width":"320.00000","height":"480.00000"}
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/Source/WebCore/ChangeLog 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-01-06 Simon Fraser <simon.fraser@apple.com>
+
+ [iOS] Revert overflow:hidden on the body affecting viewport scale (r186786)
+ https://bugs.webkit.org/show_bug.cgi?id=152803
+ rdar://problem/22242515
+
+ Reviewed by Tim Horton.
+
+ You can't assume that if an author uses overflow:hidden on the body, they have no
+ content outside the body that is important. Sites like Google Translate put
+ abspos elements outside the body.
+
+ So revert the change.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::contentsSizeRespectingOverflow): Deleted.
+ * page/FrameView.h:
+
</ins><span class="cx"> 2016-01-06 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Port blocking bypass issue using 307 redirect
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/Source/WebCore/page/FrameView.cpp 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -646,30 +646,6 @@
</span><span class="cx"> setContentsSize(size);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-IntSize FrameView::contentsSizeRespectingOverflow() const
-{
- RenderView* renderView = this->renderView();
- auto* viewportRenderer = this->viewportRenderer();
- if (!renderView || !is<RenderBox>(viewportRenderer) || !frame().isMainFrame())
- return contentsSize();
-
- ASSERT(frame().view() == this);
-
- FloatRect contentRect = renderView->unscaledDocumentRect();
- RenderBox& viewportRendererBox = downcast<RenderBox>(*viewportRenderer);
-
- if (viewportRendererBox.style().overflowX() == OHIDDEN)
- contentRect.setWidth(std::min<float>(contentRect.width(), viewportRendererBox.frameRect().width()));
-
- if (viewportRendererBox.style().overflowY() == OHIDDEN)
- contentRect.setHeight(std::min<float>(contentRect.height(), viewportRendererBox.frameRect().height()));
-
- if (renderView->hasTransform())
- contentRect = renderView->layer()->currentTransform().mapRect(contentRect);
-
- return IntSize(contentRect.size());
-}
-
</del><span class="cx"> void FrameView::applyOverflowToViewport(const RenderElement& renderer, ScrollbarMode& hMode, ScrollbarMode& vMode)
</span><span class="cx"> {
</span><span class="cx"> // Handle the overflow:hidden/scroll case for the body/html elements. WinIE treats
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.h (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.h 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/Source/WebCore/page/FrameView.h 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -105,8 +105,6 @@
</span><span class="cx"> virtual void setContentsSize(const IntSize&) override;
</span><span class="cx"> virtual void updateContentsSize() override;
</span><span class="cx">
</span><del>- WEBCORE_EXPORT IntSize contentsSizeRespectingOverflow() const;
-
</del><span class="cx"> void layout(bool allowSubtree = true);
</span><span class="cx"> WEBCORE_EXPORT bool didFirstLayout() const;
</span><span class="cx"> void layoutTimerFired();
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-01-06 Simon Fraser <simon.fraser@apple.com>
+
+ [iOS] Revert overflow:hidden on the body affecting viewport scale (r186786)
+ https://bugs.webkit.org/show_bug.cgi?id=152803
+ rdar://problem/22242515
+
+ Reviewed by Tim Horton.
+
+ * WebView/WebView.mm:
+ (-[WebView _contentsSizeRespectingOverflow]): Keep this function which is used
+ by UIKit, but change the implementation to just return the document size.
+
</ins><span class="cx"> 2016-01-04 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Turn on gesture events when building for Yosemite
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1567,11 +1567,9 @@
</span><span class="cx"> return _private->page->renderTreeSize();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+// FIXME: This is incorrectly named, and should be removed <rdar://problem/22242515>.
</ins><span class="cx"> - (NSSize)_contentsSizeRespectingOverflow
</span><span class="cx"> {
</span><del>- if (FrameView* view = [self _mainCoreFrame]->view())
- return view->contentsSizeRespectingOverflow();
-
</del><span class="cx"> return [[[[self mainFrame] frameView] documentView] bounds].size;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/Source/WebKit2/ChangeLog 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-01-06 Simon Fraser <simon.fraser@apple.com>
+
+ [iOS] Revert overflow:hidden on the body affecting viewport scale (r186786)
+ https://bugs.webkit.org/show_bug.cgi?id=152803
+ rdar://problem/22242515
+
+ Reviewed by Tim Horton.
+
+ You can't assume that if an author uses overflow:hidden on the body, they have no
+ content outside the body that is important. Sites like Google Translate put
+ abspos elements outside the body.
+
+ So revert the change.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::mainFrameDidLayout): Go back to using contents size.
+
</ins><span class="cx"> 2016-01-06 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a smart block pointer
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (194666 => 194667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-01-06 22:07:51 UTC (rev 194666)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-01-06 22:08:43 UTC (rev 194667)
</span><span class="lines">@@ -3536,7 +3536,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> if (FrameView* frameView = mainFrameView()) {
</span><del>- IntSize newContentSize = frameView->contentsSizeRespectingOverflow();
</del><ins>+ IntSize newContentSize = frameView->contentsSize();
</ins><span class="cx"> if (m_viewportConfiguration.setContentsSize(newContentSize))
</span><span class="cx"> viewportConfigurationChanged();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>