<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194611] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194611">194611</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-05 14:49:04 -0800 (Tue, 05 Jan 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Analysis task page is slow to load
https://bugs.webkit.org/show_bug.cgi?id=152517
Reviewed by Andreas Kling.
The slowness comes from <a href="http://trac.webkit.org/projects/webkit/changeset/194130">r194130</a> which made the JSON API at /api/analysis-tasks to report the start
and the end of each analysis task. This query was adding ~2s to the total JSON generation time.
Cache these values on analysis_task table since they never change once an analysis task is created.
* init-database.sql: Added columns task_start_run_time and task_end_run_time to analysis_task table.
Also added the missing drop statements at the top.
* public/api/analysis-tasks.php:
(fetch_and_push_bugs_to_tasks): Don't fetch the latest commit time of the start and the end.
(format_task): Report task_start_run_time and task_end_run_time as startRunTime and endRunTime.
* public/privileged-api/create-analysis-task.php:
(main): Set start_run_time and end_run_time when creating an analysis task.
(time_for_run): Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorginitdatabasesql">trunk/Websites/perf.webkit.org/init-database.sql</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicapianalysistasksphp">trunk/Websites/perf.webkit.org/public/api/analysis-tasks.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicprivilegedapicreateanalysistaskphp">trunk/Websites/perf.webkit.org/public/privileged-api/create-analysis-task.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (194610 => 194611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-01-05 22:45:23 UTC (rev 194610)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-01-05 22:49:04 UTC (rev 194611)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2015-12-22 Ryosuke Niwa <rniwa@webkit.org>
+
+ Analysis task page is slow to load
+ https://bugs.webkit.org/show_bug.cgi?id=152517
+
+ Reviewed by Andreas Kling.
+
+ The slowness comes from r194130 which made the JSON API at /api/analysis-tasks to report the start
+ and the end of each analysis task. This query was adding ~2s to the total JSON generation time.
+
+ Cache these values on analysis_task table since they never change once an analysis task is created.
+
+ * init-database.sql: Added columns task_start_run_time and task_end_run_time to analysis_task table.
+ Also added the missing drop statements at the top.
+
+ * public/api/analysis-tasks.php:
+ (fetch_and_push_bugs_to_tasks): Don't fetch the latest commit time of the start and the end.
+ (format_task): Report task_start_run_time and task_end_run_time as startRunTime and endRunTime.
+
+ * public/privileged-api/create-analysis-task.php:
+ (main): Set start_run_time and end_run_time when creating an analysis task.
+ (time_for_run): Added.
+
</ins><span class="cx"> 2015-12-17 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> v3 UI shouldn't open/close pane selector by mouseenter/leave
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorginitdatabasesql"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/init-database.sql (194610 => 194611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/init-database.sql 2016-01-05 22:45:23 UTC (rev 194610)
+++ trunk/Websites/perf.webkit.org/init-database.sql 2016-01-05 22:49:04 UTC (rev 194611)
</span><span class="lines">@@ -17,6 +17,8 @@
</span><span class="cx"> DROP TABLE tracker_repositories CASCADE;
</span><span class="cx"> DROP TABLE bug_trackers CASCADE;
</span><span class="cx"> DROP TABLE analysis_tasks CASCADE;
</span><ins>+DROP TABLE analysis_strategies CASCADE;
+DROP TYPE analysis_task_result_type CASCADE;
</ins><span class="cx"> DROP TABLE build_triggerables CASCADE;
</span><span class="cx"> DROP TABLE triggerable_configurations CASCADE;
</span><span class="cx"> DROP TABLE triggerable_repositories CASCADE;
</span><span class="lines">@@ -191,7 +193,9 @@
</span><span class="cx"> task_platform integer REFERENCES platforms NOT NULL,
</span><span class="cx"> task_metric integer REFERENCES test_metrics NOT NULL,
</span><span class="cx"> task_start_run integer REFERENCES test_runs,
</span><ins>+ task_start_run_time timestamp,
</ins><span class="cx"> task_end_run integer REFERENCES test_runs,
</span><ins>+ task_end_run_time timestamp,
</ins><span class="cx"> task_result analysis_task_result_type,
</span><span class="cx"> task_needed boolean,
</span><span class="cx"> CONSTRAINT analysis_task_should_be_unique_for_range UNIQUE(task_start_run, task_end_run),
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicapianalysistasksphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/api/analysis-tasks.php (194610 => 194611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/api/analysis-tasks.php 2016-01-05 22:45:23 UTC (rev 194610)
+++ trunk/Websites/perf.webkit.org/public/api/analysis-tasks.php 2016-01-05 22:49:04 UTC (rev 194611)
</span><span class="lines">@@ -75,35 +75,6 @@
</span><span class="cx"> $task['finishedBuildRequestCount'] = $build_count['finished'];
</span><span class="cx"> }
</span><span class="cx">
</span><del>- $run_ids = array();
- $task_by_run = array();
- foreach ($tasks as &$task) {
- if ($task['startRun']) {
- array_push($run_ids, $task['startRun']);
- $task_by_run[$task['startRun']] = &$task;
- }
- if ($task['endRun']) {
- array_push($run_ids, $task['endRun']);
- $task_by_run[$task['endRun']] = &$task;
- }
- }
-
- // FIXME: This query is quite expensive. We may need to store this directly in analysis_tasks table instead.
- $build_revision_times = $db->query_and_fetch_all('SELECT run_id, build_time, max(commit_time) AS revision_time
- FROM builds
- LEFT OUTER JOIN build_commits ON commit_build = build_id
- LEFT OUTER JOIN commits ON build_commit = commit_id, test_runs
- WHERE run_build = build_id AND run_id = ANY($1) GROUP BY build_id, run_id',
- array('{' . implode(', ', $run_ids) . '}'));
- foreach ($build_revision_times as &$row) {
- $time = $row['revision_time'] or $row['build_time'];
- $id = $row['run_id'];
- if ($task_by_run[$id]['startRun'] == $id)
- $task_by_run[$id]['startRunTime'] = Database::to_js_time($time);
- if ($task_by_run[$id]['endRun'] == $id)
- $task_by_run[$id]['endRunTime'] = Database::to_js_time($time);
- }
-
</del><span class="cx"> return $bugs;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -118,7 +89,9 @@
</span><span class="cx"> 'platform' => $task_row['task_platform'],
</span><span class="cx"> 'metric' => $task_row['task_metric'],
</span><span class="cx"> 'startRun' => $task_row['task_start_run'],
</span><ins>+ 'startRunTime' => Database::to_js_time($task_row['task_start_run_time']),
</ins><span class="cx"> 'endRun' => $task_row['task_end_run'],
</span><ins>+ 'endRunTime' => Database::to_js_time($task_row['task_end_run_time']),
</ins><span class="cx"> 'category' => $task_row['task_result'] ? 'bisecting' : 'unconfirmed',
</span><span class="cx"> 'result' => $task_row['task_result'],
</span><span class="cx"> 'needed' => $task_row['task_needed'] ? Database::is_true($task_row['task_needed']) : null,
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicprivilegedapicreateanalysistaskphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/privileged-api/create-analysis-task.php (194610 => 194611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/privileged-api/create-analysis-task.php 2016-01-05 22:45:23 UTC (rev 194610)
+++ trunk/Websites/perf.webkit.org/public/privileged-api/create-analysis-task.php 2016-01-05 22:49:04 UTC (rev 194611)
</span><span class="lines">@@ -25,6 +25,11 @@
</span><span class="cx">
</span><span class="cx"> $config = ensure_config_from_runs($db, $start_run, $end_run);
</span><span class="cx">
</span><ins>+ $start_run_time = time_for_run($db, $start_run_id);
+ $end_run_time = time_for_run($db, $end_run_id);
+ if (!$start_run_time || !$end_run_time)
+ exit_with_error('InvalidTimeRange', array('startTime' => $start_run_time, 'endTime' => $end_run_time));
+
</ins><span class="cx"> $db->begin_transaction();
</span><span class="cx">
</span><span class="cx"> $segmentation_id = NULL;
</span><span class="lines">@@ -57,7 +62,9 @@
</span><span class="cx"> 'platform' => $config['config_platform'],
</span><span class="cx"> 'metric' => $config['config_metric'],
</span><span class="cx"> 'start_run' => $start_run_id,
</span><ins>+ 'start_run_time' => $start_run_time,
</ins><span class="cx"> 'end_run' => $end_run_id,
</span><ins>+ 'end_run_time' => $end_run_time,
</ins><span class="cx"> 'segmentation' => $segmentation_id,
</span><span class="cx"> 'test_range' => $test_range_id));
</span><span class="cx"> $db->commit_transaction();
</span><span class="lines">@@ -81,6 +88,15 @@
</span><span class="cx"> return ensure_row_by_id($db, 'test_configurations', 'config', $start_run['run_config'], 'ConfigNotFound', $range);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function time_for_run($db, $run_id) {
+ $result = $db->query_and_fetch_all('SELECT max(commit_time) as time
+ FROM test_runs JOIN builds ON run_build = build_id
+ JOIN build_commits ON commit_build = build_id
+ JOIN commits ON build_commit = commit_id
+ WHERE run_id = $1', array($run_id));
+ return $result ? $result[0]['time'] : null;
+}
+
</ins><span class="cx"> main();
</span><span class="cx">
</span><span class="cx"> ?>
</span></span></pre>
</div>
</div>
</body>
</html>