<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194531] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194531">194531</a></dd>
<dt>Author</dt> <dd>ossy@webkit.org</dd>
<dt>Date</dt> <dd>2016-01-04 08:09:15 -0800 (Mon, 04 Jan 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>JSC generator scripts shouldn't have verbose output
https://bugs.webkit.org/show_bug.cgi?id=152382

Reviewed by Michael Catanzaro.

* b3/air/opcode_generator.rb:
* generate-bytecode-files:
* offlineasm/asm.rb:
* offlineasm/generate_offset_extractor.rb:
* offlineasm/parser.rb:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3airopcode_generatorrb">trunk/Source/JavaScriptCore/b3/air/opcode_generator.rb</a></li>
<li><a href="#trunkSourceJavaScriptCoregeneratebytecodefiles">trunk/Source/JavaScriptCore/generate-bytecode-files</a></li>
<li><a href="#trunkSourceJavaScriptCoreofflineasmasmrb">trunk/Source/JavaScriptCore/offlineasm/asm.rb</a></li>
<li><a href="#trunkSourceJavaScriptCoreofflineasmgenerate_offset_extractorrb">trunk/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb</a></li>
<li><a href="#trunkSourceJavaScriptCoreofflineasmparserrb">trunk/Source/JavaScriptCore/offlineasm/parser.rb</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (194530 => 194531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2016-01-04 13:35:14 UTC (rev 194530)
+++ trunk/Source/JavaScriptCore/ChangeLog        2016-01-04 16:09:15 UTC (rev 194531)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-01-04  Csaba Osztrogon√°c  &lt;ossy@webkit.org&gt;
+
+        JSC generator scripts shouldn't have verbose output
+        https://bugs.webkit.org/show_bug.cgi?id=152382
+
+        Reviewed by Michael Catanzaro.
+
+        * b3/air/opcode_generator.rb:
+        * generate-bytecode-files:
+        * offlineasm/asm.rb:
+        * offlineasm/generate_offset_extractor.rb:
+        * offlineasm/parser.rb:
+
</ins><span class="cx"> 2016-01-04  Benjamin Poulain  &lt;bpoulain@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [JSC] Build B3 by default on iOS ARM64
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3airopcode_generatorrb"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/air/opcode_generator.rb (194530 => 194531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/air/opcode_generator.rb        2016-01-04 13:35:14 UTC (rev 194530)
+++ trunk/Source/JavaScriptCore/b3/air/opcode_generator.rb        2016-01-04 16:09:15 UTC (rev 194531)
</span><span class="lines">@@ -456,8 +456,6 @@
</span><span class="cx"> parser = Parser.new(IO::read($fileName), $fileName)
</span><span class="cx"> $opcodes = parser.parse
</span><span class="cx"> 
</span><del>-$stderr.puts &quot;Generating code for #{$fileName}.&quot;
-
</del><span class="cx"> def writeH(filename)
</span><span class="cx">     File.open(&quot;Air#{filename}.h&quot;, &quot;w&quot;) {
</span><span class="cx">         | outp |
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoregeneratebytecodefiles"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/generate-bytecode-files (194530 => 194531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/generate-bytecode-files        2016-01-04 13:35:14 UTC (rev 194530)
+++ trunk/Source/JavaScriptCore/generate-bytecode-files        2016-01-04 16:09:15 UTC (rev 194531)
</span><span class="lines">@@ -154,24 +154,14 @@
</span><span class="cx">             initBytecodesReadFile.close()
</span><span class="cx"> 
</span><span class="cx">     if not needToGenerate:
</span><del>-        print &quot;Nothing changed.\n&quot;
</del><span class="cx">         exit(0)
</span><span class="cx"> 
</span><del>-    genString = &quot;Generating &quot;
-
</del><span class="cx">     if bytecodeHFilename:
</span><span class="cx">         bytecodeHFile = openOrExit(bytecodeHFilename, &quot;wb&quot;)
</span><del>-        genString = genString + &quot;{0} &quot;.format(bytecodeHFilename)
</del><span class="cx"> 
</span><span class="cx">     if initASMFileName:
</span><span class="cx">         initBytecodesFile = openOrExit(initASMFileName, &quot;wb&quot;)
</span><del>-        if bytecodeHFilename:
-            genString = genString + &quot;and &quot;
-        genString = genString + &quot;{0} &quot;.format(initASMFileName)
</del><span class="cx"> 
</span><del>-    print &quot;{0}from {1}\n&quot;.format(genString, bytecodeJSONFile)
-
-
</del><span class="cx">     try:
</span><span class="cx">         bytecodeSections = json.load(bytecodeFile, encoding = &quot;utf-8&quot;)
</span><span class="cx">     except:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreofflineasmasmrb"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/offlineasm/asm.rb (194530 => 194531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/offlineasm/asm.rb        2016-01-04 13:35:14 UTC (rev 194530)
+++ trunk/Source/JavaScriptCore/offlineasm/asm.rb        2016-01-04 16:09:15 UTC (rev 194531)
</span><span class="lines">@@ -282,8 +282,6 @@
</span><span class="cx"> offsetsFile = ARGV.shift
</span><span class="cx"> outputFlnm = ARGV.shift
</span><span class="cx"> 
</span><del>-$stderr.puts &quot;offlineasm: Parsing #{asmFile} and #{offsetsFile} and creating assembly file #{outputFlnm}.&quot;
-
</del><span class="cx"> begin
</span><span class="cx">     configurationList = offsetsAndConfigurationIndex(offsetsFile)
</span><span class="cx"> rescue MissingMagicValuesException
</span><span class="lines">@@ -335,6 +333,3 @@
</span><span class="cx">         }
</span><span class="cx">     }
</span><span class="cx"> }
</span><del>-
-$stderr.puts &quot;offlineasm: Assembly file #{outputFlnm} successfully generated.&quot;
-
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoreofflineasmgenerate_offset_extractorrb"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb (194530 => 194531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb        2016-01-04 13:35:14 UTC (rev 194530)
+++ trunk/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb        2016-01-04 16:09:15 UTC (rev 194531)
</span><span class="lines">@@ -45,8 +45,6 @@
</span><span class="cx">     includeOnlyBackends(validBackends.split(&quot;,&quot;))
</span><span class="cx"> end
</span><span class="cx"> 
</span><del>-$stderr.puts &quot;offlineasm: Parsing #{inputFlnm} and creating offset extractor #{outputFlnm}.&quot;
-
</del><span class="cx"> def emitMagicNumber
</span><span class="cx">     OFFSET_MAGIC_NUMBERS.each {
</span><span class="cx">         | number |
</span><span class="lines">@@ -149,6 +147,3 @@
</span><span class="cx">     }
</span><span class="cx">     outp.puts &quot;};&quot;
</span><span class="cx"> }
</span><del>-
-$stderr.puts &quot;offlineasm: offset extractor #{outputFlnm} successfully generated.&quot;
-
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoreofflineasmparserrb"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/offlineasm/parser.rb (194530 => 194531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/offlineasm/parser.rb        2016-01-04 13:35:14 UTC (rev 194530)
+++ trunk/Source/JavaScriptCore/offlineasm/parser.rb        2016-01-04 16:09:15 UTC (rev 194531)
</span><span class="lines">@@ -744,7 +744,6 @@
</span><span class="cx">                 moduleName = @tokens[@idx].string
</span><span class="cx">                 fileName = IncludeFile.new(moduleName, @tokens[@idx].codeOrigin.fileName.dirname).fileName
</span><span class="cx">                 @idx += 1
</span><del>-                $stderr.puts &quot;offlineasm: Including file #{fileName}&quot;
</del><span class="cx">                 list &lt;&lt; parse(fileName)
</span><span class="cx">             else
</span><span class="cx">                 parseError &quot;Expecting terminal #{final} #{comment}&quot;
</span></span></pre>
</div>
</div>

</body>
</html>