<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194470] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194470">194470</a></dd>
<dt>Author</dt> <dd>aestes@apple.com</dd>
<dt>Date</dt> <dd>2015-12-31 14:49:09 -0800 (Thu, 31 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix warnings uncovered by migrating to WTF_MOVE
https://bugs.webkit.org/show_bug.cgi?id=152601
Reviewed by Daniel Bates.
Source/JavaScriptCore:
* create_regex_tables: Moving a return value prevented copy elision.
* ftl/FTLUnwindInfo.cpp:
(JSC::FTL::parseUnwindInfo): Ditto.
* replay/EncodedValue.h: Ditto.
Source/WebCore:
* Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::createSession): Moving a return value prevented copy elision.
Source/WebKit2:
* UIProcess/API/APIUIClient.h:
(API::UIClient::actionsForElement): Moving a return value passed to the function by value is redundant, since it
will be implicitly moved in this case.
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::actionsForElement): Ditto.
Tools:
Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
self-move, even if doing so would trigger a warning.
* TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::TEST):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorecreate_regex_tables">trunk/Source/JavaScriptCore/create_regex_tables</a></li>
<li><a href="#trunkSourceJavaScriptCoreftlFTLUnwindInfocpp">trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorereplayEncodedValueh">trunk/Source/JavaScriptCore/replay/EncodedValue.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesencryptedmediaMediaKeyscpp">trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIAPIUIClienth">trunk/Source/WebKit2/UIProcess/API/APIUIClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaUIDelegatemm">trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFNakedPtrcpp">trunk/Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFRefPtrcpp">trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-12-31 Andy Estes <aestes@apple.com>
+
+ Fix warnings uncovered by migrating to WTF_MOVE
+ https://bugs.webkit.org/show_bug.cgi?id=152601
+
+ Reviewed by Daniel Bates.
+
+ * create_regex_tables: Moving a return value prevented copy elision.
+ * ftl/FTLUnwindInfo.cpp:
+ (JSC::FTL::parseUnwindInfo): Ditto.
+ * replay/EncodedValue.h: Ditto.
+
</ins><span class="cx"> 2015-12-30 Aleksandr Skachkov <gskachkov@gmail.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Arrow function syntax. Arrow function specific features. Lexical bind "super"
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorecreate_regex_tables"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/create_regex_tables (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/create_regex_tables 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/JavaScriptCore/create_regex_tables 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx"> function += (" characterClass->m_rangesUnicode.append(CharacterRange(0x%04x, 0x%04x));\n" % (min, max))
</span><span class="cx"> else:
</span><span class="cx"> function += (" characterClass->m_ranges.append(CharacterRange(0x%02x, 0x%02x));\n" % (min, max))
</span><del>- function += (" return WTF::move(characterClass);\n")
</del><ins>+ function += (" return characterClass;\n")
</ins><span class="cx"> function += ("}\n\n")
</span><span class="cx"> functions += function
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreftlFTLUnwindInfocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -1016,7 +1016,7 @@
</span><span class="cx">
</span><span class="cx"> #endif
</span><span class="cx"> registerOffsets->sort();
</span><del>- return WTF::move(registerOffsets);
</del><ins>+ return registerOffsets;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } } // namespace JSC::FTL
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorereplayEncodedValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/replay/EncodedValue.h (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/replay/EncodedValue.h 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/JavaScriptCore/replay/EncodedValue.h 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx"> for (const typename EncodingTraits<T>::DecodedType& value : vectorOfValues)
</span><span class="cx"> encodedVector.append<T>(value);
</span><span class="cx">
</span><del>- return WTF::move(encodedVector);
</del><ins>+ return encodedVector;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static bool decodeValue(EncodedValue& encodedVector, DecodedType& decodedValue)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/WebCore/ChangeLog 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-12-31 Andy Estes <aestes@apple.com>
+
+ Fix warnings uncovered by migrating to WTF_MOVE
+ https://bugs.webkit.org/show_bug.cgi?id=152601
+
+ Reviewed by Daniel Bates.
+
+ * Modules/encryptedmedia/MediaKeys.cpp:
+ (WebCore::MediaKeys::createSession): Moving a return value prevented copy elision.
+
</ins><span class="cx"> 2015-12-31 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Review feedback followup for:
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesencryptedmediaMediaKeyscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx"> session->generateKeyRequest(type, initData);
</span><span class="cx">
</span><span class="cx"> // 6. Return the new object to the caller.
</span><del>- return WTF::move(session);
</del><ins>+ return session;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool MediaKeys::isTypeSupported(const String& keySystem, const String& mimeType)
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-12-31 Andy Estes <aestes@apple.com>
+
+ Fix warnings uncovered by migrating to WTF_MOVE
+ https://bugs.webkit.org/show_bug.cgi?id=152601
+
+ Reviewed by Daniel Bates.
+
+ * UIProcess/API/APIUIClient.h:
+ (API::UIClient::actionsForElement): Moving a return value passed to the function by value is redundant, since it
+ will be implicitly moved in this case.
+ * UIProcess/Cocoa/UIDelegate.mm:
+ (WebKit::UIDelegate::UIClient::actionsForElement): Ditto.
+
</ins><span class="cx"> 2015-12-30 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Add explicit conversions between scrollOffset and scrollPostion, and use them in a few places
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIAPIUIClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/APIUIClient.h (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> #if HAVE(APP_LINKS)
</span><span class="cx"> virtual bool shouldIncludeAppLinkActionsForElement(_WKActivatedElementInfo *) { return true; }
</span><span class="cx"> #endif
</span><del>- virtual RetainPtr<NSArray> actionsForElement(_WKActivatedElementInfo *, RetainPtr<NSArray> defaultActions) { return WTF::move(defaultActions); }
</del><ins>+ virtual RetainPtr<NSArray> actionsForElement(_WKActivatedElementInfo *, RetainPtr<NSArray> defaultActions) { return defaultActions; }
</ins><span class="cx"> virtual void didNotHandleTapAsClick(const WebCore::IntPoint&) { }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaUIDelegatemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -360,7 +360,7 @@
</span><span class="cx"> RetainPtr<NSArray> UIDelegate::UIClient::actionsForElement(_WKActivatedElementInfo *elementInfo, RetainPtr<NSArray> defaultActions)
</span><span class="cx"> {
</span><span class="cx"> if (!m_uiDelegate.m_delegateMethods.webViewActionsForElementDefaultActions)
</span><del>- return WTF::move(defaultActions);
</del><ins>+ return defaultActions;
</ins><span class="cx">
</span><span class="cx"> auto delegate = m_uiDelegate.m_delegate.get();
</span><span class="cx"> if (!delegate)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Tools/ChangeLog 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-12-31 Andy Estes <aestes@apple.com>
+
+ Fix warnings uncovered by migrating to WTF_MOVE
+ https://bugs.webkit.org/show_bug.cgi?id=152601
+
+ Reviewed by Daniel Bates.
+
+ Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
+ self-move, even if doing so would trigger a warning.
+
+ * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
+ (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2015-12-31 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] The install-dependencies script has a syntax error
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFNakedPtrcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -179,7 +179,14 @@
</span><span class="cx"> {
</span><span class="cx"> NakedPtr<RefLogger> ptr(&a);
</span><span class="cx"> ASSERT_EQ(&a, ptr.get());
</span><ins>+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-move"
+#endif
</ins><span class="cx"> ptr = WTF::move(ptr);
</span><ins>+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
</ins><span class="cx"> ASSERT_EQ(&a, ptr.get());
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFRefPtrcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp (194469 => 194470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp 2015-12-31 22:47:14 UTC (rev 194469)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp 2015-12-31 22:49:09 UTC (rev 194470)
</span><span class="lines">@@ -270,7 +270,14 @@
</span><span class="cx"> {
</span><span class="cx"> RefPtr<RefLogger> ptr(&a);
</span><span class="cx"> ASSERT_EQ(&a, ptr.get());
</span><ins>+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-move"
+#endif
</ins><span class="cx"> ptr = WTF::move(ptr);
</span><ins>+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
</ins><span class="cx"> ASSERT_EQ(&a, ptr.get());
</span><span class="cx"> }
</span><span class="cx"> ASSERT_STREQ("ref(a) deref(a) ", takeLogStr().c_str());
</span></span></pre>
</div>
</div>
</body>
</html>