<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194428] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194428">194428</a></dd>
<dt>Author</dt> <dd>aestes@apple.com</dd>
<dt>Date</dt> <dd>2015-12-28 08:26:24 -0800 (Mon, 28 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Stop moving local objects in return statements
https://bugs.webkit.org/show_bug.cgi?id=152557
Reviewed by Brady Eidson.
Source/JavaScriptCore:
Calling std::move() on a local object in a return statement prevents the compiler from applying the return value optimization.
Clang can warn about these mistakes with -Wpessimizing-move, although only when std::move() is called directly.
I found these issues by temporarily replacing WTF::move with std::move and recompiling.
* inspector/ScriptCallStack.cpp:
(Inspector::ScriptCallStack::buildInspectorArray):
* inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::buildInspectorObject):
* jit/CallFrameShuffler.h:
(JSC::CallFrameShuffler::snapshot):
* runtime/TypeSet.cpp:
(JSC::TypeSet::allStructureRepresentations):
(JSC::StructureShape::inspectorRepresentation):
Source/WebCore:
Calling std::move() on a local object in a return statement prevents the compiler from applying the return value optimization.
Clang can warn about these mistakes with -Wpessimizing-move, although only when std::move() is called directly.
I found these issues by temporarily replacing WTF::move with std::move and recompiling.
* Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::isolatedCopy):
* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::deletedValue):
* Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::objectStoreNames):
(WebCore::IDBClient::IDBDatabase::startVersionChangeTransaction):
* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::createObjectStore):
(WebCore::IDBClient::IDBTransaction::createIndex):
(WebCore::IDBClient::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBClient::IDBTransaction::requestGetRecord):
(WebCore::IDBClient::IDBTransaction::requestIndexRecord):
(WebCore::IDBClient::IDBTransaction::requestClearObjectStore):
(WebCore::IDBClient::IDBTransaction::requestPutOrAdd):
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction):
* Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::isolatedCopy):
(WebCore::IDBDatabaseInfo::objectStoreNames):
* Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::error):
(WebCore::IDBResultData::openDatabaseSuccess):
(WebCore::IDBResultData::openDatabaseUpgradeNeeded):
* Modules/indexeddb/shared/IDBTransactionInfo.cpp:
(WebCore::IDBTransactionInfo::versionChange):
(WebCore::IDBTransactionInfo::isolatedCopy):
* Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::create):
* Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::create):
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::originLockFor):
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatNumberValue):
* dom/NodeOrString.cpp:
(WebCore::convertNodesOrStringsIntoNode):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
* inspector/InspectorNetworkAgent.cpp:
(WebCore::buildObjectForHeaders):
(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForCachedResource):
* inspector/InspectorOverlay.cpp:
(WebCore::buildArrayForQuad):
(WebCore::buildObjectForFlowRegions):
(WebCore::InspectorOverlay::buildObjectForHighlightedNodes):
* inspector/InspectorPageAgent.cpp:
(WebCore::createXHRTextDecoder):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::buildObjectForFrame):
* inspector/InspectorStyleSheet.cpp:
(WebCore::buildMediaObject):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::buildObjectForSelectorHelper):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::stopFromConsole):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createConsoleProfileData):
(WebCore::TimelineRecordFactory::createProbeSampleData):
(WebCore::TimelineRecordFactory::createEventDispatchData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createTimeStampData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::createQuad):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::buildInspectorObject):
* loader/FrameLoader.cpp:
(WebCore::createWindow):
* loader/NavigationAction.cpp:
(WebCore::NavigationAction::copyWithShouldOpenExternalURLsPolicy):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
* platform/network/ios/QuickLook.mm:
(WebCore::QuickLookHandle::create):
* testing/Internals.cpp:
(WebCore::Internals::openDummyInspectorFrontend):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::createResourceRequest):
* xml/XPathExpression.cpp:
(WebCore::XPathExpression::evaluate):
Source/WebKit2:
Calling std::move() on a local object in a return statement prevents the compiler from applying the return value optimization.
Clang can warn about these mistakes with -Wpessimizing-move, although only when std::move() is called directly.
I found these issues by temporarily replacing WTF::move with std::move and recompiling.
* UIProcess/WebPageProxy.cpp:
(WebKit::ExceededDatabaseQuotaRecords::createRecord):
Source/WTF:
* wtf/StdLibExtras.h: Added a FIXME about how using WTF::move() prevents several Clang diagnostics from emitting useful warnings.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorScriptCallStackcpp">trunk/Source/JavaScriptCore/inspector/ScriptCallStack.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectoragentsInspectorScriptProfilerAgentcpp">trunk/Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitCallFrameShufflerh">trunk/Source/JavaScriptCore/jit/CallFrameShuffler.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeTypeSetcpp">trunk/Source/JavaScriptCore/runtime/TypeSet.cpp</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfStdLibExtrash">trunk/Source/WTF/wtf/StdLibExtras.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBDatabaseIdentifiercpp">trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBKeyDatacpp">trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbclientIDBDatabaseImplcpp">trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbclientIDBTransactionImplcpp">trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbserverUniqueIDBDatabasecpp">trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbsharedIDBDatabaseInfocpp">trunk/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbsharedIDBResultDatacpp">trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbsharedIDBTransactionInfocpp">trunk/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbsharedInProcessIDBServercpp">trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioOfflineAudioContextcpp">trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseTrackercpp">trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketcpp">trunk/Source/WebCore/Modules/websockets/WebSocket.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValuecpp">trunk/Source/WebCore/css/CSSPrimitiveValue.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodeOrStringcpp">trunk/Source/WebCore/dom/NodeOrString.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorApplicationCacheAgentcpp">trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp">trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorLayerTreeAgentcpp">trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorNetworkAgentcpp">trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorOverlaycpp">trunk/Source/WebCore/inspector/InspectorOverlay.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgentcpp">trunk/Source/WebCore/inspector/InspectorPageAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorStyleSheetcpp">trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgentcpp">trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorTimelineRecordFactorycpp">trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoadercpp">trunk/Source/WebCore/loader/FrameLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderNavigationActioncpp">trunk/Source/WebCore/loader/NavigationAction.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkiosQuickLookmm">trunk/Source/WebCore/platform/network/ios/QuickLook.mm</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerScriptLoadercpp">trunk/Source/WebCore/workers/WorkerScriptLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXPathExpressioncpp">trunk/Source/WebCore/xml/XPathExpression.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2015-12-25 Andy Estes <aestes@apple.com>
+
+ Stop moving local objects in return statements
+ https://bugs.webkit.org/show_bug.cgi?id=152557
+
+ Reviewed by Brady Eidson.
+
+ Calling std::move() on a local object in a return statement prevents the compiler from applying the return value optimization.
+
+ Clang can warn about these mistakes with -Wpessimizing-move, although only when std::move() is called directly.
+ I found these issues by temporarily replacing WTF::move with std::move and recompiling.
+
+ * inspector/ScriptCallStack.cpp:
+ (Inspector::ScriptCallStack::buildInspectorArray):
+ * inspector/agents/InspectorScriptProfilerAgent.cpp:
+ (Inspector::buildInspectorObject):
+ * jit/CallFrameShuffler.h:
+ (JSC::CallFrameShuffler::snapshot):
+ * runtime/TypeSet.cpp:
+ (JSC::TypeSet::allStructureRepresentations):
+ (JSC::StructureShape::inspectorRepresentation):
+
</ins><span class="cx"> 2015-12-26 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename NodeMayOverflowInXXX to NodeMayOverflowInt32InXXX.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorScriptCallStackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/ScriptCallStack.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/ScriptCallStack.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/JavaScriptCore/inspector/ScriptCallStack.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx"> auto frames = Inspector::Protocol::Console::StackTrace::create();
</span><span class="cx"> for (size_t i = 0; i < m_frames.size(); i++)
</span><span class="cx"> frames->addItem(m_frames.at(i).buildInspectorObject());
</span><del>- return WTF::move(frames);
</del><ins>+ return frames;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace Inspector
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectoragentsInspectorScriptProfilerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -181,7 +181,7 @@
</span><span class="cx"> result->setChildren(WTF::move(children));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<Protocol::Timeline::CPUProfile> buildProfileInspectorObject(const JSC::Profile* profile)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitCallFrameShufflerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/CallFrameShuffler.h (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/CallFrameShuffler.h 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/JavaScriptCore/jit/CallFrameShuffler.h 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> RELEASE_ASSERT_NOT_REACHED();
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Ask the shuffler to put the callee into some registers once the
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeTypeSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/TypeSet.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/TypeSet.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/JavaScriptCore/runtime/TypeSet.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -224,7 +224,7 @@
</span><span class="cx"> for (size_t i = 0; i < m_structureHistory.size(); i++)
</span><span class="cx"> description->addItem(m_structureHistory.at(i)->inspectorRepresentation());
</span><span class="cx">
</span><del>- return WTF::move(description);
</del><ins>+ return description;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Inspector::Protocol::Runtime::TypeSet> TypeSet::inspectorTypeSet() const
</span><span class="lines">@@ -523,7 +523,7 @@
</span><span class="cx"> currentShape = currentShape->m_proto;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(base);
</del><ins>+ return base;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool StructureShape::hasSamePrototypeChain(PassRefPtr<StructureShape> prpOther)
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WTF/ChangeLog 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-12-25 Andy Estes <aestes@apple.com>
+
+ Stop moving local objects in return statements
+ https://bugs.webkit.org/show_bug.cgi?id=152557
+
+ Reviewed by Brady Eidson.
+
+ * wtf/StdLibExtras.h: Added a FIXME about how using WTF::move() prevents several Clang diagnostics from emitting useful warnings.
+
</ins><span class="cx"> 2015-12-22 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> FTL B3 should be able to run richards
</span></span></pre></div>
<a id="trunkSourceWTFwtfStdLibExtrash"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/StdLibExtras.h (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/StdLibExtras.h 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WTF/wtf/StdLibExtras.h 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -111,6 +111,8 @@
</span><span class="cx">
</span><span class="cx"> namespace WTF {
</span><span class="cx">
</span><ins>+// FIXME: Using this function prevents Clang's move diagnostics (-Wpessimizing-move, -Wredundant-move, -Wself-move) from
+// finding mistakes, since these diagnostics only evaluate calls to std::move().
</ins><span class="cx"> template<typename T>
</span><span class="cx"> ALWAYS_INLINE typename std::remove_reference<T>::type&& move(T&& value)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/ChangeLog 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -1,3 +1,115 @@
</span><ins>+2015-12-25 Andy Estes <aestes@apple.com>
+
+ Stop moving local objects in return statements
+ https://bugs.webkit.org/show_bug.cgi?id=152557
+
+ Reviewed by Brady Eidson.
+
+ Calling std::move() on a local object in a return statement prevents the compiler from applying the return value optimization.
+
+ Clang can warn about these mistakes with -Wpessimizing-move, although only when std::move() is called directly.
+ I found these issues by temporarily replacing WTF::move with std::move and recompiling.
+
+ * Modules/indexeddb/IDBDatabaseIdentifier.cpp:
+ (WebCore::IDBDatabaseIdentifier::isolatedCopy):
+ * Modules/indexeddb/IDBKeyData.cpp:
+ (WebCore::IDBKeyData::deletedValue):
+ * Modules/indexeddb/client/IDBDatabaseImpl.cpp:
+ (WebCore::IDBClient::IDBDatabase::objectStoreNames):
+ (WebCore::IDBClient::IDBDatabase::startVersionChangeTransaction):
+ * Modules/indexeddb/client/IDBTransactionImpl.cpp:
+ (WebCore::IDBClient::IDBTransaction::createObjectStore):
+ (WebCore::IDBClient::IDBTransaction::createIndex):
+ (WebCore::IDBClient::IDBTransaction::doRequestOpenCursor):
+ (WebCore::IDBClient::IDBTransaction::requestGetRecord):
+ (WebCore::IDBClient::IDBTransaction::requestIndexRecord):
+ (WebCore::IDBClient::IDBTransaction::requestClearObjectStore):
+ (WebCore::IDBClient::IDBTransaction::requestPutOrAdd):
+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction):
+ * Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
+ (WebCore::IDBDatabaseInfo::isolatedCopy):
+ (WebCore::IDBDatabaseInfo::objectStoreNames):
+ * Modules/indexeddb/shared/IDBResultData.cpp:
+ (WebCore::IDBResultData::error):
+ (WebCore::IDBResultData::openDatabaseSuccess):
+ (WebCore::IDBResultData::openDatabaseUpgradeNeeded):
+ * Modules/indexeddb/shared/IDBTransactionInfo.cpp:
+ (WebCore::IDBTransactionInfo::versionChange):
+ (WebCore::IDBTransactionInfo::isolatedCopy):
+ * Modules/indexeddb/shared/InProcessIDBServer.cpp:
+ (WebCore::InProcessIDBServer::create):
+ * Modules/webaudio/OfflineAudioContext.cpp:
+ (WebCore::OfflineAudioContext::create):
+ * Modules/webdatabase/DatabaseTracker.cpp:
+ (WebCore::DatabaseTracker::originLockFor):
+ * Modules/websockets/WebSocket.cpp:
+ (WebCore::WebSocket::create):
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::formatNumberValue):
+ * dom/NodeOrString.cpp:
+ (WebCore::convertNodesOrStringsIntoNode):
+ * inspector/InspectorApplicationCacheAgent.cpp:
+ (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::buildObjectForNode):
+ (WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
+ (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
+ (WebCore::InspectorDOMAgent::buildObjectForEventListener):
+ * inspector/InspectorIndexedDBAgent.cpp:
+ * inspector/InspectorLayerTreeAgent.cpp:
+ (WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
+ * inspector/InspectorNetworkAgent.cpp:
+ (WebCore::buildObjectForHeaders):
+ (WebCore::buildObjectForResourceRequest):
+ (WebCore::buildObjectForCachedResource):
+ * inspector/InspectorOverlay.cpp:
+ (WebCore::buildArrayForQuad):
+ (WebCore::buildObjectForFlowRegions):
+ (WebCore::InspectorOverlay::buildObjectForHighlightedNodes):
+ * inspector/InspectorPageAgent.cpp:
+ (WebCore::createXHRTextDecoder):
+ (WebCore::buildArrayForCookies):
+ (WebCore::InspectorPageAgent::buildObjectForFrame):
+ * inspector/InspectorStyleSheet.cpp:
+ (WebCore::buildMediaObject):
+ (WebCore::InspectorStyle::buildArrayForComputedStyle):
+ (WebCore::buildObjectForSelectorHelper):
+ (WebCore::selectorsFromSource):
+ (WebCore::InspectorStyleSheet::buildObjectForSelectorList):
+ (WebCore::InspectorStyleSheet::buildObjectForStyle):
+ (WebCore::InspectorStyleSheet::buildArrayForRuleList):
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::stopFromConsole):
+ * inspector/TimelineRecordFactory.cpp:
+ (WebCore::TimelineRecordFactory::createGenericRecord):
+ (WebCore::TimelineRecordFactory::createFunctionCallData):
+ (WebCore::TimelineRecordFactory::createConsoleProfileData):
+ (WebCore::TimelineRecordFactory::createProbeSampleData):
+ (WebCore::TimelineRecordFactory::createEventDispatchData):
+ (WebCore::TimelineRecordFactory::createGenericTimerData):
+ (WebCore::TimelineRecordFactory::createTimerInstallData):
+ (WebCore::TimelineRecordFactory::createEvaluateScriptData):
+ (WebCore::TimelineRecordFactory::createTimeStampData):
+ (WebCore::TimelineRecordFactory::createAnimationFrameData):
+ (WebCore::createQuad):
+ (WebCore::TimelineRecordFactory::createPaintData):
+ (WebCore::buildInspectorObject):
+ * loader/FrameLoader.cpp:
+ (WebCore::createWindow):
+ * loader/NavigationAction.cpp:
+ (WebCore::NavigationAction::copyWithShouldOpenExternalURLsPolicy):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::createWindow):
+ * platform/network/ios/QuickLook.mm:
+ (WebCore::QuickLookHandle::create):
+ * testing/Internals.cpp:
+ (WebCore::Internals::openDummyInspectorFrontend):
+ * workers/WorkerScriptLoader.cpp:
+ (WebCore::WorkerScriptLoader::createResourceRequest):
+ * xml/XPathExpression.cpp:
+ (WebCore::XPathExpression::evaluate):
+
</ins><span class="cx"> 2015-12-27 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Should never be reached failure in WebCore::RenderElement::clearLayoutRootIfNeeded
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBDatabaseIdentifiercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> identifier.m_openingOrigin = m_openingOrigin.isolatedCopy();
</span><span class="cx"> identifier.m_mainFrameOrigin = m_mainFrameOrigin.isolatedCopy();
</span><span class="cx">
</span><del>- return WTF::move(identifier);
</del><ins>+ return identifier;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBKeyDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -324,7 +324,7 @@
</span><span class="cx"> IDBKeyData result;
</span><span class="cx"> result.m_isNull = false;
</span><span class="cx"> result.m_isDeletedValue = true;
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool IDBKeyData::operator<(const IDBKeyData& rhs) const
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbclientIDBDatabaseImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> for (auto& name : m_info.objectStoreNames())
</span><span class="cx"> objectStoreNames->append(name);
</span><span class="cx"> objectStoreNames->sort();
</span><del>- return WTF::move(objectStoreNames);
</del><ins>+ return objectStoreNames;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<WebCore::IDBObjectStore> IDBDatabase::createObjectStore(const String&, const Dictionary&, ExceptionCodeWithMessage&)
</span><span class="lines">@@ -266,7 +266,7 @@
</span><span class="cx">
</span><span class="cx"> m_activeTransactions.set(transaction->info().identifier(), &transaction.get());
</span><span class="cx">
</span><del>- return WTF::move(transaction);
</del><ins>+ return transaction;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBDatabase::didStartTransaction(IDBTransaction& transaction)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbclientIDBTransactionImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -444,7 +444,7 @@
</span><span class="cx"> auto operation = createTransactionOperation(*this, &IDBTransaction::didCreateObjectStoreOnServer, &IDBTransaction::createObjectStoreOnServer, info);
</span><span class="cx"> scheduleOperation(WTF::move(operation));
</span><span class="cx">
</span><del>- return WTF::move(objectStore);
</del><ins>+ return objectStore;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBTransaction::createObjectStoreOnServer(TransactionOperation& operation, const IDBObjectStoreInfo& info)
</span><span class="lines">@@ -473,7 +473,7 @@
</span><span class="cx"> auto operation = createTransactionOperation(*this, &IDBTransaction::didCreateIndexOnServer, &IDBTransaction::createIndexOnServer, info);
</span><span class="cx"> scheduleOperation(WTF::move(operation));
</span><span class="cx">
</span><del>- return WTF::move(index);
</del><ins>+ return index;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBTransaction::createIndexOnServer(TransactionOperation& operation, const IDBIndexInfo& info)
</span><span class="lines">@@ -529,7 +529,7 @@
</span><span class="cx"> auto operation = createTransactionOperation(*this, request.get(), &IDBTransaction::didOpenCursorOnServer, &IDBTransaction::openCursorOnServer, cursor->info());
</span><span class="cx"> scheduleOperation(WTF::move(operation));
</span><span class="cx">
</span><del>- return WTF::move(request);
</del><ins>+ return request;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBTransaction::openCursorOnServer(TransactionOperation& operation, const IDBCursorInfo& info)
</span><span class="lines">@@ -584,7 +584,7 @@
</span><span class="cx"> auto operation = createTransactionOperation(*this, request.get(), &IDBTransaction::didGetRecordOnServer, &IDBTransaction::getRecordOnServer, keyRangeData);
</span><span class="cx"> scheduleOperation(WTF::move(operation));
</span><span class="cx">
</span><del>- return WTF::move(request);
</del><ins>+ return request;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<IDBRequest> IDBTransaction::requestGetValue(ScriptExecutionContext& context, IDBIndex& index, const IDBKeyRangeData& range)
</span><span class="lines">@@ -611,7 +611,7 @@
</span><span class="cx"> auto operation = createTransactionOperation(*this, request.get(), &IDBTransaction::didGetRecordOnServer, &IDBTransaction::getRecordOnServer, range);
</span><span class="cx"> scheduleOperation(WTF::move(operation));
</span><span class="cx">
</span><del>- return WTF::move(request);
</del><ins>+ return request;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBTransaction::getRecordOnServer(TransactionOperation& operation, const IDBKeyRangeData& keyRange)
</span><span class="lines">@@ -732,7 +732,7 @@
</span><span class="cx"> auto operation = createTransactionOperation(*this, request.get(), &IDBTransaction::didClearObjectStoreOnServer, &IDBTransaction::clearObjectStoreOnServer, objectStoreIdentifier);
</span><span class="cx"> scheduleOperation(WTF::move(operation));
</span><span class="cx">
</span><del>- return WTF::move(request);
</del><ins>+ return request;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBTransaction::clearObjectStoreOnServer(TransactionOperation& operation, const uint64_t& objectStoreIdentifier)
</span><span class="lines">@@ -763,7 +763,7 @@
</span><span class="cx"> auto operation = createTransactionOperation(*this, request.get(), &IDBTransaction::didPutOrAddOnServer, &IDBTransaction::putOrAddOnServer, key, &value, overwriteMode);
</span><span class="cx"> scheduleOperation(WTF::move(operation));
</span><span class="cx">
</span><del>- return WTF::move(request);
</del><ins>+ return request;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBTransaction::putOrAddOnServer(TransactionOperation& operation, RefPtr<IDBKey> key, RefPtr<SerializedScriptValue> value, const IndexedDB::ObjectStoreOverwriteMode& overwriteMode)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbserverUniqueIDBDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -1085,13 +1085,13 @@
</span><span class="cx">
</span><span class="cx"> hadDeferredTransactions = !deferredTransactions.isEmpty();
</span><span class="cx"> if (!hadDeferredTransactions)
</span><del>- return WTF::move(currentTransaction);
</del><ins>+ return currentTransaction;
</ins><span class="cx">
</span><span class="cx"> // Prepend the deferred transactions back on the beginning of the deque for future scheduling passes.
</span><span class="cx"> while (!deferredTransactions.isEmpty())
</span><span class="cx"> m_pendingTransactions.prepend(deferredTransactions.takeLast());
</span><span class="cx">
</span><del>- return WTF::move(currentTransaction);
</del><ins>+ return currentTransaction;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void UniqueIDBDatabase::inProgressTransactionCompleted(const IDBResourceIdentifier& transactionIdentifier)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbsharedIDBDatabaseInfocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> info.m_name = m_name.isolatedCopy();
</span><span class="cx"> info.m_version = m_version;
</span><span class="cx">
</span><del>- return WTF::move(info);
</del><ins>+ return info;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool IDBDatabaseInfo::hasObjectStore(const String& name) const
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx"> for (auto& objectStore : m_objectStoreMap.values())
</span><span class="cx"> names.uncheckedAppend(objectStore.name());
</span><span class="cx">
</span><del>- return WTF::move(names);
</del><ins>+ return names;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void IDBDatabaseInfo::deleteObjectStore(const String& objectStoreName)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbsharedIDBResultDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> IDBResultData result(requestIdentifier);
</span><span class="cx"> result.m_type = IDBResultType::Error;
</span><span class="cx"> result.m_error = error;
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IDBResultData IDBResultData::openDatabaseSuccess(const IDBResourceIdentifier& requestIdentifier, IDBServer::UniqueIDBDatabaseConnection& connection)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> result.m_type = IDBResultType::OpenDatabaseSuccess;
</span><span class="cx"> result.m_databaseConnectionIdentifier = connection.identifier();
</span><span class="cx"> result.m_databaseInfo = std::make_unique<IDBDatabaseInfo>(connection.database().info());
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> result.m_databaseConnectionIdentifier = transaction.databaseConnection().identifier();
</span><span class="cx"> result.m_databaseInfo = std::make_unique<IDBDatabaseInfo>(transaction.databaseConnection().database().info());
</span><span class="cx"> result.m_transactionInfo = std::make_unique<IDBTransactionInfo>(transaction.info());
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IDBResultData IDBResultData::deleteDatabaseSuccess(const IDBResourceIdentifier& requestIdentifier, const IDBDatabaseInfo& info)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbsharedIDBTransactionInfocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> result.m_newVersion = newVersion;
</span><span class="cx"> result.m_originalDatabaseInfo = std::make_unique<IDBDatabaseInfo>(originalDatabaseInfo);
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IDBTransactionInfo::IDBTransactionInfo(const IDBTransactionInfo& info)
</span><span class="lines">@@ -79,7 +79,7 @@
</span><span class="cx"> if (m_originalDatabaseInfo)
</span><span class="cx"> result.m_originalDatabaseInfo = std::make_unique<IDBDatabaseInfo>(*m_originalDatabaseInfo);
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbsharedInProcessIDBServercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> {
</span><span class="cx"> Ref<InProcessIDBServer> server = adoptRef(*new InProcessIDBServer);
</span><span class="cx"> server->m_server->registerConnection(server->connectionToClient());
</span><del>- return WTF::move(server);
</del><ins>+ return server;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InProcessIDBServer::InProcessIDBServer()
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioOfflineAudioContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<OfflineAudioContext> audioContext(adoptRef(new OfflineAudioContext(document, numberOfChannels, numberOfFrames, sampleRate)));
</span><span class="cx"> audioContext->suspendIfNeeded();
</span><del>- return WTF::move(audioContext);
</del><ins>+ return audioContext;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> OfflineAudioContext::OfflineAudioContext(Document& document, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseTrackercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -667,7 +667,7 @@
</span><span class="cx"> ASSERT(lock);
</span><span class="cx"> addResult.iterator->value = lock;
</span><span class="cx">
</span><del>- return WTF::move(lock);
</del><ins>+ return lock;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DatabaseTracker::deleteOriginLockFor(SecurityOrigin* origin)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -183,7 +183,7 @@
</span><span class="cx"> if (ec)
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- return WTF::move(webSocket);
</del><ins>+ return webSocket;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<WebSocket> WebSocket::create(ScriptExecutionContext& context, const String& url, const String& protocol, ExceptionCode& ec)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -976,7 +976,7 @@
</span><span class="cx"> for (unsigned i = 0; i < suffixLength; ++i)
</span><span class="cx"> buffer[length + i] = static_cast<LChar>(suffix[i]);
</span><span class="cx">
</span><del>- return WTF::move(string);
</del><ins>+ return string;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template <unsigned characterCount>
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeOrStringcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NodeOrString.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NodeOrString.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/dom/NodeOrString.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(nodeToReturn);
</del><ins>+ return nodeToReturn;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorApplicationCacheAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -164,7 +164,7 @@
</span><span class="cx"> for (const auto& resourceInfo : applicationCacheResources)
</span><span class="cx"> resources->addItem(buildObjectForApplicationCacheResource(resourceInfo));
</span><span class="cx">
</span><del>- return WTF::move(resources);
</del><ins>+ return resources;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Inspector::Protocol::ApplicationCache::ApplicationCacheResource> InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo& resourceInfo)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -1376,7 +1376,7 @@
</span><span class="cx"> value->setRole(axObject->computedRoleString());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(value);
</del><ins>+ return value;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Inspector::Protocol::Array<String>> InspectorDOMAgent::buildArrayForElementAttributes(Element* element)
</span><span class="lines">@@ -1384,13 +1384,13 @@
</span><span class="cx"> auto attributesValue = Inspector::Protocol::Array<String>::create();
</span><span class="cx"> // Go through all attributes and serialize them.
</span><span class="cx"> if (!element->hasAttributes())
</span><del>- return WTF::move(attributesValue);
</del><ins>+ return attributesValue;
</ins><span class="cx"> for (const Attribute& attribute : element->attributesIterator()) {
</span><span class="cx"> // Add attribute pair
</span><span class="cx"> attributesValue->addItem(attribute.name().toString());
</span><span class="cx"> attributesValue->addItem(attribute.value());
</span><span class="cx"> }
</span><del>- return WTF::move(attributesValue);
</del><ins>+ return attributesValue;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Inspector::Protocol::Array<Inspector::Protocol::DOM::Node>> InspectorDOMAgent::buildArrayForContainerChildren(Node* container, int depth, NodeToIdMap* nodesMap)
</span><span class="lines">@@ -1403,7 +1403,7 @@
</span><span class="cx"> children->addItem(buildObjectForNode(firstChild, 0, nodesMap));
</span><span class="cx"> m_childrenRequested.add(bind(container, nodesMap));
</span><span class="cx"> }
</span><del>- return WTF::move(children);
</del><ins>+ return children;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Node* child = innerFirstChild(container);
</span><span class="lines">@@ -1414,7 +1414,7 @@
</span><span class="cx"> children->addItem(buildObjectForNode(child, depth, nodesMap));
</span><span class="cx"> child = innerNextSibling(child);
</span><span class="cx"> }
</span><del>- return WTF::move(children);
</del><ins>+ return children;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<Inspector::Protocol::Array<Inspector::Protocol::DOM::Node>> InspectorDOMAgent::buildArrayForPseudoElements(const Element& element, NodeToIdMap* nodesMap)
</span><span class="lines">@@ -1481,7 +1481,7 @@
</span><span class="cx"> if (!sourceName.isEmpty())
</span><span class="cx"> value->setSourceName(sourceName);
</span><span class="cx"> }
</span><del>- return WTF::move(value);
</del><ins>+ return value;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InspectorDOMAgent::processAccessibilityChildren(RefPtr<AccessibilityObject>&& axObject, RefPtr<Inspector::Protocol::Array<int>>&& childNodeIds)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -225,7 +225,7 @@
</span><span class="cx"> RefPtr<IDBTransaction> idbTransaction = idbDatabase->transaction(scriptExecutionContext, objectStoreName, mode, ec);
</span><span class="cx"> if (ec.code)
</span><span class="cx"> return nullptr;
</span><del>- return WTF::move(idbTransaction);
</del><ins>+ return idbTransaction;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static RefPtr<IDBObjectStore> objectStoreForTransaction(IDBTransaction* idbTransaction, const String& objectStoreName)
</span><span class="lines">@@ -234,7 +234,7 @@
</span><span class="cx"> RefPtr<IDBObjectStore> idbObjectStore = idbTransaction->objectStore(objectStoreName, ec);
</span><span class="cx"> if (ec.code)
</span><span class="cx"> return nullptr;
</span><del>- return WTF::move(idbObjectStore);
</del><ins>+ return idbObjectStore;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static RefPtr<IDBIndex> indexForObjectStore(IDBObjectStore* idbObjectStore, const String& indexName)
</span><span class="lines">@@ -243,7 +243,7 @@
</span><span class="cx"> RefPtr<IDBIndex> idbIndex = idbObjectStore->index(indexName, ec);
</span><span class="cx"> if (ec.code)
</span><span class="cx"> return nullptr;
</span><del>- return WTF::move(idbIndex);
</del><ins>+ return idbIndex;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static RefPtr<KeyPath> keyPathFromIDBKeyPath(const IDBKeyPath& idbKeyPath)
</span><span class="lines">@@ -276,7 +276,7 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(keyPath);
</del><ins>+ return keyPath;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> class DatabaseLoader : public ExecutableWithDatabase {
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorLayerTreeAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -196,7 +196,7 @@
</span><span class="cx"> layerObject->setPseudoElement("first-line");
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(layerObject);
</del><ins>+ return layerObject;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int InspectorLayerTreeAgent::idForNode(ErrorString& errorString, Node* node)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorNetworkAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -186,7 +186,7 @@
</span><span class="cx">
</span><span class="cx"> for (const auto& header : headers)
</span><span class="cx"> headersObject->setString(header.key, header.value);
</span><del>- return WTF::move(headersObject);
</del><ins>+ return headersObject;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<Inspector::Protocol::Network::ResourceTiming> buildObjectForTiming(const ResourceLoadTiming& timing, DocumentLoader* loader)
</span><span class="lines">@@ -212,7 +212,7 @@
</span><span class="cx"> .release();
</span><span class="cx"> if (request.httpBody() && !request.httpBody()->isEmpty())
</span><span class="cx"> requestObject->setPostData(request.httpBody()->flattenToString());
</span><del>- return WTF::move(requestObject);
</del><ins>+ return requestObject;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static RefPtr<Inspector::Protocol::Network::Response> buildObjectForResourceResponse(const ResourceResponse& response, DocumentLoader* loader)
</span><span class="lines">@@ -252,7 +252,7 @@
</span><span class="cx"> if (!sourceMappingURL.isEmpty())
</span><span class="cx"> resourceObject->setSourceMapURL(sourceMappingURL);
</span><span class="cx">
</span><del>- return WTF::move(resourceObject);
</del><ins>+ return resourceObject;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorNetworkAgent::~InspectorNetworkAgent()
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorOverlaycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -372,7 +372,7 @@
</span><span class="cx"> array->addItem(buildObjectForPoint(quad.p2()));
</span><span class="cx"> array->addItem(buildObjectForPoint(quad.p3()));
</span><span class="cx"> array->addItem(buildObjectForPoint(quad.p4()));
</span><del>- return WTF::move(array);
</del><ins>+ return array;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<Inspector::Protocol::OverlayTypes::FragmentHighlightData> buildObjectForHighlight(const Highlight& highlight)
</span><span class="lines">@@ -450,7 +450,7 @@
</span><span class="cx"> arrayOfRegions->addItem(WTF::move(regionObject));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(arrayOfRegions);
</del><ins>+ return arrayOfRegions;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<Inspector::Protocol::OverlayTypes::Size> buildObjectForSize(const IntSize& size)
</span><span class="lines">@@ -834,7 +834,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(highlights);
</del><ins>+ return highlights;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InspectorOverlay::drawNodeHighlight()
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -130,7 +130,7 @@
</span><span class="cx"> decoder = TextResourceDecoder::create("text/html", "UTF-8");
</span><span class="cx"> else
</span><span class="cx"> decoder = TextResourceDecoder::create("text/plain", "UTF-8");
</span><del>- return WTF::move(decoder);
</del><ins>+ return decoder;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool InspectorPageAgent::cachedResourceContent(CachedResource* cachedResource, String* result, bool* base64Encoded)
</span><span class="lines">@@ -443,7 +443,7 @@
</span><span class="cx"> for (const auto& cookie : cookiesList)
</span><span class="cx"> cookies->addItem(buildObjectForCookie(cookie));
</span><span class="cx">
</span><del>- return WTF::move(cookies);
</del><ins>+ return cookies;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Vector<CachedResource*> cachedResourcesForFrame(Frame* frame)
</span><span class="lines">@@ -908,7 +908,7 @@
</span><span class="cx"> frameObject->setName(name);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(frameObject);
</del><ins>+ return frameObject;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Inspector::Protocol::Page::FrameResourceTree> InspectorPageAgent::buildObjectForFrameTree(Frame* frame)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorStyleSheetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -183,7 +183,7 @@
</span><span class="cx"> mediaObject->setSourceURL(sourceURL);
</span><span class="cx"> mediaObject->setSourceLine(media->queries()->lastLine());
</span><span class="cx"> }
</span><del>- return WTF::move(mediaObject);
</del><ins>+ return mediaObject;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static RefPtr<CSSRuleList> asCSSRuleList(CSSStyleSheet* styleSheet)
</span><span class="lines">@@ -327,7 +327,7 @@
</span><span class="cx"> result->addItem(WTF::move(entry));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool InspectorStyle::getText(String* result) const
</span><span class="lines">@@ -875,7 +875,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(inspectorSelector);
</del><ins>+ return inspectorSelector;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<Inspector::Protocol::Array<Inspector::Protocol::CSS::CSSSelector>> selectorsFromSource(const CSSRuleSourceData* sourceData, const String& sheetText, const CSSSelectorList& selectorList, Element* element)
</span><span class="lines">@@ -899,7 +899,7 @@
</span><span class="cx">
</span><span class="cx"> selector = CSSSelectorList::next(selector);
</span><span class="cx"> }
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Inspector::Protocol::CSS::CSSSelector> InspectorStyleSheet::buildObjectForSelector(const CSSSelector* selector, Element* element)
</span><span class="lines">@@ -931,7 +931,7 @@
</span><span class="cx"> .release();
</span><span class="cx"> if (sourceData)
</span><span class="cx"> result->setRange(buildSourceRangeObject(sourceData->ruleHeaderRange, lineEndings().get()));
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<Inspector::Protocol::CSS::CSSRule> InspectorStyleSheet::buildObjectForRule(CSSStyleRule* rule, Element* element)
</span><span class="lines">@@ -992,7 +992,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool InspectorStyleSheet::setStyleText(const InspectorCSSId& id, const String& text, String* oldText, ExceptionCode& ec)
</span><span class="lines">@@ -1231,7 +1231,7 @@
</span><span class="cx"> {
</span><span class="cx"> auto result = Inspector::Protocol::Array<Inspector::Protocol::CSS::CSSRule>::create();
</span><span class="cx"> if (!ruleList)
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx">
</span><span class="cx"> RefPtr<CSSRuleList> refRuleList = ruleList;
</span><span class="cx"> CSSStyleRuleVector rules;
</span><span class="lines">@@ -1240,7 +1240,7 @@
</span><span class="cx"> for (auto& rule : rules)
</span><span class="cx"> result->addItem(buildObjectForRule(rule.get(), nullptr));
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InspectorStyleSheet::collectFlatRules(RefPtr<CSSRuleList>&& ruleList, CSSStyleRuleVector* result)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -266,7 +266,7 @@
</span><span class="cx"> if (!m_enabledFromFrontend && m_pendingConsoleProfileRecords.isEmpty())
</span><span class="cx"> internalStop();
</span><span class="cx">
</span><del>- return WTF::move(profile);
</del><ins>+ return profile;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorTimelineRecordFactorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> if (stackTrace && stackTrace->size())
</span><span class="cx"> record->setValue(ASCIILiteral("stackTrace"), stackTrace->buildInspectorArray());
</span><span class="cx"> }
</span><del>- return WTF::move(record);
</del><ins>+ return record;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createFunctionCallData(const String& scriptName, int scriptLine)
</span><span class="lines">@@ -63,14 +63,14 @@
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setString(ASCIILiteral("scriptName"), scriptName);
</span><span class="cx"> data->setInteger(ASCIILiteral("scriptLine"), scriptLine);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createConsoleProfileData(const String& title)
</span><span class="cx"> {
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setString(ASCIILiteral("title"), title);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createProbeSampleData(const ScriptBreakpointAction& action, unsigned sampleId)
</span><span class="lines">@@ -78,21 +78,21 @@
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setInteger(ASCIILiteral("probeId"), action.identifier);
</span><span class="cx"> data->setInteger(ASCIILiteral("sampleId"), sampleId);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createEventDispatchData(const Event& event)
</span><span class="cx"> {
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setString(ASCIILiteral("type"), event.type().string());
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createGenericTimerData(int timerId)
</span><span class="cx"> {
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setInteger(ASCIILiteral("timerId"), timerId);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createTimerInstallData(int timerId, int timeout, bool singleShot)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> data->setInteger(ASCIILiteral("timerId"), timerId);
</span><span class="cx"> data->setInteger(ASCIILiteral("timeout"), timeout);
</span><span class="cx"> data->setBoolean(ASCIILiteral("singleShot"), singleShot);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createEvaluateScriptData(const String& url, double lineNumber)
</span><span class="lines">@@ -109,21 +109,21 @@
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setString(ASCIILiteral("url"), url);
</span><span class="cx"> data->setInteger(ASCIILiteral("lineNumber"), lineNumber);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createTimeStampData(const String& message)
</span><span class="cx"> {
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setString(ASCIILiteral("message"), message);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createAnimationFrameData(int callbackId)
</span><span class="cx"> {
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setInteger(ASCIILiteral("id"), callbackId);
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<InspectorArray> createQuad(const FloatQuad& quad)
</span><span class="lines">@@ -137,14 +137,14 @@
</span><span class="cx"> array->pushDouble(quad.p3().y());
</span><span class="cx"> array->pushDouble(quad.p4().x());
</span><span class="cx"> array->pushDouble(quad.p4().y());
</span><del>- return WTF::move(array);
</del><ins>+ return array;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createPaintData(const FloatQuad& quad)
</span><span class="cx"> {
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span><span class="cx"> data->setArray(ASCIILiteral("clip"), createQuad(quad));
</span><del>- return WTF::move(data);
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TimelineRecordFactory::appendLayoutRoot(InspectorObject* data, const FloatQuad& quad)
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx"> result->setChildren(WTF::move(children));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<Protocol::Timeline::CPUProfile> buildProfileInspectorObject(const JSC::Profile* profile)
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoader.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -3523,7 +3523,7 @@
</span><span class="cx"> if (Page* page = frame->page())
</span><span class="cx"> page->chrome().focus();
</span><span class="cx"> }
</span><del>- return WTF::move(frame);
</del><ins>+ return frame;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3615,7 +3615,7 @@
</span><span class="cx"> page->chrome().show();
</span><span class="cx">
</span><span class="cx"> created = true;
</span><del>- return WTF::move(frame);
</del><ins>+ return frame;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderNavigationActioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/NavigationAction.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/NavigationAction.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/loader/NavigationAction.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx"> {
</span><span class="cx"> NavigationAction result(*this);
</span><span class="cx"> result.m_shouldOpenExternalURLsPolicy = shouldOpenExternalURLsPolicy;
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -2128,7 +2128,7 @@
</span><span class="cx"> newFrame->page()->setOpenedByDOM();
</span><span class="cx">
</span><span class="cx"> if (newFrame->document()->domWindow()->isInsecureScriptAccess(activeWindow, completedURL))
</span><del>- return WTF::move(newFrame);
</del><ins>+ return newFrame;
</ins><span class="cx">
</span><span class="cx"> if (prepareDialogFunction)
</span><span class="cx"> prepareDialogFunction(*newFrame->document()->domWindow());
</span><span class="lines">@@ -2146,7 +2146,7 @@
</span><span class="cx"> if (!newFrame->page())
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- return WTF::move(newFrame);
</del><ins>+ return newFrame;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<DOMWindow> DOMWindow::open(const String& urlString, const AtomicString& frameName, const String& windowFeaturesString,
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkiosQuickLookmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ios/QuickLook.mm (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ios/QuickLook.mm 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/platform/network/ios/QuickLook.mm 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -403,7 +403,7 @@
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<QuickLookHandle> quickLookHandle(new QuickLookHandle([handle->firstRequest().nsURLRequest(DoNotUpdateHTTPBody) URL], connection, nsResponse, delegate));
</span><span class="cx"> handle->client()->didCreateQuickLookHandle(*quickLookHandle);
</span><del>- return WTF::move(quickLookHandle);
</del><ins>+ return quickLookHandle;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if USE(CFNETWORK)
</span><span class="lines">@@ -417,7 +417,7 @@
</span><span class="cx"> WebQuickLookHandleAsDelegate *delegate = [[[WebQuickLookHandleAsDelegate alloc] initWithConnectionDelegate:connectionDelegate] autorelease];
</span><span class="cx"> std::unique_ptr<QuickLookHandle> quickLookHandle(new QuickLookHandle([handle->firstRequest().nsURLRequest(DoNotUpdateHTTPBody) URL], nil, nsResponse, delegate));
</span><span class="cx"> handle->client()->didCreateQuickLookHandle(*quickLookHandle);
</span><del>- return WTF::move(quickLookHandle);
</del><ins>+ return quickLookHandle;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CFURLResponseRef QuickLookHandle::cfResponse()
</span><span class="lines">@@ -439,7 +439,7 @@
</span><span class="cx"> std::unique_ptr<QuickLookHandle> quickLookHandle(new QuickLookHandle([loader.originalRequest().nsURLRequest(DoNotUpdateHTTPBody) URL], nil, response.nsURLResponse(), delegate.get()));
</span><span class="cx"> [delegate setQuickLookHandle:quickLookHandle.get()];
</span><span class="cx"> loader.didCreateQuickLookHandle(*quickLookHandle);
</span><del>- return WTF::move(quickLookHandle);
</del><ins>+ return quickLookHandle;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> NSURLResponse *QuickLookHandle::nsResponse()
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/testing/Internals.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -1801,7 +1801,7 @@
</span><span class="cx"> RefPtr<DOMWindow> frontendWindow = window->open(url, "", "", *window, *window);
</span><span class="cx"> m_inspectorFrontend = std::make_unique<InspectorStubFrontend>(inspectedPage, frontendWindow.copyRef());
</span><span class="cx">
</span><del>- return WTF::move(frontendWindow);
</del><ins>+ return frontendWindow;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Internals::closeDummyInspectorFrontend()
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerScriptLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> {
</span><span class="cx"> auto request = std::make_unique<ResourceRequest>(m_url);
</span><span class="cx"> request->setHTTPMethod("GET");
</span><del>- return WTF::move(request);
</del><ins>+ return request;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WorkerScriptLoader::didReceiveResponse(unsigned long identifier, const ResourceResponse& response)
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXPathExpressioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XPathExpression.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XPathExpression.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebCore/xml/XPathExpression.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WTF::move(result);
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-12-25 Andy Estes <aestes@apple.com>
+
+ Stop moving local objects in return statements
+ https://bugs.webkit.org/show_bug.cgi?id=152557
+
+ Reviewed by Brady Eidson.
+
+ Calling std::move() on a local object in a return statement prevents the compiler from applying the return value optimization.
+
+ Clang can warn about these mistakes with -Wpessimizing-move, although only when std::move() is called directly.
+ I found these issues by temporarily replacing WTF::move with std::move and recompiling.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::ExceededDatabaseQuotaRecords::createRecord):
+
</ins><span class="cx"> 2015-12-26 Joonghun Park <jh718.park@samsung.com>
</span><span class="cx">
</span><span class="cx"> [WK2][EFL] Use eina_file_path_join at platformDefaultIconDatabasePath in WebProcessPoolEfl
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (194427 => 194428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-12-28 03:01:04 UTC (rev 194427)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-12-28 16:26:24 UTC (rev 194428)
</span><span class="lines">@@ -239,7 +239,7 @@
</span><span class="cx"> record->currentDatabaseUsage = currentDatabaseUsage;
</span><span class="cx"> record->expectedUsage = expectedUsage;
</span><span class="cx"> record->reply = reply;
</span><del>- return WTF::move(record);
</del><ins>+ return record;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ExceededDatabaseQuotaRecords::add(std::unique_ptr<ExceededDatabaseQuotaRecords::Record> record)
</span></span></pre>
</div>
</div>
</body>
</html>