<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194330] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194330">194330</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2015-12-21 07:16:58 -0800 (Mon, 21 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Different and incorrect flags are passed to sendSync when accessibility is enabled, SpinRunLoopWhileWaitingForReply
https://bugs.webkit.org/show_bug.cgi?id=126021
Reviewed by Darin Adler.
Get rid of SpinRunLoopWhileWaitingForReply because it’s not used anymore.
* Platform/IPC/Connection.cpp:
(IPC::Connection::waitForSyncReply): Removed the SpinRunLoopWhileWaitingForReply branch.
* Platform/IPC/Connection.h: Removed SpinRunLoopWhileWaitingForReply.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel): Don’t check
WebPage::synchronousMessagesShouldSpinRunLoop() and don’t specify
SpinRunLoopWhileWaitingForReply.
(WebKit::WebChromeClient::runJavaScriptAlert): Ditto.
(WebKit::WebChromeClient::runJavaScriptConfirm): Ditto.
(WebKit::WebChromeClient::runJavaScriptPrompt): Ditto.
(WebKit::WebChromeClient::print): Ditto.
(WebKit::WebChromeClient::exceededDatabaseQuota): Ditto.
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::synchronousMessagesShouldSpinRunLoop): Deleted.
* WebProcess/WebPage/WebPage.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2PlatformIPCConnectioncpp">trunk/Source/WebKit2/Platform/IPC/Connection.cpp</a></li>
<li><a href="#trunkSourceWebKit2PlatformIPCConnectionh">trunk/Source/WebKit2/Platform/IPC/Connection.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPageh">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (194329 => 194330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-12-21 15:15:23 UTC (rev 194329)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-21 15:16:58 UTC (rev 194330)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2015-12-21 Dan Bernstein <mitz@apple.com>
+
+ Different and incorrect flags are passed to sendSync when accessibility is enabled, SpinRunLoopWhileWaitingForReply
+ https://bugs.webkit.org/show_bug.cgi?id=126021
+
+ Reviewed by Darin Adler.
+
+ Get rid of SpinRunLoopWhileWaitingForReply because it’s not used anymore.
+
+ * Platform/IPC/Connection.cpp:
+ (IPC::Connection::waitForSyncReply): Removed the SpinRunLoopWhileWaitingForReply branch.
+
+ * Platform/IPC/Connection.h: Removed SpinRunLoopWhileWaitingForReply.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel): Don’t check
+ WebPage::synchronousMessagesShouldSpinRunLoop() and don’t specify
+ SpinRunLoopWhileWaitingForReply.
+ (WebKit::WebChromeClient::runJavaScriptAlert): Ditto.
+ (WebKit::WebChromeClient::runJavaScriptConfirm): Ditto.
+ (WebKit::WebChromeClient::runJavaScriptPrompt): Ditto.
+ (WebKit::WebChromeClient::print): Ditto.
+ (WebKit::WebChromeClient::exceededDatabaseQuota): Ditto.
+ (WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): Ditto.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::synchronousMessagesShouldSpinRunLoop): Deleted.
+ * WebProcess/WebPage/WebPage.h:
+
</ins><span class="cx"> 2015-12-20 Joonghun Park <jh718.park@samsung.com>
</span><span class="cx">
</span><span class="cx"> [WK2][EFL] Use WebsiteDataStore instead of WebDatabaseManager which has been deleted in r194295
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformIPCConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Platform/IPC/Connection.cpp (194329 => 194330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Platform/IPC/Connection.cpp 2015-12-21 15:15:23 UTC (rev 194329)
+++ trunk/Source/WebKit2/Platform/IPC/Connection.cpp 2015-12-21 15:16:58 UTC (rev 194330)
</span><span class="lines">@@ -582,18 +582,9 @@
</span><span class="cx"> // We didn't find a sync reply yet, keep waiting.
</span><span class="cx"> // This allows the WebProcess to still serve clients while waiting for the message to return.
</span><span class="cx"> // Notably, it can continue to process accessibility requests, which are on the main thread.
</span><del>- if (syncSendFlags & SpinRunLoopWhileWaitingForReply) {
-#if PLATFORM(COCOA)
- // FIXME: Although we run forever, any events incoming will cause us to drop out and exit out. This however doesn't
- // account for a timeout value passed in. Timeout is always NoTimeout in these cases, but that could change.
- RunLoop::current().runForDuration(1e10);
- timedOut = currentTime() >= absoluteTime;
-#endif
- } else
- timedOut = !SyncMessageState::singleton().wait(absoluteTime);
-
</del><ins>+ timedOut = !SyncMessageState::singleton().wait(absoluteTime);
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> didReceiveSyncReply(syncSendFlags);
</span><span class="cx">
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformIPCConnectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Platform/IPC/Connection.h (194329 => 194330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Platform/IPC/Connection.h 2015-12-21 15:15:23 UTC (rev 194329)
+++ trunk/Source/WebKit2/Platform/IPC/Connection.h 2015-12-21 15:16:58 UTC (rev 194330)
</span><span class="lines">@@ -69,10 +69,7 @@
</span><span class="cx"> enum SyncMessageSendFlags {
</span><span class="cx"> // Use this to inform that this sync call will suspend this process until the user responds with input.
</span><span class="cx"> InformPlatformProcessWillSuspend = 1 << 0,
</span><del>- // Some platform accessibility clients can't suspend gracefully and need to spin the run loop so WebProcess doesn't hang.
- // FIXME (126021): Remove when no platforms need to support this.
- SpinRunLoopWhileWaitingForReply = 1 << 1,
- UseFullySynchronousModeForTesting = 1 << 2,
</del><ins>+ UseFullySynchronousModeForTesting = 1 << 1,
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> enum WaitForMessageFlags {
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (194329 => 194330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2015-12-21 15:15:23 UTC (rev 194329)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2015-12-21 15:16:58 UTC (rev 194330)
</span><span class="lines">@@ -341,11 +341,7 @@
</span><span class="cx">
</span><span class="cx"> HangDetectionDisabler hangDetectionDisabler;
</span><span class="cx">
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
-
- if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunBeforeUnloadConfirmPanel(message, webFrame->frameID()), Messages::WebPageProxy::RunBeforeUnloadConfirmPanel::Reply(shouldClose), m_page->pageID(), std::chrono::milliseconds::max(), syncSendFlags))
</del><ins>+ if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunBeforeUnloadConfirmPanel(message, webFrame->frameID()), Messages::WebPageProxy::RunBeforeUnloadConfirmPanel::Reply(shouldClose), m_page->pageID(), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return shouldClose;
</span><span class="lines">@@ -380,10 +376,7 @@
</span><span class="cx">
</span><span class="cx"> HangDetectionDisabler hangDetectionDisabler;
</span><span class="cx">
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
- WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptAlert(webFrame->frameID(), SecurityOriginData::fromFrame(frame), alertText), Messages::WebPageProxy::RunJavaScriptAlert::Reply(), m_page->pageID(), std::chrono::milliseconds::max(), syncSendFlags);
</del><ins>+ WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptAlert(webFrame->frameID(), SecurityOriginData::fromFrame(frame), alertText), Messages::WebPageProxy::RunJavaScriptAlert::Reply(), m_page->pageID(), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool WebChromeClient::runJavaScriptConfirm(Frame* frame, const String& message)
</span><span class="lines">@@ -396,11 +389,8 @@
</span><span class="cx">
</span><span class="cx"> HangDetectionDisabler hangDetectionDisabler;
</span><span class="cx">
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
</del><span class="cx"> bool result = false;
</span><del>- if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptConfirm(webFrame->frameID(), SecurityOriginData::fromFrame(frame), message), Messages::WebPageProxy::RunJavaScriptConfirm::Reply(result), m_page->pageID(), std::chrono::milliseconds::max(), syncSendFlags))
</del><ins>+ if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptConfirm(webFrame->frameID(), SecurityOriginData::fromFrame(frame), message), Messages::WebPageProxy::RunJavaScriptConfirm::Reply(result), m_page->pageID(), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return result;
</span><span class="lines">@@ -416,11 +406,7 @@
</span><span class="cx">
</span><span class="cx"> HangDetectionDisabler hangDetectionDisabler;
</span><span class="cx">
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
-
- if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptPrompt(webFrame->frameID(), SecurityOriginData::fromFrame(frame), message, defaultValue), Messages::WebPageProxy::RunJavaScriptPrompt::Reply(result), m_page->pageID(), std::chrono::milliseconds::max(), syncSendFlags))
</del><ins>+ if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptPrompt(webFrame->frameID(), SecurityOriginData::fromFrame(frame), message, defaultValue), Messages::WebPageProxy::RunJavaScriptPrompt::Reply(result), m_page->pageID(), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return !result.isNull();
</span><span class="lines">@@ -644,11 +630,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
-
- m_page->sendSync(Messages::WebPageProxy::PrintFrame(webFrame->frameID()), Messages::WebPageProxy::PrintFrame::Reply(), std::chrono::milliseconds::max(), syncSendFlags);
</del><ins>+ m_page->sendSync(Messages::WebPageProxy::PrintFrame(webFrame->frameID()), Messages::WebPageProxy::PrintFrame::Reply(), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebChromeClient::exceededDatabaseQuota(Frame* frame, const String& databaseName, DatabaseDetails details)
</span><span class="lines">@@ -666,13 +648,9 @@
</span><span class="cx"> newQuota = m_page->injectedBundleUIClient().didExceedDatabaseQuota(m_page, securityOrigin.get(), databaseName, details.displayName(), currentQuota, currentOriginUsage, details.currentUsage(), details.expectedUsage());
</span><span class="cx">
</span><span class="cx"> if (!newQuota) {
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
-
</del><span class="cx"> WebProcess::singleton().parentProcessConnection()->sendSync(
</span><span class="cx"> Messages::WebPageProxy::ExceededDatabaseQuota(webFrame->frameID(), origin->databaseIdentifier(), databaseName, details.displayName(), currentQuota, currentOriginUsage, details.currentUsage(), details.expectedUsage()),
</span><del>- Messages::WebPageProxy::ExceededDatabaseQuota::Reply(newQuota), m_page->pageID(), std::chrono::milliseconds::max(), syncSendFlags);
</del><ins>+ Messages::WebPageProxy::ExceededDatabaseQuota::Reply(newQuota), m_page->pageID(), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> dbManager.setQuota(origin, newQuota);
</span><span class="lines">@@ -689,10 +667,6 @@
</span><span class="cx"> if (m_page->injectedBundleUIClient().didReachApplicationCacheOriginQuota(m_page, securityOrigin.get(), totalBytesNeeded))
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
-
</del><span class="cx"> auto& cacheStorage = ApplicationCacheStorage::singleton();
</span><span class="cx"> int64_t currentQuota = 0;
</span><span class="cx"> if (!cacheStorage.calculateQuotaForOrigin(origin, currentQuota))
</span><span class="lines">@@ -701,7 +675,7 @@
</span><span class="cx"> uint64_t newQuota = 0;
</span><span class="cx"> WebProcess::singleton().parentProcessConnection()->sendSync(
</span><span class="cx"> Messages::WebPageProxy::ReachedApplicationCacheOriginQuota(origin->databaseIdentifier(), currentQuota, totalBytesNeeded),
</span><del>- Messages::WebPageProxy::ReachedApplicationCacheOriginQuota::Reply(newQuota), m_page->pageID(), std::chrono::milliseconds::max(), syncSendFlags);
</del><ins>+ Messages::WebPageProxy::ReachedApplicationCacheOriginQuota::Reply(newQuota), m_page->pageID(), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend);
</ins><span class="cx">
</span><span class="cx"> cacheStorage.storeUpdatedQuotaForOrigin(origin, newQuota);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebFrameLoaderClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (194329 => 194330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2015-12-21 15:15:23 UTC (rev 194329)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2015-12-21 15:16:58 UTC (rev 194330)
</span><span class="lines">@@ -696,12 +696,8 @@
</span><span class="cx"> uint64_t policyAction;
</span><span class="cx"> DownloadID downloadID;
</span><span class="cx">
</span><del>- unsigned syncSendFlags = IPC::InformPlatformProcessWillSuspend;
- if (WebPage::synchronousMessagesShouldSpinRunLoop())
- syncSendFlags |= IPC::SpinRunLoopWhileWaitingForReply;
-
</del><span class="cx"> WebCore::Frame* coreFrame = m_frame ? m_frame->coreFrame() : nullptr;
</span><del>- if (!webPage->sendSync(Messages::WebPageProxy::DecidePolicyForResponseSync(m_frame->frameID(), SecurityOriginData::fromFrame(coreFrame), response, request, canShowMIMEType, listenerID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())), Messages::WebPageProxy::DecidePolicyForResponseSync::Reply(receivedPolicyAction, policyAction, downloadID), std::chrono::milliseconds::max(), syncSendFlags)) {
</del><ins>+ if (!webPage->sendSync(Messages::WebPageProxy::DecidePolicyForResponseSync(m_frame->frameID(), SecurityOriginData::fromFrame(coreFrame), response, request, canShowMIMEType, listenerID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())), Messages::WebPageProxy::DecidePolicyForResponseSync::Reply(receivedPolicyAction, policyAction, downloadID), std::chrono::milliseconds::max(), IPC::InformPlatformProcessWillSuspend)) {
</ins><span class="cx"> m_frame->didReceivePolicyDecision(listenerID, PolicyIgnore, 0, { });
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (194329 => 194330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2015-12-21 15:15:23 UTC (rev 194329)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2015-12-21 15:16:58 UTC (rev 194330)
</span><span class="lines">@@ -5007,11 +5007,6 @@
</span><span class="cx"> return TextIterator::rangeFromLocationAndLength(frame.selection().rootEditableElementOrDocumentElement(), static_cast<int>(range.location), length);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WebPage::synchronousMessagesShouldSpinRunLoop()
-{
- return false;
-}
-
</del><span class="cx"> void WebPage::didChangeScrollOffsetForFrame(Frame* frame)
</span><span class="cx"> {
</span><span class="cx"> if (!frame->isMainFrame())
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (194329 => 194330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2015-12-21 15:15:23 UTC (rev 194329)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2015-12-21 15:16:58 UTC (rev 194330)
</span><span class="lines">@@ -881,10 +881,6 @@
</span><span class="cx">
</span><span class="cx"> void getBytecodeProfile(uint64_t callbackID);
</span><span class="cx">
</span><del>- // Some platforms require accessibility-enabled processes to spin the run loop so that the WebProcess doesn't hang.
- // While this is not ideal, it does not have to be applied to every platform at the moment.
- static bool synchronousMessagesShouldSpinRunLoop();
-
</del><span class="cx"> #if ENABLE(SERVICE_CONTROLS) || ENABLE(TELEPHONE_NUMBER_DETECTION)
</span><span class="cx"> void handleTelephoneNumberClick(const String& number, const WebCore::IntPoint&);
</span><span class="cx"> void handleSelectionServiceClick(WebCore::FrameSelection&, const Vector<String>& telephoneNumbers, const WebCore::IntPoint&);
</span></span></pre>
</div>
</div>
</body>
</html>