<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194322] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194322">194322</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2015-12-20 13:57:01 -0800 (Sun, 20 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unused setToolbarHeight
https://bugs.webkit.org/show_bug.cgi?id=152466
Reviewed by Darin Adler.
Source/WebCore:
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setToolbarHeight): Deleted.
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* testing/Internals.cpp:
Source/WebInspectorUI:
* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
* UserInterface/Protocol/InspectorFrontendHostStub.js:
(window.InspectorFrontendHost.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight): Deleted.
Source/WebKit/ios:
* WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorFrontendClient::setToolbarHeight): Deleted.
Source/WebKit/mac:
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm::
(WebInspectorFrontendClient::setToolbarHeight): Deleted.
Source/WebKit/win:
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::setToolbarHeight): Deleted.
* WebCoreSupport/WebInspectorClient.h:
Source/WebKit2:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::setToolbarHeight): Deleted.
* UIProcess/WebInspectorProxy.messages.in:
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::setToolbarHeight): Deleted.
* WebProcess/WebPage/WebInspectorUI.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendClienth">trunk/Source/WebCore/inspector/InspectorFrontendClient.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHostcpp">trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHosth">trunk/Source/WebCore/inspector/InspectorFrontendHost.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHostidl">trunk/Source/WebCore/inspector/InspectorFrontendHost.idl</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolInspectorFrontendHostStubjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js</a></li>
<li><a href="#trunkSourceWebKitiosChangeLog">trunk/Source/WebKit/ios/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitiosWebCoreSupportWebInspectorClientIOSmm">trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebInspectorClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebInspectorClientmm">trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebInspectorClientcpp">trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebInspectorClienth">trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebInspectorProxycpp">trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebInspectorProxyh">trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebInspectorProxymessagesin">trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in</a></li>
<li><a href="#trunkSourceWebKit2UIProcesseflWebInspectorProxyEflcpp">trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessgtkWebInspectorProxyGtkcpp">trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacWebInspectorProxyMacmm">trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorUIcpp">trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorUIh">trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-12-20 Dan Bernstein <mitz@apple.com>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * inspector/InspectorFrontendClient.h:
+ * inspector/InspectorFrontendHost.cpp:
+ (WebCore::InspectorFrontendHost::setToolbarHeight): Deleted.
+ * inspector/InspectorFrontendHost.h:
+ * inspector/InspectorFrontendHost.idl:
+ * testing/Internals.cpp:
+
</ins><span class="cx"> 2015-12-20 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r194033 and r194267.
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -64,8 +64,6 @@
</span><span class="cx"> WEBCORE_EXPORT virtual void changeAttachedWindowHeight(unsigned) = 0;
</span><span class="cx"> WEBCORE_EXPORT virtual void changeAttachedWindowWidth(unsigned) = 0;
</span><span class="cx">
</span><del>- virtual void setToolbarHeight(unsigned) = 0;
-
</del><span class="cx"> WEBCORE_EXPORT virtual void openInNewTab(const String& url) = 0;
</span><span class="cx">
</span><span class="cx"> virtual bool canSave() = 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendHostcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -208,12 +208,6 @@
</span><span class="cx"> m_client->changeAttachedWindowWidth(width);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorFrontendHost::setToolbarHeight(unsigned height)
-{
- if (m_client)
- m_client->setToolbarHeight(height);
-}
-
</del><span class="cx"> void InspectorFrontendHost::startWindowDrag()
</span><span class="cx"> {
</span><span class="cx"> if (m_client)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendHosth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -64,7 +64,6 @@
</span><span class="cx">
</span><span class="cx"> void setAttachedWindowHeight(unsigned);
</span><span class="cx"> void setAttachedWindowWidth(unsigned);
</span><del>- void setToolbarHeight(unsigned);
</del><span class="cx">
</span><span class="cx"> void startWindowDrag();
</span><span class="cx"> void moveWindowBy(float x, float y) const;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendHostidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -46,7 +46,6 @@
</span><span class="cx">
</span><span class="cx"> void setAttachedWindowHeight(unsigned long height);
</span><span class="cx"> void setAttachedWindowWidth(unsigned long width);
</span><del>- void setToolbarHeight(unrestricted float height);
</del><span class="cx">
</span><span class="cx"> void startWindowDrag();
</span><span class="cx"> void moveWindowBy(unrestricted float x, unrestricted float y);
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebCore/testing/Internals.cpp 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -234,7 +234,6 @@
</span><span class="cx"> protected:
</span><span class="cx"> virtual void setAttachedWindowHeight(unsigned) override { }
</span><span class="cx"> virtual void setAttachedWindowWidth(unsigned) override { }
</span><del>- virtual void setToolbarHeight(unsigned) override { }
</del><span class="cx">
</span><span class="cx"> public:
</span><span class="cx"> // Inspector::FrontendChannel API
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-12-20 Dan Bernstein <mitz@apple.com>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.contentLoaded):
+ * UserInterface/Protocol/InspectorFrontendHostStub.js:
+ (window.InspectorFrontendHost.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight): Deleted.
+
</ins><span class="cx"> 2015-12-19 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] WebKit contains dead source code for OS X Mavericks and earlier
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -366,7 +366,6 @@
</span><span class="cx"> this._dockingAvailable = false;
</span><span class="cx">
</span><span class="cx"> this._updateDockNavigationItems();
</span><del>- this._updateToolbarHeight();
</del><span class="cx"> this._setupViewHierarchy();
</span><span class="cx">
</span><span class="cx"> // These tabs are always available for selecting, modulo isTabAllowed().
</span><span class="lines">@@ -1436,12 +1435,6 @@
</span><span class="cx"> this._tabBrowserSizeDidChange();
</span><span class="cx"> };
</span><span class="cx">
</span><del>-WebInspector._updateToolbarHeight = function()
-{
- if (WebInspector.Platform.name === "mac" && WebInspector.Platform.version.release < 10)
- InspectorFrontendHost.setToolbarHeight(this.toolbar.element.offsetHeight);
-};
-
</del><span class="cx"> WebInspector._setupViewHierarchy = function()
</span><span class="cx"> {
</span><span class="cx"> let rootView = WebInspector.View.rootView();
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolInspectorFrontendHostStubjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -84,10 +84,6 @@
</span><span class="cx"> {
</span><span class="cx"> },
</span><span class="cx">
</span><del>- setToolbarHeight: function(width)
- {
- },
-
</del><span class="cx"> startWindowDrag: function()
</span><span class="cx"> {
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkSourceWebKitiosChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/ChangeLog (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/ios/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-12-20 Dan Bernstein <mitz@apple.com>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebInspectorClientIOS.mm:
+ (WebInspectorFrontendClient::setToolbarHeight): Deleted.
+
</ins><span class="cx"> 2015-12-18 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Turn off "shrink-to-fit" viewport scaling in UIWebViews
</span></span></pre></div>
<a id="trunkSourceWebKitiosWebCoreSupportWebInspectorClientIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -128,7 +128,6 @@
</span><span class="cx"> void WebInspectorFrontendClient::detachWindow() { }
</span><span class="cx"> void WebInspectorFrontendClient::setAttachedWindowHeight(unsigned) { }
</span><span class="cx"> void WebInspectorFrontendClient::setAttachedWindowWidth(unsigned) { }
</span><del>-void WebInspectorFrontendClient::setToolbarHeight(unsigned) { }
</del><span class="cx"> void WebInspectorFrontendClient::startWindowDrag() { }
</span><span class="cx"> void WebInspectorFrontendClient::inspectedURLChanged(const String&) { }
</span><span class="cx"> void WebInspectorFrontendClient::updateWindowTitle() const { }
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-12-20 Dan Bernstein <mitz@apple.com>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ * WebCoreSupport/WebInspectorClient.mm::
+ (WebInspectorFrontendClient::setToolbarHeight): Deleted.
+
</ins><span class="cx"> 2015-12-19 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] WebKit contains dead source code for OS X Mavericks and earlier
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -119,7 +119,6 @@
</span><span class="cx">
</span><span class="cx"> virtual void setAttachedWindowHeight(unsigned height) override;
</span><span class="cx"> virtual void setAttachedWindowWidth(unsigned height) override;
</span><del>- virtual void setToolbarHeight(unsigned) override;
</del><span class="cx">
</span><span class="cx"> virtual void inspectedURLChanged(const String& newURL) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebInspectorClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -272,10 +272,6 @@
</span><span class="cx"> // Dock to right is not implemented in WebKit 1.
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorFrontendClient::setToolbarHeight(unsigned height)
-{
-}
-
</del><span class="cx"> void WebInspectorFrontendClient::inspectedURLChanged(const String& newURL)
</span><span class="cx"> {
</span><span class="cx"> m_inspectedURL = newURL;
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/win/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-12-20 Dan Bernstein <mitz@apple.com>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebInspectorClient.cpp:
+ (WebInspectorFrontendClient::setToolbarHeight): Deleted.
+ * WebCoreSupport/WebInspectorClient.h:
+
</ins><span class="cx"> 2015-12-15 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> [TexMap] Operate with a reference to the TextureMapper wherever possible
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebInspectorClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -327,11 +327,6 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorFrontendClient::setToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
</del><span class="cx"> void WebInspectorFrontendClient::inspectedURLChanged(const String& newURL)
</span><span class="cx"> {
</span><span class="cx"> m_inspectedURL = newURL;
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -105,7 +105,6 @@
</span><span class="cx">
</span><span class="cx"> virtual void setAttachedWindowHeight(unsigned) override;
</span><span class="cx"> virtual void setAttachedWindowWidth(unsigned) override;
</span><del>- virtual void setToolbarHeight(unsigned) override;
</del><span class="cx">
</span><span class="cx"> virtual void inspectedURLChanged(const WTF::String& newURL) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2015-12-20 Dan Bernstein <mitz@apple.com>
+
+ Remove unused setToolbarHeight
+ https://bugs.webkit.org/show_bug.cgi?id=152466
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * UIProcess/WebInspectorProxy.h:
+ (WebKit::WebInspectorProxy::setToolbarHeight): Deleted.
+ * UIProcess/WebInspectorProxy.messages.in:
+ * UIProcess/efl/WebInspectorProxyEfl.cpp:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * UIProcess/gtk/WebInspectorProxyGtk.cpp:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::setToolbarHeight): Deleted.
+ * WebProcess/WebPage/WebInspectorUI.h:
+
</ins><span class="cx"> 2015-12-19 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] WebKit contains dead source code for OS X Mavericks and earlier
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebInspectorProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -732,11 +732,6 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorProxy::platformSetToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
</del><span class="cx"> void WebInspectorProxy::platformStartWindowDrag()
</span><span class="cx"> {
</span><span class="cx"> notImplemented();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebInspectorProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -128,7 +128,6 @@
</span><span class="cx">
</span><span class="cx"> void setAttachedWindowHeight(unsigned);
</span><span class="cx"> void setAttachedWindowWidth(unsigned);
</span><del>- void setToolbarHeight(unsigned height) { platformSetToolbarHeight(height); }
</del><span class="cx">
</span><span class="cx"> void startWindowDrag();
</span><span class="cx">
</span><span class="lines">@@ -176,7 +175,6 @@
</span><span class="cx"> void platformDetach();
</span><span class="cx"> void platformSetAttachedWindowHeight(unsigned);
</span><span class="cx"> void platformSetAttachedWindowWidth(unsigned);
</span><del>- void platformSetToolbarHeight(unsigned);
</del><span class="cx"> void platformStartWindowDrag();
</span><span class="cx"> void platformSave(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs);
</span><span class="cx"> void platformAppend(const String& filename, const String& content);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebInspectorProxymessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -39,7 +39,6 @@
</span><span class="cx">
</span><span class="cx"> SetAttachedWindowHeight(unsigned height)
</span><span class="cx"> SetAttachedWindowWidth(unsigned width)
</span><del>- SetToolbarHeight(unsigned height)
</del><span class="cx">
</span><span class="cx"> StartWindowDrag()
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesseflWebInspectorProxyEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -232,11 +232,6 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorProxy::platformSetToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
</del><span class="cx"> void WebInspectorProxy::platformStartWindowDrag()
</span><span class="cx"> {
</span><span class="cx"> notImplemented();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessgtkWebInspectorProxyGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -343,11 +343,6 @@
</span><span class="cx"> webkitWebViewBaseSetInspectorViewSize(WEBKIT_WEB_VIEW_BASE(inspectedPage()->viewWidget()), width);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorProxy::platformSetToolbarHeight(unsigned)
-{
- notImplemented();
-}
-
</del><span class="cx"> void WebInspectorProxy::platformStartWindowDrag()
</span><span class="cx"> {
</span><span class="cx"> notImplemented();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacWebInspectorProxyMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -784,10 +784,6 @@
</span><span class="cx"> inspectedViewFrameDidChange(width);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorProxy::platformSetToolbarHeight(unsigned height)
-{
-}
-
</del><span class="cx"> void WebInspectorProxy::platformStartWindowDrag()
</span><span class="cx"> {
</span><span class="cx"> #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorUIcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -187,11 +187,6 @@
</span><span class="cx"> WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::SetAttachedWindowWidth(width), m_inspectedPageIdentifier);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorUI::setToolbarHeight(unsigned height)
-{
- WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::SetToolbarHeight(height), m_inspectedPageIdentifier);
-}
-
</del><span class="cx"> void WebInspectorUI::openInNewTab(const String& url)
</span><span class="cx"> {
</span><span class="cx"> if (m_backendConnection)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorUIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h (194321 => 194322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-12-20 20:08:36 UTC (rev 194321)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-12-20 21:57:01 UTC (rev 194322)
</span><span class="lines">@@ -91,8 +91,6 @@
</span><span class="cx"> void changeAttachedWindowHeight(unsigned) override;
</span><span class="cx"> void changeAttachedWindowWidth(unsigned) override;
</span><span class="cx">
</span><del>- void setToolbarHeight(unsigned) override;
-
</del><span class="cx"> void openInNewTab(const String& url) override;
</span><span class="cx">
</span><span class="cx"> bool canSave() override;
</span></span></pre>
</div>
</div>
</body>
</html>