<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194232] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194232">194232</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-17 14:13:45 -0800 (Thu, 17 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Dashboard charts should have uniform widths on v3 UI
https://bugs.webkit.org/show_bug.cgi?id=152395
Reviewed by Chris Dumez.
Fix the bug by applying table-layout: fixed on the dashboard table.
* public/v3/pages/dashboard-page.js:
(DashboardPage.prototype.render): Added header-column as a class name to explicitly set the header column with.
(DashboardPage.cssTemplate): Adjusted CSS accordingly.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagesdashboardpagejs">trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (194231 => 194232)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 22:11:59 UTC (rev 194231)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 22:13:45 UTC (rev 194232)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2015-12-17 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Dashboard charts should have uniform widths on v3 UI
+ https://bugs.webkit.org/show_bug.cgi?id=152395
+
+ Reviewed by Chris Dumez.
+
+ Fix the bug by applying table-layout: fixed on the dashboard table.
+
+ * public/v3/pages/dashboard-page.js:
+ (DashboardPage.prototype.render): Added header-column as a class name to explicitly set the header column with.
+ (DashboardPage.cssTemplate): Adjusted CSS accordingly.
+
+2015-12-17 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Closing a pane on v3 UI always closes the last pane
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=152388
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagesdashboardpagejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js (194231 => 194232)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js 2015-12-17 22:11:59 UTC (rev 194231)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js 2015-12-17 22:13:45 UTC (rev 194232)
</span><span class="lines">@@ -92,7 +92,11 @@
</span><span class="cx"> var tree = [];
</span><span class="cx"> for (var group of this._tableGroups) {
</span><span class="cx"> tree.push(element('thead', element('tr',
</span><del>- group[0].map(function (cell) { return element('td', cell.content || cell); }))));
</del><ins>+ group[0].map(function (cell, cellIndex) {
+ if (!cellIndex)
+ return element('th', {class: 'heading-column'});
+ return element('td', cell.content || cell);
+ }))));
</ins><span class="cx">
</span><span class="cx"> tree.push(element('tbody', group.slice(1).map(function (row) {
</span><span class="cx"> return element('tr', row.map(function (cell, cellIndex) {
</span><span class="lines">@@ -164,6 +168,9 @@
</span><span class="cx"> static cssTemplate()
</span><span class="cx"> {
</span><span class="cx"> return `
</span><ins>+ .dashboard-table {
+ table-layout: fixed;
+ }
</ins><span class="cx"> .dashboard-table td,
</span><span class="cx"> .dashboard-table th {
</span><span class="cx"> border: none;
</span><span class="lines">@@ -183,6 +190,10 @@
</span><span class="cx"> width: 2rem;
</span><span class="cx"> position: relative;
</span><span class="cx"> }
</span><ins>+ .dashboard-table .heading-column {
+ width: 2rem;
+ height: 1rem;
+ }
</ins><span class="cx"> .dashboard-table th .vertical-label {
</span><span class="cx"> position: absolute;
</span><span class="cx"> left: 0;
</span></span></pre>
</div>
</div>
</body>
</html>