<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194240] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194240">194240</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-17 15:02:25 -0800 (Thu, 17 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>v3 UI shouldn't open/close pane selector by mouseenter/leave
https://bugs.webkit.org/show_bug.cgi?id=152399
Reviewed by Andreas Kling.
Removed the code to open and close the pane selector by mouseenter and mouseleave
since multiple people have complained about the behavior.
* public/v3/pages/charts-toolbar.js:
(ChartsToolbar): Removed the event listeners.
(ChartsToolbar.prototype._addPane): Don't close the pane selector when adding a new pane
to better support the use case of adding multiple panes.
(ChartsToolbar.cssTemplate): Tweaked CSS.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pageschartstoolbarjs">trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (194239 => 194240)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 22:57:13 UTC (rev 194239)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-12-17 23:02:25 UTC (rev 194240)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2015-12-17 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ v3 UI shouldn't open/close pane selector by mouseenter/leave
+ https://bugs.webkit.org/show_bug.cgi?id=152399
+
+ Reviewed by Andreas Kling.
+
+ Removed the code to open and close the pane selector by mouseenter and mouseleave
+ since multiple people have complained about the behavior.
+
+ * public/v3/pages/charts-toolbar.js:
+ (ChartsToolbar): Removed the event listeners.
+ (ChartsToolbar.prototype._addPane): Don't close the pane selector when adding a new pane
+ to better support the use case of adding multiple panes.
+ (ChartsToolbar.cssTemplate): Tweaked CSS.
+
+2015-12-17 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Popover for analysis tasks shows up at the left edge of annotation bars in the v3 UI
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=152389
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pageschartstoolbarjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js (194239 => 194240)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js 2015-12-17 22:57:13 UTC (rev 194239)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js 2015-12-17 23:02:25 UTC (rev 194240)
</span><span class="lines">@@ -18,26 +18,8 @@
</span><span class="cx">
</span><span class="cx"> this._paneSelector.setCallback(this._addPane.bind(this));
</span><span class="cx"> this._paneSelectorOpener.addEventListener('click', this._togglePaneSelector.bind(this));
</span><del>-
- var self = this;
- this._paneSelectorOpener.addEventListener('mouseenter', function () {
- self._openPaneSelector(false);
- temporarilyIgnoreMouseleave = true;
- setTimeout(function () { temporarilyIgnoreMouseleave = false; }, 0);
- });
- this._paneSelectorContainer.style.display = 'none';
</del><span class="cx">
</span><del>- var temporarilyIgnoreMouseleave = false;
- this._paneSelectorContainer.addEventListener('mousemove', function () {
- temporarilyIgnoreMouseleave = true; // Workaround webkit.org/b/152170
- setTimeout(function () { temporarilyIgnoreMouseleave = false; }, 0);
- });
- this._paneSelectorContainer.addEventListener('mouseleave', function (event) {
- setTimeout(function () {
- if (!temporarilyIgnoreMouseleave)
- self._closePaneSelector();
- }, 0);
- });
</del><ins>+ this._paneSelectorContainer.style.display = 'none';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> render()
</span><span class="lines">@@ -75,7 +57,6 @@
</span><span class="cx"> this._numberOfDaysCallback(numberOfDays, event.type == 'change');
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> _togglePaneSelector(event)
</span><span class="cx"> {
</span><span class="cx"> event.preventDefault();
</span><span class="lines">@@ -107,11 +88,8 @@
</span><span class="cx">
</span><span class="cx"> _addPane(platform, metric)
</span><span class="cx"> {
</span><del>- if (!this._addPaneCallback)
- return;
-
- this._closePaneSelector();
- this._addPaneCallback(platform, metric);
</del><ins>+ if (this._addPaneCallback)
+ this._addPaneCallback(platform, metric);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -135,6 +113,10 @@
</span><span class="cx"> {
</span><span class="cx"> return Toolbar.cssTemplate() + `
</span><span class="cx">
</span><ins>+ .charts-toolbar > .buttoned-toolbar:first-child {
+ margin-right: 0.5rem;
+ }
+
</ins><span class="cx"> .buttoned-toolbar li a.pane-selector-opener:hover {
</span><span class="cx"> background: rgba(204, 153, 51, 0.1);
</span><span class="cx"> }
</span><span class="lines">@@ -153,6 +135,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .start-time-slider {
</span><ins>+ padding-left: 1rem;
</ins><span class="cx"> line-height: 1em;
</span><span class="cx"> font-size: 0.9rem;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>