<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[194093] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/194093">194093</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-14 21:15:52 -0800 (Mon, 14 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Using fake timestamp in OS version make some results invisible
https://bugs.webkit.org/show_bug.cgi?id=152289
Reviewed by Stephanie Lewis.
Fix various bugs after <a href="http://trac.webkit.org/projects/webkit/changeset/194088">r194088</a>.
* public/api/commits.php:
(format_commit): Include the commit order.
* public/v2/data.js:
(CommitLogs._cacheConsecutiveCommits): Sort by commit order when commit time is missing.
* tools/pull-os-versions.py:
(OSBuildFetcher._assign_order): Use integer instead of fake time for commit order.
(available_builds_from_command): Exit early when an exception is thrown.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicapicommitsphp">trunk/Websites/perf.webkit.org/public/api/commits.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2datajs">trunk/Websites/perf.webkit.org/public/v2/data.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgtoolspullosversionspy">trunk/Websites/perf.webkit.org/tools/pull-os-versions.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (194092 => 194093)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-12-15 04:52:55 UTC (rev 194092)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-12-15 05:15:52 UTC (rev 194093)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2015-12-14 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Using fake timestamp in OS version make some results invisible
+ https://bugs.webkit.org/show_bug.cgi?id=152289
+
+ Reviewed by Stephanie Lewis.
+
+ Fix various bugs after r194088.
+
+ * public/api/commits.php:
+ (format_commit): Include the commit order.
+ * public/v2/data.js:
+ (CommitLogs._cacheConsecutiveCommits): Sort by commit order when commit time is missing.
+ * tools/pull-os-versions.py:
+ (OSBuildFetcher._assign_order): Use integer instead of fake time for commit order.
+ (available_builds_from_command): Exit early when an exception is thrown.
+
+2015-12-14 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Fix a typo in the previous commit.
</span><span class="cx">
</span><span class="cx"> * public/include/report-processor.php:
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicapicommitsphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/api/commits.php (194092 => 194093)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/api/commits.php 2015-12-15 04:52:55 UTC (rev 194092)
+++ trunk/Websites/perf.webkit.org/public/api/commits.php 2015-12-15 05:15:52 UTC (rev 194093)
</span><span class="lines">@@ -116,6 +116,7 @@
</span><span class="cx"> 'revision' => $commit_row['commit_revision'],
</span><span class="cx"> 'parent' => $commit_row['commit_parent'],
</span><span class="cx"> 'time' => Database::to_js_time($commit_row['commit_time']),
</span><ins>+ 'order' => $commit_row['commit_order'],
</ins><span class="cx"> 'authorName' => $committer_row ? $committer_row['committer_name'] : null,
</span><span class="cx"> 'authorEmail' => $committer_row ? $committer_row['committer_account'] : null,
</span><span class="cx"> 'message' => $commit_row['commit_message']
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2datajs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (194092 => 194093)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/data.js 2015-12-15 04:52:55 UTC (rev 194092)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js 2015-12-15 05:15:52 UTC (rev 194093)
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> cachedCommits.commitsByTime.push(commit);
</span><span class="cx"> });
</span><span class="cx">
</span><del>- cachedCommits.commitsByTime.sort(function (a, b) { return a.time - b.time; });
</del><ins>+ cachedCommits.commitsByTime.sort(function (a, b) { return a.time && b.time ? (a.time - b.time) : (a.order - b.order); });
</ins><span class="cx"> cachedCommits.commitsByTime.forEach(function (commit, index) { commit.cacheIndex = index; });
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgtoolspullosversionspy"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/tools/pull-os-versions.py (194092 => 194093)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/tools/pull-os-versions.py 2015-12-15 04:52:55 UTC (rev 194092)
+++ trunk/Websites/perf.webkit.org/tools/pull-os-versions.py 2015-12-15 05:15:52 UTC (rev 194093)
</span><span class="lines">@@ -79,9 +79,7 @@
</span><span class="cx"> kind = ord(match.group('kind').upper()) - ord('A')
</span><span class="cx"> minor = int(match.group('minor'))
</span><span class="cx"> variant = ord(match.group('variant').upper()) - ord('A') + 1 if match.group('variant') else 0
</span><del>- # These fake times won't conflict with real commit time since even 99Z9999z is still in Feb 1973
- fake_time = datetime.utcfromtimestamp((major * 100 + kind) * 10000 + minor + float(variant) / 100)
- commit['order'] = fake_time.isoformat()
</del><ins>+ commit['order'] = ((major * 100 + kind) * 10000 + minor) * 100 + variant
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> def available_builds_from_command(repository_name, command, lines_to_ignore):
</span><span class="lines">@@ -89,6 +87,7 @@
</span><span class="cx"> output = subprocess.check_output(command, stderr=subprocess.STDOUT)
</span><span class="cx"> except subprocess.CalledProcessError as error:
</span><span class="cx"> print "Failed:", str(error)
</span><ins>+ return []
</ins><span class="cx">
</span><span class="cx"> regex = re.compile(lines_to_ignore)
</span><span class="cx"> return [{'repository': repository_name, 'revision': line} for line in output.split('\n') if not regex.match(line)]
</span></span></pre>
</div>
</div>
</body>
</html>