<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193972] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193972">193972</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-11 12:56:12 -0800 (Fri, 11 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
https://bugs.webkit.org/show_bug.cgi?id=152156
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-12-11
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
* llvm/InitializeLLVMMac.cpp:
Remove stale comment. The ObjC class this comment referenced
has already been removed.
Source/WebCore:
* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::CDMSessionAVContentKeySession):
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::CDMSessionAVStreamSession):
Rename classes with a "Web" prefix.
Source/WebKit2:
* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
Rename internal classes with "_WK" prefix.
Tools:
Our frameworks should appropriately prefix all ObjC classes,
not just external symbols.
* Scripts/check-for-inappropriate-objc-class-names:
Remove the -g switch to check all ObjC class names.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorellvmInitializeLLVMMaccpp">trunk/Source/JavaScriptCore/llvm/InitializeLLVMMac.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVContentKeySessionh">trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVContentKeySessionmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVStreamSessionh">trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVStreamSessionmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWebVideoFullscreenManagerProxymm">trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxyh">trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxymm">trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptscheckforinappropriateobjcclassnames">trunk/Tools/Scripts/check-for-inappropriate-objc-class-names</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
+
+ check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
+ https://bugs.webkit.org/show_bug.cgi?id=152156
+
+ Reviewed by Dan Bernstein.
+
+ * llvm/InitializeLLVMMac.cpp:
+ Remove stale comment. The ObjC class this comment referenced
+ has already been removed.
+
</ins><span class="cx"> 2015-12-11 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> [JSC] Little cleanup of FTLOutput type casts and conversions
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorellvmInitializeLLVMMaccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/llvm/InitializeLLVMMac.cpp (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/llvm/InitializeLLVMMac.cpp 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/JavaScriptCore/llvm/InitializeLLVMMac.cpp 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -32,9 +32,6 @@
</span><span class="cx"> #include "InitializeLLVMPOSIX.h"
</span><span class="cx"> #include <wtf/StringPrintStream.h>
</span><span class="cx">
</span><del>-// Use the "JS" prefix to make check-for-inappropriate-objc-class-names happy. I
-// think this is better than hacking that script.
-
</del><span class="cx"> namespace JSC {
</span><span class="cx">
</span><span class="cx"> LLVMInitializerFunction getLLVMInitializerFunction(bool verbose)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebCore/ChangeLog 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
+
+ check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
+ https://bugs.webkit.org/show_bug.cgi?id=152156
+
+ Reviewed by Dan Bernstein.
+
+ * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
+ * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
+ (WebCore::CDMSessionAVContentKeySession::CDMSessionAVContentKeySession):
+ * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
+ * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
+ (WebCore::CDMSessionAVStreamSession::CDMSessionAVStreamSession):
+ Rename classes with a "Web" prefix.
+
</ins><span class="cx"> 2015-12-11 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Modern IDB: storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html fails.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVContentKeySessionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx">
</span><span class="cx"> OBJC_CLASS AVContentKeyRequest;
</span><span class="cx"> OBJC_CLASS AVContentKeySession;
</span><del>-OBJC_CLASS CDMSessionAVContentKeySessionDelegate;
</del><ins>+OBJC_CLASS WebCDMSessionAVContentKeySessionDelegate;
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx"> AVContentKeySession* contentKeySession();
</span><span class="cx">
</span><span class="cx"> RetainPtr<AVContentKeySession> m_contentKeySession;
</span><del>- RetainPtr<CDMSessionAVContentKeySessionDelegate> m_contentKeySessionDelegate;
</del><ins>+ RetainPtr<WebCDMSessionAVContentKeySessionDelegate> m_contentKeySessionDelegate;
</ins><span class="cx"> RetainPtr<AVContentKeyRequest> m_keyRequest;
</span><span class="cx"> RefPtr<Uint8Array> m_initData;
</span><span class="cx"> RetainPtr<NSData> m_expiredSession;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVContentKeySessionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -80,13 +80,13 @@
</span><span class="cx"> - (void)renewExpiringContentKeyResponseData;
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@interface CDMSessionAVContentKeySessionDelegate : NSObject {
</del><ins>+@interface WebCDMSessionAVContentKeySessionDelegate : NSObject {
</ins><span class="cx"> WebCore::CDMSessionAVContentKeySession *m_parent;
</span><span class="cx"> }
</span><span class="cx"> - (void)invalidate;
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@implementation CDMSessionAVContentKeySessionDelegate
</del><ins>+@implementation WebCDMSessionAVContentKeySessionDelegate
</ins><span class="cx"> - (id)initWithParent:(WebCore::CDMSessionAVContentKeySession *)parent
</span><span class="cx"> {
</span><span class="cx"> if ((self = [super init]))
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx">
</span><span class="cx"> CDMSessionAVContentKeySession::CDMSessionAVContentKeySession(const Vector<int>& protocolVersions, CDMPrivateMediaSourceAVFObjC& cdm, CDMSessionClient* client)
</span><span class="cx"> : CDMSessionMediaSourceAVFObjC(cdm, client)
</span><del>- , m_contentKeySessionDelegate(adoptNS([[CDMSessionAVContentKeySessionDelegate alloc] initWithParent:this]))
</del><ins>+ , m_contentKeySessionDelegate(adoptNS([[WebCDMSessionAVContentKeySessionDelegate alloc] initWithParent:this]))
</ins><span class="cx"> , m_protocolVersions(protocolVersions)
</span><span class="cx"> , m_mode(Normal)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVStreamSessionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> #if ENABLE(ENCRYPTED_MEDIA_V2) && ENABLE(MEDIA_SOURCE)
</span><span class="cx">
</span><span class="cx"> OBJC_CLASS AVStreamSession;
</span><del>-OBJC_CLASS CDMSessionAVStreamSessionObserver;
</del><ins>+OBJC_CLASS WebCDMSessionAVStreamSessionObserver;
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx"> RefPtr<Uint8Array> m_initData;
</span><span class="cx"> RefPtr<Uint8Array> m_certificate;
</span><span class="cx"> RetainPtr<NSData> m_expiredSession;
</span><del>- RetainPtr<CDMSessionAVStreamSessionObserver> m_dataParserObserver;
</del><ins>+ RetainPtr<WebCDMSessionAVStreamSessionObserver> m_dataParserObserver;
</ins><span class="cx"> Vector<int> m_protocolVersions;
</span><span class="cx"> enum { Normal, KeyRelease } m_mode;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVStreamSessionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -66,12 +66,12 @@
</span><span class="cx"> + (void)removePendingExpiredSessionReports:(NSArray *)expiredSessionReports withAppIdentifier:(NSData *)appIdentifier storageDirectoryAtURL:(NSURL *)storageURL;
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@interface CDMSessionAVStreamSessionObserver : NSObject {
</del><ins>+@interface WebCDMSessionAVStreamSessionObserver : NSObject {
</ins><span class="cx"> WebCore::CDMSessionAVStreamSession *m_parent;
</span><span class="cx"> }
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@implementation CDMSessionAVStreamSessionObserver
</del><ins>+@implementation WebCDMSessionAVStreamSessionObserver
</ins><span class="cx"> - (id)initWithParent:(WebCore::CDMSessionAVStreamSession *)parent
</span><span class="cx"> {
</span><span class="cx"> if ((self = [super init]))
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> CDMSessionAVStreamSession::CDMSessionAVStreamSession(const Vector<int>& protocolVersions, CDMPrivateMediaSourceAVFObjC& cdm, CDMSessionClient* client)
</span><span class="cx"> : CDMSessionMediaSourceAVFObjC(cdm, client)
</span><span class="cx"> , m_weakPtrFactory(this)
</span><del>- , m_dataParserObserver(adoptNS([[CDMSessionAVStreamSessionObserver alloc] initWithParent:this]))
</del><ins>+ , m_dataParserObserver(adoptNS([[WebCDMSessionAVStreamSessionObserver alloc] initWithParent:this]))
</ins><span class="cx"> , m_protocolVersions(protocolVersions)
</span><span class="cx"> , m_mode(Normal)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
+
+ check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
+ https://bugs.webkit.org/show_bug.cgi?id=152156
+
+ Reviewed by Dan Bernstein.
+
+ * UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
+ (WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
+ * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
+ * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
+ (WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
+ Rename internal classes with "_WK" prefix.
+
</ins><span class="cx"> 2015-12-10 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Expose media capture devices persistent permissions to WebCore
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWebVideoFullscreenManagerProxymm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -39,11 +39,11 @@
</span><span class="cx"> #import <WebCore/TimeRanges.h>
</span><span class="cx"> #import <WebKitSystemInterface.h>
</span><span class="cx">
</span><del>-@interface WebLayerHostView : UIView
</del><ins>+@interface WKLayerHostView : UIView
</ins><span class="cx"> @property (nonatomic, assign) uint32_t contextID;
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@implementation WebLayerHostView
</del><ins>+@implementation WKLayerHostView
</ins><span class="cx">
</span><span class="cx"> + (Class)layerClass {
</span><span class="cx"> return [CALayerHost class];
</span><span class="lines">@@ -339,9 +339,9 @@
</span><span class="cx">
</span><span class="cx"> std::tie(model, interface) = ensureModelAndInterface(contextId);
</span><span class="cx">
</span><del>- RetainPtr<WebLayerHostView> view = static_cast<WebLayerHostView*>(model->layerHostView());
</del><ins>+ RetainPtr<WKLayerHostView> view = static_cast<WKLayerHostView*>(model->layerHostView());
</ins><span class="cx"> if (!view) {
</span><del>- view = adoptNS([[WebLayerHostView alloc] init]);
</del><ins>+ view = adoptNS([[WKLayerHostView alloc] init]);
</ins><span class="cx"> model->setLayerHostView(view);
</span><span class="cx"> }
</span><span class="cx"> [view setContextID:videoLayerID];
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> #include <WebCore/IntPoint.h>
</span><span class="cx"> #include <WebCore/IntSize.h>
</span><span class="cx">
</span><del>-OBJC_CLASS OneShotDisplayLinkHandler;
</del><ins>+OBJC_CLASS WKOneShotDisplayLinkHandler;
</ins><span class="cx">
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx">
</span><span class="cx"> CallbackMap m_callbacks;
</span><span class="cx">
</span><del>- RetainPtr<OneShotDisplayLinkHandler> m_displayLinkHandler;
</del><ins>+ RetainPtr<WKOneShotDisplayLinkHandler> m_displayLinkHandler;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxymm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> // FIXME: Mac will need something similar; we should figure out how to share this with DisplayRefreshMonitor without
</span><span class="cx"> // breaking WebKit1 behavior or WebKit2-WebKit1 coexistence.
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>-@interface OneShotDisplayLinkHandler : NSObject {
</del><ins>+@interface WKOneShotDisplayLinkHandler : NSObject {
</ins><span class="cx"> WebKit::RemoteLayerTreeDrawingAreaProxy* _drawingAreaProxy;
</span><span class="cx"> CADisplayLink *_displayLink;
</span><span class="cx"> }
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@implementation OneShotDisplayLinkHandler
</del><ins>+@implementation WKOneShotDisplayLinkHandler
</ins><span class="cx">
</span><span class="cx"> - (id)initWithDrawingAreaProxy:(WebKit::RemoteLayerTreeDrawingAreaProxy*)drawingAreaProxy
</span><span class="cx"> {
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> : DrawingAreaProxy(DrawingAreaTypeRemoteLayerTree, webPageProxy)
</span><span class="cx"> , m_remoteLayerTreeHost(*this)
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- , m_displayLinkHandler(adoptNS([[OneShotDisplayLinkHandler alloc] initWithDrawingAreaProxy:this]))
</del><ins>+ , m_displayLinkHandler(adoptNS([[WKOneShotDisplayLinkHandler alloc] initWithDrawingAreaProxy:this]))
</ins><span class="cx"> #endif
</span><span class="cx"> {
</span><span class="cx"> #if USE(IOSURFACE)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Tools/ChangeLog 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
+
+ check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
+ https://bugs.webkit.org/show_bug.cgi?id=152156
+
+ Reviewed by Dan Bernstein.
+
+ Our frameworks should appropriately prefix all ObjC classes,
+ not just external symbols.
+
+ * Scripts/check-for-inappropriate-objc-class-names:
+ Remove the -g switch to check all ObjC class names.
+
</ins><span class="cx"> 2015-12-10 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Expose media capture devices persistent permissions to WebCore
</span></span></pre></div>
<a id="trunkToolsScriptscheckforinappropriateobjcclassnames"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/check-for-inappropriate-objc-class-names (193971 => 193972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/check-for-inappropriate-objc-class-names 2015-12-11 20:52:21 UTC (rev 193971)
+++ trunk/Tools/Scripts/check-for-inappropriate-objc-class-names 2015-12-11 20:56:12 UTC (rev 193972)
</span><span class="lines">@@ -60,7 +60,7 @@
</span><span class="cx"> my $sawError = 0;
</span><span class="cx">
</span><span class="cx"> if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePathAge < $buildTimestampAge || $scriptAge < $buildTimestampAge) {
</span><del>- if (!open NM, "(nm -Ugjp '$executablePath' | sed 's/^/STDOUT:/') 2>&1 |") {
</del><ins>+ if (!open NM, "(nm -Ujp '$executablePath' | sed 's/^/STDOUT:/') 2>&1 |") {
</ins><span class="cx"> print "ERROR: Could not open $executablePath\n";
</span><span class="cx"> $sawError = 1;
</span><span class="cx"> next;
</span></span></pre>
</div>
</div>
</body>
</html>