<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193948] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193948">193948</a></dd>
<dt>Author</dt> <dd>youenn.fablet@crf.canon.fr</dd>
<dt>Date</dt> <dd>2015-12-10 23:45:09 -0800 (Thu, 10 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Binding and builtin generators should lowercase RTCXX as rtcXX and not rTCXX
https://bugs.webkit.org/show_bug.cgi?id=152121
Reviewed by Darin Adler.
Source/JavaScriptCore:
* Scripts/builtins/builtins_generator.py:
(WK_lcfirst): Added RTC special rule.
Source/WebCore:
No change in behavior.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation): Using rtcXX in lieu of rTCXX.
* bindings/js/WebCoreJSBuiltinInternals.h:
(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions): Ditto.
(WebCore::JSBuiltinInternalFunctions::rtcPeerConnectionInternals): Added.
(WebCore::JSBuiltinInternalFunctions::visit): Ditto.
(WebCore::JSBuiltinInternalFunctions::init): Ditto.
(WebCore::JSBuiltinInternalFunctions::rTCPeerConnectionInternals): Deleted.
* bindings/js/WebCoreJSBuiltins.h:
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions): Using rtcXX in lieu of rTCXX.
(WebCore::JSBuiltinFunctions::rtcPeerConnectionBuiltins): Added.
(WebCore::JSBuiltinFunctions::rtcPeerConnectionInternalsBuiltins): Added.
(WebCore::JSBuiltinFunctions::rTCPeerConnectionBuiltins): Deleted.
(WebCore::JSBuiltinFunctions::rTCPeerConnectionInternalsBuiltins): Deleted.
* bindings/scripts/CodeGenerator.pm:
(WK_lcfirst): Added RTC special rule.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreScriptsbuiltinsbuiltins_generatorpy">trunk/Source/JavaScriptCore/Scripts/builtins/builtins_generator.py</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMWindowBasecpp">trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsWebCoreJSBuiltinInternalsh">trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsWebCoreJSBuiltinsh">trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorpm">trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (193947 => 193948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-12-11 07:45:09 UTC (rev 193948)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-12-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
+
+ Binding and builtin generators should lowercase RTCXX as rtcXX and not rTCXX
+ https://bugs.webkit.org/show_bug.cgi?id=152121
+
+ Reviewed by Darin Adler.
+
+ * Scripts/builtins/builtins_generator.py:
+ (WK_lcfirst): Added RTC special rule.
+
</ins><span class="cx"> 2015-12-09 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> FTL B3 should be able to run quicksort asm.js test
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreScriptsbuiltinsbuiltins_generatorpy"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Scripts/builtins/builtins_generator.py (193947 => 193948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Scripts/builtins/builtins_generator.py 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/JavaScriptCore/Scripts/builtins/builtins_generator.py 2015-12-11 07:45:09 UTC (rev 193948)
</span><span class="lines">@@ -44,6 +44,7 @@
</span><span class="cx"> str = str.replace('xML', 'xml')
</span><span class="cx"> str = str.replace('xSLT', 'xslt')
</span><span class="cx"> str = str.replace('cSS', 'css')
</span><ins>+ str = str.replace('rTC', 'rtc')
</ins><span class="cx"> return str
</span><span class="cx">
</span><span class="cx"> def WK_ucfirst(str):
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (193947 => 193948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/ChangeLog 2015-12-11 07:45:09 UTC (rev 193948)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2015-12-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
+
+ Binding and builtin generators should lowercase RTCXX as rtcXX and not rTCXX
+ https://bugs.webkit.org/show_bug.cgi?id=152121
+
+ Reviewed by Darin Adler.
+
+ No change in behavior.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::finishCreation): Using rtcXX in lieu of rTCXX.
+ * bindings/js/WebCoreJSBuiltinInternals.h:
+ (WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions): Ditto.
+ (WebCore::JSBuiltinInternalFunctions::rtcPeerConnectionInternals): Added.
+ (WebCore::JSBuiltinInternalFunctions::visit): Ditto.
+ (WebCore::JSBuiltinInternalFunctions::init): Ditto.
+ (WebCore::JSBuiltinInternalFunctions::rTCPeerConnectionInternals): Deleted.
+ * bindings/js/WebCoreJSBuiltins.h:
+ (WebCore::JSBuiltinFunctions::JSBuiltinFunctions): Using rtcXX in lieu of rTCXX.
+ (WebCore::JSBuiltinFunctions::rtcPeerConnectionBuiltins): Added.
+ (WebCore::JSBuiltinFunctions::rtcPeerConnectionInternalsBuiltins): Added.
+ (WebCore::JSBuiltinFunctions::rTCPeerConnectionBuiltins): Deleted.
+ (WebCore::JSBuiltinFunctions::rTCPeerConnectionInternalsBuiltins): Deleted.
+ * bindings/scripts/CodeGenerator.pm:
+ (WK_lcfirst): Added RTC special rule.
+
</ins><span class="cx"> 2015-12-10 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> ASSERTION FAILED: !simpleLineLayout() in WebCore::RenderText::collectSelectionRectsForLineBoxes
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMWindowBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp (193947 => 193948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp 2015-12-11 07:45:09 UTC (rev 193948)
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><span class="cx"> #define DECLARE_GLOBAL_STATIC(name)\
</span><span class="cx"> GlobalPropertyInfo(\
</span><del>- clientData.builtinFunctions().rTCPeerConnectionInternalsBuiltins().name##PrivateName(), m_privateFunctions.rTCPeerConnectionInternals().m_##name##Function.get() , DontDelete | ReadOnly),
</del><ins>+ clientData.builtinFunctions().rtcPeerConnectionInternalsBuiltins().name##PrivateName(), m_privateFunctions.rtcPeerConnectionInternals().m_##name##Function.get() , DontDelete | ReadOnly),
</ins><span class="cx"> WEBCORE_FOREACH_RTCPEERCONNECTIONINTERNALS_BUILTIN_FUNCTION_NAME(DECLARE_GLOBAL_STATIC)
</span><span class="cx"> #undef DECLARE_GLOBAL_STATIC
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsWebCoreJSBuiltinInternalsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h (193947 => 193948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h 2015-12-11 07:45:09 UTC (rev 193948)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> , m_writableStreamInternalsFunctions(vm)
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><del>- , m_rTCPeerConnectionInternalsFunctions(vm)
</del><ins>+ , m_rtcPeerConnectionInternalsFunctions(vm)
</ins><span class="cx"> #endif
</span><span class="cx"> { }
</span><span class="cx">
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> WritableStreamInternalsBuiltinFunctions writableStreamInternals() { return m_writableStreamInternalsFunctions; }
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><del>- RTCPeerConnectionInternalsBuiltinFunctions rTCPeerConnectionInternals() { return m_rTCPeerConnectionInternalsFunctions; }
</del><ins>+ RTCPeerConnectionInternalsBuiltinFunctions rtcPeerConnectionInternals() { return m_rtcPeerConnectionInternalsFunctions; }
</ins><span class="cx"> #endif
</span><span class="cx"> void visit(JSC::SlotVisitor& visitor) {
</span><span class="cx"> #if ENABLE(STREAMS_API)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> m_writableStreamInternalsFunctions.visit(visitor);
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><del>- m_rTCPeerConnectionInternalsFunctions.visit(visitor);
</del><ins>+ m_rtcPeerConnectionInternalsFunctions.visit(visitor);
</ins><span class="cx"> #endif
</span><span class="cx"> #ifndef SKIP_UNUSED_PARAM
</span><span class="cx"> UNUSED_PARAM(visitor);
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> m_writableStreamInternalsFunctions.init(globalObject);
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><del>- m_rTCPeerConnectionInternalsFunctions.init(globalObject);
</del><ins>+ m_rtcPeerConnectionInternalsFunctions.init(globalObject);
</ins><span class="cx"> #endif
</span><span class="cx"> #ifndef SKIP_UNUSED_PARAM
</span><span class="cx"> UNUSED_PARAM(globalObject);
</span><span class="lines">@@ -100,7 +100,7 @@
</span><span class="cx"> WritableStreamInternalsBuiltinFunctions m_writableStreamInternalsFunctions;
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><del>- RTCPeerConnectionInternalsBuiltinFunctions m_rTCPeerConnectionInternalsFunctions;
</del><ins>+ RTCPeerConnectionInternalsBuiltinFunctions m_rtcPeerConnectionInternalsFunctions;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsWebCoreJSBuiltinsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h (193947 => 193948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2015-12-11 07:45:09 UTC (rev 193948)
</span><span class="lines">@@ -68,8 +68,8 @@
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><span class="cx"> , m_mediaDevicesBuiltins(&vm)
</span><span class="cx"> , m_navigatorUserMediaBuiltins(&vm)
</span><del>- , m_rTCPeerConnectionBuiltins(&vm)
- , m_rTCPeerConnectionInternalsBuiltins(&vm)
</del><ins>+ , m_rtcPeerConnectionBuiltins(&vm)
+ , m_rtcPeerConnectionInternalsBuiltins(&vm)
</ins><span class="cx"> #endif
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(STREAMS_API)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> m_writableStreamInternalsBuiltins.exportNames();
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><del>- m_rTCPeerConnectionInternalsBuiltins.exportNames();
</del><ins>+ m_rtcPeerConnectionInternalsBuiltins.exportNames();
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> #if ENABLE(STREAMS_API)
</span><span class="lines">@@ -95,8 +95,8 @@
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><span class="cx"> MediaDevicesBuiltinsWrapper& mediaDevicesBuiltins() { return m_mediaDevicesBuiltins; }
</span><span class="cx"> NavigatorUserMediaBuiltinsWrapper& navigatorUserMediaBuiltins() { return m_navigatorUserMediaBuiltins;}
</span><del>- RTCPeerConnectionBuiltinsWrapper& rTCPeerConnectionBuiltins() { return m_rTCPeerConnectionBuiltins; }
- RTCPeerConnectionInternalsBuiltinsWrapper& rTCPeerConnectionInternalsBuiltins() { return m_rTCPeerConnectionInternalsBuiltins; }
</del><ins>+ RTCPeerConnectionBuiltinsWrapper& rtcPeerConnectionBuiltins() { return m_rtcPeerConnectionBuiltins; }
+ RTCPeerConnectionInternalsBuiltinsWrapper& rtcPeerConnectionInternalsBuiltins() { return m_rtcPeerConnectionInternalsBuiltins; }
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="lines">@@ -115,8 +115,8 @@
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><span class="cx"> MediaDevicesBuiltinsWrapper m_mediaDevicesBuiltins;
</span><span class="cx"> NavigatorUserMediaBuiltinsWrapper m_navigatorUserMediaBuiltins;
</span><del>- RTCPeerConnectionBuiltinsWrapper m_rTCPeerConnectionBuiltins;
- RTCPeerConnectionInternalsBuiltinsWrapper m_rTCPeerConnectionInternalsBuiltins;
</del><ins>+ RTCPeerConnectionBuiltinsWrapper m_rtcPeerConnectionBuiltins;
+ RTCPeerConnectionInternalsBuiltinsWrapper m_rtcPeerConnectionInternalsBuiltins;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (193947 => 193948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-12-11 07:31:28 UTC (rev 193947)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-12-11 07:45:09 UTC (rev 193948)
</span><span class="lines">@@ -476,6 +476,7 @@
</span><span class="cx"> die "Sequences must not be used as the type of an attribute, constant or exception field." if $object->GetSequenceType($type);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+# These match WK_lcfirst and WK_ucfirst defined in builtins_generator.py.
</ins><span class="cx"> # Uppercase the first letter while respecting WebKit style guidelines.
</span><span class="cx"> # E.g., xmlEncoding becomes XMLEncoding, but xmlllang becomes Xmllang.
</span><span class="cx"> sub WK_ucfirst
</span><span class="lines">@@ -500,6 +501,7 @@
</span><span class="cx"> $ret =~ s/xML/xml/ if $ret =~ /^xML/;
</span><span class="cx"> $ret =~ s/xSLT/xslt/ if $ret =~ /^xSLT/;
</span><span class="cx"> $ret =~ s/cSS/css/ if $ret =~ /^cSS/;
</span><ins>+ $ret =~ s/rTC/rtc/ if $ret =~ /^rTC/;
</ins><span class="cx">
</span><span class="cx"> # For HTML5 FileSystem API Flags attributes.
</span><span class="cx"> # (create is widely used to instantiate an object and must be avoided.)
</span></span></pre>
</div>
</div>
</body>
</html>