<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193889] trunk/Websites/bugs.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193889">193889</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-09 19:42:46 -0800 (Wed, 09 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: code-review-tests.html fails with error "Received an error at line 214"
https://bugs.webkit.org/show_bug.cgi?id=152103
Reviewed by Darin Adler.
Fixes an issue where opening the file code-review-test.html in Safari shows the error message
"FAIL: Received an error at line 214" and in the console there is a JavaScript TypeError:
undefined is not an object (evaluating '$('.overallComments textarea').val().trim')
Notice that test testReaddDiscardedCommentWithPreviousComment() is the only test that appends
the toolbar, which inserts the overall comments textarea. The test testSaveCommentsWithMissingLineIds()
assumes that the own properties of the window object are enumerated in the same order as they
were defined in the file code-review-test.html such that the test testReaddDiscardedCommentWithPreviousComment()
is executed before test testSaveCommentsWithMissingLineIds(). The behavior of JavaScriptCore with
respect to the enumeration order of properties on the window object have changed since the
test testSaveCommentsWithMissingLineIds() was written such that the order of the own properties
on the window object do not reflect the order in which they were defined in the file. We should
append the toolbar before running the tests and explicitly execute the tests in chosen order so
as to be able to reason of the test results regardless of the enumeration ordering of the
properties in the DOM window object.
Also, removed duplicate 'd' in the name of function "testReaddDiscardedCommentWithPreviousComment"
such that it reads "testReadDiscardedCommentWithPreviousComment".
* code-review-test.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesbugswebkitorgChangeLog">trunk/Websites/bugs.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesbugswebkitorgcodereviewtesthtml">trunk/Websites/bugs.webkit.org/code-review-test.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesbugswebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/ChangeLog (193888 => 193889)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/ChangeLog 2015-12-10 03:16:48 UTC (rev 193888)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2015-12-10 03:42:46 UTC (rev 193889)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2015-12-09 Daniel Bates <dabates@apple.com>
+
+ REGRESSION: code-review-tests.html fails with error "Received an error at line 214"
+ https://bugs.webkit.org/show_bug.cgi?id=152103
+
+ Reviewed by Darin Adler.
+
+ Fixes an issue where opening the file code-review-test.html in Safari shows the error message
+ "FAIL: Received an error at line 214" and in the console there is a JavaScript TypeError:
+ undefined is not an object (evaluating '$('.overallComments textarea').val().trim')
+
+ Notice that test testReaddDiscardedCommentWithPreviousComment() is the only test that appends
+ the toolbar, which inserts the overall comments textarea. The test testSaveCommentsWithMissingLineIds()
+ assumes that the own properties of the window object are enumerated in the same order as they
+ were defined in the file code-review-test.html such that the test testReaddDiscardedCommentWithPreviousComment()
+ is executed before test testSaveCommentsWithMissingLineIds(). The behavior of JavaScriptCore with
+ respect to the enumeration order of properties on the window object have changed since the
+ test testSaveCommentsWithMissingLineIds() was written such that the order of the own properties
+ on the window object do not reflect the order in which they were defined in the file. We should
+ append the toolbar before running the tests and explicitly execute the tests in chosen order so
+ as to be able to reason of the test results regardless of the enumeration ordering of the
+ properties in the DOM window object.
+
+ Also, removed duplicate 'd' in the name of function "testReaddDiscardedCommentWithPreviousComment"
+ such that it reads "testReadDiscardedCommentWithPreviousComment".
+
+ * code-review-test.html:
+
</ins><span class="cx"> 2015-11-17 Lucas Forschler <lforschler@apple.com>
</span><span class="cx">
</span><span class="cx"> bugs.webkit.org is running with changes that are not checked in.
</span></span></pre></div>
<a id="trunkWebsitesbugswebkitorgcodereviewtesthtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/code-review-test.html (193888 => 193889)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/code-review-test.html 2015-12-10 03:16:48 UTC (rev 193888)
+++ trunk/Websites/bugs.webkit.org/code-review-test.html 2015-12-10 03:42:46 UTC (rev 193889)
</span><span class="lines">@@ -218,7 +218,7 @@
</span><span class="cx"> handler.call(this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function testReaddDiscardedCommentWithPreviousComment() {
</del><ins>+function testReadDiscardedCommentWithPreviousComment() {
</ins><span class="cx"> document.getElementById('diff-content').innerHTML =
</span><span class="cx"> '<div class="FileDiff">' +
</span><span class="cx"> '<h1><a href="http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog">Source/WebCore/ChangeLog</a></h1>' +
</span><span class="lines">@@ -247,7 +247,6 @@
</span><span class="cx">
</span><span class="cx"> eraseDraftComments();
</span><span class="cx"> crawlDiff();
</span><del>- appendToolbar();
</del><span class="cx">
</span><span class="cx"> var line = document.getElementById('line0');
</span><span class="cx"> var author = "ojan@chromium.org";
</span><span class="lines">@@ -456,9 +455,17 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><del>-for (var property in window) {
- if (property.indexOf('test') == 0) {
- window[property]();
- }
-}
</del><ins>+var tests_to_run = [
+ window.testTracLinks,
+ window.testDraftCommentSaver,
+ window.testReadDiscardedCommentWithPreviousComment,
+ window.testSideBySideDiffWithPreviousCommentsOnSharedLine,
+ window.testSanitizeFragmentForCopy,
+ window.testIsChangeLog,
+ window.testSaveCommentsWithMissingLineIds,
+];
+
+appendToolbar();
+for (var i = 0; i < tests_to_run.length; ++i)
+ tests_to_run[i]();
</ins><span class="cx"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>