<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193892] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193892">193892</a></dd>
<dt>Author</dt> <dd>beidson@apple.com</dd>
<dt>Date</dt> <dd>2015-12-09 23:09:34 -0800 (Wed, 09 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Modern IDB: storage/indexeddb/objectstore-basics.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152101
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Multiple tests updated to the new error messaging cover it).
* Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::putOrAdd): Add plenty of detailed error messaging.
LayoutTests:
* platform/mac-wk1/TestExpectations:
* platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt.
* platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt.
* platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt.
* platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt.
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-type-binary-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/mozilla/bad-keypath-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk1TestExpectations">trunk/LayoutTests/platform/mac-wk1/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbinvalidkeysexpectedtxt">trunk/LayoutTests/storage/indexeddb/invalid-keys-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbkeytypebinaryexpectedtxt">trunk/LayoutTests/storage/indexeddb/key-type-binary-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbkeypathedgesexpectedtxt">trunk/LayoutTests/storage/indexeddb/keypath-edges-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbmozillabadkeypathexpectedtxt">trunk/LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbmozillakeyrequirementsinlineandpassedexpectedtxt">trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbmozillakeyrequirementsputnokeyexpectedtxt">trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbmozillakeyrequirementsputnullkeyexpectedtxt">trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstorageindexeddbobjectstorebasicsexpectedtxt">trunk/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbclientIDBObjectStoreImplcpp">trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformwk2storageindexeddbmozillabadkeypathexpectedtxt">trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwk2storageindexeddbmozillakeyrequirementsinlineandpassedexpectedtxt">trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwk2storageindexeddbmozillakeyrequirementsputnokeyexpectedtxt">trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwk2storageindexeddbmozillakeyrequirementsputnullkeyexpectedtxt">trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/ChangeLog 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2015-12-09 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><ins>+ Modern IDB: storage/indexeddb/objectstore-basics.html fails.
+ https://bugs.webkit.org/show_bug.cgi?id=152101
+
+ Reviewed by Alex Christensen.
+
+ * platform/mac-wk1/TestExpectations:
+ * platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt.
+ * platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt.
+ * platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt.
+ * platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt.
+ * storage/indexeddb/invalid-keys-expected.txt:
+ * storage/indexeddb/key-type-binary-expected.txt:
+ * storage/indexeddb/keypath-edges-expected.txt:
+ * storage/indexeddb/mozilla/bad-keypath-expected.txt:
+ * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
+ * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
+ * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
+ * storage/indexeddb/objectstore-basics-expected.txt:
+
+2015-12-09 Brady Eidson <beidson@apple.com>
+
</ins><span class="cx"> Modern IDB: storage/indexeddb/metadata.html fails
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=152099
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk1TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -111,7 +111,6 @@
</span><span class="cx"> storage/indexeddb/key-type-array.html [ Failure ]
</span><span class="cx"> storage/indexeddb/lazy-index-types.html [ Failure ]
</span><span class="cx"> storage/indexeddb/objectstore-autoincrement.html [ Failure ]
</span><del>-storage/indexeddb/objectstore-basics.html [ Failure ]
</del><span class="cx"> storage/indexeddb/objectstore-count.html [ Failure ]
</span><span class="cx"> storage/indexeddb/open-cursor.html [ Failure ]
</span><span class="cx"> storage/indexeddb/open-db-private-browsing.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwk2storageindexeddbmozillabadkeypathexpectedtxtfromrev193891trunkLayoutTestsstorageindexeddbmozillabadkeypathexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt (from rev 193891, trunk/LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt) (0 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+Test IndexedDB adding property with invalid keypath
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = "bad-keypath.html"
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+objectStore = db.createObjectStore('foo', { keyPath: 'keyPath' });
+request = objectStore.add({ keyPath: 'foo' });
+Expecting exception from request = objectStore.add({});
+PASS Exception was thrown.
+PASS code is 0
+PASS ename is 'DataError'
+Exception message: The data provided does not meet requirements.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformwk2storageindexeddbmozillakeyrequirementsinlineandpassedexpectedtxtfromrev193891trunkLayoutTestsstorageindexeddbmozillakeyrequirementsinlineandpassedexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt (from rev 193891, trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt) (0 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+Test IndexedDB's behavior adding inline and passed key simultaneously
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = "key-requirements-inline-and-passed.html"
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+objectStore = db.createObjectStore('baz', { keyPath: 'id' });
+Expecting exception from objectStore.add({id: 5}, 5);
+PASS Exception was thrown.
+PASS code is 0
+PASS ename is 'DataError'
+Exception message: The data provided does not meet requirements.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformwk2storageindexeddbmozillakeyrequirementsputnokeyexpectedtxtfromrev193891trunkLayoutTestsstorageindexeddbmozillakeyrequirementsputnokeyexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt (from rev 193891, trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt) (0 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+Test IndexedDB's behavior puting without key
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = "key-requirements-put-no-key.html"
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+objectStore = db.createObjectStore('bar');
+Expecting exception from objectStore.put({});
+PASS Exception was thrown.
+PASS code is 0
+PASS ename is 'DataError'
+Exception message: The data provided does not meet requirements.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformwk2storageindexeddbmozillakeyrequirementsputnullkeyexpectedtxtfromrev193891trunkLayoutTestsstorageindexeddbmozillakeyrequirementsputnullkeyexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt (from rev 193891, trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt) (0 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+Test IndexedDB's behavior put()ing with null key
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = "key-requirements-put-null-key.html"
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+objectStore = db.createObjectStore('bar');
+Expecting exception from objectStore.put({}, null);
+PASS Exception was thrown.
+PASS code is 0
+PASS ename is 'DataError'
+Exception message: The data provided does not meet requirements.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbinvalidkeysexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/invalid-keys-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/invalid-keys-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/invalid-keys-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -13,82 +13,82 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', null)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', (function() { return arguments; }()))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', true)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', false)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', new Error)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', function () {})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', JSON)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', Math)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', NaN)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', new Date(NaN))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', {})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', /regex/)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', self)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', self.document)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Expecting exception from request = objectStore.put('value', self.document.body)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbkeytypebinaryexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/key-type-binary-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/key-type-binary-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/key-type-binary-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -19,49 +19,49 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put(1, new Uint8Array([0]));
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put(2, new Uint8Array([0, 0]));
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put(3, new Uint8Array([0, 1]));
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put(4, new Uint8Array([1]));
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put(5, new Uint8Array([1, 0]));
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put(6, new Uint8Array([1, 1]));
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put(7, new Uint8Array([255]));
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> testInvalidBinaryKeys2():
</span><span class="cx"> trans = db.transaction('store', 'readwrite')
</span><span class="lines">@@ -71,61 +71,61 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Uint16Array([1,2,3]))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Uint32Array([1,2,3]))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Int8Array([1,2,3]))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Int16Array([1,2,3]))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Int32Array([1,2,3]))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Float32Array([1,2,3]))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Float64Array([1,2,3]))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new Uint8Array([1,2,3]).buffer)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Expecting exception from store.put('value', new DataView(new Uint8Array([1,2,3]).buffer))
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbkeypathedgesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/keypath-edges-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/keypath-edges-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/keypath-edges-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -20,21 +20,21 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path did not yield a value.
</ins><span class="cx">
</span><span class="cx"> Key path doesn't resolve to a value; should yield null, should throw DATA_ERR
</span><span class="cx"> Expecting exception from store.put({})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path did not yield a value.
</ins><span class="cx">
</span><span class="cx"> Key path resolves to a value that is invalid key; should yield 'invalid' key, should throw DATA_ERR
</span><span class="cx"> Expecting exception from store.put({foo: null})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path yielded a value that is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Key path resolves to a value that is valid key; should yield 'string' key, should succeed
</span><span class="cx"> store.put({foo: 'zoo'})
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path yielded a value that is not a valid key.
</ins><span class="cx">
</span><span class="cx"> Key path resolves to a value that is valid key; should yield 'string' key, should succeed
</span><span class="cx"> store.put({foo: 'zoo'})
</span></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbmozillabadkeypathexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path did not yield a value.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbmozillakeyrequirementsinlineandpassedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The object store uses in-line keys and the key parameter was provided.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbmozillakeyrequirementsputnokeyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The object store uses out-of-line keys and has no key generator and the key parameter was not provided.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbmozillakeyrequirementsputnullkeyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: The data provided does not meet requirements.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsstorageindexeddbobjectstorebasicsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -29,8 +29,6 @@
</span><span class="cx"> PASS typeof store.clear is "function"
</span><span class="cx"> PASS 'openCursor' in store is true
</span><span class="cx"> PASS typeof store.openCursor is "function"
</span><del>-PASS 'openKeyCursor' in store is true
-PASS typeof store.openKeyCursor is "function"
</del><span class="cx"> PASS 'createIndex' in store is true
</span><span class="cx"> PASS typeof store.createIndex is "function"
</span><span class="cx"> PASS 'index' in store is true
</span><span class="lines">@@ -97,7 +95,7 @@
</span><span class="cx"> Expecting exception from store.add({x: 'bar', y: self}, 'bar')
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is DOMException.DATA_CLONE_ERR
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': An object could not be cloned.
</del><ins>+Exception message: DataCloneError: DOM Exception 25
</ins><span class="cx"> Try to insert data where key path yields a Date key:
</span><span class="cx"> store.add({x: testDateB, y: 'value'}, 'key')
</span><span class="cx"> addSuccess():
</span><span class="lines">@@ -113,7 +111,7 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': The parameter is not a valid key.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> db.transaction(['storeName'], 'readwrite')
</span><span class="cx"> store = transaction.objectStore('storeName')
</span><span class="cx"> Ensure invalid key pointed at by index keyPath is ignored
</span><span class="lines">@@ -151,13 +149,13 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': The parameter is not a valid key.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> Passing an invalid key into store.put().
</span><span class="cx"> Expecting exception from store.put(null, {})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'put' on 'IDBObjectStore': The parameter is not a valid key.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> testPreConditions():
</span><span class="cx"> indexedDB.open(dbname, 3)
</span><span class="lines">@@ -174,31 +172,31 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'put' on 'IDBObjectStore': The object store uses in-line keys and the key parameter was provided.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The object store uses in-line keys and the key parameter was provided.
</ins><span class="cx"> The object store uses out-of-line keys and has no key generator and the key parameter was not provided.
</span><span class="cx"> Expecting exception from storeWithOutOfLineKeys.put({})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'put' on 'IDBObjectStore': The object store uses out-of-line keys and has no key generator and the key parameter was not provided.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The object store uses out-of-line keys and has no key generator and the key parameter was not provided.
</ins><span class="cx"> The object store uses in-line keys and the result of evaluating the object store's key path yields a value and that value is not a valid key.
</span><span class="cx"> Expecting exception from storeWithInLineKeys.put({key: null})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'put' on 'IDBObjectStore': Evaluating the object store's key path yielded a value that is not a valid key.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path yielded a value that is not a valid key.
</ins><span class="cx"> The object store uses in-line keys but no key generator and the result of evaluating the object store's key path does not yield a value.
</span><span class="cx"> Expecting exception from storeWithInLineKeys.put({})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'put' on 'IDBObjectStore': Evaluating the object store's key path did not yield a value.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path did not yield a value.
</ins><span class="cx"> The key parameter was provided but does not contain a valid key.
</span><span class="cx"> Expecting exception from storeWithOutOfLineKeys.put({}, null)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'put' on 'IDBObjectStore': The parameter is not a valid key.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx">
</span><span class="cx"> IDBObjectStore.add()
</span><span class="cx"> The object store uses in-line keys and the key parameter was provided.
</span><span class="lines">@@ -206,31 +204,31 @@
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': The object store uses in-line keys and the key parameter was provided.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The object store uses in-line keys and the key parameter was provided.
</ins><span class="cx"> The object store uses out-of-line keys and has no key generator and the key parameter was not provided.
</span><span class="cx"> Expecting exception from storeWithOutOfLineKeys.add({})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': The object store uses out-of-line keys and has no key generator and the key parameter was not provided.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The object store uses out-of-line keys and has no key generator and the key parameter was not provided.
</ins><span class="cx"> The object store uses in-line keys and the result of evaluating the object store's key path yields a value and that value is not a valid key.
</span><span class="cx"> Expecting exception from storeWithInLineKeys.add({key: null})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': Evaluating the object store's key path yielded a value that is not a valid key.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path yielded a value that is not a valid key.
</ins><span class="cx"> The object store uses in-line keys but no key generator and the result of evaluating the object store's key path does not yield a value.
</span><span class="cx"> Expecting exception from storeWithInLineKeys.add({})
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': Evaluating the object store's key path did not yield a value.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: Evaluating the object store's key path did not yield a value.
</ins><span class="cx"> The key parameter was provided but does not contain a valid key.
</span><span class="cx"> Expecting exception from storeWithOutOfLineKeys.add({}, null)
</span><span class="cx"> PASS Exception was thrown.
</span><span class="cx"> PASS code is 0
</span><span class="cx"> PASS ename is 'DataError'
</span><del>-Exception message: Failed to execute 'add' on 'IDBObjectStore': The parameter is not a valid key.
</del><ins>+Exception message: Failed to store record in an IDBObjectStore: The parameter is not a valid key.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/Source/WebCore/ChangeLog 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-12-09 Brady Eidson <beidson@apple.com>
+
+ Modern IDB: storage/indexeddb/objectstore-basics.html fails.
+ https://bugs.webkit.org/show_bug.cgi?id=152101
+
+ Reviewed by Alex Christensen.
+
+ No new tests (Multiple tests updated to the new error messaging cover it).
+
+ * Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
+ (WebCore::IDBClient::IDBObjectStore::putOrAdd): Add plenty of detailed error messaging.
+
</ins><span class="cx"> 2015-12-09 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> TextPainter: Make before and after selection painting more explicit.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbclientIDBObjectStoreImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp (193891 => 193892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp 2015-12-10 04:59:56 UTC (rev 193891)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp 2015-12-10 07:09:34 UTC (rev 193892)
</span><span class="lines">@@ -271,6 +271,7 @@
</span><span class="cx">
</span><span class="cx"> if (key && key->type() == KeyType::Invalid) {
</span><span class="cx"> ec.code = IDBDatabaseException::DataError;
</span><ins>+ ec.message = ASCIILiteral("Failed to store record in an IDBObjectStore: The parameter is not a valid key.");
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -279,12 +280,14 @@
</span><span class="cx"> if (usesInlineKeys && inlineKeyCheck == InlineKeyCheck::Perform) {
</span><span class="cx"> if (key) {
</span><span class="cx"> ec.code = IDBDatabaseException::DataError;
</span><ins>+ ec.message = ASCIILiteral("Failed to store record in an IDBObjectStore: The object store uses in-line keys and the key parameter was provided.");
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<IDBKey> keyPathKey = maybeCreateIDBKeyFromScriptValueAndKeyPath(state, value, m_info.keyPath());
</span><span class="cx"> if (keyPathKey && !keyPathKey->isValid()) {
</span><span class="cx"> ec.code = IDBDatabaseException::DataError;
</span><ins>+ ec.message = ASCIILiteral("Failed to store record in an IDBObjectStore: Evaluating the object store's key path yielded a value that is not a valid key.");
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -296,6 +299,7 @@
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><span class="cx"> ec.code = IDBDatabaseException::DataError;
</span><ins>+ ec.message = ASCIILiteral("Failed to store record in an IDBObjectStore: Evaluating the object store's key path did not yield a value.");
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -306,6 +310,7 @@
</span><span class="cx"> }
</span><span class="cx"> } else if (!usesKeyGenerator && !key) {
</span><span class="cx"> ec.code = IDBDatabaseException::DataError;
</span><ins>+ ec.message = ASCIILiteral("Failed to store record in an IDBObjectStore: The object store uses out-of-line keys and has no key generator and the key parameter was not provided.");
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>