<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193651] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193651">193651</a></dd>
<dt>Author</dt> <dd>yoon@igalia.com</dd>
<dt>Date</dt> <dd>2015-12-07 14:23:19 -0800 (Mon, 07 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Clean up virtual functions in MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=151940
Reviewed by Carlos Garcia Campos.
- Using 'override' when appropriate
- Explicitly marking methods as virtual when they are inherently virtual
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamerBaseh">trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (193650 => 193651)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-07 22:14:25 UTC (rev 193650)
+++ trunk/Source/WebCore/ChangeLog 2015-12-07 22:23:19 UTC (rev 193651)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-12-07 Gwang Yoon Hwang <yoon@igalia.com>
+
+ [GTK] Clean up virtual functions in MediaPlayerPrivateGStreamerBase
+ https://bugs.webkit.org/show_bug.cgi?id=151940
+
+ Reviewed by Carlos Garcia Campos.
+
+ - Using 'override' when appropriate
+ - Explicitly marking methods as virtual when they are inherently virtual
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
</ins><span class="cx"> 2015-12-07 Saam barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> Add op_watchdog opcode that is generated when VM has a watchdog
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamerBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h (193650 => 193651)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2015-12-07 22:14:25 UTC (rev 193650)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2015-12-07 22:23:19 UTC (rev 193651)
</span><span class="lines">@@ -56,53 +56,53 @@
</span><span class="cx"> public:
</span><span class="cx"> virtual ~MediaPlayerPrivateGStreamerBase();
</span><span class="cx">
</span><del>- FloatSize naturalSize() const;
</del><ins>+ virtual FloatSize naturalSize() const override;
</ins><span class="cx">
</span><del>- void setVolume(float);
- float volume() const;
</del><ins>+ virtual void setVolume(float) override;
+ virtual float volume() const;
</ins><span class="cx">
</span><span class="cx"> #if USE(GSTREAMER_GL)
</span><span class="cx"> bool ensureGstGLContext();
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- bool supportsMuting() const { return true; }
- void setMuted(bool);
</del><ins>+ virtual bool supportsMuting() const override { return true; }
+ virtual void setMuted(bool) override;
</ins><span class="cx"> bool muted() const;
</span><span class="cx">
</span><del>- MediaPlayer::NetworkState networkState() const;
- MediaPlayer::ReadyState readyState() const;
</del><ins>+ virtual MediaPlayer::NetworkState networkState() const override;
+ virtual MediaPlayer::ReadyState readyState() const override;
</ins><span class="cx">
</span><del>- void setVisible(bool) { }
- void setSize(const IntSize&);
</del><ins>+ virtual void setVisible(bool) override { }
+ virtual void setSize(const IntSize&) override;
</ins><span class="cx"> void sizeChanged();
</span><span class="cx">
</span><del>- void paint(GraphicsContext&, const FloatRect&);
</del><ins>+ virtual void paint(GraphicsContext&, const FloatRect&) override;
</ins><span class="cx">
</span><del>- virtual bool hasSingleSecurityOrigin() const { return true; }
</del><ins>+ virtual bool hasSingleSecurityOrigin() const override { return true; }
</ins><span class="cx"> virtual float maxTimeLoaded() const { return 0.0; }
</span><span class="cx">
</span><del>- bool supportsFullscreen() const;
- PlatformMedia platformMedia() const;
</del><ins>+ virtual bool supportsFullscreen() const override;
+ virtual PlatformMedia platformMedia() const override;
</ins><span class="cx">
</span><del>- MediaPlayer::MovieLoadType movieLoadType() const;
</del><ins>+ virtual MediaPlayer::MovieLoadType movieLoadType() const override;
</ins><span class="cx"> virtual bool isLiveStream() const = 0;
</span><span class="cx">
</span><span class="cx"> MediaPlayer* mediaPlayer() const { return m_player; }
</span><span class="cx">
</span><del>- unsigned decodedFrameCount() const;
- unsigned droppedFrameCount() const;
- unsigned audioDecodedByteCount() const;
- unsigned videoDecodedByteCount() const;
</del><ins>+ virtual unsigned decodedFrameCount() const override;
+ virtual unsigned droppedFrameCount() const override;
+ virtual unsigned audioDecodedByteCount() const override;
+ virtual unsigned videoDecodedByteCount() const override;
</ins><span class="cx">
</span><span class="cx"> #if USE(TEXTURE_MAPPER_GL) && !USE(COORDINATED_GRAPHICS)
</span><del>- virtual PlatformLayer* platformLayer() const { return const_cast<MediaPlayerPrivateGStreamerBase*>(this); }
</del><ins>+ virtual PlatformLayer* platformLayer() const override { return const_cast<MediaPlayerPrivateGStreamerBase*>(this); }
</ins><span class="cx"> #if PLATFORM(WIN_CAIRO)
</span><span class="cx"> // FIXME: Accelerated rendering has not been implemented for WinCairo yet.
</span><del>- virtual bool supportsAcceleratedRendering() const { return false; }
</del><ins>+ virtual bool supportsAcceleratedRendering() const override { return false; }
</ins><span class="cx"> #else
</span><del>- virtual bool supportsAcceleratedRendering() const { return true; }
</del><ins>+ virtual bool supportsAcceleratedRendering() const override { return true; }
</ins><span class="cx"> #endif
</span><del>- virtual void paintToTextureMapper(TextureMapper*, const FloatRect&, const TransformationMatrix&, float);
</del><ins>+ virtual void paintToTextureMapper(TextureMapper*, const FloatRect&, const TransformationMatrix&, float) override;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> protected:
</span></span></pre>
</div>
</div>
</body>
</html>