<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193637] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193637">193637</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-07 10:35:56 -0800 (Mon, 07 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update Objective-C code generator to pass a reference to calling object for partial interfaces
https://bugs.webkit.org/show_bug.cgi?id=151739
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-12-07
Reviewed by Darin Adler.
The fix updates the Objective-C code generator to pass a reference to calling object for partial interfaces.
The change from pass by pointer to pass by reference was introduced in <a href="http://trac.webkit.org/projects/webkit/changeset/192849">r192849</a>.
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
(-[DOMTestInterface supplementalStr1]):
(-[DOMTestInterface supplementalStr2]):
(-[DOMTestInterface setSupplementalStr2:]):
(-[DOMTestInterface supplementalStr3]):
(-[DOMTestInterface setSupplementalStr3:]):
(-[DOMTestInterface supplementalNode]):
(-[DOMTestInterface setSupplementalNode:]):
(-[DOMTestInterface builtinAttribute]):
(-[DOMTestInterface setBuiltinAttribute:]):
(-[DOMTestInterface supplementalMethod1]):
(-[DOMTestInterface supplementalMethod2:objArg:]):
(-[DOMTestInterface supplementalMethod3]):
(-[DOMTestInterface supplementalMethod4]):
(-[DOMTestInterface builtinFunction]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestObjCDOMTestInterfacemm">trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (193636 => 193637)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-07 18:30:53 UTC (rev 193636)
+++ trunk/Source/WebCore/ChangeLog 2015-12-07 18:35:56 UTC (rev 193637)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2015-12-07 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
+
+ Update Objective-C code generator to pass a reference to calling object for partial interfaces
+ https://bugs.webkit.org/show_bug.cgi?id=151739
+
+ Reviewed by Darin Adler.
+
+ The fix updates the Objective-C code generator to pass a reference to calling object for partial interfaces.
+ The change from pass by pointer to pass by reference was introduced in r192849.
+
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (GenerateImplementation):
+ * bindings/scripts/test/ObjC/DOMTestInterface.mm:
+ (-[DOMTestInterface supplementalStr1]):
+ (-[DOMTestInterface supplementalStr2]):
+ (-[DOMTestInterface setSupplementalStr2:]):
+ (-[DOMTestInterface supplementalStr3]):
+ (-[DOMTestInterface setSupplementalStr3:]):
+ (-[DOMTestInterface supplementalNode]):
+ (-[DOMTestInterface setSupplementalNode:]):
+ (-[DOMTestInterface builtinAttribute]):
+ (-[DOMTestInterface setBuiltinAttribute:]):
+ (-[DOMTestInterface supplementalMethod1]):
+ (-[DOMTestInterface supplementalMethod2:objArg:]):
+ (-[DOMTestInterface supplementalMethod3]):
+ (-[DOMTestInterface supplementalMethod4]):
+ (-[DOMTestInterface builtinFunction]):
+
</ins><span class="cx"> 2015-12-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash in MemoryCache::pruneDeadResourcesToSize()
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (193636 => 193637)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-12-07 18:30:53 UTC (rev 193636)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-12-07 18:35:56 UTC (rev 193637)
</span><span class="lines">@@ -1281,7 +1281,7 @@
</span><span class="cx"> if ($attribute->signature->extendedAttributes->{"ImplementedBy"}) {
</span><span class="cx"> my $implementedBy = $attribute->signature->extendedAttributes->{"ImplementedBy"};
</span><span class="cx"> $implIncludes{"${implementedBy}.h"} = 1;
</span><del>- $getterContentHead = "WebCore::${implementedBy}::${getterExpressionPrefix}IMPL";
</del><ins>+ $getterContentHead = "WebCore::${implementedBy}::${getterExpressionPrefix}*IMPL";
</ins><span class="cx"> } else {
</span><span class="cx"> $getterContentHead = "IMPL->$getterExpressionPrefix";
</span><span class="cx"> }
</span><span class="lines">@@ -1421,7 +1421,7 @@
</span><span class="cx"> if ($attribute->signature->extendedAttributes->{"ImplementedBy"}) {
</span><span class="cx"> my $implementedBy = $attribute->signature->extendedAttributes->{"ImplementedBy"};
</span><span class="cx"> $implIncludes{"${implementedBy}.h"} = 1;
</span><del>- unshift(@arguments, "IMPL");
</del><ins>+ unshift(@arguments, "*IMPL");
</ins><span class="cx"> $functionName = "WebCore::${implementedBy}::${functionName}";
</span><span class="cx"> } else {
</span><span class="cx"> $functionName = "IMPL->${functionName}";
</span><span class="lines">@@ -1549,7 +1549,7 @@
</span><span class="cx"> if ($function->signature->extendedAttributes->{"ImplementedBy"}) {
</span><span class="cx"> my $implementedBy = $function->signature->extendedAttributes->{"ImplementedBy"};
</span><span class="cx"> $implIncludes{"${implementedBy}.h"} = 1;
</span><del>- unshift(@parameterNames, $caller);
</del><ins>+ unshift(@parameterNames, "*" . $caller);
</ins><span class="cx"> $content = "WebCore::${implementedBy}::" . $codeGenerator->WK_lcfirst($functionName) . "(" . join(", ", @parameterNames) . ")";
</span><span class="cx"> } else {
</span><span class="cx"> my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementedAs"} || $codeGenerator->WK_lcfirst($functionName);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestObjCDOMTestInterfacemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm (193636 => 193637)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm 2015-12-07 18:30:53 UTC (rev 193636)
+++ trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm 2015-12-07 18:35:56 UTC (rev 193637)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> - (NSString *)supplementalStr1
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- return WebCore::TestSupplemental::supplementalStr1(IMPL);
</del><ins>+ return WebCore::TestSupplemental::supplementalStr1(*IMPL);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -125,13 +125,13 @@
</span><span class="cx"> - (NSString *)supplementalStr2
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- return WebCore::TestSupplemental::supplementalStr2(IMPL);
</del><ins>+ return WebCore::TestSupplemental::supplementalStr2(*IMPL);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)setSupplementalStr2:(NSString *)newSupplementalStr2
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::TestSupplemental::setSupplementalStr2(IMPL, newSupplementalStr2);
</del><ins>+ WebCore::TestSupplemental::setSupplementalStr2(*IMPL, newSupplementalStr2);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -139,13 +139,13 @@
</span><span class="cx"> - (NSString *)supplementalStr3
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- return WebCore::TestSupplemental::supplementalStr3(IMPL);
</del><ins>+ return WebCore::TestSupplemental::supplementalStr3(*IMPL);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)setSupplementalStr3:(NSString *)newSupplementalStr3
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::TestSupplemental::setSupplementalStr3(IMPL, newSupplementalStr3);
</del><ins>+ WebCore::TestSupplemental::setSupplementalStr3(*IMPL, newSupplementalStr3);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -153,7 +153,7 @@
</span><span class="cx"> - (DOMNode *)supplementalNode
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- return kit(WTF::getPtr(WebCore::TestSupplemental::supplementalNode(IMPL)));
</del><ins>+ return kit(WTF::getPtr(WebCore::TestSupplemental::supplementalNode(*IMPL)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)setSupplementalNode:(DOMNode *)newSupplementalNode
</span><span class="lines">@@ -161,7 +161,7 @@
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><span class="cx"> ASSERT(newSupplementalNode);
</span><span class="cx">
</span><del>- WebCore::TestSupplemental::setSupplementalNode(IMPL, core(newSupplementalNode));
</del><ins>+ WebCore::TestSupplemental::setSupplementalNode(*IMPL, core(newSupplementalNode));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -169,13 +169,13 @@
</span><span class="cx"> - (unsigned short)builtinAttribute
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- return WebCore::TestSupplemental::builtinAttribute(IMPL);
</del><ins>+ return WebCore::TestSupplemental::builtinAttribute(*IMPL);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)setBuiltinAttribute:(unsigned short)newBuiltinAttribute
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::TestSupplemental::setBuiltinAttribute(IMPL, newBuiltinAttribute);
</del><ins>+ WebCore::TestSupplemental::setBuiltinAttribute(*IMPL, newBuiltinAttribute);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -227,7 +227,7 @@
</span><span class="cx"> - (void)supplementalMethod1
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::TestSupplemental::supplementalMethod1(IMPL);
</del><ins>+ WebCore::TestSupplemental::supplementalMethod1(*IMPL);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><span class="cx"> WebCore::ExceptionCode ec = 0;
</span><del>- DOMTestObj *result = kit(WTF::getPtr(WebCore::TestSupplemental::supplementalMethod2(IMPL, strArg, core(objArg), ec)));
</del><ins>+ DOMTestObj *result = kit(WTF::getPtr(WebCore::TestSupplemental::supplementalMethod2(*IMPL, strArg, core(objArg), ec)));
</ins><span class="cx"> WebCore::raiseOnDOMError(ec);
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="lines">@@ -250,7 +250,7 @@
</span><span class="cx"> - (void)supplementalMethod3
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::TestSupplemental::supplementalMethod3(IMPL);
</del><ins>+ WebCore::TestSupplemental::supplementalMethod3(*IMPL);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif
</span><span class="lines">@@ -260,7 +260,7 @@
</span><span class="cx"> - (void)supplementalMethod4
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::TestSupplemental::supplementalMethod4(IMPL);
</del><ins>+ WebCore::TestSupplemental::supplementalMethod4(*IMPL);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif
</span><span class="lines">@@ -270,7 +270,7 @@
</span><span class="cx"> - (void)builtinFunction
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::TestSupplemental::builtinFunction(IMPL);
</del><ins>+ WebCore::TestSupplemental::builtinFunction(*IMPL);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre>
</div>
</div>
</body>
</html>