<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193613] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193613">193613</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2015-12-06 22:27:08 -0800 (Sun, 06 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clipping along compositing borders in svg-edit
https://bugs.webkit.org/show_bug.cgi?id=151791
Reviewed by Zalan Bujtas.
Source/WebCore:
RenderSVGRoot::layout() failed to clear overflow before recomputing
visual overflow, which could cause it to get stuck with stale overflow.
This would cause underpainting if its size went from small to large.
Test: svg/overflow/visual-overflow-change.html
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
LayoutTests:
Ref test that triggers recomputation of overflow.
* svg/overflow/visual-overflow-change-expected.html: Added.
* svg/overflow/visual-overflow-change.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGRootcpp">trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgoverflowvisualoverflowchangeexpectedhtml">trunk/LayoutTests/svg/overflow/visual-overflow-change-expected.html</a></li>
<li><a href="#trunkLayoutTestssvgoverflowvisualoverflowchangehtml">trunk/LayoutTests/svg/overflow/visual-overflow-change.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (193612 => 193613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-12-07 06:15:28 UTC (rev 193612)
+++ trunk/LayoutTests/ChangeLog 2015-12-07 06:27:08 UTC (rev 193613)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-12-06 Simon Fraser <simon.fraser@apple.com>
+
+ Clipping along compositing borders in svg-edit
+ https://bugs.webkit.org/show_bug.cgi?id=151791
+
+ Reviewed by Zalan Bujtas.
+
+ Ref test that triggers recomputation of overflow.
+
+ * svg/overflow/visual-overflow-change-expected.html: Added.
+ * svg/overflow/visual-overflow-change.html: Added.
+
</ins><span class="cx"> 2015-12-06 Andy VanWagoner <thetalecrafter@gmail.com>
</span><span class="cx">
</span><span class="cx"> [INTL] Implement String.prototype.toLocaleLowerCase in ECMA-402
</span></span></pre></div>
<a id="trunkLayoutTestssvgoverflowvisualoverflowchangeexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/overflow/visual-overflow-change-expected.html (0 => 193613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/overflow/visual-overflow-change-expected.html (rev 0)
+++ trunk/LayoutTests/svg/overflow/visual-overflow-change-expected.html 2015-12-07 06:27:08 UTC (rev 193613)
</span><span class="lines">@@ -0,0 +1,53 @@
</span><ins>+<!DOCTYPE HTML>
+<head>
+ <style>
+ body {
+ overflow: hidden;
+ margin: 0;
+ }
+
+ .svgcanvas {
+ position: relative;
+ width: 3800px;
+ height: 600px;
+ display: inline-block;
+ overflow: hidden;
+ }
+
+ .indicator {
+ position: absolute;
+ top: 0;
+ left: 0;
+ width: 3800px; /* Trigger composited tiling */
+ height: 600px;
+ display: inline-block;
+ background-color: red;
+ }
+
+ .composited {
+ -webkit-transform: translateZ(0);
+ }
+
+ #svgroot {
+ position: absolute;
+ top: 0;
+ left: 0;
+ background-color: gray;
+ }
+
+ svg {
+ border: 4px solid black;
+ box-sizing: border-box;
+ }
+ </style>
+</head>
+ <!-- You should see no red -->
+ <div class="indicator"></div>
+ <div class="composited svgcanvas">
+ <svg id="svgroot" width="1920" height="1400" overflow="visible">
+ <svg id="canvasBackground" x="540" y="480" width="640" height="480" overflow="none">
+ <rect width="100%" height="100%" fill="green"/>
+ </svg>
+ </svg>
+ </div>
+</div>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgoverflowvisualoverflowchangehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/overflow/visual-overflow-change.html (0 => 193613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/overflow/visual-overflow-change.html (rev 0)
+++ trunk/LayoutTests/svg/overflow/visual-overflow-change.html 2015-12-07 06:27:08 UTC (rev 193613)
</span><span class="lines">@@ -0,0 +1,75 @@
</span><ins>+<!DOCTYPE HTML>
+<head>
+ <style>
+ body {
+ overflow: hidden;
+ margin: 0;
+ }
+
+ .svgcanvas {
+ position: relative;
+ width: 3800px;
+ height: 600px;
+ display: inline-block;
+ overflow: hidden;
+ }
+
+ .indicator {
+ position: absolute;
+ top: 0;
+ left: 0;
+ width: 3800px; /* Trigger composited tiling */
+ height: 600px;
+ display: inline-block;
+ background-color: red;
+ }
+
+ .composited {
+ -webkit-transform: translateZ(0);
+ }
+
+ #svgroot {
+ position: absolute;
+ top: 0;
+ left: 0;
+ background-color: gray;
+ }
+
+ svg {
+ border: 4px solid black;
+ box-sizing: border-box;
+ }
+ </style>
+ <script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function doTest()
+ {
+ window.setTimeout(function() {
+ var svg = document.getElementById('svgroot');
+ svg.setAttribute('x', 640);
+ svg.setAttribute('y', 480);
+ svg.setAttribute('width', 1920);
+ svg.setAttribute('height', 1400);
+ var background = document.getElementById('canvasBackground');
+ background.setAttribute('x', 540);
+ background.setAttribute('y', 480);
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 0);
+ }
+ window.addEventListener('load', doTest, false);
+ </script>
+</head>
+ <!-- You should see no red -->
+ <div class="indicator"></div>
+ <div class="composited svgcanvas">
+ <svg id="svgroot" width="640" height="480" overflow="visible">
+ <svg id="canvasBackground" width="640" height="480" overflow="none">
+ <rect width="100%" height="100%" fill="green"/>
+ </svg>
+ </svg>
+ </div>
+</div>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (193612 => 193613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-07 06:15:28 UTC (rev 193612)
+++ trunk/Source/WebCore/ChangeLog 2015-12-07 06:27:08 UTC (rev 193613)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2015-12-06 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Clipping along compositing borders in svg-edit
+ https://bugs.webkit.org/show_bug.cgi?id=151791
+
+ Reviewed by Zalan Bujtas.
+
+ RenderSVGRoot::layout() failed to clear overflow before recomputing
+ visual overflow, which could cause it to get stuck with stale overflow.
+ This would cause underpainting if its size went from small to large.
+
+ Test: svg/overflow/visual-overflow-change.html
+
+ * rendering/svg/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::layout):
+
+2015-12-06 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> REGRESSION (r187121): Can't get to the main content of the page at https://theintercept.com/drone-papers/
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=151849
</span><span class="cx"> rdar://problem/23132828
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGRootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (193612 => 193613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2015-12-07 06:15:28 UTC (rev 193612)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2015-12-07 06:27:08 UTC (rev 193613)
</span><span class="lines">@@ -196,6 +196,7 @@
</span><span class="cx"> m_needsBoundariesOrTransformUpdate = false;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ clearOverflow();
</ins><span class="cx"> if (!shouldApplyViewportClip()) {
</span><span class="cx"> FloatRect contentRepaintRect = repaintRectInLocalCoordinates();
</span><span class="cx"> contentRepaintRect = m_localToBorderBoxTransform.mapRect(contentRepaintRect);
</span></span></pre>
</div>
</div>
</body>
</html>