<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193427] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193427">193427</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-04 10:50:10 -0800 (Fri, 04 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Unskip many inspector/debugger tests
https://bugs.webkit.org/show_bug.cgi?id=151843
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
* bindings/ScriptFunctionCall.cpp:
(Deprecated::ScriptFunctionCall::call):
Ignore TerminationExceptions, as those aren't real execution
exceptions and may be seen on Workers that have closed.
LayoutTests:
* TestExpectations:
* platform/mac/TestExpectations:
Skip specific tests.
* platform/mac-wk2/TestExpectations:
Test no longer existed.
* inspector/debugger/resources/exception.js:
(exceptionDOM):
Keep the code outputing a NotFoundException. This particular
invocation was recently changed to throw a TypeError.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerresourcesexceptionjs">trunk/LayoutTests/inspector/debugger/resources/exception.js</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebindingsScriptFunctionCallcpp">trunk/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (193426 => 193427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/ChangeLog 2015-12-04 18:50:10 UTC (rev 193427)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2015-12-04 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Unskip many inspector/debugger tests
+ https://bugs.webkit.org/show_bug.cgi?id=151843
+
+ Reviewed by Timothy Hatcher.
+
+ * TestExpectations:
+ * platform/mac/TestExpectations:
+ Skip specific tests.
+
+ * platform/mac-wk2/TestExpectations:
+ Test no longer existed.
+
+ * inspector/debugger/resources/exception.js:
+ (exceptionDOM):
+ Keep the code outputing a NotFoundException. This particular
+ invocation was recently changed to throw a TypeError.
+
+2015-12-04 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Remove untested and unused Worker inspection
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=151848
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (193426 => 193427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/TestExpectations 2015-12-04 18:50:10 UTC (rev 193427)
</span><span class="lines">@@ -126,7 +126,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/129639 inspector/dom/dom-search-crash.html [ Skip ]
</span><span class="cx">
</span><del>-webkit.org/b/133761 inspector/debugger/breakpoint-action-detach.html [ Skip ]
</del><span class="cx"> webkit.org/b/147502 inspector/debugger/break-on-uncaught-exception-throw-in-promise-rethrow-in-catch.html [ Skip ]
</span><span class="cx"> webkit.org/b/147502 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then-with-catch.html [ Skip ]
</span><span class="cx"> webkit.org/b/147502 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then.html [ Skip ]
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerresourcesexceptionjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/resources/exception.js (193426 => 193427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/resources/exception.js 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/inspector/debugger/resources/exception.js 2015-12-04 18:50:10 UTC (rev 193427)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx">
</span><span class="cx"> function exceptionDOM()
</span><span class="cx"> {
</span><del>- document.body.appendChild(0);
</del><ins>+ document.body.removeChild(document.createElement("span"));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function throwString()
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (193426 => 193427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-12-04 18:50:10 UTC (rev 193427)
</span><span class="lines">@@ -743,9 +743,16 @@
</span><span class="cx"> webkit.org/b/123369 svg/css/parent-shadow-offscreen.svg [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/123369 svg/css/root-shadow-offscreen.svg [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-# webkit.org/b/100846, webkit.org/b/136715, webkit.org/b/148642, webkit.org/b/148654
-inspector/debugger
-inspector/dom-debugger/node-removed.html
</del><ins>+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-rethrow-in-catch.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then-with-catch.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-with-catch.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise.html
+inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html
+inspector/debugger/didSampleProbe-multiple-probes.html
+inspector/debugger/nested-inspectors.html
+inspector/debugger/pause-reason.html
+inspector/debugger/regress-133182.html
</ins><span class="cx">
</span><span class="cx"> webkit.org/b/124311 compositing/regions/transform-transparent-positioned-video-inside-region.html [ ImageOnlyFailure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (193426 => 193427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-12-04 18:50:10 UTC (rev 193427)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2015-12-04 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Unskip many inspector/debugger tests
+ https://bugs.webkit.org/show_bug.cgi?id=151843
+
+ Reviewed by Timothy Hatcher.
+
+ * bindings/ScriptFunctionCall.cpp:
+ (Deprecated::ScriptFunctionCall::call):
+ Ignore TerminationExceptions, as those aren't real execution
+ exceptions and may be seen on Workers that have closed.
+
+2015-12-04 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Remove untested and unused Worker inspection
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=151848
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebindingsScriptFunctionCallcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp (193426 => 193427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp 2015-12-04 18:50:10 UTC (rev 193427)
</span><span class="lines">@@ -140,7 +140,8 @@
</span><span class="cx"> result = JSC::call(m_exec, function, callType, callData, thisObject, m_arguments, exception);
</span><span class="cx">
</span><span class="cx"> if (exception) {
</span><del>- hadException = true;
</del><ins>+ // Do not treat a terminated execution exception as having an exception. Just treat it as an empty result.
+ hadException = !isTerminatedExecutionException(exception);
</ins><span class="cx"> return Deprecated::ScriptValue();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>