<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193309] branches/safari-601-branch/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193309">193309</a></dd>
<dt>Author</dt> <dd>timothy@apple.com</dd>
<dt>Date</dt> <dd>2015-12-03 11:09:17 -0800 (Thu, 03 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/192110">r192110</a>. rdar://problem/23221163</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari601branchSourceWebInspectorUIChangeLog">branches/safari-601-branch/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#branchessafari601branchSourceWebInspectorUIUserInterfaceViewsSearchSidebarPaneljs">branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari601branchSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193308 => 193309)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:09:11 UTC (rev 193308)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:09:17 UTC (rev 193309)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2015-12-03 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><ins>+ Merge r192110. rdar://problem/23221163
+
+ 2015-11-06 Timothy Hatcher <timothy@apple.com>
+
+ Web Inspector: Search Results tab causes jump to Resources tab on reload
+ https://bugs.webkit.org/show_bug.cgi?id=150817
+
+ Reviewed by Brian Burg.
+
+ Remove the "search on reload" behavior from the Search Results tab. It often didn't find everything
+ on large pages, since it only searched after 500ms of the main resource changing. The bug here
+ was caused by performSearch selecting the first result, even if it was a background tab. We now
+ avoid doing unnecessary search work in the background when the Search Results tab isn't visible.
+
+ * UserInterface/Views/SearchSidebarPanel.js:
+ (WebInspector.SearchSidebarPanel): Deleted.
+ (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange): Remove children from the
+ sidebar since performSearch isn't doing it now and ScriptTreeElements were not being removed.
+ ResourceTreeElements were already being removed by NavigationSidebarPanel's prune behavior.
+ Removed the call to performSearch and related code.
+ (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange.delayedWork): Deleted.
+
+2015-12-03 Timothy Hatcher <timothy@apple.com>
+
</ins><span class="cx"> Merge r192086. rdar://problem/23221163
</span><span class="cx">
</span><span class="cx"> 2015-11-05 Matt Baker <mattbaker@apple.com>
</span></span></pre></div>
<a id="branchessafari601branchSourceWebInspectorUIUserInterfaceViewsSearchSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (193308 => 193309)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2015-12-03 19:09:11 UTC (rev 193308)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2015-12-03 19:09:17 UTC (rev 193309)
</span><span class="lines">@@ -47,8 +47,6 @@
</span><span class="cx">
</span><span class="cx"> this.filterBar.placeholder = WebInspector.UIString("Filter Search Results");
</span><span class="cx">
</span><del>- this._lastSearchedPageSetting = new WebInspector.Setting("last-searched-page", null);
-
</del><span class="cx"> this._searchQuerySetting = new WebInspector.Setting("search-sidebar-query", "");
</span><span class="cx"> this._inputElement.value = this._searchQuerySetting.value;
</span><span class="cx">
</span><span class="lines">@@ -81,7 +79,6 @@
</span><span class="cx">
</span><span class="cx"> this._inputElement.value = searchQuery;
</span><span class="cx"> this._searchQuerySetting.value = searchQuery;
</span><del>- this._lastSearchedPageSetting.value = searchQuery && WebInspector.frameResourceManager.mainFrame ? WebInspector.frameResourceManager.mainFrame.url.hash : null;
</del><span class="cx">
</span><span class="cx"> this.hideEmptyContentPlaceholder();
</span><span class="cx">
</span><span class="lines">@@ -342,26 +339,11 @@
</span><span class="cx"> this._delayedSearchTimeout = undefined;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ this.contentTreeOutline.removeChildren();
</ins><span class="cx"> this.contentBrowser.contentViewContainer.closeAllContentViews();
</span><span class="cx">
</span><span class="cx"> if (this.visible)
</span><span class="cx"> this.focusSearchField();
</span><del>-
- // Only if the last page searched is the same as the current page.
- var mainFrame = event.target;
- if (this._lastSearchedPageSetting.value !== mainFrame.url.hash)
- return;
-
- function delayedWork()
- {
- this._delayedSearchTimeout = undefined;
-
- // Search for whatever is in the input field. This was populated with the last used search term.
- this.performSearch(this._inputElement.value);
- }
-
- // Perform the search on a delay so we have a better chance of finding subresource results.
- this._delayedSearchTimeout = setTimeout(delayedWork.bind(this), 500);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _treeElementSelected(treeElement, selectedByUser)
</span></span></pre>
</div>
</div>
</body>
</html>