<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193408] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193408">193408</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-12-03 21:21:45 -0800 (Thu, 03 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Reduce uses of PassRefPtr in DOM - 1
https://bugs.webkit.org/show_bug.cgi?id=149788
Reviewed by Darin Adler.
As a step to purge PassRefPtr, this patch reduces the uses in WebCore/dom.
* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::getOrCreate):
* dom/ChildListMutationScope.h:
* dom/ClipboardEvent.cpp:
(WebCore::ClipboardEvent::ClipboardEvent):
* dom/ClipboardEvent.h:
* dom/CompositionEvent.cpp:
(WebCore::CompositionEvent::CompositionEvent):
(WebCore::CompositionEvent::initCompositionEvent):
* dom/CompositionEvent.h:
* dom/DOMNamedFlowCollection.cpp:
(WebCore::DOMNamedFlowCollection::item):
* dom/DOMNamedFlowCollection.h:
* dom/DOMStringList.h:
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::getLastEvent):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::getLastEvent):
* dom/DeviceOrientationController.h:
* editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent):
* page/DeviceController.h:
(WebCore::DeviceController::getLastEvent):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomChildListMutationScopecpp">trunk/Source/WebCore/dom/ChildListMutationScope.cpp</a></li>
<li><a href="#trunkSourceWebCoredomChildListMutationScopeh">trunk/Source/WebCore/dom/ChildListMutationScope.h</a></li>
<li><a href="#trunkSourceWebCoredomClipboardEventcpp">trunk/Source/WebCore/dom/ClipboardEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomClipboardEventh">trunk/Source/WebCore/dom/ClipboardEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomCompositionEventcpp">trunk/Source/WebCore/dom/CompositionEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomCompositionEventh">trunk/Source/WebCore/dom/CompositionEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomDOMNamedFlowCollectioncpp">trunk/Source/WebCore/dom/DOMNamedFlowCollection.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDOMNamedFlowCollectionh">trunk/Source/WebCore/dom/DOMNamedFlowCollection.h</a></li>
<li><a href="#trunkSourceWebCoredomDOMStringListh">trunk/Source/WebCore/dom/DOMStringList.h</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorcpp">trunk/Source/WebCore/editing/Editor.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/ChangeLog 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+2015-12-03 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Reduce uses of PassRefPtr in DOM - 1
+ https://bugs.webkit.org/show_bug.cgi?id=149788
+
+ Reviewed by Darin Adler.
+
+ As a step to purge PassRefPtr, this patch reduces the uses in WebCore/dom.
+
+ * dom/ChildListMutationScope.cpp:
+ (WebCore::ChildListMutationAccumulator::getOrCreate):
+ * dom/ChildListMutationScope.h:
+ * dom/ClipboardEvent.cpp:
+ (WebCore::ClipboardEvent::ClipboardEvent):
+ * dom/ClipboardEvent.h:
+ * dom/CompositionEvent.cpp:
+ (WebCore::CompositionEvent::CompositionEvent):
+ (WebCore::CompositionEvent::initCompositionEvent):
+ * dom/CompositionEvent.h:
+ * dom/DOMNamedFlowCollection.cpp:
+ (WebCore::DOMNamedFlowCollection::item):
+ * dom/DOMNamedFlowCollection.h:
+ * dom/DOMStringList.h:
+ * dom/DeviceMotionController.cpp:
+ (WebCore::DeviceMotionController::getLastEvent):
+ * dom/DeviceMotionController.h:
+ * dom/DeviceOrientationController.cpp:
+ (WebCore::DeviceOrientationController::getLastEvent):
+ * dom/DeviceOrientationController.h:
+ * editing/Editor.cpp:
+ (WebCore::Editor::dispatchCPPEvent):
+ * page/DeviceController.h:
+ (WebCore::DeviceController::getLastEvent):
+
</ins><span class="cx"> 2015-12-03 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove the use of GraphicsContextStateSaver from RenderLayer::paintLayerByApplyingTransform
</span></span></pre></div>
<a id="trunkSourceWebCoredomChildListMutationScopecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ChildListMutationScope.cpp (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ChildListMutationScope.cpp 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/ChildListMutationScope.cpp 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> accumulatorMap().remove(m_target.ptr());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ChildListMutationAccumulator> ChildListMutationAccumulator::getOrCreate(ContainerNode& target)
</del><ins>+RefPtr<ChildListMutationAccumulator> ChildListMutationAccumulator::getOrCreate(ContainerNode& target)
</ins><span class="cx"> {
</span><span class="cx"> AccumulatorMap::AddResult result = accumulatorMap().add(&target, nullptr);
</span><span class="cx"> RefPtr<ChildListMutationAccumulator> accumulator;
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> accumulator = adoptRef(new ChildListMutationAccumulator(target, MutationObserverInterestGroup::createForChildListMutation(target)));
</span><span class="cx"> result.iterator->value = accumulator.get();
</span><span class="cx"> }
</span><del>- return accumulator.release();
</del><ins>+ return accumulator;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> inline bool ChildListMutationAccumulator::isAddedNodeInOrder(Node& child)
</span></span></pre></div>
<a id="trunkSourceWebCoredomChildListMutationScopeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ChildListMutationScope.h (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ChildListMutationScope.h 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/ChildListMutationScope.h 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> // ChildListMutationAccumulator is not meant to be used directly; ChildListMutationScope is the public interface.
</span><span class="cx"> class ChildListMutationAccumulator : public RefCounted<ChildListMutationAccumulator> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<ChildListMutationAccumulator> getOrCreate(ContainerNode&);
</del><ins>+ static RefPtr<ChildListMutationAccumulator> getOrCreate(ContainerNode&);
</ins><span class="cx"> ~ChildListMutationAccumulator();
</span><span class="cx">
</span><span class="cx"> void childAdded(Node&);
</span></span></pre></div>
<a id="trunkSourceWebCoredomClipboardEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ClipboardEvent.cpp (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ClipboardEvent.cpp 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/ClipboardEvent.cpp 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ClipboardEvent::ClipboardEvent(const AtomicString& eventType, bool canBubble, bool cancelable, PassRefPtr<DataTransfer> dataTransfer)
</del><ins>+ClipboardEvent::ClipboardEvent(const AtomicString& eventType, bool canBubble, bool cancelable, DataTransfer* dataTransfer)
</ins><span class="cx"> : Event(eventType, canBubble, cancelable), m_dataTransfer(dataTransfer)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomClipboardEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ClipboardEvent.h (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ClipboardEvent.h 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/ClipboardEvent.h 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> {
</span><span class="cx"> return adoptRef(*new ClipboardEvent);
</span><span class="cx"> }
</span><del>- static Ref<ClipboardEvent> create(const AtomicString& type, bool canBubbleArg, bool cancelableArg, PassRefPtr<DataTransfer> clipboardArg)
</del><ins>+ static Ref<ClipboardEvent> create(const AtomicString& type, bool canBubbleArg, bool cancelableArg, DataTransfer* clipboardArg)
</ins><span class="cx"> {
</span><span class="cx"> return adoptRef(*new ClipboardEvent(type, canBubbleArg, cancelableArg, clipboardArg));
</span><span class="cx"> }
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> ClipboardEvent();
</span><del>- ClipboardEvent(const AtomicString& type, bool canBubbleArg, bool cancelableArg, PassRefPtr<DataTransfer>);
</del><ins>+ ClipboardEvent(const AtomicString& type, bool canBubbleArg, bool cancelableArg, DataTransfer*);
</ins><span class="cx">
</span><span class="cx"> virtual EventInterface eventInterface() const override;
</span><span class="cx"> virtual bool isClipboardEvent() const override;
</span></span></pre></div>
<a id="trunkSourceWebCoredomCompositionEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CompositionEvent.cpp (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CompositionEvent.cpp 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/CompositionEvent.cpp 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-CompositionEvent::CompositionEvent(const AtomicString& type, PassRefPtr<AbstractView> view, const String& data)
</del><ins>+CompositionEvent::CompositionEvent(const AtomicString& type, AbstractView* view, const String& data)
</ins><span class="cx"> : UIEvent(type, true, true, view, 0)
</span><span class="cx"> , m_data(data)
</span><span class="cx"> {
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CompositionEvent::initCompositionEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<AbstractView> view, const String& data)
</del><ins>+void CompositionEvent::initCompositionEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view, const String& data)
</ins><span class="cx"> {
</span><span class="cx"> if (dispatched())
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCoredomCompositionEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CompositionEvent.h (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CompositionEvent.h 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/CompositionEvent.h 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> return adoptRef(*new CompositionEvent);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static Ref<CompositionEvent> create(const AtomicString& type, PassRefPtr<AbstractView> view, const String& data)
</del><ins>+ static Ref<CompositionEvent> create(const AtomicString& type, AbstractView* view, const String& data)
</ins><span class="cx"> {
</span><span class="cx"> return adoptRef(*new CompositionEvent(type, view, data));
</span><span class="cx"> }
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~CompositionEvent();
</span><span class="cx">
</span><del>- void initCompositionEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<AbstractView>, const String& data);
</del><ins>+ void initCompositionEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView*, const String& data);
</ins><span class="cx">
</span><span class="cx"> String data() const { return m_data; }
</span><span class="cx">
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> CompositionEvent();
</span><del>- CompositionEvent(const AtomicString& type, PassRefPtr<AbstractView>, const String&);
</del><ins>+ CompositionEvent(const AtomicString& type, AbstractView*, const String&);
</ins><span class="cx"> CompositionEvent(const AtomicString& type, const CompositionEventInit&);
</span><span class="cx">
</span><span class="cx"> String m_data;
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMNamedFlowCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMNamedFlowCollection.cpp (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMNamedFlowCollection.cpp 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/DOMNamedFlowCollection.cpp 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> return m_namedFlows.size();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<WebKitNamedFlow> DOMNamedFlowCollection::item(unsigned long index) const
</del><ins>+RefPtr<WebKitNamedFlow> DOMNamedFlowCollection::item(unsigned long index) const
</ins><span class="cx"> {
</span><span class="cx"> if (index >= static_cast<unsigned long>(m_namedFlows.size()))
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMNamedFlowCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMNamedFlowCollection.h (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMNamedFlowCollection.h 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/DOMNamedFlowCollection.h 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx">
</span><span class="cx"> #include "NamedFlowCollection.h"
</span><span class="cx"> #include <wtf/ListHashSet.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><span class="lines">@@ -48,7 +47,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unsigned long length() const;
</span><del>- PassRefPtr<WebKitNamedFlow> item(unsigned long index) const;
</del><ins>+ RefPtr<WebKitNamedFlow> item(unsigned long index) const;
</ins><span class="cx"> RefPtr<WebKitNamedFlow> namedItem(const AtomicString& name) const;
</span><span class="cx"> Vector<AtomicString> supportedPropertyNames();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMStringListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMStringList.h (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMStringList.h 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/dom/DOMStringList.h 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -26,7 +26,6 @@
</span><span class="cx"> #ifndef DOMStringList_h
</span><span class="cx"> #define DOMStringList_h
</span><span class="cx">
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/Editor.cpp (193407 => 193408)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/Editor.cpp 2015-12-04 04:51:20 UTC (rev 193407)
+++ trunk/Source/WebCore/editing/Editor.cpp 2015-12-04 05:21:45 UTC (rev 193408)
</span><span class="lines">@@ -851,7 +851,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<DataTransfer> dataTransfer = DataTransfer::createForCopyAndPaste(policy);
</span><span class="cx">
</span><del>- Ref<Event> event = ClipboardEvent::create(eventType, true, true, dataTransfer);
</del><ins>+ Ref<Event> event = ClipboardEvent::create(eventType, true, true, dataTransfer.get());
</ins><span class="cx"> target->dispatchEvent(event);
</span><span class="cx"> bool noDefaultProcessing = event->defaultPrevented();
</span><span class="cx"> if (noDefaultProcessing && policy == DataTransferAccessPolicy::Writable) {
</span></span></pre>
</div>
</div>
</body>
</html>