<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[193334] branches/safari-601-branch/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/193334">193334</a></dd>
<dt>Author</dt> <dd>timothy@apple.com</dd>
<dt>Date</dt> <dd>2015-12-03 11:11:59 -0800 (Thu, 03 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/192735">r192735</a>. rdar://problem/23221163</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari601branchSourceWebInspectorUIChangeLog">branches/safari-601-branch/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#branchessafari601branchSourceWebInspectorUIUserInterfaceViewsFolderizedTreeElementjs">branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari601branchSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (193333 => 193334)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:11:54 UTC (rev 193333)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog 2015-12-03 19:11:59 UTC (rev 193334)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2015-12-03 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><ins>+ Merge r192735. rdar://problem/23221163
+
+ 2015-11-22 Matt Baker <mattbaker@apple.com>
+
+ Web Inspector: Clean up FolderizedTreeElement folder settings
+ https://bugs.webkit.org/show_bug.cgi?id=151539
+
+ Reviewed by Brian Burg.
+
+ The expanded state for each folder was stored as an external property on the folder
+ tree element. Now FolderizedTreeElement keeps a map of folders to settings.
+
+ * UserInterface/Views/FolderizedTreeElement.js:
+ (WebInspector.FolderizedTreeElement):
+ (WebInspector.FolderizedTreeElement.prototype.removeChildren):
+ (WebInspector.FolderizedTreeElement.prototype._parentTreeElementForRepresentedObject):
+ (WebInspector.FolderizedTreeElement.prototype._folderTreeElementExpandedStateChange):
+
+2015-12-03 Timothy Hatcher <timothy@apple.com>
+
</ins><span class="cx"> Merge r192719. rdar://problem/23221163
</span><span class="cx">
</span><span class="cx"> 2015-11-20 Joseph Pecoraro <pecoraro@apple.com>
</span></span></pre></div>
<a id="branchessafari601branchSourceWebInspectorUIUserInterfaceViewsFolderizedTreeElementjs"></a>
<div class="modfile"><h4>Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js (193333 => 193334)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js 2015-12-03 19:11:54 UTC (rev 193333)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js 2015-12-03 19:11:59 UTC (rev 193334)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx">
</span><span class="cx"> this.shouldRefreshChildren = true;
</span><span class="cx">
</span><ins>+ this._folderExpandedSettingMap = new Map;
</ins><span class="cx"> this._folderSettingsKey = "";
</span><span class="cx"> this._folderTypeMap = new Map;
</span><span class="cx"> this._folderizeSettingsMap = new Map;
</span><span class="lines">@@ -80,6 +81,7 @@
</span><span class="cx"> for (var folder of this._folderTypeMap.values())
</span><span class="cx"> folder.removeChildren();
</span><span class="cx">
</span><ins>+ this._folderExpandedSettingMap.clear();
</ins><span class="cx"> this._folderTypeMap.clear();
</span><span class="cx">
</span><span class="cx"> this._groupedIntoFolders = false;
</span><span class="lines">@@ -273,9 +275,12 @@
</span><span class="cx"> function createFolderTreeElement(type, displayName)
</span><span class="cx"> {
</span><span class="cx"> var folderTreeElement = new WebInspector.FolderTreeElement(displayName);
</span><del>- folderTreeElement.__expandedSetting = new WebInspector.Setting(type + "-folder-expanded-" + this._folderSettingsKey, false);
- if (folderTreeElement.__expandedSetting.value)
</del><ins>+ var folderExpandedSetting = new WebInspector.Setting(type + "-folder-expanded-" + this._folderSettingsKey, false);
+ this._folderExpandedSettingMap.set(folderTreeElement, folderExpandedSetting);
+
+ if (folderExpandedSetting.value)
</ins><span class="cx"> folderTreeElement.expand();
</span><ins>+
</ins><span class="cx"> folderTreeElement.onexpand = this._folderTreeElementExpandedStateChange.bind(this);
</span><span class="cx"> folderTreeElement.oncollapse = this._folderTreeElementExpandedStateChange.bind(this);
</span><span class="cx"> return folderTreeElement;
</span><span class="lines">@@ -298,8 +303,12 @@
</span><span class="cx">
</span><span class="cx"> _folderTreeElementExpandedStateChange(folderTreeElement)
</span><span class="cx"> {
</span><del>- console.assert(folderTreeElement.__expandedSetting);
- folderTreeElement.__expandedSetting.value = folderTreeElement.expanded;
</del><ins>+ var expandedSetting = this._folderExpandedSettingMap.get(folderTreeElement);
+ console.assert(expandedSetting, "No expanded setting for folderTreeElement", folderTreeElement);
+ if (!expandedSetting)
+ return;
+
+ expandedSetting.value = folderTreeElement.expanded;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _settingsForRepresentedObject(representedObject)
</span></span></pre>
</div>
</div>
</body>
</html>