<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192828] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192828">192828</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-11-30 14:15:27 -0800 (Mon, 30 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add an option to select the results form the graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=151666
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-11-30
Reviewed by Ryosuke Niwa.
We need an easy way to select the graphics benchmark results table such
that when it is copied to the clipboard, rich text format is set to the
clipboard.
* Animometer/runner/animometer.html: Add a new button to select the results table or JSON.
* Animometer/runner/resources/animometer.js:
(window.sectionsManager._sectionDataElement): Selects the container <data> element.
(window.sectionsManager._sectionDataDivElement): Replace a literal string with a string table entry.
(window.sectionsManager.showTestName): Replace a literal string with a string table entry.
(window.sectionsManager.selectData): Selects the container <data> element in a selection.
(window.sectionsManager.selectDataContents): Select the contents of container <data> element in a selection.
(window.benchmarkController.selectResults): Selects the results table.
(window.benchmarkController.showJSON): Function rename.
(window.benchmarkController.selectJSON): Selects the contents of the results JSON.
(window.benchmarkController.showJson): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsAnimometerrunneranimometerhtml">trunk/PerformanceTests/Animometer/runner/animometer.html</a></li>
<li><a href="#trunkPerformanceTestsAnimometerrunnerresourcesanimometerjs">trunk/PerformanceTests/Animometer/runner/resources/animometer.js</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsAnimometerrunneranimometerhtml"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/runner/animometer.html (192827 => 192828)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/runner/animometer.html 2015-11-30 22:15:18 UTC (rev 192827)
+++ trunk/PerformanceTests/Animometer/runner/animometer.html 2015-11-30 22:15:27 UTC (rev 192828)
</span><span class="lines">@@ -55,7 +55,8 @@
</span><span class="cx"> <table class="results-table"></table>
</span><span class="cx"> </data>
</span><span class="cx"> <footer>
</span><del>- <button class="large-button" onclick="benchmarkController.showJson()">JSON</button>
</del><ins>+ <button class="large-button" onclick="benchmarkController.selectResults()">Select</button>
+ <button class="large-button" onclick="benchmarkController.showJSON()">JSON</button>
</ins><span class="cx"> <button class="large-button" onclick="benchmarkController.startTest()">Test Again</button>
</span><span class="cx"> </footer>
</span><span class="cx"> </section>
</span><span class="lines">@@ -67,6 +68,7 @@
</span><span class="cx"> <div class="results-json" contentEditable="true"></div>
</span><span class="cx"> </data>
</span><span class="cx"> <footer>
</span><ins>+ <button class="large-button" onclick="benchmarkController.selectJSON('json')">Select</button>
</ins><span class="cx"> <button class="large-button" onclick="benchmarkController.showResults()">Results</button>
</span><span class="cx"> <button class="large-button" onclick="benchmarkController.startTest()">Test Again</button>
</span><span class="cx"> </footer>
</span><span class="lines">@@ -79,6 +81,7 @@
</span><span class="cx"> <div class="results-json" contentEditable="true"></div>
</span><span class="cx"> </data>
</span><span class="cx"> <footer>
</span><ins>+ <button class="large-button" onclick="benchmarkController.selectJSON('test-json')">Select</button>
</ins><span class="cx"> <button class="large-button" onclick="benchmarkController.showResults()">Results</button>
</span><span class="cx"> <button class="large-button" onclick="benchmarkController.startTest()">Test Again</button>
</span><span class="cx"> </footer>
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometerrunnerresourcesanimometerjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.js (192827 => 192828)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/runner/resources/animometer.js 2015-11-30 22:15:18 UTC (rev 192827)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.js 2015-11-30 22:15:27 UTC (rev 192828)
</span><span class="lines">@@ -58,6 +58,11 @@
</span><span class="cx"> {
</span><span class="cx"> return document.querySelector("#" + sectionIdentifier + " > header > h1");
</span><span class="cx"> },
</span><ins>+
+ _sectionDataElement: function(sectionIdentifier)
+ {
+ return document.querySelector("#" + sectionIdentifier + " > data");
+ },
</ins><span class="cx">
</span><span class="cx"> _sectionDataDivElement: function(sectionIdentifier)
</span><span class="cx"> {
</span><span class="lines">@@ -70,7 +75,7 @@
</span><span class="cx"> element.textContent = title + ":";
</span><span class="cx">
</span><span class="cx"> var score = benchmarkRunnerClient.score.toFixed(2);
</span><del>- element.textContent += " [Score = " + score + "]";
</del><ins>+ element.textContent += " [" + Strings.text.score + " = " + score + "]";
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> showTestName: function(sectionIdentifier, title, testName)
</span><span class="lines">@@ -81,7 +86,7 @@
</span><span class="cx"> if (!testName.length)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- element.textContent += " [test = " + testName + "]";
</del><ins>+ element.textContent += " [" + Strings.text.testName + " = " + testName + "]";
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> showJSON: function(sectionIdentifier, json)
</span><span class="lines">@@ -94,6 +99,24 @@
</span><span class="cx"> }, 4);
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ selectData: function(sectionIdentifier)
+ {
+ window.getSelection().removeAllRanges();
+ var element = this._sectionDataElement(sectionIdentifier);
+ var range = document.createRange();
+ range.selectNode(element);
+ window.getSelection().addRange(range);
+ },
+
+ selectDataContents: function(sectionIdentifier)
+ {
+ window.getSelection().removeAllRanges();
+ var element = this._sectionDataDivElement(sectionIdentifier);
+ var range = document.createRange();
+ range.selectNodeContents(element);
+ window.getSelection().addRange(range);
+ },
+
</ins><span class="cx"> showSection: function(sectionIdentifier, pushState)
</span><span class="cx"> {
</span><span class="cx"> var currentSectionElement = document.querySelector("section.selected");
</span><span class="lines">@@ -414,6 +437,11 @@
</span><span class="cx"> this._runBenchmark(suites, options);
</span><span class="cx"> sectionsManager.showSection("running");
</span><span class="cx"> },
</span><ins>+
+ selectResults: function()
+ {
+ sectionsManager.selectData("results");
+ },
</ins><span class="cx">
</span><span class="cx"> showResults: function()
</span><span class="cx"> {
</span><span class="lines">@@ -421,12 +449,12 @@
</span><span class="cx"> sectionsManager.showSection("results", true);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- showJson: function()
</del><ins>+ showJSON: function()
</ins><span class="cx"> {
</span><span class="cx"> sectionsManager.showScore("json", Strings.text.results.results);
</span><span class="cx"> sectionsManager.showSection("json", true);
</span><span class="cx"> },
</span><del>-
</del><ins>+
</ins><span class="cx"> showTestGraph: function(testName, axes, samples, samplingTimeOffset)
</span><span class="cx"> {
</span><span class="cx"> sectionsManager.showTestName("test-graph", Strings.text.results.graph, testName);
</span><span class="lines">@@ -439,7 +467,12 @@
</span><span class="cx"> sectionsManager.showTestName("test-json", Strings.text.results.graph, testName);
</span><span class="cx"> sectionsManager.showJSON("test-json", json);
</span><span class="cx"> sectionsManager.showSection("test-json", true);
</span><del>- }
</del><ins>+ },
+
+ selectJSON: function(sectionIdentifier)
+ {
+ sectionsManager.selectDataContents(sectionIdentifier);
+ },
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> window.addEventListener("load", benchmarkController.initialize);
</span></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (192827 => 192828)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2015-11-30 22:15:18 UTC (rev 192827)
+++ trunk/PerformanceTests/ChangeLog 2015-11-30 22:15:27 UTC (rev 192828)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2015-11-30 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Add an option to select the results form the graphics benchmark
+ https://bugs.webkit.org/show_bug.cgi?id=151666
+
+ Reviewed by Ryosuke Niwa.
+
+ We need an easy way to select the graphics benchmark results table such
+ that when it is copied to the clipboard, rich text format is set to the
+ clipboard.
+
+ * Animometer/runner/animometer.html: Add a new button to select the results table or JSON.
+
+ * Animometer/runner/resources/animometer.js:
+ (window.sectionsManager._sectionDataElement): Selects the container <data> element.
+ (window.sectionsManager._sectionDataDivElement): Replace a literal string with a string table entry.
+ (window.sectionsManager.showTestName): Replace a literal string with a string table entry.
+ (window.sectionsManager.selectData): Selects the container <data> element in a selection.
+ (window.sectionsManager.selectDataContents): Select the contents of container <data> element in a selection.
+ (window.benchmarkController.selectResults): Selects the results table.
+ (window.benchmarkController.showJSON): Function rename.
+ (window.benchmarkController.selectJSON): Selects the contents of the results JSON.
+ (window.benchmarkController.showJson): Deleted.
+
</ins><span class="cx"> 2015-11-20 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Animometer: graphs should not do interpolation
</span></span></pre>
</div>
</div>
</body>
</html>