<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192829] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192829">192829</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2015-11-30 14:17:58 -0800 (Mon, 30 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove some unused synchronous drawing SPI
https://bugs.webkit.org/show_bug.cgi?id=151672
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView forceAsyncDrawingAreaSizeUpdate:]): Deleted.
(-[WKView waitForAsyncDrawingAreaSizeUpdate]): Deleted.
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::forceAsyncDrawingAreaSizeUpdate): Deleted.
(WebKit::WebViewImpl::waitForAsyncDrawingAreaSizeUpdate): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKViewPrivateh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewmm">trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaWebViewImplh">trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaWebViewImplmm">trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (192828 => 192829)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-11-30 22:15:27 UTC (rev 192828)
+++ trunk/Source/WebKit2/ChangeLog 2015-11-30 22:17:58 UTC (rev 192829)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2015-11-30 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><ins>+ Remove some unused synchronous drawing SPI
+ https://bugs.webkit.org/show_bug.cgi?id=151672
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/Cocoa/WKViewPrivate.h:
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView forceAsyncDrawingAreaSizeUpdate:]): Deleted.
+ (-[WKView waitForAsyncDrawingAreaSizeUpdate]): Deleted.
+ * UIProcess/Cocoa/WebViewImpl.h:
+ * UIProcess/Cocoa/WebViewImpl.mm:
+ (WebKit::WebViewImpl::forceAsyncDrawingAreaSizeUpdate): Deleted.
+ (WebKit::WebViewImpl::waitForAsyncDrawingAreaSizeUpdate): Deleted.
+
+2015-11-30 Tim Horton <timothy_horton@apple.com>
+
</ins><span class="cx"> Get rid of the legacy swipe shadow style
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=151671
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKViewPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (192828 => 192829)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2015-11-30 22:15:27 UTC (rev 192828)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2015-11-30 22:17:58 UTC (rev 192829)
</span><span class="lines">@@ -101,9 +101,6 @@
</span><span class="cx"> - (BOOL)windowOcclusionDetectionEnabled;
</span><span class="cx"> - (void)setWindowOcclusionDetectionEnabled:(BOOL)flag;
</span><span class="cx">
</span><del>-- (void)forceAsyncDrawingAreaSizeUpdate:(NSSize)size;
-- (void)waitForAsyncDrawingAreaSizeUpdate;
-
</del><span class="cx"> - (void)setMagnification:(double)magnification centeredAtPoint:(NSPoint)point;
</span><span class="cx">
</span><span class="cx"> - (void)setAllowsLinkPreview:(BOOL)allowsLinkPreview;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (192828 => 192829)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-11-30 22:15:27 UTC (rev 192828)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-11-30 22:17:58 UTC (rev 192829)
</span><span class="lines">@@ -1316,16 +1316,6 @@
</span><span class="cx"> return _data->_impl->pageExtendedBackgroundColor();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (void)forceAsyncDrawingAreaSizeUpdate:(NSSize)size
-{
- _data->_impl->forceAsyncDrawingAreaSizeUpdate(NSSizeToCGSize(size));
-}
-
-- (void)waitForAsyncDrawingAreaSizeUpdate
-{
- _data->_impl->waitForAsyncDrawingAreaSizeUpdate();
-}
-
</del><span class="cx"> - (BOOL)isUsingUISideCompositing
</span><span class="cx"> {
</span><span class="cx"> return _data->_impl->isUsingUISideCompositing();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaWebViewImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h (192828 => 192829)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h 2015-11-30 22:15:27 UTC (rev 192828)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h 2015-11-30 22:17:58 UTC (rev 192829)
</span><span class="lines">@@ -147,8 +147,6 @@
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy();
</span><span class="cx"> bool isUsingUISideCompositing() const;
</span><span class="cx"> void setDrawingAreaSize(CGSize);
</span><del>- void forceAsyncDrawingAreaSizeUpdate(CGSize);
- void waitForAsyncDrawingAreaSizeUpdate();
</del><span class="cx"> void updateLayer();
</span><span class="cx"> static bool wantsUpdateLayer() { return true; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaWebViewImplmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm (192828 => 192829)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm 2015-11-30 22:15:27 UTC (rev 192828)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm 2015-11-30 22:17:58 UTC (rev 192829)
</span><span class="lines">@@ -757,47 +757,6 @@
</span><span class="cx"> m_resizeScrollOffset = CGSizeZero;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wmissing-noreturn"
-// This method forces a drawing area geometry update, even if frame size updates are disabled.
-// The updated is performed asynchronously; we don't wait for the geometry update before returning.
-// The area drawn need not match the current frame size - if it differs it will be anchored to the
-// frame according to the current contentAnchor.
-void WebViewImpl::forceAsyncDrawingAreaSizeUpdate(CGSize size)
-{
- // This SPI is only used on 10.9 and below, and is incompatible with the fence-based drawing area size synchronization in 10.10+.
-#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 1090
- if (m_clipsToVisibleRect)
- updateViewExposedRect();
- setDrawingAreaSize(size);
-
- // If a geometry update is pending the new update won't be sent. Poll without waiting for any
- // pending did-update message now, such that the new update can be sent. We do so after setting
- // the drawing area size such that the latest update is sent.
- if (DrawingAreaProxy* drawingArea = m_page->drawingArea())
- drawingArea->waitForPossibleGeometryUpdate(std::chrono::milliseconds::zero());
-#else
- ASSERT_NOT_REACHED();
-#endif
-}
-
-void WebViewImpl::waitForAsyncDrawingAreaSizeUpdate()
-{
- // This SPI is only used on 10.9 and below, and is incompatible with the fence-based drawing area size synchronization in 10.10+.
-#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 1090
- if (DrawingAreaProxy* drawingArea = m_page->drawingArea()) {
- // If a geometry update is still pending then the action of receiving the
- // first geometry update may result in another update being scheduled -
- // we should wait for this to complete too.
- drawingArea->waitForPossibleGeometryUpdate(DrawingAreaProxy::didUpdateBackingStoreStateTimeout() / 2);
- drawingArea->waitForPossibleGeometryUpdate(DrawingAreaProxy::didUpdateBackingStoreStateTimeout() / 2);
- }
-#else
- ASSERT_NOT_REACHED();
-#endif
-}
-#pragma clang diagnostic pop
-
</del><span class="cx"> void WebViewImpl::updateLayer()
</span><span class="cx"> {
</span><span class="cx"> m_view.layer.backgroundColor = CGColorGetConstantColor(drawsBackground() ? kCGColorWhite : kCGColorClear);
</span></span></pre>
</div>
</div>
</body>
</html>