<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192817] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192817">192817</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-11-30 13:09:42 -0800 (Mon, 30 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Perf dashboard should always show comparison to baseline and target even if one is missing
https://bugs.webkit.org/show_bug.cgi?id=151510
Reviewed by Darin Adler.
Show the comparison status against the baseline when baseline is present but target is missing.
To make the code more readable, this patch splits the logic into three cases:
1. Both baseline and target are present
2. Only baseline is present
3. Only target is present
Also extracted a helper function to construct the label.
* public/v2/app.js:
(.labelForDiff): Added.
(App.Pane.computeStatus):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (192816 => 192817)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:05:25 UTC (rev 192816)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:09:42 UTC (rev 192817)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-11-30 Ryosuke Niwa <rniwa@webkit.org>
+
+ Perf dashboard should always show comparison to baseline and target even if one is missing
+ https://bugs.webkit.org/show_bug.cgi?id=151510
+
+ Reviewed by Darin Adler.
+
+ Show the comparison status against the baseline when baseline is present but target is missing.
+
+ To make the code more readable, this patch splits the logic into three cases:
+ 1. Both baseline and target are present
+ 2. Only baseline is present
+ 3. Only target is present
+
+ Also extracted a helper function to construct the label.
+
+ * public/v2/app.js:
+ (.labelForDiff): Added.
+ (App.Pane.computeStatus):
+
</ins><span class="cx"> 2015-11-23 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r192716 and r192717.
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (192816 => 192817)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-11-30 21:05:25 UTC (rev 192816)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-11-30 21:09:42 UTC (rev 192817)
</span><span class="lines">@@ -486,15 +486,27 @@
</span><span class="cx"> var className = '';
</span><span class="cx"> var formatter = d3.format('.3p');
</span><span class="cx">
</span><ins>+ function labelForDiff(diff, name) { return formatter(Math.abs(diff)) + ' ' + (diff > 0 ? 'above' : 'below') + ' ' + name; }
+
</ins><span class="cx"> var smallerIsBetter = chartData.smallerIsBetter;
</span><del>- if (diffFromBaseline !== undefined && diffFromBaseline > 0 == smallerIsBetter) {
- label = formatter(Math.abs(diffFromBaseline)) + ' ' + (smallerIsBetter ? 'above' : 'below') + ' baseline';
- className = 'worse';
- } else if (diffFromTarget !== undefined && diffFromTarget < 0 == smallerIsBetter) {
- label = formatter(Math.abs(diffFromTarget)) + ' ' + (smallerIsBetter ? 'below' : 'above') + ' target';
- className = 'better';
- } else if (diffFromTarget !== undefined)
- label = formatter(Math.abs(diffFromTarget)) + ' until target';
</del><ins>+ if (diffFromBaseline !== undefined && diffFromTarget !== undefined) {
+ if (diffFromBaseline > 0 == smallerIsBetter) {
+ label = labelForDiff(diffFromBaseline, 'baseline');
+ className = 'worse';
+ } else if (diffFromTarget < 0 == smallerIsBetter) {
+ label = labelForDiff(diffFromBaseline, 'target');
+ className = 'better';
+ } else
+ label = formatter(Math.abs(diffFromTarget)) + ' until target';
+ } else if (diffFromBaseline !== undefined) {
+ label = labelForDiff(diffFromBaseline, 'baseline');
+ if (diffFromBaseline > 0 == smallerIsBetter)
+ className = 'worse';
+ } else if (diffFromTarget !== undefined) {
+ label = labelForDiff(diffFromTarget, 'target');
+ if (diffFromTarget < 0 == smallerIsBetter)
+ className = 'better';
+ }
</ins><span class="cx">
</span><span class="cx"> var valueDelta = null;
</span><span class="cx"> var relativeDelta = null;
</span></span></pre>
</div>
</div>
</body>
</html>