<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192818] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192818">192818</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-11-30 13:12:43 -0800 (Mon, 30 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Perf dashboard should extend baseline and target to the future
https://bugs.webkit.org/show_bug.cgi?id=151511
Reviewed by Darin Adler.
* public/v2/data.js:
(RunsData.prototype.timeSeriesByCommitTime): Added extendToFuture as an argument.
(RunsData.prototype.timeSeriesByBuildTime): Ditto.
(RunsData.prototype._timeSeriesByTimeInternal): Ditto.
(TimeSeries): Add a new point to the end if extendToFuture is set and the series is not empty.
* public/v2/manifest.js:
(App.Manifest._formatFetchedData): Set extendToFuture to true for baselines and targets.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2datajs">trunk/Websites/perf.webkit.org/public/v2/data.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (192817 => 192818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:09:42 UTC (rev 192817)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:12:43 UTC (rev 192818)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2015-11-30 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Perf dashboard should extend baseline and target to the future
+ https://bugs.webkit.org/show_bug.cgi?id=151511
+
+ Reviewed by Darin Adler.
+
+ * public/v2/data.js:
+ (RunsData.prototype.timeSeriesByCommitTime): Added extendToFuture as an argument.
+ (RunsData.prototype.timeSeriesByBuildTime): Ditto.
+ (RunsData.prototype._timeSeriesByTimeInternal): Ditto.
+ (TimeSeries): Add a new point to the end if extendToFuture is set and the series is not empty.
+ * public/v2/manifest.js:
+ (App.Manifest._formatFetchedData): Set extendToFuture to true for baselines and targets.
+
+2015-11-30 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Perf dashboard should always show comparison to baseline and target even if one is missing
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=151510
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2datajs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (192817 => 192818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/data.js 2015-11-30 21:09:42 UTC (rev 192817)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js 2015-11-30 21:12:43 UTC (rev 192818)
</span><span class="lines">@@ -323,17 +323,17 @@
</span><span class="cx"> return this._measurements.length;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RunsData.prototype.timeSeriesByCommitTime = function (includeOutliers)
</del><ins>+RunsData.prototype.timeSeriesByCommitTime = function (includeOutliers, extendToFuture)
</ins><span class="cx"> {
</span><del>- return this._timeSeriesByTimeInternal(true, includeOutliers);
</del><ins>+ return this._timeSeriesByTimeInternal(true, includeOutliers, extendToFuture);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RunsData.prototype.timeSeriesByBuildTime = function (includeOutliers)
</del><ins>+RunsData.prototype.timeSeriesByBuildTime = function (includeOutliers, extendToFuture)
</ins><span class="cx"> {
</span><del>- return this._timeSeriesByTimeInternal(false, includeOutliers);
</del><ins>+ return this._timeSeriesByTimeInternal(false, includeOutliers, extendToFuture);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RunsData.prototype._timeSeriesByTimeInternal = function (useCommitType, includeOutliers)
</del><ins>+RunsData.prototype._timeSeriesByTimeInternal = function (useCommitType, includeOutliers, extendToFuture)
</ins><span class="cx"> {
</span><span class="cx"> var series = new Array();
</span><span class="cx"> var seriesIndex = 0;
</span><span class="lines">@@ -349,7 +349,7 @@
</span><span class="cx"> markedOutlier: measurement.markedOutlier(),
</span><span class="cx"> });
</span><span class="cx"> }
</span><del>- return new TimeSeries(series);
</del><ins>+ return new TimeSeries(series, extendToFuture);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: We need to devise a way to fetch runs in multiple chunks so that
</span><span class="lines">@@ -420,13 +420,26 @@
</span><span class="cx"> return unit != 'fps' && unit != '/s' && unit != 'pt';
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function TimeSeries(series)
</del><ins>+// FIXME: Extending the baseline/target to the future should be a server-side configuration.
+function TimeSeries(series, extendToFuture)
</ins><span class="cx"> {
</span><span class="cx"> this._series = series.sort(function (a, b) {
</span><span class="cx"> var diff = a.time - b.time;
</span><span class="cx"> return diff ? diff : a.secondaryTime - b.secondaryTime;
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ if (extendToFuture && this._series.length) {
+ var lastPoint = this._series[this._series.length - 1];
+ this._series.push({
+ measurement: lastPoint.measurement,
+ time: Date.now() + 24 * 3600 * 1000,
+ secondaryTime: Date.now() + 24 * 3600 * 1000,
+ value: lastPoint.value,
+ interval: lastPoint.interval,
+ markedOutlier: lastPoint.markedOutlier,
+ });
+ }
+
</ins><span class="cx"> var self = this;
</span><span class="cx"> var min = undefined;
</span><span class="cx"> var max = undefined;
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (192817 => 192818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-11-30 21:09:42 UTC (rev 192817)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-11-30 21:12:43 UTC (rev 192818)
</span><span class="lines">@@ -365,12 +365,12 @@
</span><span class="cx"> var deltaFormatterWithoutSign = this._makeFormatter(unit, 2, false);
</span><span class="cx">
</span><span class="cx"> var currentTimeSeries = configurations.current.timeSeriesByCommitTime(false);
</span><del>- var baselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(false) : null;
- var targetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(false) : null;
</del><ins>+ var baselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(false, true) : null;
+ var targetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(false, true) : null;
</ins><span class="cx">
</span><span class="cx"> var unfilteredCurrentTimeSeries = configurations.current.timeSeriesByCommitTime(true);
</span><del>- var unfilteredBaselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(true) : null;
- var unfilteredTargetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(true) : null;
</del><ins>+ var unfilteredBaselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(true, true) : null;
+ var unfilteredTargetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(true, true) : null;
</ins><span class="cx">
</span><span class="cx"> return {
</span><span class="cx"> current: currentTimeSeries,
</span></span></pre>
</div>
</div>
</body>
</html>