<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192741] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192741">192741</a></dd>
<dt>Author</dt> <dd>svillar@igalia.com</dd>
<dt>Date</dt> <dd>2015-11-23 01:03:30 -0800 (Mon, 23 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>ASSERTION FAILED: freeSpace >= 0 in WebCore::RenderGrid::computeTrackSizesForDirection
https://bugs.webkit.org/show_bug.cgi?id=151254
Reviewed by Darin Adler.
Source/WebCore:
When in quirks mode, abnormally huge margins could lead to
negative computations of available logical sizes. We could add
an !document.inQuirksMode() check in the assertion but since
negative freeSpace values are valid (i.e. the condition is not
really part of the contract and everything will work as
expected) I've decided to simply remove it.
Test: fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeTrackSizesForDirection): Deleted.
LayoutTests:
* fast/css-grid-layout/grid-quirks-mode-huge-margin-crash-expected.txt: Added.
* fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderGridcpp">trunk/Source/WebCore/rendering/RenderGrid.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridquirksmodehugemargincrashexpectedtxt">trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridquirksmodehugemargincrashhtml">trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (192740 => 192741)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-11-23 08:49:03 UTC (rev 192740)
+++ trunk/LayoutTests/ChangeLog 2015-11-23 09:03:30 UTC (rev 192741)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-11-17 Sergio Villar Senin <svillar@igalia.com>
+
+ ASSERTION FAILED: freeSpace >= 0 in WebCore::RenderGrid::computeTrackSizesForDirection
+ https://bugs.webkit.org/show_bug.cgi?id=151254
+
+ Reviewed by Darin Adler.
+
+ * fast/css-grid-layout/grid-quirks-mode-huge-margin-crash-expected.txt: Added.
+ * fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html: Added.
+
</ins><span class="cx"> 2015-11-22 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a test to make sure that font-variant: inherit works correctly.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridquirksmodehugemargincrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash-expected.txt (0 => 192741)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash-expected.txt 2015-11-23 09:03:30 UTC (rev 192741)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+This test has PASSED if it doesn't CRASH.
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridquirksmodehugemargincrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html (0 => 192741)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html 2015-11-23 09:03:30 UTC (rev 192741)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+}
+</script>
+<link href="resources/grid.css" rel="stylesheet">
+<style>
+.grid {
+ margin: 5641665960219;
+ overflow-y: scroll;
+}
+</style>
+
+<div class="grid"></div>
+<p>This test has PASSED if it doesn't CRASH.</p>
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (192740 => 192741)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-11-23 08:49:03 UTC (rev 192740)
+++ trunk/Source/WebCore/ChangeLog 2015-11-23 09:03:30 UTC (rev 192741)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-11-17 Sergio Villar Senin <svillar@igalia.com>
+
+ ASSERTION FAILED: freeSpace >= 0 in WebCore::RenderGrid::computeTrackSizesForDirection
+ https://bugs.webkit.org/show_bug.cgi?id=151254
+
+ Reviewed by Darin Adler.
+
+ When in quirks mode, abnormally huge margins could lead to
+ negative computations of available logical sizes. We could add
+ an !document.inQuirksMode() check in the assertion but since
+ negative freeSpace values are valid (i.e. the condition is not
+ really part of the contract and everything will work as
+ expected) I've decided to simply remove it.
+
+ Test: fast/css-grid-layout/grid-quirks-mode-huge-margin-crash.html
+
+ * rendering/RenderGrid.cpp:
+ (WebCore::RenderGrid::computeTrackSizesForDirection): Deleted.
+
</ins><span class="cx"> 2015-11-22 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Font selection should not consult font-variant property
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderGridcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (192740 => 192741)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderGrid.cpp 2015-11-23 08:49:03 UTC (rev 192740)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp 2015-11-23 09:03:30 UTC (rev 192741)
</span><span class="lines">@@ -328,7 +328,6 @@
</span><span class="cx">
</span><span class="cx"> void RenderGrid::computeTrackSizesForDirection(GridTrackSizingDirection direction, GridSizingData& sizingData, LayoutUnit freeSpace)
</span><span class="cx"> {
</span><del>- ASSERT(freeSpace >= 0);
</del><span class="cx"> LayoutUnit totalGuttersSize = guttersSize(direction, direction == ForRows ? gridRowCount() : gridColumnCount());
</span><span class="cx"> sizingData.setFreeSpaceForDirection(direction, freeSpace - totalGuttersSize);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>