<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192745] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192745">192745</a></dd>
<dt>Author</dt> <dd>bburg@apple.com</dd>
<dt>Date</dt> <dd>2015-11-23 09:00:34 -0800 (Mon, 23 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: when inspecting the inspector, add the inspection level to the title bar
https://bugs.webkit.org/show_bug.cgi?id=151555
Reviewed by Timothy Hatcher.
Source/WebCore:
* English.lproj/Localizable.strings: add new localized string for alternate inspector title.
Source/WebInspectorUI:
Drive-by update to remove some localization strings that are no longer used.
* Localizations/en.lproj/localizedStrings.js:
Source/WebKit2:
If the inspection level says we are inspecting an inspector, include the level
in the title bar to easily disambiguate it from the base level inspector.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::updateInspectorWindowTitle):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreEnglishlprojLocalizablestrings">trunk/Source/WebCore/English.lproj/Localizable.strings</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacWebInspectorProxyMacmm">trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (192744 => 192745)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-11-23 13:38:49 UTC (rev 192744)
+++ trunk/Source/WebCore/ChangeLog 2015-11-23 17:00:34 UTC (rev 192745)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-11-23 Brian Burg <bburg@apple.com>
+
+ Web Inspector: when inspecting the inspector, add the inspection level to the title bar
+ https://bugs.webkit.org/show_bug.cgi?id=151555
+
+ Reviewed by Timothy Hatcher.
+
+ * English.lproj/Localizable.strings: add new localized string for alternate inspector title.
+
</ins><span class="cx"> 2015-11-23 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GStreamer] No need to assert the pipeline's bus presence in MediaPlayerPrivateGStreamerBase dtor
</span></span></pre></div>
<a id="trunkSourceWebCoreEnglishlprojLocalizablestrings"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (192744 => 192745)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/English.lproj/Localizable.strings 2015-11-23 13:38:49 UTC (rev 192744)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2015-11-23 17:00:34 UTC (rev 192745)
</span><span class="lines">@@ -685,6 +685,9 @@
</span><span class="cx"> /* Description of WebCrypto master keys in Keychain */
</span><span class="cx"> "Used to encrypt WebCrypto keys in persistent storage, such as IndexedDB" = "Used to encrypt WebCrypto keys in persistent storage, such as IndexedDB";
</span><span class="cx">
</span><ins>+/* Web Inspector window title when inspecting Web Inspector */
+"Web Inspector [%d] — %@" = "Web Inspector [%d] — %@";
+
</ins><span class="cx"> /* Web Inspector window title */
</span><span class="cx"> "Web Inspector — %@" = "Web Inspector — %@";
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (192744 => 192745)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-11-23 13:38:49 UTC (rev 192744)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-11-23 17:00:34 UTC (rev 192745)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-11-23 Brian Burg <bburg@apple.com>
+
+ Web Inspector: when inspecting the inspector, add the inspection level to the title bar
+ https://bugs.webkit.org/show_bug.cgi?id=151555
+
+ Reviewed by Timothy Hatcher.
+
+ Drive-by update to remove some localization strings that are no longer used.
+
+ * Localizations/en.lproj/localizedStrings.js:
+
</ins><span class="cx"> 2015-11-22 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Clean up FolderizedTreeElement folder settings
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (192744 => 192745)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-11-23 13:38:49 UTC (rev 192744)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-11-23 17:00:34 UTC (rev 192745)
</span><span class="lines">@@ -548,9 +548,7 @@
</span><span class="cx"> localizedStrings["Show Source"] = "Show Source";
</span><span class="cx"> localizedStrings["Show compositing borders"] = "Show compositing borders";
</span><span class="cx"> localizedStrings["Show console tab"] = "Show console tab";
</span><del>-localizedStrings["Show only resources with breakpoints."] = "Show only resources with breakpoints.";
</del><span class="cx"> localizedStrings["Show only resources with issues."] = "Show only resources with issues.";
</span><del>-localizedStrings["Show resources with and without breakpoints."] = "Show resources with and without breakpoints.";
</del><span class="cx"> localizedStrings["Show resources with and without issues."] = "Show resources with and without issues.";
</span><span class="cx"> localizedStrings["Show shadow DOM nodes"] = "Show shadow DOM nodes";
</span><span class="cx"> localizedStrings["Show the details sidebar (%s)"] = "Show the details sidebar (%s)";
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (192744 => 192745)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-11-23 13:38:49 UTC (rev 192744)
+++ trunk/Source/WebKit2/ChangeLog 2015-11-23 17:00:34 UTC (rev 192745)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-11-23 Brian Burg <bburg@apple.com>
+
+ Web Inspector: when inspecting the inspector, add the inspection level to the title bar
+ https://bugs.webkit.org/show_bug.cgi?id=151555
+
+ Reviewed by Timothy Hatcher.
+
+ If the inspection level says we are inspecting an inspector, include the level
+ in the title bar to easily disambiguate it from the base level inspector.
+
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::updateInspectorWindowTitle):
+
</ins><span class="cx"> 2015-11-23 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed speculative buildfix after r192701.
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacWebInspectorProxyMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (192744 => 192745)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-11-23 13:38:49 UTC (rev 192744)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2015-11-23 17:00:34 UTC (rev 192745)
</span><span class="lines">@@ -328,8 +328,14 @@
</span><span class="cx"> if (!m_inspectorWindow)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- NSString *title = [NSString stringWithFormat:WEB_UI_STRING("Web Inspector — %@", "Web Inspector window title"), (NSString *)m_urlString];
- [m_inspectorWindow setTitle:title];
</del><ins>+ unsigned inspectionLevel = inspectorLevel();
+ if (inspectionLevel > 1) {
+ NSString *debugTitle = [NSString stringWithFormat:WEB_UI_STRING("Web Inspector [%d] — %@", "Web Inspector window title when inspecting Web Inspector"), inspectionLevel, (NSString *)m_urlString];
+ [m_inspectorWindow setTitle:debugTitle];
+ } else {
+ NSString *title = [NSString stringWithFormat:WEB_UI_STRING("Web Inspector — %@", "Web Inspector window title"), (NSString *)m_urlString];
+ [m_inspectorWindow setTitle:title];
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> WebPageProxy* WebInspectorProxy::platformCreateInspectorPage()
</span></span></pre>
</div>
</div>
</body>
</html>