<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192628] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192628">192628</a></dd>
<dt>Author</dt> <dd>ossy@webkit.org</dd>
<dt>Date</dt> <dd>2015-11-19 09:38:43 -0800 (Thu, 19 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Fix -Winconsistent-missing-override clang warnings
https://bugs.webkit.org/show_bug.cgi?id=151443
Reviewed by Darin Adler.
Source/WebCore:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::delegatedScrollRequested):
(WebCore::EmptyChromeClient::scheduleAnimation):
Source/WebKit2:
* Shared/CoordinatedGraphics/CoordinatedBackingStore.h:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
* UIProcess/CoordinatedGraphics/WebView.h:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
(WebKit::CoordinatedDrawingArea::layerTreeStateIsFrozen):
(WebKit::CoordinatedDrawingArea::layerTreeHost):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(WebKit::CoordinatedLayerTreeHost::layerTreeContext):
(WebKit::CoordinatedLayerTreeHost::pauseRendering):
(WebKit::CoordinatedLayerTreeHost::resumeRendering):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderEmptyClientsh">trunk/Source/WebCore/loader/EmptyClients.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedCoordinatedGraphicsCoordinatedBackingStoreh">trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedBackingStore.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCoordinatedGraphicsCoordinatedLayerTreeHostProxyh">trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCoordinatedGraphicsWebViewh">trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageCoordinatedGraphicsCoordinatedDrawingAreah">trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageCoordinatedGraphicsCoordinatedLayerTreeHosth">trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebCore/ChangeLog 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-11-19 Csaba Osztrogonác <ossy@webkit.org>
+
+ [EFL] Fix -Winconsistent-missing-override clang warnings
+ https://bugs.webkit.org/show_bug.cgi?id=151443
+
+ Reviewed by Darin Adler.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::delegatedScrollRequested):
+ (WebCore::EmptyChromeClient::scheduleAnimation):
+
</ins><span class="cx"> 2015-11-19 Jon Lee <jonlee@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a test for media control dropoff
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderEmptyClientsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/EmptyClients.h (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/EmptyClients.h 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -130,10 +130,10 @@
</span><span class="cx"> virtual void invalidateContentsForSlowScroll(const IntRect&) override { }
</span><span class="cx"> virtual void scroll(const IntSize&, const IntRect&, const IntRect&) override { }
</span><span class="cx"> #if USE(COORDINATED_GRAPHICS)
</span><del>- virtual void delegatedScrollRequested(const IntPoint&) { }
</del><ins>+ virtual void delegatedScrollRequested(const IntPoint&) override { }
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(REQUEST_ANIMATION_FRAME) && !USE(REQUEST_ANIMATION_FRAME_TIMER)
</span><del>- virtual void scheduleAnimation() { }
</del><ins>+ virtual void scheduleAnimation() override { }
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> virtual IntPoint screenToRootView(const IntPoint& p) const override { return p; }
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebKit2/ChangeLog 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-11-19 Csaba Osztrogonác <ossy@webkit.org>
+
+ [EFL] Fix -Winconsistent-missing-override clang warnings
+ https://bugs.webkit.org/show_bug.cgi?id=151443
+
+ Reviewed by Darin Adler.
+
+ * Shared/CoordinatedGraphics/CoordinatedBackingStore.h:
+ * UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
+ * UIProcess/CoordinatedGraphics/WebView.h:
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
+ (WebKit::CoordinatedDrawingArea::layerTreeStateIsFrozen):
+ (WebKit::CoordinatedDrawingArea::layerTreeHost):
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
+ (WebKit::CoordinatedLayerTreeHost::layerTreeContext):
+ (WebKit::CoordinatedLayerTreeHost::pauseRendering):
+ (WebKit::CoordinatedLayerTreeHost::resumeRendering):
+
</ins><span class="cx"> 2015-11-18 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Progress towards implementing Downloads with NETWORK_SESSION
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedCoordinatedGraphicsCoordinatedBackingStoreh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedBackingStore.h (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedBackingStore.h 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedBackingStore.h 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -63,9 +63,9 @@
</span><span class="cx"> void updateTile(uint32_t tileID, const WebCore::IntRect&, const WebCore::IntRect&, PassRefPtr<WebCore::CoordinatedSurface>, const WebCore::IntPoint&);
</span><span class="cx"> static Ref<CoordinatedBackingStore> create() { return adoptRef(*new CoordinatedBackingStore); }
</span><span class="cx"> void commitTileOperations(WebCore::TextureMapper*);
</span><del>- RefPtr<WebCore::BitmapTexture> texture() const;
</del><ins>+ RefPtr<WebCore::BitmapTexture> texture() const override;
</ins><span class="cx"> void setSize(const WebCore::FloatSize&);
</span><del>- virtual void paintToTextureMapper(WebCore::TextureMapper*, const WebCore::FloatRect&, const WebCore::TransformationMatrix&, float);
</del><ins>+ virtual void paintToTextureMapper(WebCore::TextureMapper*, const WebCore::FloatRect&, const WebCore::TransformationMatrix&, float) override;
</ins><span class="cx"> virtual void drawBorder(WebCore::TextureMapper*, const WebCore::Color&, float borderWidth, const WebCore::FloatRect&, const WebCore::TransformationMatrix&) override;
</span><span class="cx"> virtual void drawRepaintCounter(WebCore::TextureMapper*, int repaintCount, const WebCore::Color&, const WebCore::FloatRect&, const WebCore::TransformationMatrix&) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCoordinatedGraphicsCoordinatedLayerTreeHostProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> virtual void renderNextFrame() override;
</span><span class="cx"> virtual void purgeBackingStores() override;
</span><span class="cx">
</span><del>- virtual void commitScrollOffset(uint32_t layerID, const WebCore::IntSize& offset);
</del><ins>+ virtual void commitScrollOffset(uint32_t layerID, const WebCore::IntSize& offset) override;
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> void dispatchUpdate(std::function<void()>);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCoordinatedGraphicsWebViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -106,10 +106,10 @@
</span><span class="cx">
</span><span class="cx"> WebPageProxy* page() { return m_page.get(); }
</span><span class="cx">
</span><del>- void didChangeContentSize(const WebCore::IntSize&);
</del><ins>+ void didChangeContentSize(const WebCore::IntSize&) override;
</ins><span class="cx"> const WebCore::IntSize& contentsSize() const { return m_contentsSize; }
</span><span class="cx"> WebCore::FloatSize visibleContentsSize() const;
</span><del>- void didFindZoomableArea(const WebCore::IntPoint&, const WebCore::IntRect&);
</del><ins>+ void didFindZoomableArea(const WebCore::IntPoint&, const WebCore::IntRect&) override;
</ins><span class="cx">
</span><span class="cx"> // FIXME: Should become private when Web Events creation is moved to WebView.
</span><span class="cx"> WebCore::AffineTransform transformFromScene() const;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageCoordinatedGraphicsCoordinatedDrawingAreah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -47,15 +47,15 @@
</span><span class="cx"> // DrawingArea
</span><span class="cx"> virtual void setNeedsDisplay() override;
</span><span class="cx"> virtual void setNeedsDisplayInRect(const WebCore::IntRect&) override;
</span><del>- virtual void scroll(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollDelta);
</del><ins>+ virtual void scroll(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollDelta) override;
</ins><span class="cx"> virtual void pageBackgroundTransparencyChanged() override;
</span><del>- virtual void setLayerTreeStateIsFrozen(bool);
- virtual bool layerTreeStateIsFrozen() const { return m_layerTreeStateIsFrozen; }
- virtual LayerTreeHost* layerTreeHost() const { return m_layerTreeHost.get(); }
- virtual void forceRepaint();
- virtual bool forceRepaintAsync(uint64_t callbackID);
</del><ins>+ virtual void setLayerTreeStateIsFrozen(bool) override;
+ virtual bool layerTreeStateIsFrozen() const override { return m_layerTreeStateIsFrozen; }
+ virtual LayerTreeHost* layerTreeHost() const override { return m_layerTreeHost.get(); }
+ virtual void forceRepaint() override;
+ virtual bool forceRepaintAsync(uint64_t callbackID) override;
</ins><span class="cx">
</span><del>- virtual void setPaintingEnabled(bool);
</del><ins>+ virtual void setPaintingEnabled(bool) override;
</ins><span class="cx"> virtual void updatePreferences(const WebPreferencesStore&) override;
</span><span class="cx"> virtual void mainFrameContentSizeChanged(const WebCore::IntSize&) override;
</span><span class="cx">
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx"> virtual void scheduleCompositingLayerFlushImmediately() override;
</span><span class="cx">
</span><span class="cx"> #if USE(COORDINATED_GRAPHICS_MULTIPROCESS)
</span><del>- virtual void didReceiveCoordinatedLayerTreeHostMessage(IPC::Connection&, IPC::MessageDecoder&);
</del><ins>+ virtual void didReceiveCoordinatedLayerTreeHostMessage(IPC::Connection&, IPC::MessageDecoder&) override;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK)
</span><span class="lines">@@ -76,8 +76,8 @@
</span><span class="cx"> virtual void attachViewOverlayGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*) override;
</span><span class="cx">
</span><span class="cx"> // IPC message handlers.
</span><del>- virtual void updateBackingStoreState(uint64_t backingStoreStateID, bool respondImmediately, float deviceScaleFactor, const WebCore::IntSize&, const WebCore::IntSize& scrollOffset);
- virtual void didUpdate();
</del><ins>+ virtual void updateBackingStoreState(uint64_t backingStoreStateID, bool respondImmediately, float deviceScaleFactor, const WebCore::IntSize&, const WebCore::IntSize& scrollOffset) override;
+ virtual void didUpdate() override;
</ins><span class="cx"> virtual void suspendPainting();
</span><span class="cx"> virtual void resumePainting();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageCoordinatedGraphicsCoordinatedLayerTreeHosth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h (192627 => 192628)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h 2015-11-19 15:50:01 UTC (rev 192627)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h 2015-11-19 17:38:43 UTC (rev 192628)
</span><span class="lines">@@ -43,26 +43,26 @@
</span><span class="cx"> static Ref<CoordinatedLayerTreeHost> create(WebPage*);
</span><span class="cx"> virtual ~CoordinatedLayerTreeHost();
</span><span class="cx">
</span><del>- virtual const LayerTreeContext& layerTreeContext() { return m_layerTreeContext; }
- virtual void setLayerFlushSchedulingEnabled(bool);
- virtual void scheduleLayerFlush();
- virtual void setShouldNotifyAfterNextScheduledLayerFlush(bool);
- virtual void setRootCompositingLayer(WebCore::GraphicsLayer*);
- virtual void invalidate();
</del><ins>+ virtual const LayerTreeContext& layerTreeContext() override { return m_layerTreeContext; }
+ virtual void setLayerFlushSchedulingEnabled(bool) override;
+ virtual void scheduleLayerFlush() override;
+ virtual void setShouldNotifyAfterNextScheduledLayerFlush(bool) override;
+ virtual void setRootCompositingLayer(WebCore::GraphicsLayer*) override;
+ virtual void invalidate() override;
</ins><span class="cx">
</span><span class="cx"> virtual void setNonCompositedContentsNeedDisplay() override { }
</span><span class="cx"> virtual void setNonCompositedContentsNeedDisplayInRect(const WebCore::IntRect&) override { }
</span><span class="cx"> virtual void scrollNonCompositedContents(const WebCore::IntRect&) override { }
</span><del>- virtual void forceRepaint();
- virtual bool forceRepaintAsync(uint64_t callbackID);
- virtual void sizeDidChange(const WebCore::IntSize& newSize);
</del><ins>+ virtual void forceRepaint() override;
+ virtual bool forceRepaintAsync(uint64_t callbackID) override;
+ virtual void sizeDidChange(const WebCore::IntSize& newSize) override;
</ins><span class="cx">
</span><del>- virtual void pauseRendering() { m_isSuspended = true; }
- virtual void resumeRendering() { m_isSuspended = false; scheduleLayerFlush(); }
</del><ins>+ virtual void pauseRendering() override { m_isSuspended = true; }
+ virtual void resumeRendering() override { m_isSuspended = false; scheduleLayerFlush(); }
</ins><span class="cx"> virtual void deviceOrPageScaleFactorChanged() override;
</span><span class="cx"> virtual void pageBackgroundTransparencyChanged() override;
</span><span class="cx">
</span><del>- virtual void didReceiveCoordinatedLayerTreeHostMessage(IPC::Connection&, IPC::MessageDecoder&);
</del><ins>+ virtual void didReceiveCoordinatedLayerTreeHostMessage(IPC::Connection&, IPC::MessageDecoder&) override;
</ins><span class="cx"> virtual WebCore::GraphicsLayerFactory* graphicsLayerFactory() override;
</span><span class="cx"> WebCore::CoordinatedGraphicsLayer* mainContentsLayer();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>