<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192550] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192550">192550</a></dd>
<dt>Author</dt> <dd>said@apple.com</dd>
<dt>Date</dt> <dd>2015-11-17 16:16:56 -0800 (Tue, 17 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Disable flattening the stage iframe of the graphics benchmark when running on iOS
https://bugs.webkit.org/show_bug.cgi?id=151361
Reviewed by Simon Fraser.
Use fixed size for stage iframe of the graphics benchmark to disable
flattening the iframe while animating the particles. Also ensure the
bouncing particles do not go outside the iframe's boundaries.
* Animometer/runner/resources/animometer.css:
(section#running > #running-test > iframe):
(@media screen and (min-device-width: 1800px)):
* Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(BouncingParticle.prototype.animate):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsAnimometerrunnerresourcesanimometercss">trunk/PerformanceTests/Animometer/runner/resources/animometer.css</a></li>
<li><a href="#trunkPerformanceTestsAnimometertestsbouncingparticlesresourcesbouncingparticlesjs">trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsAnimometerrunnerresourcesanimometercss"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.css (192549 => 192550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/runner/resources/animometer.css 2015-11-18 00:08:38 UTC (rev 192549)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.css 2015-11-18 00:16:56 UTC (rev 192550)
</span><span class="lines">@@ -328,9 +328,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> section#running > #running-test > iframe {
</span><del>- width: 100%;
- height: 100%;
</del><ins>+ width: 800px;
+ height: 600px;
</ins><span class="cx"> border: 0px none;
</span><ins>+ overflow: hidden;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> section#running > #progress {
</span><span class="lines">@@ -361,6 +362,13 @@
</span><span class="cx"> padding: 16px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+@media screen and (min-device-width: 1800px) {
+ section#running > #running-test > iframe {
+ width: 1600px;
+ height: 800px;
+ }
+}
+
</ins><span class="cx"> /* -------------------------------------------------------------------------- */
</span><span class="cx"> /* Results Section */
</span><span class="cx"> /* -------------------------------------------------------------------------- */
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometertestsbouncingparticlesresourcesbouncingparticlesjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js (192549 => 192550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js 2015-11-18 00:08:38 UTC (rev 192549)
+++ trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js 2015-11-18 00:16:56 UTC (rev 192550)
</span><span class="lines">@@ -23,36 +23,44 @@
</span><span class="cx">
</span><span class="cx"> // If particle is going to move off right side
</span><span class="cx"> if (this._position.x + this._size.x > this._stageSize.x) {
</span><del>- // If direction is East-South
</del><ins>+ // If direction is East-South, go West-South.
</ins><span class="cx"> if (this._angle >= 0 && this._angle < Math.PI / 2)
</span><span class="cx"> this._angle = Math.PI - this._angle;
</span><del>- // If angle is East-North
</del><ins>+ // If angle is East-North, go West-North.
</ins><span class="cx"> else if (this._angle > Math.PI / 2 * 3)
</span><span class="cx"> this._angle = this._angle - (this._angle - Math.PI / 2 * 3) * 2;
</span><ins>+ // Make sure the particle does not go outside the stage boundaries.
+ this._position.x = this._stageSize.x - this._size.x;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // If particle is going to move off left side
</span><span class="cx"> if (this._position.x < 0) {
</span><del>- // If angle is West-South
</del><ins>+ // If angle is West-South, go East-South.
</ins><span class="cx"> if (this._angle > Math.PI / 2 && this._angle < Math.PI)
</span><span class="cx"> this._angle = Math.PI - this._angle;
</span><del>- // If angle is West-North
</del><ins>+ // If angle is West-North, go East-North.
</ins><span class="cx"> else if (this._angle > Math.PI && this._angle < Math.PI / 2 * 3)
</span><span class="cx"> this._angle = this._angle + (Math.PI / 2 * 3 - this._angle) * 2;
</span><ins>+ // Make sure the particle does not go outside the stage boundaries.
+ this._position.x = 0;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // If particle is going to move off bottom side
</span><span class="cx"> if (this._position.y + this._size.y > this._stageSize.y) {
</span><del>- // If direction is South
</del><ins>+ // If direction is South, go North.
</ins><span class="cx"> if (this._angle > 0 && this._angle < Math.PI)
</span><span class="cx"> this._angle = Math.PI * 2 - this._angle;
</span><ins>+ // Make sure the particle does not go outside the stage boundaries.
+ this._position.y = this._stageSize.y - this._size.y;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // If particle is going to move off top side
</span><span class="cx"> if (this._position.y < 0) {
</span><del>- // If direction is North
</del><ins>+ // If direction is North, go South.
</ins><span class="cx"> if (this._angle > Math.PI && this._angle < Math.PI * 2)
</span><span class="cx"> this._angle = this._angle - (this._angle - Math.PI) * 2;
</span><ins>+ // Make sure the particle does not go outside the stage boundaries.
+ this._position.y = 0;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (192549 => 192550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2015-11-18 00:08:38 UTC (rev 192549)
+++ trunk/PerformanceTests/ChangeLog 2015-11-18 00:16:56 UTC (rev 192550)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2015-11-17 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><ins>+ Disable flattening the stage iframe of the graphics benchmark when running on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=151361
+
+ Reviewed by Simon Fraser.
+
+ Use fixed size for stage iframe of the graphics benchmark to disable
+ flattening the iframe while animating the particles. Also ensure the
+ bouncing particles do not go outside the iframe's boundaries.
+
+ * Animometer/runner/resources/animometer.css:
+ (section#running > #running-test > iframe):
+ (@media screen and (min-device-width: 1800px)):
+ * Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
+ (BouncingParticle.prototype.animate):
+
+2015-11-17 Said Abou-Hallawa <sabouhallawa@apple.com>
+
</ins><span class="cx"> Use the media queries to dynamically set the stage for the graphics benchmark
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=151327
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>