<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[192505] trunk/PerformanceTests</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192505">192505</a></dd>

<dt>Author</dt> <dd>commit-queue@webkit.org</dd>

<dt>Date</dt> <dd>2015-11-16 19:29:43 -0800 (Mon, 16 Nov 2015)</dd>

</dl>

<h3>Log Message</h3>

<pre>Remove the option for animating using setInterval from the graphics benchmark

https://bugs.webkit.org/show_bug.cgi?id=151283

Patch by Said Abou-Hallawa &lt;sabouhallawa@apple.com&gt; on 2015-11-16

Reviewed by Darin Adler.

Get rid of the option to run animation using setInterval().

* Animometer/tests/resources/main.js:

(Animator.prototype.animate):

(Benchmark):

(Benchmark.prototype.start):

(Animator.prototype.start): Deleted.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkPerformanceTestsAnimometertestsresourcesmainjs">trunk/PerformanceTests/Animometer/tests/resources/main.js</a></li>

<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkPerformanceTestsAnimometertestsresourcesmainjs"></a>

<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/resources/main.js (192504 => 192505)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/PerformanceTests/Animometer/tests/resources/main.js        2015-11-17 03:27:43 UTC (rev 192504)

+++ trunk/PerformanceTests/Animometer/tests/resources/main.js        2015-11-17 03:29:43 UTC (rev 192505)

</span><span class="lines">@@ -74,11 +74,6 @@

</span><span class="cx"> 

</span><span class="cx"> Animator.prototype =

</span><span class="cx"> {

</span><del>-    start: function()

-    {

-        this._intervalId = setInterval(this.animate.bind(this), 1);

-    },

-    

</del><span class="cx">     timeDelta: function()

</span><span class="cx">     {

</span><span class="cx">         return this._currentTimeOffset - this._startTimeOffset;

</span><span class="lines">@@ -117,14 +112,10 @@

<span class="cx">         // Adjust the test to reach the desired FPS.

</span><span class="cx">         var result = this._benchmark.update(this._currentTimeOffset, this.timeDelta(), currentFrameRate);

</span><span class="cx">         

<del>-        // Stop the animator if the benchmark has finished.

-        if (!result &amp;&amp; typeof this._intervalId != &quot;undefined&quot;)

-            clearInterval(this._intervalId);

-

</del><span class="cx">         // Start the next drop/measure cycle.

</span><span class="cx">         this._frameCount = 0;

</span><span class="cx">         

<del>-        // result may stop the animator if requestAnimationFrame() has been used.

</del><ins>+        // If result == 0, no more requestAnimationFrame() will be invoked.

</ins><span class="cx">         return result;

</span><span class="cx">     },

</span><span class="cx">     

</span><span class="lines">@@ -138,8 +129,6 @@

</span><span class="cx"> function Benchmark(options)

</span><span class="cx"> {

</span><span class="cx">     this._options = options;

</span><del>-    this._method = this._options[&quot;method&quot;] || &quot;requestAnimationFrame&quot;;

-

</del><span class="cx">     this._recordInterval = 200;    

</span><span class="cx">     this._isSampling = false;

</span><span class="cx"> 

</span><span class="lines">@@ -147,7 +136,7 @@

</span><span class="cx">     var lowValue = -parseInt(this._options[&quot;addLimit&quot;]) || 1;

</span><span class="cx">     var highValue = parseInt(this._options[&quot;removeLimit&quot;]) || 1;

</span><span class="cx">     

</span><del>-    this._controller = new PIDController(gain, options[&quot;frame-rate&quot;], lowValue, highValue);

</del><ins>+    this._controller = new PIDController(gain, this._options[&quot;frame-rate&quot;], lowValue, highValue);

</ins><span class="cx">     this._sampler = new Sampler(2);

</span><span class="cx">     this._state = new BenchmarkState(this._options[&quot;test-interval&quot;] * 1000);

</span><span class="cx"> }

</span><span class="lines">@@ -157,10 +146,7 @@

<span class="cx">     // Called from the load event listener or from this.run().

</span><span class="cx">     start: function()

</span><span class="cx">     {

</span><del>-        if (this._method == &quot;setInterval&quot;)

-            this._animator.start();

-        else

-            this._animator.animateLoop();

</del><ins>+        this._animator.animateLoop();

</ins><span class="cx">     },

</span><span class="cx">     

<span class="cx">     // Called from the animator to adjust the complexity of the test.

</span></span></pre></div>

<a id="trunkPerformanceTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (192504 => 192505)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/PerformanceTests/ChangeLog        2015-11-17 03:27:43 UTC (rev 192504)

+++ trunk/PerformanceTests/ChangeLog        2015-11-17 03:29:43 UTC (rev 192505)

</span><span class="lines">@@ -1,5 +1,20 @@

</span><span class="cx"> 2015-11-16  Said Abou-Hallawa  &lt;sabouhallawa@apple.com&gt;

</span><span class="cx"> 

</span><ins>+        Remove the option for animating using setInterval from the graphics benchmark

+        https://bugs.webkit.org/show_bug.cgi?id=151283

+

+        Reviewed by Darin Adler.

+        

+        Get rid of the option to run animation using setInterval().

+

+        * Animometer/tests/resources/main.js:

+        (Animator.prototype.animate):

+        (Benchmark):

+        (Benchmark.prototype.start):

+        (Animator.prototype.start): Deleted.

+

+2015-11-16  Said Abou-Hallawa  &lt;sabouhallawa@apple.com&gt;

+

</ins><span class="cx">         Highlight the alarming test results in the graphics benchmark results page

</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=151286

</span><span class="cx"> 

</span></span></pre>

</div>

</div>

</body>

</html>