<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192416] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192416">192416</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2015-11-13 07:59:27 -0800 (Fri, 13 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[JSC] JSPropertyNameEnumerator could be destructorless.
<https://webkit.org/b/151242>
Reviewed by Mark Lam.
Make JSPropertyNameEnumerator destructorless and have it store the property names
cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.
* heap/CopyToken.h:
* runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):
(JSC::JSPropertyNameEnumerator::destroy): Deleted.
* runtime/JSPropertyNameEnumerator.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreheapCopyTokenh">trunk/Source/JavaScriptCore/heap/CopyToken.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSPropertyNameEnumeratorcpp">trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSPropertyNameEnumeratorh">trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (192415 => 192416)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-11-13 12:50:42 UTC (rev 192415)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-11-13 15:59:27 UTC (rev 192416)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-11-13 Andreas Kling <akling@apple.com>
+
+ [JSC] JSPropertyNameEnumerator could be destructorless.
+ <https://webkit.org/b/151242>
+
+ Reviewed by Mark Lam.
+
+ Make JSPropertyNameEnumerator destructorless and have it store the property names
+ cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
+ in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.
+
+ * heap/CopyToken.h:
+ * runtime/JSPropertyNameEnumerator.cpp:
+ (JSC::JSPropertyNameEnumerator::finishCreation):
+ (JSC::JSPropertyNameEnumerator::visitChildren):
+ (JSC::JSPropertyNameEnumerator::copyBackingStore):
+ (JSC::JSPropertyNameEnumerator::destroy): Deleted.
+ * runtime/JSPropertyNameEnumerator.h:
+
</ins><span class="cx"> 2015-11-12 Benjamin Poulain <bpoulain@apple.com>
</span><span class="cx">
</span><span class="cx"> [JSC] Do not generate an Add when adding a zero immediate to something
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreheapCopyTokenh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/heap/CopyToken.h (192415 => 192416)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/heap/CopyToken.h 2015-11-13 12:50:42 UTC (rev 192415)
+++ trunk/Source/JavaScriptCore/heap/CopyToken.h 2015-11-13 15:59:27 UTC (rev 192416)
</span><span class="lines">@@ -32,7 +32,8 @@
</span><span class="cx"> ButterflyCopyToken,
</span><span class="cx"> TypedArrayVectorCopyToken,
</span><span class="cx"> MapBackingStoreCopyToken,
</span><del>- DirectArgumentsOverridesCopyToken
</del><ins>+ DirectArgumentsOverridesCopyToken,
+ JSPropertyNameEnumeratorCopyToken,
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace JSC
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSPropertyNameEnumeratorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp (192415 => 192416)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp 2015-11-13 12:50:42 UTC (rev 192415)
+++ trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp 2015-11-13 15:59:27 UTC (rev 192416)
</span><span class="lines">@@ -26,6 +26,8 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSPropertyNameEnumerator.h"
</span><span class="cx">
</span><ins>+#include "CopiedBlockInlines.h"
+#include "CopyVisitorInlines.h"
</ins><span class="cx"> #include "JSCInlines.h"
</span><span class="cx"> #include "StrongInlines.h"
</span><span class="cx">
</span><span class="lines">@@ -70,25 +72,45 @@
</span><span class="cx"> m_endStructurePropertyIndex = endStructurePropertyIndex;
</span><span class="cx"> m_endGenericPropertyIndex = vector.size();
</span><span class="cx">
</span><del>- m_propertyNames.resizeToFit(vector.size());
- for (unsigned i = 0; i < vector.size(); ++i) {
- const Identifier& identifier = vector[i];
- m_propertyNames[i].set(vm, this, jsString(&vm, identifier.string()));
</del><ins>+ if (!vector.isEmpty()) {
+ void* backingStore;
+ RELEASE_ASSERT(vm.heap.tryAllocateStorage(this, vector.size() * sizeof(WriteBarrier<JSString>), &backingStore));
+ WriteBarrier<JSString>* propertyNames = reinterpret_cast<WriteBarrier<JSString>*>(backingStore);
+ m_propertyNames.set(vm, this, propertyNames);
+
+ for (unsigned i = 0; i < vector.size(); ++i)
+ propertyNames[i].set(vm, this, jsString(&vm, vector[i].string()));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void JSPropertyNameEnumerator::destroy(JSCell* cell)
-{
- jsCast<JSPropertyNameEnumerator*>(cell)->JSPropertyNameEnumerator::~JSPropertyNameEnumerator();
-}
-
</del><span class="cx"> void JSPropertyNameEnumerator::visitChildren(JSCell* cell, SlotVisitor& visitor)
</span><span class="cx"> {
</span><span class="cx"> Base::visitChildren(cell, visitor);
</span><span class="cx"> JSPropertyNameEnumerator* thisObject = jsCast<JSPropertyNameEnumerator*>(cell);
</span><del>- for (unsigned i = 0; i < thisObject->m_propertyNames.size(); ++i)
- visitor.append(&thisObject->m_propertyNames[i]);
</del><span class="cx"> visitor.append(&thisObject->m_prototypeChain);
</span><ins>+
+ if (thisObject->cachedPropertyNameCount()) {
+ visitor.appendValues(reinterpret_cast<WriteBarrier<Unknown>*>(thisObject->m_propertyNames.getWithoutBarrier()), thisObject->cachedPropertyNameCount());
+ visitor.copyLater(
+ thisObject, JSPropertyNameEnumeratorCopyToken,
+ thisObject->m_propertyNames.getWithoutBarrier(), thisObject->cachedPropertyNameCount() * sizeof(JSString*));
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+void JSPropertyNameEnumerator::copyBackingStore(JSCell* cell, CopyVisitor& visitor, CopyToken token)
+{
+ JSPropertyNameEnumerator* thisObject = jsCast<JSPropertyNameEnumerator*>(cell);
+ ASSERT_GC_OBJECT_INHERITS(thisObject, info());
+
+ RELEASE_ASSERT(token == JSPropertyNameEnumeratorCopyToken);
+
+ void* oldPropertyNames = thisObject->m_propertyNames.getWithoutBarrier();
+ if (visitor.checkIfShouldCopy(oldPropertyNames)) {
+ WriteBarrier<JSString>* newPropertyNames = static_cast<WriteBarrier<JSString>*>(visitor.allocateNewSpace(thisObject->cachedPropertyNameCount() * sizeof(WriteBarrier<JSString>)));
+ memcpy(newPropertyNames, oldPropertyNames, thisObject->cachedPropertyNameCount() * sizeof(JSString*));
+ thisObject->m_propertyNames.setWithoutBarrier(newPropertyNames);
+ visitor.didCopy(oldPropertyNames, thisObject->cachedPropertyNameCount() * sizeof(JSString*));
+ }
+}
+
</ins><span class="cx"> } // namespace JSC
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSPropertyNameEnumeratorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.h (192415 => 192416)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.h 2015-11-13 12:50:42 UTC (rev 192415)
+++ trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.h 2015-11-13 15:59:27 UTC (rev 192416)
</span><span class="lines">@@ -43,9 +43,6 @@
</span><span class="cx"> static JSPropertyNameEnumerator* create(VM&);
</span><span class="cx"> static JSPropertyNameEnumerator* create(VM&, Structure*, uint32_t, uint32_t, PropertyNameArray&);
</span><span class="cx">
</span><del>- static const bool needsDestruction = true;
- static void destroy(JSCell*);
-
</del><span class="cx"> static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
</span><span class="cx"> {
</span><span class="cx"> return Structure::create(vm, globalObject, prototype, TypeInfo(CellType, StructureFlags), info());
</span><span class="lines">@@ -55,9 +52,9 @@
</span><span class="cx">
</span><span class="cx"> JSString* propertyNameAtIndex(uint32_t index) const
</span><span class="cx"> {
</span><del>- if (index >= m_propertyNames.size())
</del><ins>+ if (index >= cachedPropertyNameCount())
</ins><span class="cx"> return nullptr;
</span><del>- return m_propertyNames[index].get();
</del><ins>+ return m_propertyNames.get(this)[index].get();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> StructureChain* cachedPrototypeChain() const { return m_prototypeChain.get(); }
</span><span class="lines">@@ -81,18 +78,25 @@
</span><span class="cx"> static ptrdiff_t cachedInlineCapacityOffset() { return OBJECT_OFFSETOF(JSPropertyNameEnumerator, m_cachedInlineCapacity); }
</span><span class="cx"> static ptrdiff_t cachedPropertyNamesVectorOffset()
</span><span class="cx"> {
</span><del>- return OBJECT_OFFSETOF(JSPropertyNameEnumerator, m_propertyNames) + Vector<WriteBarrier<JSString>>::dataMemoryOffset();
</del><ins>+ return OBJECT_OFFSETOF(JSPropertyNameEnumerator, m_propertyNames);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void visitChildren(JSCell*, SlotVisitor&);
</span><ins>+ static void copyBackingStore(JSCell*, CopyVisitor&, CopyToken);
</ins><span class="cx">
</span><ins>+ uint32_t cachedPropertyNameCount() const
+ {
+ // Note that this depends on m_endGenericPropertyIndex being the number of entries in m_propertyNames.
+ return m_endGenericPropertyIndex;
+ }
+
</ins><span class="cx"> private:
</span><span class="cx"> JSPropertyNameEnumerator(VM&, StructureID, uint32_t);
</span><span class="cx"> void finishCreation(VM&, uint32_t, uint32_t, PassRefPtr<PropertyNameArrayData>);
</span><span class="cx">
</span><del>- Vector<WriteBarrier<JSString>> m_propertyNames;
</del><ins>+ CopyBarrier<WriteBarrier<JSString>> m_propertyNames;
+ WriteBarrier<StructureChain> m_prototypeChain;
</ins><span class="cx"> StructureID m_cachedStructureID;
</span><del>- WriteBarrier<StructureChain> m_prototypeChain;
</del><span class="cx"> uint32_t m_indexedLength;
</span><span class="cx"> uint32_t m_endStructurePropertyIndex;
</span><span class="cx"> uint32_t m_endGenericPropertyIndex;
</span></span></pre>
</div>
</div>
</body>
</html>