<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192192] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192192">192192</a></dd>
<dt>Author</dt> <dd>ryanhaddad@apple.com</dd>
<dt>Date</dt> <dd>2015-11-09 16:55:28 -0800 (Mon, 09 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/192181">r192181</a>.
This change causes asserts on mac-wk1 debug testers
Reverted changeset:
"Fixed crash loading Mozilla layout test
editor/libeditor/crashtests/431086-1.xhtml."
https://bugs.webkit.org/show_bug.cgi?id=150252
http://trac.webkit.org/changeset/192181</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreeditingiosEditorIOSmm">trunk/Source/WebCore/editing/ios/EditorIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreeditingmacEditorMacmm">trunk/Source/WebCore/editing/mac/EditorMac.mm</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingexecCommand150252expectedtxt">trunk/LayoutTests/editing/execCommand/150252-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingexecCommand150252xhtml">trunk/LayoutTests/editing/execCommand/150252.xhtml</a></li>
<li><a href="#trunkLayoutTestseditingexecCommand150252_minimalexpectedtxt">trunk/LayoutTests/editing/execCommand/150252_minimal-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingexecCommand150252_minimalxhtml">trunk/LayoutTests/editing/execCommand/150252_minimal.xhtml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/LayoutTests/ChangeLog        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-11-09 Ryan Haddad <ryanhaddad@apple.com>
+
+ Unreviewed, rolling out r192181.
+
+ This change causes asserts on mac-wk1 debug testers
+
+ Reverted changeset:
+
+ "Fixed crash loading Mozilla layout test
+ editor/libeditor/crashtests/431086-1.xhtml."
+ https://bugs.webkit.org/show_bug.cgi?id=150252
+ http://trac.webkit.org/changeset/192181
+
</ins><span class="cx"> 2015-11-09 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash when right clicking in input box with -webkit-user-select: none
</span></span></pre></div>
<a id="trunkLayoutTestseditingexecCommand150252expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/editing/execCommand/150252-expected.txt (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/execCommand/150252-expected.txt        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/LayoutTests/editing/execCommand/150252-expected.txt        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -1 +0,0 @@
</span><del>-This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252
</del></span></pre></div>
<a id="trunkLayoutTestseditingexecCommand150252xhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/editing/execCommand/150252.xhtml (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/execCommand/150252.xhtml        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/LayoutTests/editing/execCommand/150252.xhtml        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -1,26 +0,0 @@
</span><del>-<div id="150252" xmlns="http://www.w3.org/1999/xhtml">
-
-<script type="text/javascript">
-
-function boom()
-{
- if (window.testRunner)
- testRunner.dumpAsText();
-
- var r = document.documentElement;
- r.style.position = "absolute";
- r.contentEditable = "true";
- r.focus();
- r.contentEditable = "false";
- r.focus();
- r.contentEditable = "true";
- document.execCommand("subscript", false, null);
- r.contentEditable = "false";
- document.getElementById("150252").innerHTML = "This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252";
-}
-
-window.addEventListener("load", boom, false);
-
-</script>
-
-</div>
</del></span></pre></div>
<a id="trunkLayoutTestseditingexecCommand150252_minimalexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/editing/execCommand/150252_minimal-expected.txt (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/execCommand/150252_minimal-expected.txt        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/LayoutTests/editing/execCommand/150252_minimal-expected.txt        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -1 +0,0 @@
</span><del>-This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252
</del></span></pre></div>
<a id="trunkLayoutTestseditingexecCommand150252_minimalxhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/editing/execCommand/150252_minimal.xhtml (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/execCommand/150252_minimal.xhtml        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/LayoutTests/editing/execCommand/150252_minimal.xhtml        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -1,15 +0,0 @@
</span><del>-<div id="150252" xmlns="http://www.w3.org/1999/xhtml">
-
-<script>
-
-if (window.testRunner)
- testRunner.dumpAsText();
-
-document.documentElement.contentEditable = "true";
-document.documentElement.focus();
-document.execCommand("superscript", false, null);
-document.getElementById("150252").innerHTML = "This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252";
-
-</script>
-
-</div>
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/Source/WebCore/ChangeLog        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-11-09 Ryan Haddad <ryanhaddad@apple.com>
+
+ Unreviewed, rolling out r192181.
+
+ This change causes asserts on mac-wk1 debug testers
+
+ Reverted changeset:
+
+ "Fixed crash loading Mozilla layout test
+ editor/libeditor/crashtests/431086-1.xhtml."
+ https://bugs.webkit.org/show_bug.cgi?id=150252
+ http://trac.webkit.org/changeset/192181
+
</ins><span class="cx"> 2015-11-09 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash when right clicking in input box with -webkit-user-select: none
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingiosEditorIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ios/EditorIOS.mm        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -192,13 +192,13 @@
</span><span class="cx"> RenderStyle* style = styleForSelectionStart(&m_frame, nodeToRemove); // sets nodeToRemove
</span><span class="cx">
</span><span class="cx"> const Font* result = nullptr;
</span><del>- if (style) {
</del><ins>+ if (style)
</ins><span class="cx"> result = &style->fontCascade().primaryFont();
</span><del>- if (nodeToRemove) {
- ExceptionCode ec;
- nodeToRemove->remove(ec);
- ASSERT(!ec);
- }
</del><ins>+
+ if (nodeToRemove) {
+ ExceptionCode ec;
+ nodeToRemove->remove(ec);
+ ASSERT(!ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return result;
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmacEditorMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/mac/EditorMac.mm (192191 => 192192)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/mac/EditorMac.mm        2015-11-10 00:44:17 UTC (rev 192191)
+++ trunk/Source/WebCore/editing/mac/EditorMac.mm        2015-11-10 00:55:28 UTC (rev 192192)
</span><span class="lines">@@ -118,12 +118,12 @@
</span><span class="cx"> RenderStyle* style = styleForSelectionStart(&m_frame, nodeToRemove); // sets nodeToRemove
</span><span class="cx">
</span><span class="cx"> const Font* result = nullptr;
</span><del>- if (style) {
</del><ins>+ if (style)
</ins><span class="cx"> result = &style->fontCascade().primaryFont();
</span><del>- if (nodeToRemove)
- nodeToRemove->remove(ASSERT_NO_EXCEPTION);
- }
</del><span class="cx">
</span><ins>+ if (nodeToRemove)
+ nodeToRemove->remove(ASSERT_NO_EXCEPTION);
+
</ins><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>