<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[192132] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/192132">192132</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-11-07 15:48:08 -0800 (Sat, 07 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>embed element without src and type attributes should represent nothing
https://bugs.webkit.org/show_bug.cgi?id=148853
<rdar://problem/22588235>
Reviewed by Zalan Bujtas.
LayoutTests/imported/w3c:
Rebaseline existing tests.
* web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:
* web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt:
Source/WebCore:
As per the HTML specification, an embed element without src and type
attributes should represent nothing:
https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element
This patch fixes the issue by making sure we don't construct a
renderer for such embed elements.
The new behavior is consistent with Firefox but differs from Chrome.
No new tests, already covered by existing tests.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
LayoutTests:
* TestExpectations:
Unskip 2 ref-tests that were previously failing.
* accessibility/inline-block-assertion-expected.txt:
* editing/execCommand/crash-140261-expected.txt:
* fast/block/float/4145535Crash-expected.txt:
* fast/dom/HTMLDocument/document-plugins-expected.txt:
* fast/dom/insertedIntoDocument-child-expected.txt:
* fast/dom/insertedIntoDocument-sibling-expected.txt:
* fast/dom/plugin-attributes-enumeration-expected.txt:
* fast/replaced/percent-height-in-anonymous-block-widget.html:
* fast/replaced/replaced-breaking.html:
* fast/replaced/table-percent-height.html:
* fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt:
* imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt:
Rebaseline / update existing tests.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsaccessibilityinlineblockassertionexpectedtxt">trunk/LayoutTests/accessibility/inline-block-assertion-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingexecCommandcrash140261expectedtxt">trunk/LayoutTests/editing/execCommand/crash-140261-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastblockfloat4145535Crashexpectedtxt">trunk/LayoutTests/fast/block/float/4145535Crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLDocumentdocumentpluginsexpectedtxt">trunk/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdominsertedIntoDocumentchildexpectedtxt">trunk/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdominsertedIntoDocumentsiblingexpectedtxt">trunk/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdompluginattributesenumerationexpectedtxt">trunk/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastreplacedpercentheightinanonymousblockwidgethtml">trunk/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html</a></li>
<li><a href="#trunkLayoutTestsfastreplacedreplacedbreakinghtml">trunk/LayoutTests/fast/replaced/replaced-breaking.html</a></li>
<li><a href="#trunkLayoutTestsfastreplacedtablepercentheighthtml">trunk/LayoutTests/fast/replaced/table-percent-height.html</a></li>
<li><a href="#trunkLayoutTestsfasttextinternationalembedbidistyleinisolatecrashexpectedtxt">trunk/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedblinkfastcssgridlayoutgridaddpositionedblockitemafterinlineitemexpectedtxt">trunk/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomdocumentsdomtreeaccessorsdocumentgetElementsByNamedocumentgetElementsByNamenewelementsexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomdocumentsdomtreeaccessorsnameditem05expectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLEmbedElementcpp">trunk/Source/WebCore/html/HTMLEmbedElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/ChangeLog 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2015-11-07 Chris Dumez <cdumez@apple.com>
+
+ embed element without src and type attributes should represent nothing
+ https://bugs.webkit.org/show_bug.cgi?id=148853
+ <rdar://problem/22588235>
+
+ Reviewed by Zalan Bujtas.
+
+ * TestExpectations:
+ Unskip 2 ref-tests that were previously failing.
+
+ * accessibility/inline-block-assertion-expected.txt:
+ * editing/execCommand/crash-140261-expected.txt:
+ * fast/block/float/4145535Crash-expected.txt:
+ * fast/dom/HTMLDocument/document-plugins-expected.txt:
+ * fast/dom/insertedIntoDocument-child-expected.txt:
+ * fast/dom/insertedIntoDocument-sibling-expected.txt:
+ * fast/dom/plugin-attributes-enumeration-expected.txt:
+ * fast/replaced/percent-height-in-anonymous-block-widget.html:
+ * fast/replaced/replaced-breaking.html:
+ * fast/replaced/table-percent-height.html:
+ * fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt:
+ * imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt:
+ Rebaseline / update existing tests.
+
</ins><span class="cx"> 2015-11-06 Scott Valentine <svalentine@ikayzo.com>
</span><span class="cx">
</span><span class="cx"> Adding new tests for exporting generated RSA keys.
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/TestExpectations 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -294,8 +294,6 @@
</span><span class="cx">
</span><span class="cx"> # New W3C ref tests that are failing.
</span><span class="cx"> webkit.org/b/148847 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html [ ImageOnlyFailure ]
</span><del>-webkit.org/b/148853 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-01.html [ ImageOnlyFailure ]
-webkit.org/b/148853 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html [ ImageOnlyFailure ]
</del><span class="cx"> webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><span class="cx"> # @supports W3C Failures
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityinlineblockassertionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/inline-block-assertion-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/inline-block-assertion-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/accessibility/inline-block-assertion-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-
</del><ins>+
</ins><span class="cx"> Make sure that an inline block element is not cast incorrectly causing an assertion.
</span><span class="cx">
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span></span></pre></div>
<a id="trunkLayoutTestseditingexecCommandcrash140261expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/execCommand/crash-140261-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/execCommand/crash-140261-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/editing/execCommand/crash-140261-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-
</del><ins>+
</ins><span class="cx"> Test for crash in WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock()
</span><span class="cx">
</span><span class="cx"> This test passes if it doesn't crash.
</span></span></pre></div>
<a id="trunkLayoutTestsfastblockfloat4145535Crashexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/block/float/4145535Crash-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/block/float/4145535Crash-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/block/float/4145535Crash-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -3,6 +3,4 @@
</span><span class="cx"> layer at (0,0) size 800x600
</span><span class="cx"> RenderBlock {HTML} at (0,0) size 800x600
</span><span class="cx"> RenderBody {BODY} at (8,8) size 784x584
</span><del>- RenderBlock (anonymous) at (0,0) size 784x150
- RenderEmbeddedObject {EMBED} at (0,0) size 300x150
- RenderTable {TABLE} at (0,150) size 0x0
</del><ins>+ RenderTable {TABLE} at (0,0) size 0x0
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLDocumentdocumentpluginsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -3,5 +3,3 @@
</span><span class="cx"> If the test passes, you will see a pass message below.
</span><span class="cx">
</span><span class="cx"> PASS
</span><del>-
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastdominsertedIntoDocumentchildexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,2 +1,2 @@
</span><del>-PASS
</del><ins>+PASS
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdominsertedIntoDocumentsiblingexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1 +1 @@
</span><del>-PASS
</del><ins>+PASS
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdompluginattributesenumerationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -35,4 +35,4 @@
</span><span class="cx"> hspace
</span><span class="cx"> object
</span><span class="cx"> vspace
</span><del>-
</del><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastreplacedpercentheightinanonymousblockwidgethtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx"> </p>
</span><span class="cx"> <div style="height: 50px; background: blue; width: 100px;" id="target">
</span><span class="cx"> <div></div>
</span><del>- <embed id="object" style="height: 100%;">
</del><ins>+ <embed id="object" type="video/quicktime" style="height: 100%;">
</ins><span class="cx"> </div>
</span><span class="cx"> </body>
</span><span class="cx"> <script>
</span></span></pre></div>
<a id="trunkLayoutTestsfastreplacedreplacedbreakinghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/replaced/replaced-breaking.html (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/replaced/replaced-breaking.html 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/replaced/replaced-breaking.html 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -15,7 +15,7 @@
</span><span class="cx"> <input type="checkbox"><input type="checkbox">
</span><span class="cx"> <input type="radio"><input type="radio">
</span><span class="cx"> <iframe></iframe><iframe></iframe>
</span><del>- <embed></embed><embed></embed>
</del><ins>+ <embed type="video/quicktime"></embed><embed type="video/quicktime"></embed>
</ins><span class="cx"> </div>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkLayoutTestsfastreplacedtablepercentheighthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/replaced/table-percent-height.html (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/replaced/table-percent-height.html 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/replaced/table-percent-height.html 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -143,8 +143,8 @@
</span><span class="cx"> <table><tr><td><canvas id="canvas-75" style="background-color: #00ff00; height: 75%;"></canvas></td></tr></table>
</span><span class="cx"> <table><tr><td><canvas id="canvas-100" style="background-color: #00ff00; height: 100%;"></canvas></td></tr></table>
</span><span class="cx">
</span><del>-<table><tr><td><embed id="embed-75" style="background-color: #00ff00; height: 75%;"></embed></td></tr></table>
-<table><tr><td><embed id="embed-100" style="background-color: #00ff00; height: 100%;"></embed></td></tr></table>
</del><ins>+<table><tr><td><embed id="embed-75" type="video/quicktime" style="background-color: #00ff00; height: 75%;"></embed></td></tr></table>
+<table><tr><td><embed id="embed-100" type="video/quicktime" style="background-color: #00ff00; height: 100%;"></embed></td></tr></table>
</ins><span class="cx">
</span><span class="cx"> <table><tr><td><img id="img-75" src="resources/square-blue-100x100.png" style="height: 75%;"></td></tr></table>
</span><span class="cx"> <table><tr><td><img id="img-100" src="resources/square-blue-100x100.png" style="height: 100%;"></td></tr></table>
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextinternationalembedbidistyleinisolatecrashexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1 +1 @@
</span><del>-PASS, if no exception or crash in debug
</del><ins>+PASS, if no exception or crash in debug
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedblinkfastcssgridlayoutgridaddpositionedblockitemafterinlineitemexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,3 +1,3 @@
</span><span class="cx"> This test checks that adding a positioned block grid item after an inline grid item (which inserts it inside the existing anonymous block wrapping the inline item) does not crash on debug.
</span><span class="cx">
</span><del>-test
</del><ins>+test
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-11-07 Chris Dumez <cdumez@apple.com>
+
+ embed element without src and type attributes should represent nothing
+ https://bugs.webkit.org/show_bug.cgi?id=148853
+ <rdar://problem/22588235>
+
+ Reviewed by Zalan Bujtas.
+
+ Rebaseline existing tests.
+
+ * web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:
+ * web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt:
+
</ins><span class="cx"> 2015-11-03 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Accept 8 and 4 value hex colors (#RRGGBBAA)
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomdocumentsdomtreeaccessorsdocumentgetElementsByNamedocumentgetElementsByNamenewelementsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-
</del><ins>+
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> PASS getElementsByName and newly introduced HTML elements
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomdocumentsdomtreeaccessorsnameditem05expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-
</del><span class="cx">
</span><span class="cx"> PASS If there is one embed, it should be returned (name)
</span><span class="cx"> PASS If there are two embeds, a collection should be returned. (name)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/Source/WebCore/ChangeLog 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2015-11-07 Chris Dumez <cdumez@apple.com>
+
+ embed element without src and type attributes should represent nothing
+ https://bugs.webkit.org/show_bug.cgi?id=148853
+ <rdar://problem/22588235>
+
+ Reviewed by Zalan Bujtas.
+
+ As per the HTML specification, an embed element without src and type
+ attributes should represent nothing:
+ https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element
+
+ This patch fixes the issue by making sure we don't construct a
+ renderer for such embed elements.
+
+ The new behavior is consistent with Firefox but differs from Chrome.
+
+ No new tests, already covered by existing tests.
+
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::rendererIsNeeded):
+
</ins><span class="cx"> 2015-11-07 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLEmbedElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLEmbedElement.cpp (192131 => 192132)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2015-11-07 18:11:39 UTC (rev 192131)
+++ trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2015-11-07 23:48:08 UTC (rev 192132)
</span><span class="lines">@@ -183,6 +183,9 @@
</span><span class="cx">
</span><span class="cx"> bool HTMLEmbedElement::rendererIsNeeded(const RenderStyle& style)
</span><span class="cx"> {
</span><ins>+ if (!fastHasAttribute(typeAttr) && !fastHasAttribute(srcAttr))
+ return false;
+
</ins><span class="cx"> if (isImageType())
</span><span class="cx"> return HTMLPlugInImageElement::rendererIsNeeded(style);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>