<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191957] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191957">191957</a></dd>
<dt>Author</dt> <dd>ossy@webkit.org</dd>
<dt>Date</dt> <dd>2015-11-03 10:30:05 -0800 (Tue, 03 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, partially revert <a href="http://trac.webkit.org/projects/webkit/changeset/191952">r191952</a>.
Removed GCC compiler workarounds (unreachable returns).
* b3/B3Type.h:
(JSC::B3::sizeofType):
* b3/air/AirArg.h:
(JSC::B3::Air::Arg::isUse):
(JSC::B3::Air::Arg::isDef):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isType):
* b3/air/AirCode.h:
(JSC::B3::Air::Code::newTmp):
(JSC::B3::Air::Code::numTmps):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3B3Typeh">trunk/Source/JavaScriptCore/b3/B3Type.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3airAirArgh">trunk/Source/JavaScriptCore/b3/air/AirArg.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3airAirCodeh">trunk/Source/JavaScriptCore/b3/air/AirCode.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (191956 => 191957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-11-03 18:29:59 UTC (rev 191956)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-11-03 18:30:05 UTC (rev 191957)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2015-11-03 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><ins>+ Unreviewed, partially revert r191952.
+
+ Removed GCC compiler workarounds (unreachable returns).
+
+ * b3/B3Type.h:
+ (JSC::B3::sizeofType):
+ * b3/air/AirArg.h:
+ (JSC::B3::Air::Arg::isUse):
+ (JSC::B3::Air::Arg::isDef):
+ (JSC::B3::Air::Arg::isGP):
+ (JSC::B3::Air::Arg::isFP):
+ (JSC::B3::Air::Arg::isType):
+ * b3/air/AirCode.h:
+ (JSC::B3::Air::Code::newTmp):
+ (JSC::B3::Air::Code::numTmps):
+
+2015-11-03 Csaba Osztrogonác <ossy@webkit.org>
+
</ins><span class="cx"> Fix the ENABLE(B3_JIT) build on Linux
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=150794
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3B3Typeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/B3Type.h (191956 => 191957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/B3Type.h 2015-11-03 18:29:59 UTC (rev 191956)
+++ trunk/Source/JavaScriptCore/b3/B3Type.h 2015-11-03 18:30:05 UTC (rev 191957)
</span><span class="lines">@@ -68,8 +68,6 @@
</span><span class="cx"> case Double:
</span><span class="cx"> return 8;
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return 0;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } } // namespace JSC::B3
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3airAirArgh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/air/AirArg.h (191956 => 191957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/air/AirArg.h 2015-11-03 18:29:59 UTC (rev 191956)
+++ trunk/Source/JavaScriptCore/b3/air/AirArg.h 2015-11-03 18:30:05 UTC (rev 191957)
</span><span class="lines">@@ -122,8 +122,6 @@
</span><span class="cx"> case UseAddr:
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return false;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Returns true if the Role implies that the Inst will Def the Arg.
</span><span class="lines">@@ -137,8 +135,6 @@
</span><span class="cx"> case UseDef:
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return false;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Type typeForB3Type(B3::Type type)
</span><span class="lines">@@ -472,8 +468,6 @@
</span><span class="cx"> case Invalid:
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return false;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Tells us if this Arg can be used in a position that requires a FP value.
</span><span class="lines">@@ -496,8 +490,6 @@
</span><span class="cx"> case Tmp:
</span><span class="cx"> return isFPTmp();
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return false;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool hasType() const
</span><span class="lines">@@ -526,8 +518,6 @@
</span><span class="cx"> case FP:
</span><span class="cx"> return isFP();
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return false;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool isGPR() const
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3airAirCodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/air/AirCode.h (191956 => 191957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/air/AirCode.h 2015-11-03 18:29:59 UTC (rev 191956)
+++ trunk/Source/JavaScriptCore/b3/air/AirCode.h 2015-11-03 18:30:05 UTC (rev 191957)
</span><span class="lines">@@ -71,8 +71,6 @@
</span><span class="cx"> case Arg::FP:
</span><span class="cx"> return Tmp::fpTmpForIndex(m_numFPTmps++);
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return { };
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unsigned numTmps(Arg::Type type)
</span><span class="lines">@@ -83,8 +81,6 @@
</span><span class="cx"> case Arg::FP:
</span><span class="cx"> return m_numFPTmps;
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT_NOT_REACHED();
- return 0;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unsigned callArgAreaSize() const { return m_callArgAreaSize; }
</span></span></pre>
</div>
</div>
</body>
</html>