<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191967] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191967">191967</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-11-03 12:27:35 -0800 (Tue, 03 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Handle or Remove ParseHTML Timeline Event Records
https://bugs.webkit.org/show_bug.cgi?id=150689
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-11-03
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
* inspector/protocol/Timeline.json:
Source/WebCore:
Remove ParseHTML nesting recordings. We were not using them
and for most pages their self-time is very small in comparison
to other events. We may consider adding it back later for
UI purposes but for now the frontend doesn't use the records
so lets remove it.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer): Deleted.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willWriteHTMLImpl): Deleted.
(WebCore::InspectorInstrumentation::didWriteHTMLImpl): Deleted.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willWriteHTML): Deleted.
(WebCore::InspectorInstrumentation::didWriteHTML): Deleted.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willWriteHTML): Deleted.
(WebCore::InspectorTimelineAgent::didWriteHTML): Deleted.
(WebCore::toProtocol): Deleted.
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createParseHTMLData): Deleted.
* inspector/TimelineRecordFactory.h:
Source/WebInspectorUI:
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorprotocolTimelinejson">trunk/Source/JavaScriptCore/inspector/protocol/Timeline.json</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLDocumentParsercpp">trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationcpp">trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationh">trunk/Source/WebCore/inspector/InspectorInstrumentation.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgentcpp">trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgenth">trunk/Source/WebCore/inspector/InspectorTimelineAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorTimelineRecordFactorycpp">trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorTimelineRecordFactoryh">trunk/Source/WebCore/inspector/TimelineRecordFactory.h</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersTimelineManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-11-03 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Handle or Remove ParseHTML Timeline Event Records
+ https://bugs.webkit.org/show_bug.cgi?id=150689
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/protocol/Timeline.json:
+
</ins><span class="cx"> 2015-11-03 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename InlineCallFrame:: getCallerSkippingDeadFrames to something more descriptive
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorprotocolTimelinejson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/protocol/Timeline.json (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/protocol/Timeline.json 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/JavaScriptCore/inspector/protocol/Timeline.json 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -15,7 +15,6 @@
</span><span class="cx"> "Paint",
</span><span class="cx"> "Composite",
</span><span class="cx"> "RenderingFrame",
</span><del>- "ParseHTML",
</del><span class="cx"> "TimerInstall",
</span><span class="cx"> "TimerRemove",
</span><span class="cx"> "TimerFire",
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/ChangeLog 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -1,3 +1,33 @@
</span><ins>+2015-11-03 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Handle or Remove ParseHTML Timeline Event Records
+ https://bugs.webkit.org/show_bug.cgi?id=150689
+
+ Reviewed by Timothy Hatcher.
+
+ Remove ParseHTML nesting recordings. We were not using them
+ and for most pages their self-time is very small in comparison
+ to other events. We may consider adding it back later for
+ UI purposes but for now the frontend doesn't use the records
+ so lets remove it.
+
+ * html/parser/HTMLDocumentParser.cpp:
+ (WebCore::HTMLDocumentParser::pumpTokenizer): Deleted.
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::willWriteHTMLImpl): Deleted.
+ (WebCore::InspectorInstrumentation::didWriteHTMLImpl): Deleted.
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::willWriteHTML): Deleted.
+ (WebCore::InspectorInstrumentation::didWriteHTML): Deleted.
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::willWriteHTML): Deleted.
+ (WebCore::InspectorTimelineAgent::didWriteHTML): Deleted.
+ (WebCore::toProtocol): Deleted.
+ * inspector/InspectorTimelineAgent.h:
+ * inspector/TimelineRecordFactory.cpp:
+ (WebCore::TimelineRecordFactory::createParseHTMLData): Deleted.
+ * inspector/TimelineRecordFactory.h:
+
</ins><span class="cx"> 2015-11-03 Keith Rollin <krollin@apple.com>
</span><span class="cx">
</span><span class="cx"> HTMLOptionElement.text should never return the value of label
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLDocumentParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -28,12 +28,12 @@
</span><span class="cx"> #include "HTMLDocumentParser.h"
</span><span class="cx">
</span><span class="cx"> #include "DocumentFragment.h"
</span><ins>+#include "Frame.h"
+#include "HTMLDocument.h"
</ins><span class="cx"> #include "HTMLParserScheduler.h"
</span><span class="cx"> #include "HTMLPreloadScanner.h"
</span><span class="cx"> #include "HTMLScriptRunner.h"
</span><span class="cx"> #include "HTMLTreeBuilder.h"
</span><del>-#include "HTMLDocument.h"
-#include "InspectorInstrumentation.h"
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -247,13 +247,6 @@
</span><span class="cx">
</span><span class="cx"> PumpSession session(m_pumpSessionNestingLevel, contextForParsingSession());
</span><span class="cx">
</span><del>- // We tell the InspectorInstrumentation about every pump, even if we
- // end up pumping nothing. It can filter out empty pumps itself.
- // FIXME: m_input.current().length() is only accurate if we
- // end up parsing the whole buffer in this pump. We should pass how
- // much we parsed as part of didWriteHTML instead of willWriteHTML.
- auto cookie = InspectorInstrumentation::willWriteHTML(document(), m_input.current().currentLine().zeroBasedInt());
-
</del><span class="cx"> m_xssAuditor.init(document(), &m_xssAuditorDelegate);
</span><span class="cx">
</span><span class="cx"> while (canTakeNextToken(mode, session) && !session.needsYield) {
</span><span class="lines">@@ -294,8 +287,6 @@
</span><span class="cx"> }
</span><span class="cx"> m_preloadScanner->scan(*m_preloader, *document());
</span><span class="cx"> }
</span><del>-
- InspectorInstrumentation::didWriteHTML(cookie, m_input.current().currentLine().zeroBasedInt());
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLDocumentParser::constructTreeFromHTMLToken(HTMLTokenizer::TokenPtr& rawToken)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -832,22 +832,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-InspectorInstrumentationCookie InspectorInstrumentation::willWriteHTMLImpl(InstrumentingAgents& instrumentingAgents, unsigned startLine, Frame* frame)
-{
- int timelineAgentId = 0;
- if (InspectorTimelineAgent* timelineAgent = instrumentingAgents.inspectorTimelineAgent()) {
- timelineAgent->willWriteHTML(startLine, frame);
- timelineAgentId = timelineAgent->id();
- }
- return InspectorInstrumentationCookie(instrumentingAgents, timelineAgentId);
-}
-
-void InspectorInstrumentation::didWriteHTMLImpl(const InspectorInstrumentationCookie& cookie, unsigned endLine)
-{
- if (InspectorTimelineAgent* timelineAgent = retrieveTimelineAgent(cookie))
- timelineAgent->didWriteHTML(endLine);
-}
-
</del><span class="cx"> // JavaScriptCore InspectorDebuggerAgent should know Console MessageTypes.
</span><span class="cx"> static bool isConsoleAssertMessage(MessageSource source, MessageType type)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -203,9 +203,6 @@
</span><span class="cx"> static void didRunJavaScriptDialog(const InspectorInstrumentationCookie&);
</span><span class="cx"> static void willDestroyCachedResource(CachedResource&);
</span><span class="cx">
</span><del>- static InspectorInstrumentationCookie willWriteHTML(Document*, unsigned startLine);
- static void didWriteHTML(const InspectorInstrumentationCookie&, unsigned endLine);
-
</del><span class="cx"> static void addMessageToConsole(Page&, std::unique_ptr<Inspector::ConsoleMessage>);
</span><span class="cx">
</span><span class="cx"> // FIXME: Convert to ScriptArguments to match non-worker context.
</span><span class="lines">@@ -383,9 +380,6 @@
</span><span class="cx"> static void didRunJavaScriptDialogImpl(const InspectorInstrumentationCookie&);
</span><span class="cx"> static void willDestroyCachedResourceImpl(CachedResource&);
</span><span class="cx">
</span><del>- static InspectorInstrumentationCookie willWriteHTMLImpl(InstrumentingAgents&, unsigned startLine, Frame*);
- static void didWriteHTMLImpl(const InspectorInstrumentationCookie&, unsigned endLine);
-
</del><span class="cx"> static void addMessageToConsoleImpl(InstrumentingAgents&, std::unique_ptr<Inspector::ConsoleMessage>);
</span><span class="cx">
</span><span class="cx"> static void consoleCountImpl(InstrumentingAgents&, JSC::ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="lines">@@ -1057,21 +1051,6 @@
</span><span class="cx"> willDestroyCachedResourceImpl(cachedResource);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline InspectorInstrumentationCookie InspectorInstrumentation::willWriteHTML(Document* document, unsigned startLine)
-{
- FAST_RETURN_IF_NO_FRONTENDS(InspectorInstrumentationCookie());
- if (InstrumentingAgents* instrumentingAgents = instrumentingAgentsForDocument(document))
- return willWriteHTMLImpl(*instrumentingAgents, startLine, document->frame());
- return InspectorInstrumentationCookie();
-}
-
-inline void InspectorInstrumentation::didWriteHTML(const InspectorInstrumentationCookie& cookie, unsigned endLine)
-{
- FAST_RETURN_IF_NO_FRONTENDS(void());
- if (cookie.isValid())
- didWriteHTMLImpl(cookie, endLine);
-}
-
</del><span class="cx"> inline void InspectorInstrumentation::didOpenDatabase(ScriptExecutionContext* context, RefPtr<Database>&& database, const String& domain, const String& name, const String& version)
</span><span class="cx"> {
</span><span class="cx"> FAST_RETURN_IF_NO_FRONTENDS(void());
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -395,20 +395,6 @@
</span><span class="cx"> didCompleteCurrentRecord(TimelineRecordType::Paint);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorTimelineAgent::willWriteHTML(unsigned startLine, Frame* frame)
-{
- pushCurrentRecord(TimelineRecordFactory::createParseHTMLData(startLine), TimelineRecordType::ParseHTML, true, frame);
-}
-
-void InspectorTimelineAgent::didWriteHTML(unsigned endLine)
-{
- if (!m_recordStack.isEmpty()) {
- const TimelineRecordEntry& entry = m_recordStack.last();
- entry.data->setInteger("endLine", endLine);
- didCompleteCurrentRecord(TimelineRecordType::ParseHTML);
- }
-}
-
</del><span class="cx"> void InspectorTimelineAgent::didInstallTimer(int timerId, int timeout, bool singleShot, Frame* frame)
</span><span class="cx"> {
</span><span class="cx"> appendRecord(TimelineRecordFactory::createTimerInstallData(timerId, timeout, singleShot), TimelineRecordType::TimerInstall, true, frame);
</span><span class="lines">@@ -531,9 +517,6 @@
</span><span class="cx"> case TimelineRecordType::RenderingFrame:
</span><span class="cx"> return Inspector::Protocol::Timeline::EventType::RenderingFrame;
</span><span class="cx">
</span><del>- case TimelineRecordType::ParseHTML:
- return Inspector::Protocol::Timeline::EventType::ParseHTML;
-
</del><span class="cx"> case TimelineRecordType::TimerInstall:
</span><span class="cx"> return Inspector::Protocol::Timeline::EventType::TimerInstall;
</span><span class="cx"> case TimelineRecordType::TimerRemove:
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.h (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -67,8 +67,6 @@
</span><span class="cx"> Composite,
</span><span class="cx"> RenderingFrame,
</span><span class="cx">
</span><del>- ParseHTML,
-
</del><span class="cx"> TimerInstall,
</span><span class="cx"> TimerRemove,
</span><span class="cx"> TimerFire,
</span><span class="lines">@@ -137,8 +135,6 @@
</span><span class="cx"> void willRecalculateStyle(Frame*);
</span><span class="cx"> void didRecalculateStyle();
</span><span class="cx"> void didScheduleStyleRecalculation(Frame*);
</span><del>- void willWriteHTML(unsigned startLine, Frame*);
- void didWriteHTML(unsigned endLine);
</del><span class="cx"> void didTimeStamp(Frame&, const String&);
</span><span class="cx"> void didRequestAnimationFrame(int callbackId, Frame*);
</span><span class="cx"> void didCancelAnimationFrame(int callbackId, Frame*);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorTimelineRecordFactorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -119,13 +119,6 @@
</span><span class="cx"> return WTF::move(data);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<InspectorObject> TimelineRecordFactory::createParseHTMLData(unsigned startLine)
-{
- Ref<InspectorObject> data = InspectorObject::create();
- data->setInteger(ASCIILiteral("startLine"), startLine);
- return WTF::move(data);
-}
-
</del><span class="cx"> Ref<InspectorObject> TimelineRecordFactory::createAnimationFrameData(int callbackId)
</span><span class="cx"> {
</span><span class="cx"> Ref<InspectorObject> data = InspectorObject::create();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorTimelineRecordFactoryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.h (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/TimelineRecordFactory.h 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.h 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -61,7 +61,6 @@
</span><span class="cx"> static Ref<Inspector::InspectorObject> createTimerInstallData(int timerId, int timeout, bool singleShot);
</span><span class="cx"> static Ref<Inspector::InspectorObject> createEvaluateScriptData(const String&, double lineNumber);
</span><span class="cx"> static Ref<Inspector::InspectorObject> createTimeStampData(const String&);
</span><del>- static Ref<Inspector::InspectorObject> createParseHTMLData(unsigned startLine);
</del><span class="cx"> static Ref<Inspector::InspectorObject> createAnimationFrameData(int callbackId);
</span><span class="cx"> static Ref<Inspector::InspectorObject> createPaintData(const FloatQuad&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-11-03 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Handle or Remove ParseHTML Timeline Event Records
+ https://bugs.webkit.org/show_bug.cgi?id=150689
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/TimelineManager.js:
+ (WebInspector.TimelineManager.prototype._processRecord):
+
</ins><span class="cx"> 2015-11-02 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersTimelineManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (191966 => 191967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2015-11-03 20:19:20 UTC (rev 191966)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2015-11-03 20:27:35 UTC (rev 191967)
</span><span class="lines">@@ -313,10 +313,6 @@
</span><span class="cx">
</span><span class="cx"> return new WebInspector.RenderingFrameTimelineRecord(startTime, endTime);
</span><span class="cx">
</span><del>- case TimelineAgent.EventType.ParseHTML:
- // FIXME: <https://webkit.org/b/150689> Web Inspector: Handle or Remove ParseHTML Timeline Event Records
- return null;
-
</del><span class="cx"> case TimelineAgent.EventType.EvaluateScript:
</span><span class="cx"> if (!sourceCodeLocation) {
</span><span class="cx"> var mainFrame = WebInspector.frameResourceManager.mainFrame;
</span></span></pre>
</div>
</div>
</body>
</html>