<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191953] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191953">191953</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2015-11-03 09:13:24 -0800 (Tue, 03 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update to match text-orientation spec
https://bugs.webkit.org/show_bug.cgi?id=150765
Reviewed by Darin Adler.
Source/WebCore:
The CSS spec has removed the "sideways-right" value of text-orientation in favor
of "sideways." This patch makes the parser treat "sideways-right" the same as
"sideways."
Test: fast/text/orientation-sideways-right.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::fontAndGlyphOrientation): Deleted.
* rendering/style/RenderStyleConstants.h:
LayoutTests:
* fast/text/orientation-sideways-right-expected.html: Added.
* fast/text/orientation-sideways-right.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValueMappingsh">trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStyleConstantsh">trunk/Source/WebCore/rendering/style/RenderStyleConstants.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasttextorientationsidewaysrightexpectedhtml">trunk/LayoutTests/fast/text/orientation-sideways-right-expected.html</a></li>
<li><a href="#trunkLayoutTestsfasttextorientationsidewaysrighthtml">trunk/LayoutTests/fast/text/orientation-sideways-right.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (191952 => 191953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-11-03 15:50:37 UTC (rev 191952)
+++ trunk/LayoutTests/ChangeLog 2015-11-03 17:13:24 UTC (rev 191953)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-11-03 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Update to match text-orientation spec
+ https://bugs.webkit.org/show_bug.cgi?id=150765
+
+ Reviewed by Darin Adler.
+
+ * fast/text/orientation-sideways-right-expected.html: Added.
+ * fast/text/orientation-sideways-right.html: Added.
+
</ins><span class="cx"> 2015-11-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> Move webkitGetUserMedia to JS Builtin
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextorientationsidewaysrightexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/text/orientation-sideways-right-expected.html (0 => 191953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/orientation-sideways-right-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/orientation-sideways-right-expected.html 2015-11-03 17:13:24 UTC (rev 191953)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+This test makes sure that text-orientation: sideways is treated the same as text-orientation: sideways-right.
+<div id="placeholder"></div>
+<div style="text-orientation: upright;">
+<div id="t" style="-webkit-writing-mode: vertical-rl; -webkit-text-orientation: sideways;">abcd</div>
+</div>
+<script>
+var t = document.getElementById("t");
+var receiver = document.getElementById("placeholder");
+receiver.textContent = window.getComputedStyle(t).getPropertyValue("-webkit-text-orientation");
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextorientationsidewaysrighthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/text/orientation-sideways-right.html (0 => 191953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/orientation-sideways-right.html (rev 0)
+++ trunk/LayoutTests/fast/text/orientation-sideways-right.html 2015-11-03 17:13:24 UTC (rev 191953)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+This test makes sure that text-orientation: sideways is treated the same as text-orientation: sideways-right.
+<div id="placeholder"></div>
+<div style="text-orientation: upright;">
+<div id="t" style="-webkit-writing-mode: vertical-rl; -webkit-text-orientation: sideways-right;">abcd</div>
+</div>
+<script>
+var t = document.getElementById("t");
+var receiver = document.getElementById("placeholder");
+receiver.textContent = window.getComputedStyle(t).getPropertyValue("-webkit-text-orientation");
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191952 => 191953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-11-03 15:50:37 UTC (rev 191952)
+++ trunk/Source/WebCore/ChangeLog 2015-11-03 17:13:24 UTC (rev 191953)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-11-03 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Update to match text-orientation spec
+ https://bugs.webkit.org/show_bug.cgi?id=150765
+
+ Reviewed by Darin Adler.
+
+ The CSS spec has removed the "sideways-right" value of text-orientation in favor
+ of "sideways." This patch makes the parser treat "sideways-right" the same as
+ "sideways."
+
+ Test: fast/text/orientation-sideways-right.html
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::operator TextOrientation):
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted.
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::fontAndGlyphOrientation): Deleted.
+ * rendering/style/RenderStyleConstants.h:
+
</ins><span class="cx"> 2015-11-03 Xabier Rodriguez Calvar <calvaris@igalia.com>
</span><span class="cx">
</span><span class="cx"> [Streams API] Rework promises to use @newPromiseCapability
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValueMappingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (191952 => 191953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2015-11-03 15:50:37 UTC (rev 191952)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2015-11-03 17:13:24 UTC (rev 191953)
</span><span class="lines">@@ -3334,9 +3334,6 @@
</span><span class="cx"> case TextOrientation::Sideways:
</span><span class="cx"> m_value.valueID = CSSValueSideways;
</span><span class="cx"> break;
</span><del>- case TextOrientation::SidewaysRight:
- m_value.valueID = CSSValueSidewaysRight;
- break;
</del><span class="cx"> case TextOrientation::Mixed:
</span><span class="cx"> m_value.valueID = CSSValueMixed;
</span><span class="cx"> break;
</span><span class="lines">@@ -3354,7 +3351,7 @@
</span><span class="cx"> case CSSValueSideways:
</span><span class="cx"> return TextOrientation::Sideways;
</span><span class="cx"> case CSSValueSidewaysRight:
</span><del>- return TextOrientation::SidewaysRight;
</del><ins>+ return TextOrientation::Sideways;
</ins><span class="cx"> case CSSValueVerticalRight:
</span><span class="cx"> return TextOrientation::Mixed;
</span><span class="cx"> case CSSValueMixed:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (191952 => 191953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2015-11-03 15:50:37 UTC (rev 191952)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2015-11-03 17:13:24 UTC (rev 191953)
</span><span class="lines">@@ -1833,8 +1833,6 @@
</span><span class="cx"> return { Vertical, NonCJKGlyphOrientation::Upright };
</span><span class="cx"> case TextOrientation::Sideways:
</span><span class="cx"> return { Horizontal, NonCJKGlyphOrientation::Mixed };
</span><del>- case TextOrientation::SidewaysRight:
- return { Horizontal, NonCJKGlyphOrientation::Mixed };
</del><span class="cx"> default:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> return { Horizontal, NonCJKGlyphOrientation::Mixed };
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStyleConstantsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyleConstants.h (191952 => 191953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyleConstants.h 2015-11-03 15:50:37 UTC (rev 191952)
+++ trunk/Source/WebCore/rendering/style/RenderStyleConstants.h 2015-11-03 17:13:24 UTC (rev 191953)
</span><span class="lines">@@ -586,7 +586,7 @@
</span><span class="cx"> };
</span><span class="cx"> typedef unsigned TextEmphasisPosition;
</span><span class="cx">
</span><del>-enum class TextOrientation { Mixed, Upright, Sideways, SidewaysRight };
</del><ins>+enum class TextOrientation { Mixed, Upright, Sideways };
</ins><span class="cx">
</span><span class="cx"> enum TextOverflow { TextOverflowClip = 0, TextOverflowEllipsis };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>