<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191751] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191751">191751</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2015-10-29 13:18:56 -0700 (Thu, 29 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Date input values should not overlap with menu list dropdown button on iOS
https://bugs.webkit.org/show_bug.cgi?id=150681
<rdar://problem/19965078>
Reviewed by Zalan Bujtas.
Source/WebCore:
Adds a right margin on iOS date and time inputs so that the inner div does
not render the value of the date on top of the dropdown button on the right
of the menu list.
Tests: fast/forms/date/date-input-rendering-basic.html
fast/forms/time/time-input-rendering-basic.html
* css/html.css:
(input::-webkit-date-and-time-value):
LayoutTests:
Tests that date and time inputs render properly. Namely, the text should not
be rendered such that it covers the dropdown button on the right of the menu
list.
* fast/forms/date/date-input-rendering-basic-expected.txt: Added.
* fast/forms/date/date-input-rendering-basic.html: Added.
* fast/forms/time/time-input-rendering-basic-expected.txt: Added.
* fast/forms/time/time-input-rendering-basic.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecsshtmlcss">trunk/Source/WebCore/css/html.css</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastformsdatedateinputrenderingbasicexpectedtxt">trunk/LayoutTests/fast/forms/date/date-input-rendering-basic-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformsdatedateinputrenderingbasichtml">trunk/LayoutTests/fast/forms/date/date-input-rendering-basic.html</a></li>
<li><a href="#trunkLayoutTestsfastformstimetimeinputrenderingbasicexpectedtxt">trunk/LayoutTests/fast/forms/time/time-input-rendering-basic-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformstimetimeinputrenderingbasichtml">trunk/LayoutTests/fast/forms/time/time-input-rendering-basic.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (191750 => 191751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-29 20:09:57 UTC (rev 191750)
+++ trunk/LayoutTests/ChangeLog 2015-10-29 20:18:56 UTC (rev 191751)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-10-29 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Date input values should not overlap with menu list dropdown button on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=150681
+ <rdar://problem/19965078>
+
+ Reviewed by Zalan Bujtas.
+
+ Tests that date and time inputs render properly. Namely, the text should not
+ be rendered such that it covers the dropdown button on the right of the menu
+ list.
+
+ * fast/forms/date/date-input-rendering-basic-expected.txt: Added.
+ * fast/forms/date/date-input-rendering-basic.html: Added.
+ * fast/forms/time/time-input-rendering-basic-expected.txt: Added.
+ * fast/forms/time/time-input-rendering-basic.html: Added.
+
</ins><span class="cx"> 2015-10-29 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> storage/indexeddb/modern tests crashing frequently on mac-wk1, marking as flaky crashers
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsdatedateinputrenderingbasicexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/date/date-input-rendering-basic-expected.txt (0 => 191751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/date/date-input-rendering-basic-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/date/date-input-rendering-basic-expected.txt 2015-10-29 20:18:56 UTC (rev 191751)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderText {#text} at (101,2) size 4x19
+ text run at (101,2) width 4: " "
+ RenderText {#text} at (0,0) size 0x0
+layer at (10,10) size 97x22 clip at (11,11) size 95x20
+ RenderFlexibleBox {INPUT} at (2,2) size 97x22 [bgcolor=#FFFFFF] [border: (1px solid #4C4C4C)]
+ RenderBlock {DIV} at (6,4) size 57x14
+ RenderText {#text} at (0,0) size 57x14
+ text run at (0,0) width 57: "Apr 1, 1976"
+layer at (115,10) size 97x22 clip at (116,11) size 95x20
+ RenderFlexibleBox {INPUT} at (107,2) size 97x22 [bgcolor=#FFFFFF] [border: (1px solid #4C4C4C)]
+ RenderBlock {DIV} at (16,4) size 57x14
+ RenderText {#text} at (0,0) size 57x14
+ text run at (0,0) width 57: "Apr 1, 1976"
</ins></span></pre></div>
<a id="trunkLayoutTestsfastformsdatedateinputrenderingbasichtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/date/date-input-rendering-basic.html (0 => 191751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/date/date-input-rendering-basic.html (rev 0)
+++ trunk/LayoutTests/fast/forms/date/date-input-rendering-basic.html 2015-10-29 20:18:56 UTC (rev 191751)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+<html>
+ <body>
+ <input type="date" dir="ltr" value="1976-04-01"></input>
+ <input type="date" dir="rtl" value="1976-04-01"></input>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastformstimetimeinputrenderingbasicexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/time/time-input-rendering-basic-expected.txt (0 => 191751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/time/time-input-rendering-basic-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/time/time-input-rendering-basic-expected.txt 2015-10-29 20:18:56 UTC (rev 191751)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderText {#text} at (82,2) size 4x19
+ text run at (82,2) width 4: " "
+ RenderText {#text} at (0,0) size 0x0
+layer at (10,10) size 78x22 clip at (11,11) size 76x20
+ RenderFlexibleBox {INPUT} at (2,2) size 78x22 [bgcolor=#FFFFFF] [border: (1px solid #4C4C4C)]
+ RenderBlock {DIV} at (6,4) size 41x14
+ RenderText {#text} at (0,0) size 41x14
+ text run at (0,0) width 41: "9:41 AM"
+layer at (96,10) size 78x22 clip at (97,11) size 76x20
+ RenderFlexibleBox {INPUT} at (88,2) size 78x22 [bgcolor=#FFFFFF] [border: (1px solid #4C4C4C)]
+ RenderBlock {DIV} at (13,4) size 41x14
+ RenderText {#text} at (0,0) size 41x14
+ text run at (0,0) width 17: "AM"
+ text run at (16,0) width 4 RTL: " "
+ text run at (19,0) width 22: "9:41"
</ins></span></pre></div>
<a id="trunkLayoutTestsfastformstimetimeinputrenderingbasichtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/time/time-input-rendering-basic.html (0 => 191751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/time/time-input-rendering-basic.html (rev 0)
+++ trunk/LayoutTests/fast/forms/time/time-input-rendering-basic.html 2015-10-29 20:18:56 UTC (rev 191751)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+<html>
+ <body>
+ <input type="time" dir="ltr" value="09:41:00"></input>
+ <input type="time" dir="rtl" value="09:41:00"></input>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191750 => 191751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-29 20:09:57 UTC (rev 191750)
+++ trunk/Source/WebCore/ChangeLog 2015-10-29 20:18:56 UTC (rev 191751)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-10-29 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Date input values should not overlap with menu list dropdown button on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=150681
+ <rdar://problem/19965078>
+
+ Reviewed by Zalan Bujtas.
+
+ Adds a right margin on iOS date and time inputs so that the inner div does
+ not render the value of the date on top of the dropdown button on the right
+ of the menu list.
+
+ Tests: fast/forms/date/date-input-rendering-basic.html
+ fast/forms/time/time-input-rendering-basic.html
+
+ * css/html.css:
+ (input::-webkit-date-and-time-value):
+
</ins><span class="cx"> 2015-10-29 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Fix Mac CMake build
</span></span></pre></div>
<a id="trunkSourceWebCorecsshtmlcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/html.css (191750 => 191751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/html.css 2015-10-29 20:09:57 UTC (rev 191750)
+++ trunk/Source/WebCore/css/html.css 2015-10-29 20:18:56 UTC (rev 191751)
</span><span class="lines">@@ -526,12 +526,14 @@
</span><span class="cx"> #endif
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if !(defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS)
</del><span class="cx"> input::-webkit-date-and-time-value {
</span><ins>+#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS
+ margin-right: 18px;
+#else
</ins><span class="cx"> margin: 1px 24px 1px 4px;
</span><span class="cx"> white-space: pre;
</span><ins>+#endif
</ins><span class="cx"> }
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> input::-webkit-inner-spin-button {
</span><span class="cx"> -webkit-appearance: inner-spin-button;
</span></span></pre>
</div>
</div>
</body>
</html>