<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191704] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191704">191704</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-28 16:53:14 -0700 (Wed, 28 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Do not sanitize user input for input[type=url]
https://bugs.webkit.org/show_bug.cgi?id=150346
<rdar://problem/23243240>
Patch by Keith Rollin <krollin@apple.com> on 2015-10-28
Reviewed by Brent Fulgham.
The Windows version of DumpRenderTree's eventSender.keyDown handler
simulates user-entry by decomposing the given character into a virtual
key code and a set of modifier keys. The code that determines if the
shift key should be simulated only worked if the character was an
upper case character. Extend this support to also include symbols that
(on the U.S. keyboard) require holding down the shift key.
This change allows fast/forms/input-user-input-sanitization.html
to succeed, which requires us to simulate the entering of '@' and ':'.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreewinEventSendercpp">trunk/Tools/DumpRenderTree/win/EventSender.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (191703 => 191704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-10-28 23:25:28 UTC (rev 191703)
+++ trunk/Tools/ChangeLog 2015-10-28 23:53:14 UTC (rev 191704)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2015-10-28 Keith Rollin <krollin@apple.com>
+
+ Do not sanitize user input for input[type=url]
+ https://bugs.webkit.org/show_bug.cgi?id=150346
+ <rdar://problem/23243240>
+
+ Reviewed by Brent Fulgham.
+
+ The Windows version of DumpRenderTree's eventSender.keyDown handler
+ simulates user-entry by decomposing the given character into a virtual
+ key code and a set of modifier keys. The code that determines if the
+ shift key should be simulated only worked if the character was an
+ upper case character. Extend this support to also include symbols that
+ (on the U.S. keyboard) require holding down the shift key.
+
+ This change allows fast/forms/input-user-input-sanitization.html
+ to succeed, which requires us to simulate the entering of '@' and ':'.
+
+ * DumpRenderTree/win/EventSender.cpp:
+ (keyDownCallback):
+
</ins><span class="cx"> 2015-10-28 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Compile and link with CMake on Mac
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinEventSendercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/EventSender.cpp (191703 => 191704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/EventSender.cpp 2015-10-28 23:25:28 UTC (rev 191703)
+++ trunk/Tools/DumpRenderTree/win/EventSender.cpp 2015-10-28 23:53:14 UTC (rev 191704)
</span><span class="lines">@@ -511,9 +511,10 @@
</span><span class="cx"> virtualKeyCode = VK_MENU;
</span><span class="cx"> keyData += makeKeyDataForScanCode(VK_RMENU);
</span><span class="cx"> } else {
</span><ins>+ static const char shiftedUSCharacters[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZ~!@#$%^&*()_+{}|:\"<>?";
</ins><span class="cx"> charCode = JSStringGetCharactersPtr(character)[0];
</span><span class="cx"> virtualKeyCode = LOBYTE(VkKeyScan(charCode));
</span><del>- if (WTF::isASCIIUpper(charCode))
</del><ins>+ if (strchr(shiftedUSCharacters, charCode))
</ins><span class="cx"> needsShiftKeyModifier = true;
</span><span class="cx"> }
</span><span class="cx"> JSStringRelease(character);
</span></span></pre>
</div>
</div>
</body>
</html>