<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191529] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191529">191529</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-23 18:26:22 -0700 (Fri, 23 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/191500">r191500</a>.
https://bugs.webkit.org/show_bug.cgi?id=150526
Broke two JSC regression tests (Requested by msaboff on
#webkit).
Reverted changeset:
"[ES6] Add DFG/FTL support for accessor put operations"
https://bugs.webkit.org/show_bug.cgi?id=148860
http://trac.webkit.org/changeset/191500</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGAbstractInterpreterInlinesh">trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGByteCodeParsercpp">trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGCapabilitiescpp">trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGClobberizeh">trunk/Source/JavaScriptCore/dfg/DFGClobberize.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGDoesGCcpp">trunk/Source/JavaScriptCore/dfg/DFGDoesGC.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGFixupPhasecpp">trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGNodeh">trunk/Source/JavaScriptCore/dfg/DFGNode.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGNodeTypeh">trunk/Source/JavaScriptCore/dfg/DFGNodeType.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGPredictionPropagationPhasecpp">trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSafeToExecuteh">trunk/Source/JavaScriptCore/dfg/DFGSafeToExecute.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJITcpp">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJITh">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJIT32_64cpp">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGSpeculativeJIT64cpp">trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreftlFTLCapabilitiescpp">trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreftlFTLIntrinsicRepositoryh">trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreftlFTLLowerDFGToLLVMcpp">trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITh">trunk/Source/JavaScriptCore/jit/JIT.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITInlinesh">trunk/Source/JavaScriptCore/jit/JITInlines.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITOperationscpp">trunk/Source/JavaScriptCore/jit/JITOperations.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITOperationsh">trunk/Source/JavaScriptCore/jit/JITOperations.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITPropertyAccesscpp">trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITPropertyAccess32_64cpp">trunk/Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputaccessorsbyidclassjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id-class.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputaccessorsbyidjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputgetterbyidclassjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id-class.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputgetterbyidjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputgetterbyvalclassjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val-class.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputgetterbyvaljs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputsetterbyidclassjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id-class.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputsetterbyidjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputsetterbyvalclassjs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val-class.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgputsetterbyvaljs">trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-10-23 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r191500.
+ https://bugs.webkit.org/show_bug.cgi?id=150526
+
+ Broke two JSC regression tests (Requested by msaboff on
+ #webkit).
+
+ Reverted changeset:
+
+ "[ES6] Add DFG/FTL support for accessor put operations"
+ https://bugs.webkit.org/show_bug.cgi?id=148860
+ http://trac.webkit.org/changeset/191500
+
</ins><span class="cx"> 2015-10-23 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Add DFG/FTL support for accessor put operations
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGAbstractInterpreterInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -2363,15 +2363,6 @@
</span><span class="cx"> clobberWorld(node->origin.semantic, clobberLimit);
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>-
- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- case PutGetterByVal:
- case PutSetterByVal: {
- clobberWorld(node->origin.semantic, clobberLimit);
- break;
- }
</del><span class="cx">
</span><span class="cx"> case In: {
</span><span class="cx"> // FIXME: We can determine when the property definitely exists based on abstract
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGByteCodeParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -3749,38 +3749,6 @@
</span><span class="cx"> NEXT_OPCODE(op_put_by_id);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- case op_put_getter_by_id:
- case op_put_setter_by_id: {
- Node* base = get(VirtualRegister(currentInstruction[1].u.operand));
- unsigned identifierNumber = m_inlineStackTop->m_identifierRemap[currentInstruction[2].u.operand];
- unsigned attributes = currentInstruction[3].u.operand;
- Node* accessor = get(VirtualRegister(currentInstruction[4].u.operand));
- NodeType op = (opcodeID == op_put_getter_by_id) ? PutGetterById : PutSetterById;
- addToGraph(op, OpInfo(identifierNumber), OpInfo(attributes), base, accessor);
- NEXT_OPCODE(op_put_getter_by_id);
- }
-
- case op_put_getter_setter: {
- Node* base = get(VirtualRegister(currentInstruction[1].u.operand));
- unsigned identifierNumber = m_inlineStackTop->m_identifierRemap[currentInstruction[2].u.operand];
- unsigned attributes = currentInstruction[3].u.operand;
- Node* getter = get(VirtualRegister(currentInstruction[4].u.operand));
- Node* setter = get(VirtualRegister(currentInstruction[5].u.operand));
- addToGraph(PutGetterSetterById, OpInfo(identifierNumber), OpInfo(attributes), base, getter, setter);
- NEXT_OPCODE(op_put_getter_setter);
- }
-
- case op_put_getter_by_val:
- case op_put_setter_by_val: {
- Node* base = get(VirtualRegister(currentInstruction[1].u.operand));
- Node* subscript = get(VirtualRegister(currentInstruction[2].u.operand));
- unsigned attributes = currentInstruction[3].u.operand;
- Node* accessor = get(VirtualRegister(currentInstruction[4].u.operand));
- NodeType op = (opcodeID == op_put_getter_by_val) ? PutGetterByVal : PutSetterByVal;
- addToGraph(op, OpInfo(attributes), base, subscript, accessor);
- NEXT_OPCODE(op_put_getter_by_val);
- }
-
</del><span class="cx"> case op_profile_type: {
</span><span class="cx"> Node* valueToProfile = get(VirtualRegister(currentInstruction[1].u.operand));
</span><span class="cx"> addToGraph(ProfileType, OpInfo(currentInstruction[2].u.location), valueToProfile);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGCapabilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -154,11 +154,6 @@
</span><span class="cx"> case op_get_by_id:
</span><span class="cx"> case op_get_array_length:
</span><span class="cx"> case op_put_by_id:
</span><del>- case op_put_getter_by_id:
- case op_put_setter_by_id:
- case op_put_getter_setter:
- case op_put_getter_by_val:
- case op_put_setter_by_val:
</del><span class="cx"> case op_jmp:
</span><span class="cx"> case op_jtrue:
</span><span class="cx"> case op_jfalse:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGClobberizeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGClobberize.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGClobberize.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGClobberize.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -379,11 +379,6 @@
</span><span class="cx"> case PutById:
</span><span class="cx"> case PutByIdFlush:
</span><span class="cx"> case PutByIdDirect:
</span><del>- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- case PutGetterByVal:
- case PutSetterByVal:
</del><span class="cx"> case ArrayPush:
</span><span class="cx"> case ArrayPop:
</span><span class="cx"> case Call:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGDoesGCcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGDoesGC.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGDoesGC.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGDoesGC.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -95,11 +95,6 @@
</span><span class="cx"> case PutById:
</span><span class="cx"> case PutByIdFlush:
</span><span class="cx"> case PutByIdDirect:
</span><del>- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- case PutGetterByVal:
- case PutSetterByVal:
</del><span class="cx"> case CheckStructure:
</span><span class="cx"> case GetExecutable:
</span><span class="cx"> case GetButterfly:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGFixupPhasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1057,25 +1057,6 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- case PutGetterById:
- case PutSetterById: {
- fixEdge<KnownCellUse>(node->child1());
- fixEdge<KnownCellUse>(node->child2());
- break;
- }
-
- case PutGetterSetterById: {
- fixEdge<KnownCellUse>(node->child1());
- break;
- }
-
- case PutGetterByVal:
- case PutSetterByVal: {
- fixEdge<KnownCellUse>(node->child1());
- fixEdge<KnownCellUse>(node->child3());
- break;
- }
-
</del><span class="cx"> case GetExecutable: {
</span><span class="cx"> fixEdge<FunctionUse>(node->child1());
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGNode.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGNode.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGNode.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -853,9 +853,6 @@
</span><span class="cx"> case PutById:
</span><span class="cx"> case PutByIdFlush:
</span><span class="cx"> case PutByIdDirect:
</span><del>- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
</del><span class="cx"> return true;
</span><span class="cx"> default:
</span><span class="cx"> return false;
</span><span class="lines">@@ -867,37 +864,6 @@
</span><span class="cx"> ASSERT(hasIdentifier());
</span><span class="cx"> return m_opInfo;
</span><span class="cx"> }
</span><del>-
- bool hasAccessorAttributes()
- {
- switch (op()) {
- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- case PutGetterByVal:
- case PutSetterByVal:
- return true;
- default:
- return false;
- }
- }
-
- int32_t accessorAttributes()
- {
- ASSERT(hasAccessorAttributes());
- switch (op()) {
- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- return m_opInfo2;
- case PutGetterByVal:
- case PutSetterByVal:
- return m_opInfo;
- default:
- RELEASE_ASSERT_NOT_REACHED();
- return 0;
- }
- }
</del><span class="cx">
</span><span class="cx"> bool hasPromotedLocationDescriptor()
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGNodeTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGNodeType.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGNodeType.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGNodeType.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -179,13 +179,8 @@
</span><span class="cx"> macro(GetById, NodeResultJS | NodeMustGenerate) \
</span><span class="cx"> macro(GetByIdFlush, NodeResultJS | NodeMustGenerate) \
</span><span class="cx"> macro(PutById, NodeMustGenerate) \
</span><del>- macro(PutByIdFlush, NodeMustGenerate) \
</del><ins>+ macro(PutByIdFlush, NodeMustGenerate | NodeMustGenerate) \
</ins><span class="cx"> macro(PutByIdDirect, NodeMustGenerate) \
</span><del>- macro(PutGetterById, NodeMustGenerate) \
- macro(PutSetterById, NodeMustGenerate) \
- macro(PutGetterSetterById, NodeMustGenerate) \
- macro(PutGetterByVal, NodeMustGenerate) \
- macro(PutSetterByVal, NodeMustGenerate) \
</del><span class="cx"> macro(CheckStructure, NodeMustGenerate) \
</span><span class="cx"> macro(GetExecutable, NodeResultJS) \
</span><span class="cx"> macro(PutStructure, NodeMustGenerate) \
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGPredictionPropagationPhasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -651,11 +651,6 @@
</span><span class="cx"> case PutByIdDirect:
</span><span class="cx"> case PutByOffset:
</span><span class="cx"> case MultiPutByOffset:
</span><del>- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- case PutGetterByVal:
- case PutSetterByVal:
</del><span class="cx"> case DFG::Jump:
</span><span class="cx"> case Branch:
</span><span class="cx"> case Switch:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSafeToExecuteh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSafeToExecute.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSafeToExecute.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGSafeToExecute.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -188,11 +188,6 @@
</span><span class="cx"> case PutById:
</span><span class="cx"> case PutByIdFlush:
</span><span class="cx"> case PutByIdDirect:
</span><del>- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- case PutGetterByVal:
- case PutSetterByVal:
</del><span class="cx"> case CheckStructure:
</span><span class="cx"> case GetExecutable:
</span><span class="cx"> case GetButterfly:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJITcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -6741,61 +6741,6 @@
</span><span class="cx"> ownerIsRememberedOrInEden.link(&m_jit);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SpeculativeJIT::compilePutAccessorById(Node* node)
-{
- SpeculateCellOperand base(this, node->child1());
- SpeculateCellOperand accessor(this, node->child2());
-
- flushRegisters();
- callOperation(node->op() == PutGetterById ? operationPutGetterById : operationPutSetterById, NoResult, base.gpr(), identifierUID(node->identifierNumber()), node->accessorAttributes(), accessor.gpr());
- m_jit.exceptionCheck();
-
- noResult(node);
-}
-
-void SpeculativeJIT::compilePutGetterSetterById(Node* node)
-{
- SpeculateCellOperand base(this, node->child1());
- JSValueOperand getter(this, node->child2());
- JSValueOperand setter(this, node->child3());
-
- flushRegisters();
-#if USE(JSVALUE64)
- callOperation(operationPutGetterSetter, NoResult, base.gpr(), identifierUID(node->identifierNumber()), node->accessorAttributes(), getter.gpr(), setter.gpr());
-#else
- // These JSValues may be JSUndefined OR JSFunction*.
- // At that time,
- // 1. If the JSValue is JSUndefined, its payload becomes nullptr.
- // 2. If the JSValue is JSFunction*, its payload becomes JSFunction*.
- // So extract payload and pass it to operationPutGetterSetter. This hack is used as the same way in baseline JIT.
- JSValueRegs getterRegs = getter.jsValueRegs();
- JSValueRegs setterRegs = setter.jsValueRegs();
- callOperation(operationPutGetterSetter, NoResult, base.gpr(), identifierUID(node->identifierNumber()), node->accessorAttributes(), getterRegs.payloadGPR(), setterRegs.payloadGPR());
-#endif
- m_jit.exceptionCheck();
-
- noResult(node);
-}
-
-void SpeculativeJIT::compilePutAccessorByVal(Node* node)
-{
- SpeculateCellOperand base(this, node->child1());
- JSValueOperand subscript(this, node->child2());
- SpeculateCellOperand accessor(this, node->child3());
-
- flushRegisters();
- auto operation = node->op() == PutGetterByVal ? operationPutGetterByVal : operationPutSetterByVal;
-#if USE(JSVALUE64)
- callOperation(operation, NoResult, base.gpr(), subscript.gpr(), node->accessorAttributes(), accessor.gpr());
-#else
- JSValueRegs subscriptRegs = subscript.jsValueRegs();
- callOperation(operation, NoResult, base.gpr(), subscriptRegs.tagGPR(), subscriptRegs.payloadGPR(), node->accessorAttributes(), accessor.gpr());
-#endif
- m_jit.exceptionCheck();
-
- noResult(node);
-}
-
</del><span class="cx"> } } // namespace JSC::DFG
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJITh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1155,17 +1155,36 @@
</span><span class="cx"> return appendCallSetResult(operation, result);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- JITCompiler::Call callOperation(V_JITOperation_ECIZC operation, GPRReg regOp1, UniquedStringImpl* identOp2, int32_t op3, GPRReg regOp4)
</del><ins>+ template<typename FunctionType>
+ JITCompiler::Call callOperation(FunctionType operation, NoResultTag)
</ins><span class="cx"> {
</span><del>- m_jit.setupArgumentsWithExecState(regOp1, TrustedImmPtr(identOp2), TrustedImm32(op3), regOp4);
- return appendCall(operation);
</del><ins>+ return callOperation(operation);
</ins><span class="cx"> }
</span><del>-
- template<typename FunctionType, typename... Args>
- JITCompiler::Call callOperation(FunctionType operation, NoResultTag, Args... args)
</del><ins>+ template<typename FunctionType, typename ArgumentType1>
+ JITCompiler::Call callOperation(FunctionType operation, NoResultTag, ArgumentType1 arg1)
</ins><span class="cx"> {
</span><del>- return callOperation(operation, args...);
</del><ins>+ return callOperation(operation, arg1);
</ins><span class="cx"> }
</span><ins>+ template<typename FunctionType, typename ArgumentType1, typename ArgumentType2>
+ JITCompiler::Call callOperation(FunctionType operation, NoResultTag, ArgumentType1 arg1, ArgumentType2 arg2)
+ {
+ return callOperation(operation, arg1, arg2);
+ }
+ template<typename FunctionType, typename ArgumentType1, typename ArgumentType2, typename ArgumentType3>
+ JITCompiler::Call callOperation(FunctionType operation, NoResultTag, ArgumentType1 arg1, ArgumentType2 arg2, ArgumentType3 arg3)
+ {
+ return callOperation(operation, arg1, arg2, arg3);
+ }
+ template<typename FunctionType, typename ArgumentType1, typename ArgumentType2, typename ArgumentType3, typename ArgumentType4>
+ JITCompiler::Call callOperation(FunctionType operation, NoResultTag, ArgumentType1 arg1, ArgumentType2 arg2, ArgumentType3 arg3, ArgumentType4 arg4)
+ {
+ return callOperation(operation, arg1, arg2, arg3, arg4);
+ }
+ template<typename FunctionType, typename ArgumentType1, typename ArgumentType2, typename ArgumentType3, typename ArgumentType4, typename ArgumentType5>
+ JITCompiler::Call callOperation(FunctionType operation, NoResultTag, ArgumentType1 arg1, ArgumentType2 arg2, ArgumentType3 arg3, ArgumentType4 arg4, ArgumentType5 arg5)
+ {
+ return callOperation(operation, arg1, arg2, arg3, arg4, arg5);
+ }
</ins><span class="cx">
</span><span class="cx"> JITCompiler::Call callOperation(D_JITOperation_ZZ operation, FPRReg result, GPRReg arg1, GPRReg arg2)
</span><span class="cx"> {
</span><span class="lines">@@ -1515,16 +1534,6 @@
</span><span class="cx"> m_jit.setupArgumentsWithExecState(TrustedImm32(arg1), arg2, TrustedImm32(arg3), arg4, TrustedImm32(arg5));
</span><span class="cx"> return appendCall(operation);
</span><span class="cx"> }
</span><del>- JITCompiler::Call callOperation(V_JITOperation_ECJZC operation, GPRReg regOp1, GPRReg regOp2, int32_t op3, GPRReg regOp4)
- {
- m_jit.setupArgumentsWithExecState(regOp1, regOp2, TrustedImm32(op3), regOp4);
- return appendCall(operation);
- }
- JITCompiler::Call callOperation(V_JITOperation_ECIZJJ operation, GPRReg regOp1, UniquedStringImpl* identOp2, int32_t op3, GPRReg regOp4, GPRReg regOp5)
- {
- m_jit.setupArgumentsWithExecState(regOp1, TrustedImmPtr(identOp2), TrustedImm32(op3), regOp4, regOp5);
- return appendCall(operation);
- }
</del><span class="cx"> #else // USE(JSVALUE32_64)
</span><span class="cx">
</span><span class="cx"> // EncodedJSValue in JSVALUE32_64 is a 64-bit integer. When being compiled in ARM EABI, it must be aligned even-numbered register (r0, r2 or [sp]).
</span><span class="lines">@@ -1846,16 +1855,6 @@
</span><span class="cx"> m_jit.setupArgumentsWithExecState(TrustedImm32(arg1), arg2Payload, arg2Tag, TrustedImm32(arg3), arg4, TrustedImm32(arg5));
</span><span class="cx"> return appendCall(operation);
</span><span class="cx"> }
</span><del>- JITCompiler::Call callOperation(V_JITOperation_ECJZC operation, GPRReg arg1, GPRReg arg2Tag, GPRReg arg2Payload, int32_t arg3, GPRReg arg4)
- {
- m_jit.setupArgumentsWithExecState(arg1, arg2Payload, arg2Tag, TrustedImm32(arg3), arg4);
- return appendCall(operation);
- }
- JITCompiler::Call callOperation(V_JITOperation_ECIZCC operation, GPRReg arg1, UniquedStringImpl* identOp2, int32_t op3, GPRReg arg4, GPRReg arg5)
- {
- m_jit.setupArgumentsWithExecState(arg1, TrustedImmPtr(identOp2), TrustedImm32(op3), arg4, arg5);
- return appendCall(operation);
- }
</del><span class="cx"> #undef EABI_32BIT_DUMMY_ARG
</span><span class="cx"> #undef SH4_32BIT_DUMMY_ARG
</span><span class="cx">
</span><span class="lines">@@ -2244,9 +2243,6 @@
</span><span class="cx"> void compileTypeOf(Node*);
</span><span class="cx"> void compileCheckStructure(Node*, GPRReg cellGPR, GPRReg tempGPR);
</span><span class="cx"> void compileCheckStructure(Node*);
</span><del>- void compilePutAccessorById(Node*);
- void compilePutGetterSetterById(Node*);
- void compilePutAccessorByVal(Node*);
</del><span class="cx">
</span><span class="cx"> void moveTrueTo(GPRReg);
</span><span class="cx"> void moveFalseTo(GPRReg);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJIT32_64cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -4170,23 +4170,6 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- case PutGetterById:
- case PutSetterById: {
- compilePutAccessorById(node);
- break;
- }
-
- case PutGetterSetterById: {
- compilePutGetterSetterById(node);
- break;
- }
-
- case PutGetterByVal:
- case PutSetterByVal: {
- compilePutAccessorByVal(node);
- break;
- }
-
</del><span class="cx"> case GetGlobalLexicalVariable:
</span><span class="cx"> case GetGlobalVar: {
</span><span class="cx"> GPRTemporary resultPayload(this);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGSpeculativeJIT64cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -4162,23 +4162,6 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- case PutGetterById:
- case PutSetterById: {
- compilePutAccessorById(node);
- break;
- }
-
- case PutGetterSetterById: {
- compilePutGetterSetterById(node);
- break;
- }
-
- case PutGetterByVal:
- case PutSetterByVal: {
- compilePutAccessorByVal(node);
- break;
- }
-
</del><span class="cx"> case GetGlobalLexicalVariable:
</span><span class="cx"> case GetGlobalVar: {
</span><span class="cx"> GPRTemporary result(this);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreftlFTLCapabilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -204,11 +204,6 @@
</span><span class="cx"> case ForwardVarargs:
</span><span class="cx"> case Switch:
</span><span class="cx"> case TypeOf:
</span><del>- case PutGetterById:
- case PutSetterById:
- case PutGetterSetterById:
- case PutGetterByVal:
- case PutSetterByVal:
</del><span class="cx"> // These are OK.
</span><span class="cx"> break;
</span><span class="cx"> case ArithSub:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreftlFTLIntrinsicRepositoryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -118,9 +118,6 @@
</span><span class="cx"> macro(V_JITOperation_J, functionType(voidType, int64)) \
</span><span class="cx"> macro(V_JITOperation_Z, functionType(voidType, int32)) \
</span><span class="cx"> macro(V_JITOperation_E, functionType(voidType, intPtr)) \
</span><del>- macro(V_JITOperation_ECIZC, functionType(voidType, intPtr, intPtr, intPtr, int32, intPtr)) \
- macro(V_JITOperation_ECIZJJ, functionType(voidType, intPtr, intPtr, intPtr, int32, int64, int64)) \
- macro(V_JITOperation_ECJZC, functionType(voidType, intPtr, intPtr, int64, int32, intPtr)) \
</del><span class="cx"> macro(Z_JITOperation_D, functionType(int32, doubleType)) \
</span><span class="cx"> macro(Z_JITOperation_EC, functionType(int32, intPtr, intPtr)) \
</span><span class="cx"> macro(Z_JITOperation_EGC, functionType(int32, intPtr, intPtr, intPtr)) \
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreftlFTLLowerDFGToLLVMcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -565,17 +565,6 @@
</span><span class="cx"> case PutByIdFlush:
</span><span class="cx"> compilePutById();
</span><span class="cx"> break;
</span><del>- case PutGetterById:
- case PutSetterById:
- compilePutAccessorById();
- break;
- case PutGetterSetterById:
- compilePutGetterSetterById();
- break;
- case PutGetterByVal:
- case PutSetterByVal:
- compilePutAccessorByVal();
- break;
</del><span class="cx"> case GetButterfly:
</span><span class="cx"> compileGetButterfly();
</span><span class="cx"> break;
</span><span class="lines">@@ -3010,38 +2999,6 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>-
- void compilePutAccessorById()
- {
- LValue base = lowCell(m_node->child1());
- LValue accessor = lowCell(m_node->child2());
- auto uid = m_graph.identifiers()[m_node->identifierNumber()];
- vmCall(
- m_out.operation(m_node->op() == PutGetterById ? operationPutGetterById : operationPutSetterById),
- m_callFrame, base, m_out.constIntPtr(uid), m_out.constInt32(m_node->accessorAttributes()), accessor);
- }
-
- void compilePutGetterSetterById()
- {
- LValue base = lowCell(m_node->child1());
- LValue getter = lowJSValue(m_node->child2());
- LValue setter = lowJSValue(m_node->child3());
- auto uid = m_graph.identifiers()[m_node->identifierNumber()];
- vmCall(
- m_out.operation(operationPutGetterSetter),
- m_callFrame, base, m_out.constIntPtr(uid), m_out.constInt32(m_node->accessorAttributes()), getter, setter);
-
- }
-
- void compilePutAccessorByVal()
- {
- LValue base = lowCell(m_node->child1());
- LValue subscript = lowJSValue(m_node->child2());
- LValue accessor = lowCell(m_node->child3());
- vmCall(
- m_out.operation(m_node->op() == PutGetterByVal ? operationPutGetterByVal : operationPutSetterByVal),
- m_callFrame, base, subscript, m_out.constInt32(m_node->accessorAttributes()), accessor);
- }
</del><span class="cx">
</span><span class="cx"> void compileArrayPush()
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JIT.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JIT.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/jit/JIT.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -762,13 +762,9 @@
</span><span class="cx"> MacroAssembler::Call callOperation(V_JITOperation_E);
</span><span class="cx"> MacroAssembler::Call callOperation(V_JITOperation_EC, RegisterID);
</span><span class="cx"> MacroAssembler::Call callOperation(V_JITOperation_ECC, RegisterID, RegisterID);
</span><del>- MacroAssembler::Call callOperation(V_JITOperation_ECIZC, RegisterID, UniquedStringImpl*, int32_t, RegisterID);
- MacroAssembler::Call callOperation(V_JITOperation_ECIZCC, RegisterID, UniquedStringImpl*, int32_t, RegisterID, RegisterID);
-#if USE(JSVALUE64)
- MacroAssembler::Call callOperation(V_JITOperation_ECJZC, RegisterID, RegisterID, int32_t, RegisterID);
-#else
</del><ins>+ MacroAssembler::Call callOperation(V_JITOperation_ECIZC, RegisterID, const Identifier*, int32_t, RegisterID);
+ MacroAssembler::Call callOperation(V_JITOperation_ECIZCC, RegisterID, const Identifier*, int32_t, RegisterID, RegisterID);
</ins><span class="cx"> MacroAssembler::Call callOperation(V_JITOperation_ECJZC, RegisterID, RegisterID, RegisterID, int32_t, RegisterID);
</span><del>-#endif
</del><span class="cx"> MacroAssembler::Call callOperation(J_JITOperation_EE, RegisterID);
</span><span class="cx"> MacroAssembler::Call callOperation(V_JITOperation_EZSymtabJ, int, SymbolTable*, RegisterID);
</span><span class="cx"> MacroAssembler::Call callOperation(J_JITOperation_EZSymtabJ, int, SymbolTable*, RegisterID);
</span><span class="lines">@@ -779,10 +775,12 @@
</span><span class="cx"> #else
</span><span class="cx"> MacroAssembler::Call callOperationNoExceptionCheck(V_JITOperation_EJ, RegisterID, RegisterID);
</span><span class="cx"> #endif
</span><ins>+ MacroAssembler::Call callOperation(V_JITOperation_EJIdZJ, RegisterID, const Identifier*, int32_t, RegisterID);
+ MacroAssembler::Call callOperation(V_JITOperation_EJIdZJJ, RegisterID, const Identifier*, int32_t, RegisterID, RegisterID);
+ MacroAssembler::Call callOperation(V_JITOperation_EJJZJ, RegisterID, RegisterID, int32_t, RegisterID);
</ins><span class="cx"> #if USE(JSVALUE64)
</span><span class="cx"> MacroAssembler::Call callOperation(F_JITOperation_EFJZZ, RegisterID, RegisterID, int32_t, RegisterID);
</span><span class="cx"> MacroAssembler::Call callOperation(V_JITOperation_ESsiJJI, StructureStubInfo*, RegisterID, RegisterID, UniquedStringImpl*);
</span><del>- MacroAssembler::Call callOperation(V_JITOperation_ECIZJJ, RegisterID, UniquedStringImpl*, int32_t, RegisterID, RegisterID);
</del><span class="cx"> #else
</span><span class="cx"> MacroAssembler::Call callOperation(V_JITOperation_ESsiJJI, StructureStubInfo*, RegisterID, RegisterID, RegisterID, RegisterID, UniquedStringImpl*);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITInlines.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITInlines.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/jit/JITInlines.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -406,11 +406,6 @@
</span><span class="cx"> return appendCallWithCallFrameRollbackOnException(operation);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_ECIZC operation, RegisterID regOp1, UniquedStringImpl* identOp2, int32_t op3, RegisterID regOp4)
-{
- setupArgumentsWithExecState(regOp1, TrustedImmPtr(identOp2), TrustedImm32(op3), regOp4);
- return appendCallWithExceptionCheck(operation);
-}
</del><span class="cx">
</span><span class="cx"> #if USE(JSVALUE64)
</span><span class="cx"> ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(Z_JITOperation_EJZZ operation, GPRReg arg1, int32_t arg2, int32_t arg3)
</span><span class="lines">@@ -546,13 +541,19 @@
</span><span class="cx"> return appendCallWithExceptionCheck(operation);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_ECIZJJ operation, RegisterID regOp1, UniquedStringImpl* identOp2, int32_t op3, RegisterID regOp4, RegisterID regOp5)
</del><ins>+ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_EJIdZJ operation, RegisterID regOp1, const Identifier* identOp2, int32_t op3, RegisterID regOp4)
</ins><span class="cx"> {
</span><ins>+ setupArgumentsWithExecState(regOp1, TrustedImmPtr(identOp2), TrustedImm32(op3), regOp4);
+ return appendCallWithExceptionCheck(operation);
+}
+
+ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_EJIdZJJ operation, RegisterID regOp1, const Identifier* identOp2, int32_t op3, RegisterID regOp4, RegisterID regOp5)
+{
</ins><span class="cx"> setupArgumentsWithExecState(regOp1, TrustedImmPtr(identOp2), TrustedImm32(op3), regOp4, regOp5);
</span><span class="cx"> return appendCallWithExceptionCheck(operation);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_ECJZC operation, RegisterID regOp1, RegisterID regOp2, int32_t op3, RegisterID regOp4)
</del><ins>+ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_EJJZJ operation, RegisterID regOp1, RegisterID regOp2, int32_t op3, RegisterID regOp4)
</ins><span class="cx"> {
</span><span class="cx"> setupArgumentsWithExecState(regOp1, regOp2, TrustedImm32(op3), regOp4);
</span><span class="cx"> return appendCallWithExceptionCheck(operation);
</span><span class="lines">@@ -674,8 +675,14 @@
</span><span class="cx"> return appendCallWithExceptionCheck(operation);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_ECIZCC operation, RegisterID regOp1, UniquedStringImpl* identOp2, int32_t op3, RegisterID regOp4, RegisterID regOp5)
</del><ins>+ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_ECIZC operation, RegisterID regOp1, const Identifier* identOp2, int32_t op3, RegisterID regOp4)
</ins><span class="cx"> {
</span><ins>+ setupArgumentsWithExecState(regOp1, TrustedImmPtr(identOp2), TrustedImm32(op3), regOp4);
+ return appendCallWithExceptionCheck(operation);
+}
+
+ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(V_JITOperation_ECIZCC operation, RegisterID regOp1, const Identifier* identOp2, int32_t op3, RegisterID regOp4, RegisterID regOp5)
+{
</ins><span class="cx"> setupArgumentsWithExecState(regOp1, TrustedImmPtr(identOp2), TrustedImm32(op3), regOp4, regOp5);
</span><span class="cx"> return appendCallWithExceptionCheck(operation);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITOperationscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITOperations.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITOperations.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/jit/JITOperations.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1353,78 +1353,109 @@
</span><span class="cx"> base->putSetter(exec, propertyKey, accessor, attribute);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void JIT_OPERATION operationPutGetterById(ExecState* exec, JSCell* object, UniquedStringImpl* uid, int32_t options, JSCell* getter)
</del><ins>+#if USE(JSVALUE64)
+void JIT_OPERATION operationPutGetterById(ExecState* exec, EncodedJSValue encodedObjectValue, Identifier* identifier, int32_t options, EncodedJSValue encodedGetterValue)
</ins><span class="cx"> {
</span><span class="cx"> VM& vm = exec->vm();
</span><span class="cx"> NativeCallFrameTracer tracer(&vm, exec);
</span><span class="cx">
</span><del>- ASSERT(object && object->isObject());
- JSObject* baseObj = object->getObject();
</del><ins>+ ASSERT(JSValue::decode(encodedObjectValue).isObject());
+ JSObject* baseObj = asObject(JSValue::decode(encodedObjectValue));
</ins><span class="cx">
</span><del>- ASSERT(getter->isObject());
- baseObj->putGetter(exec, uid, getter, options);
</del><ins>+ JSValue getter = JSValue::decode(encodedGetterValue);
+ ASSERT(getter.isObject());
+ baseObj->putGetter(exec, *identifier, asObject(getter), options);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void JIT_OPERATION operationPutSetterById(ExecState* exec, JSCell* object, UniquedStringImpl* uid, int32_t options, JSCell* setter)
</del><ins>+void JIT_OPERATION operationPutSetterById(ExecState* exec, EncodedJSValue encodedObjectValue, Identifier* identifier, int32_t options, EncodedJSValue encodedSetterValue)
</ins><span class="cx"> {
</span><span class="cx"> VM& vm = exec->vm();
</span><span class="cx"> NativeCallFrameTracer tracer(&vm, exec);
</span><span class="cx">
</span><del>- ASSERT(object && object->isObject());
- JSObject* baseObj = object->getObject();
</del><ins>+ ASSERT(JSValue::decode(encodedObjectValue).isObject());
+ JSObject* baseObj = asObject(JSValue::decode(encodedObjectValue));
</ins><span class="cx">
</span><del>- ASSERT(setter->isObject());
- baseObj->putSetter(exec, uid, setter, options);
</del><ins>+ JSValue setter = JSValue::decode(encodedSetterValue);
+ ASSERT(setter.isObject());
+ baseObj->putSetter(exec, *identifier, asObject(setter), options);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void JIT_OPERATION operationPutGetterByVal(ExecState* exec, JSCell* base, EncodedJSValue encodedSubscript, int32_t attribute, JSCell* getter)
</del><ins>+void JIT_OPERATION operationPutGetterSetter(ExecState* exec, EncodedJSValue encodedObjectValue, Identifier* identifier, int32_t attribute,
+ EncodedJSValue encodedGetterValue, EncodedJSValue encodedSetterValue)
</ins><span class="cx"> {
</span><span class="cx"> VM& vm = exec->vm();
</span><span class="cx"> NativeCallFrameTracer tracer(&vm, exec);
</span><span class="cx">
</span><del>- putAccessorByVal(exec, asObject(base), JSValue::decode(encodedSubscript), attribute, asObject(getter), AccessorType::Getter);
</del><ins>+ ASSERT(JSValue::decode(encodedObjectValue).isObject());
+ JSObject* baseObj = asObject(JSValue::decode(encodedObjectValue));
+
+ GetterSetter* accessor = GetterSetter::create(vm, exec->lexicalGlobalObject());
+
+ JSValue getter = JSValue::decode(encodedGetterValue);
+ JSValue setter = JSValue::decode(encodedSetterValue);
+ ASSERT(getter.isObject() || getter.isUndefined());
+ ASSERT(setter.isObject() || setter.isUndefined());
+ ASSERT(getter.isObject() || setter.isObject());
+
+ if (!getter.isUndefined())
+ accessor->setGetter(vm, exec->lexicalGlobalObject(), asObject(getter));
+ if (!setter.isUndefined())
+ accessor->setSetter(vm, exec->lexicalGlobalObject(), asObject(setter));
+ baseObj->putDirectAccessor(exec, *identifier, accessor, attribute);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void JIT_OPERATION operationPutSetterByVal(ExecState* exec, JSCell* base, EncodedJSValue encodedSubscript, int32_t attribute, JSCell* setter)
</del><ins>+void JIT_OPERATION operationPutGetterByVal(ExecState* exec, EncodedJSValue encodedBase, EncodedJSValue encodedSubscript, int32_t attribute, EncodedJSValue encodedGetter)
</ins><span class="cx"> {
</span><span class="cx"> VM& vm = exec->vm();
</span><span class="cx"> NativeCallFrameTracer tracer(&vm, exec);
</span><ins>+ JSObject* base = asObject(JSValue::decode(encodedBase));
+ JSValue subscript = JSValue::decode(encodedSubscript);
+ JSObject* getter = asObject(JSValue::decode(encodedGetter));
+ putAccessorByVal(exec, base, subscript, attribute, getter, AccessorType::Getter);
+}
</ins><span class="cx">
</span><del>- putAccessorByVal(exec, asObject(base), JSValue::decode(encodedSubscript), attribute, asObject(setter), AccessorType::Setter);
</del><ins>+void JIT_OPERATION operationPutSetterByVal(ExecState* exec, EncodedJSValue encodedBase, EncodedJSValue encodedSubscript, int32_t attribute, EncodedJSValue encodedSetter)
+{
+ VM& vm = exec->vm();
+ NativeCallFrameTracer tracer(&vm, exec);
+ JSObject* base = asObject(JSValue::decode(encodedBase));
+ JSValue subscript = JSValue::decode(encodedSubscript);
+ JSObject* setter = asObject(JSValue::decode(encodedSetter));
+ putAccessorByVal(exec, base, subscript, attribute, setter, AccessorType::Setter);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-#if USE(JSVALUE64)
-void JIT_OPERATION operationPutGetterSetter(ExecState* exec, JSCell* object, UniquedStringImpl* uid, int32_t attribute, EncodedJSValue encodedGetterValue, EncodedJSValue encodedSetterValue)
</del><ins>+#else
+void JIT_OPERATION operationPutGetterById(ExecState* exec, JSCell* object, Identifier* identifier, int32_t options, JSCell* getter)
</ins><span class="cx"> {
</span><span class="cx"> VM& vm = exec->vm();
</span><span class="cx"> NativeCallFrameTracer tracer(&vm, exec);
</span><span class="cx">
</span><span class="cx"> ASSERT(object && object->isObject());
</span><del>- JSObject* baseObj = asObject(object);
</del><ins>+ JSObject* baseObj = object->getObject();
</ins><span class="cx">
</span><del>- GetterSetter* accessor = GetterSetter::create(vm, exec->lexicalGlobalObject());
</del><ins>+ ASSERT(getter->isObject());
+ baseObj->putGetter(exec, *identifier, getter, options);
+}
</ins><span class="cx">
</span><del>- JSValue getter = JSValue::decode(encodedGetterValue);
- JSValue setter = JSValue::decode(encodedSetterValue);
- ASSERT(getter.isObject() || getter.isUndefined());
- ASSERT(setter.isObject() || setter.isUndefined());
- ASSERT(getter.isObject() || setter.isObject());
</del><ins>+void JIT_OPERATION operationPutSetterById(ExecState* exec, JSCell* object, Identifier* identifier, int32_t options, JSCell* setter)
+{
+ VM& vm = exec->vm();
+ NativeCallFrameTracer tracer(&vm, exec);
</ins><span class="cx">
</span><del>- if (!getter.isUndefined())
- accessor->setGetter(vm, exec->lexicalGlobalObject(), asObject(getter));
- if (!setter.isUndefined())
- accessor->setSetter(vm, exec->lexicalGlobalObject(), asObject(setter));
- baseObj->putDirectAccessor(exec, uid, accessor, attribute);
</del><ins>+ ASSERT(object && object->isObject());
+ JSObject* baseObj = object->getObject();
+
+ ASSERT(setter->isObject());
+ baseObj->putSetter(exec, *identifier, setter, options);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-#else
-void JIT_OPERATION operationPutGetterSetter(ExecState* exec, JSCell* object, UniquedStringImpl* uid, int32_t attribute, JSCell* getter, JSCell* setter)
</del><ins>+void JIT_OPERATION operationPutGetterSetter(ExecState* exec, JSCell* object, Identifier* identifier, int32_t attribute, JSCell* getter, JSCell* setter)
</ins><span class="cx"> {
</span><span class="cx"> VM& vm = exec->vm();
</span><span class="cx"> NativeCallFrameTracer tracer(&vm, exec);
</span><span class="cx">
</span><span class="cx"> ASSERT(object && object->isObject());
</span><del>- JSObject* baseObj = asObject(object);
</del><ins>+ JSObject* baseObj = object->getObject();
</ins><span class="cx">
</span><span class="cx"> GetterSetter* accessor = GetterSetter::create(vm, exec->lexicalGlobalObject());
</span><span class="cx">
</span><span class="lines">@@ -1436,8 +1467,25 @@
</span><span class="cx"> accessor->setGetter(vm, exec->lexicalGlobalObject(), getter->getObject());
</span><span class="cx"> if (setter)
</span><span class="cx"> accessor->setSetter(vm, exec->lexicalGlobalObject(), setter->getObject());
</span><del>- baseObj->putDirectAccessor(exec, uid, accessor, attribute);
</del><ins>+ baseObj->putDirectAccessor(exec, *identifier, accessor, attribute);
</ins><span class="cx"> }
</span><ins>+
+void JIT_OPERATION operationPutGetterByVal(ExecState* exec, JSCell* base, EncodedJSValue encodedSubscript, int32_t attribute, JSCell* getter)
+{
+ VM& vm = exec->vm();
+ NativeCallFrameTracer tracer(&vm, exec);
+
+ putAccessorByVal(exec, asObject(base), JSValue::decode(encodedSubscript), attribute, asObject(getter), AccessorType::Getter);
+}
+
+void JIT_OPERATION operationPutSetterByVal(ExecState* exec, JSCell* base, EncodedJSValue encodedSubscript, int32_t attribute, JSCell* setter)
+{
+ VM& vm = exec->vm();
+ NativeCallFrameTracer tracer(&vm, exec);
+
+ putAccessorByVal(exec, asObject(base), JSValue::decode(encodedSubscript), attribute, asObject(setter), AccessorType::Setter);
+}
+
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> void JIT_OPERATION operationPopScope(ExecState* exec, int32_t scopeReg)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITOperationsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITOperations.h (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITOperations.h 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/jit/JITOperations.h 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -189,9 +189,8 @@
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_ECb)(ExecState*, CodeBlock*);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_ECC)(ExecState*, JSCell*, JSCell*);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_ECIcf)(ExecState*, JSCell*, InlineCallFrame*);
</span><del>-typedef void JIT_OPERATION (*V_JITOperation_ECIZC)(ExecState*, JSCell*, UniquedStringImpl*, int32_t, JSCell*);
-typedef void JIT_OPERATION (*V_JITOperation_ECIZCC)(ExecState*, JSCell*, UniquedStringImpl*, int32_t, JSCell*, JSCell*);
-typedef void JIT_OPERATION (*V_JITOperation_ECIZJJ)(ExecState*, JSCell*, UniquedStringImpl*, int32_t, EncodedJSValue, EncodedJSValue);
</del><ins>+typedef void JIT_OPERATION (*V_JITOperation_ECIZC)(ExecState*, JSCell*, Identifier*, int32_t, JSCell*);
+typedef void JIT_OPERATION (*V_JITOperation_ECIZCC)(ExecState*, JSCell*, Identifier*, int32_t, JSCell*, JSCell*);
</ins><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_ECJZC)(ExecState*, JSCell*, EncodedJSValue, int32_t, JSCell*);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_ECCIcf)(ExecState*, JSCell*, JSCell*, InlineCallFrame*);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_ECJJ)(ExecState*, JSCell*, EncodedJSValue, EncodedJSValue);
</span><span class="lines">@@ -201,6 +200,9 @@
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_EZSymtabJ)(ExecState*, int32_t, SymbolTable*, EncodedJSValue);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_EJ)(ExecState*, EncodedJSValue);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_EJCI)(ExecState*, EncodedJSValue, JSCell*, UniquedStringImpl*);
</span><ins>+typedef void JIT_OPERATION (*V_JITOperation_EJIdZJ)(ExecState*, EncodedJSValue, Identifier*, int32_t, EncodedJSValue);
+typedef void JIT_OPERATION (*V_JITOperation_EJIdZJJ)(ExecState*, EncodedJSValue, Identifier*, int32_t, EncodedJSValue, EncodedJSValue);
+typedef void JIT_OPERATION (*V_JITOperation_EJJZJ)(ExecState*, EncodedJSValue, EncodedJSValue, int32_t, EncodedJSValue);
</ins><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_EJJJ)(ExecState*, EncodedJSValue, EncodedJSValue, EncodedJSValue);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_EJJJAp)(ExecState*, EncodedJSValue, EncodedJSValue, EncodedJSValue, ArrayProfile*);
</span><span class="cx"> typedef void JIT_OPERATION (*V_JITOperation_EJJJBy)(ExecState*, EncodedJSValue, EncodedJSValue, EncodedJSValue, ByValInfo*);
</span><span class="lines">@@ -311,14 +313,18 @@
</span><span class="cx"> SlowPathReturnType JIT_OPERATION operationOptimize(ExecState*, int32_t) WTF_INTERNAL;
</span><span class="cx"> #endif
</span><span class="cx"> void JIT_OPERATION operationPutByIndex(ExecState*, EncodedJSValue, int32_t, EncodedJSValue);
</span><del>-void JIT_OPERATION operationPutGetterById(ExecState*, JSCell*, UniquedStringImpl*, int32_t options, JSCell*) WTF_INTERNAL;
-void JIT_OPERATION operationPutSetterById(ExecState*, JSCell*, UniquedStringImpl*, int32_t options, JSCell*) WTF_INTERNAL;
</del><ins>+#if USE(JSVALUE64)
+void JIT_OPERATION operationPutGetterById(ExecState*, EncodedJSValue, Identifier*, int32_t options, EncodedJSValue) WTF_INTERNAL;
+void JIT_OPERATION operationPutSetterById(ExecState*, EncodedJSValue, Identifier*, int32_t options, EncodedJSValue) WTF_INTERNAL;
+void JIT_OPERATION operationPutGetterSetter(ExecState*, EncodedJSValue, Identifier*, int32_t attribute, EncodedJSValue, EncodedJSValue) WTF_INTERNAL;
+void JIT_OPERATION operationPutGetterByVal(ExecState*, EncodedJSValue, EncodedJSValue, int32_t attribute, EncodedJSValue) WTF_INTERNAL;
+void JIT_OPERATION operationPutSetterByVal(ExecState*, EncodedJSValue, EncodedJSValue, int32_t attribute, EncodedJSValue) WTF_INTERNAL;
+#else
+void JIT_OPERATION operationPutGetterById(ExecState*, JSCell*, Identifier*, int32_t options, JSCell*) WTF_INTERNAL;
+void JIT_OPERATION operationPutSetterById(ExecState*, JSCell*, Identifier*, int32_t options, JSCell*) WTF_INTERNAL;
+void JIT_OPERATION operationPutGetterSetter(ExecState*, JSCell*, Identifier*, int32_t attribute, JSCell*, JSCell*) WTF_INTERNAL;
</ins><span class="cx"> void JIT_OPERATION operationPutGetterByVal(ExecState*, JSCell*, EncodedJSValue, int32_t attribute, JSCell*) WTF_INTERNAL;
</span><span class="cx"> void JIT_OPERATION operationPutSetterByVal(ExecState*, JSCell*, EncodedJSValue, int32_t attribute, JSCell*) WTF_INTERNAL;
</span><del>-#if USE(JSVALUE64)
-void JIT_OPERATION operationPutGetterSetter(ExecState*, JSCell*, UniquedStringImpl*, int32_t attribute, EncodedJSValue, EncodedJSValue) WTF_INTERNAL;
-#else
-void JIT_OPERATION operationPutGetterSetter(ExecState*, JSCell*, UniquedStringImpl*, int32_t attribute, JSCell*, JSCell*) WTF_INTERNAL;
</del><span class="cx"> #endif
</span><span class="cx"> void JIT_OPERATION operationPushFunctionNameScope(ExecState*, int32_t, SymbolTable*, EncodedJSValue) WTF_INTERNAL;
</span><span class="cx"> void JIT_OPERATION operationPopScope(ExecState*, int32_t) WTF_INTERNAL;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITPropertyAccesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -492,7 +492,7 @@
</span><span class="cx"> emitGetVirtualRegister(currentInstruction[1].u.operand, regT0);
</span><span class="cx"> int32_t options = currentInstruction[3].u.operand;
</span><span class="cx"> emitGetVirtualRegister(currentInstruction[4].u.operand, regT1);
</span><del>- callOperation(operationPutGetterById, regT0, m_codeBlock->identifier(currentInstruction[2].u.operand).impl(), options, regT1);
</del><ins>+ callOperation(operationPutGetterById, regT0, &m_codeBlock->identifier(currentInstruction[2].u.operand), options, regT1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void JIT::emit_op_put_setter_by_id(Instruction* currentInstruction)
</span><span class="lines">@@ -500,7 +500,7 @@
</span><span class="cx"> emitGetVirtualRegister(currentInstruction[1].u.operand, regT0);
</span><span class="cx"> int32_t options = currentInstruction[3].u.operand;
</span><span class="cx"> emitGetVirtualRegister(currentInstruction[4].u.operand, regT1);
</span><del>- callOperation(operationPutSetterById, regT0, m_codeBlock->identifier(currentInstruction[2].u.operand).impl(), options, regT1);
</del><ins>+ callOperation(operationPutSetterById, regT0, &m_codeBlock->identifier(currentInstruction[2].u.operand), options, regT1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void JIT::emit_op_put_getter_setter(Instruction* currentInstruction)
</span><span class="lines">@@ -509,7 +509,7 @@
</span><span class="cx"> int32_t attribute = currentInstruction[3].u.operand;
</span><span class="cx"> emitGetVirtualRegister(currentInstruction[4].u.operand, regT1);
</span><span class="cx"> emitGetVirtualRegister(currentInstruction[5].u.operand, regT2);
</span><del>- callOperation(operationPutGetterSetter, regT0, m_codeBlock->identifier(currentInstruction[2].u.operand).impl(), attribute, regT1, regT2);
</del><ins>+ callOperation(operationPutGetterSetter, regT0, &m_codeBlock->identifier(currentInstruction[2].u.operand), attribute, regT1, regT2);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void JIT::emit_op_put_getter_by_val(Instruction* currentInstruction)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITPropertyAccess32_64cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx">
</span><span class="cx"> emitLoadPayload(base, regT1);
</span><span class="cx"> emitLoadPayload(getter, regT3);
</span><del>- callOperation(operationPutGetterById, regT1, m_codeBlock->identifier(property).impl(), options, regT3);
</del><ins>+ callOperation(operationPutGetterById, regT1, &m_codeBlock->identifier(property), options, regT3);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void JIT::emit_op_put_setter_by_id(Instruction* currentInstruction)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx">
</span><span class="cx"> emitLoadPayload(base, regT1);
</span><span class="cx"> emitLoadPayload(setter, regT3);
</span><del>- callOperation(operationPutSetterById, regT1, m_codeBlock->identifier(property).impl(), options, regT3);
</del><ins>+ callOperation(operationPutSetterById, regT1, &m_codeBlock->identifier(property), options, regT3);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void JIT::emit_op_put_getter_setter(Instruction* currentInstruction)
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx"> emitLoadPayload(base, regT1);
</span><span class="cx"> emitLoadPayload(getter, regT3);
</span><span class="cx"> emitLoadPayload(setter, regT4);
</span><del>- callOperation(operationPutGetterSetter, regT1, m_codeBlock->identifier(property).impl(), attribute, regT3, regT4);
</del><ins>+ callOperation(operationPutGetterSetter, regT1, &m_codeBlock->identifier(property), attribute, regT3, regT4);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void JIT::emit_op_put_getter_by_val(Instruction* currentInstruction)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputaccessorsbyidclassjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id-class.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id-class.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id-class.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,82 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, false);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function getter()
-{
- class Cocoa {
- get hello() {
- return 42;
- }
- }
-
- let object = new Cocoa();
- testAttribute(object.__proto__, 'hello', 'get');
- return object.hello;
-}
-noInline(getter);
-
-function setter()
-{
- class Cocoa {
- constructor() {
- this.value = 0;
- }
- set hello(value) {
- this.value = value;
- }
- }
-
- let object = new Cocoa();
- testAttribute(object.__proto__, 'hello', 'set');
- object.hello = 42;
- return object.value;
-
-}
-noInline(setter);
-
-function accessors()
-{
- class Cocoa {
- constructor() {
- this.value = 0;
- }
- get hello() {
- return this.value;
- }
- set hello(value) {
- this.value = value;
- }
- }
-
- let object = new Cocoa();
- testAttribute(object.__proto__, 'hello', 'getset');
- object.hello = 42;
- return object.hello;
-}
-noInline(accessors);
-
-for (var i = 0; i < 10000; ++i) {
- shouldBe(getter(), 42);
- shouldBe(setter(), 42);
- shouldBe(accessors(), 42);
-}
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputaccessorsbyidjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-accessors-by-id.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,75 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, true);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function getter()
-{
- var object = {
- get hello() {
- return 42;
- }
- };
-
- testAttribute(object, 'hello', 'get');
- return object.hello;
-}
-noInline(getter);
-
-function setter()
-{
- var object = {
- value: 0,
- set hello(value) {
- this.value = value;
- }
- };
-
- testAttribute(object, 'hello', 'set');
- object.hello = 42;
- return object.value;
-
-}
-noInline(setter);
-
-function accessors()
-{
- var object = {
- value: 0,
- get hello() {
- return this.value;
- },
- set hello(value) {
- this.value = value;
- }
- };
-
- testAttribute(object, 'hello', 'getset');
- object.hello = 42;
- return object.hello;
-}
-noInline(accessors);
-
-for (var i = 0; i < 10000; ++i) {
- shouldBe(getter(), 42);
- shouldBe(setter(), 42);
- shouldBe(accessors(), 42);
-}
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputgetterbyidclassjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id-class.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id-class.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id-class.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,45 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, false);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function getter(name)
-{
- class Cocoa {
- constructor() {
- this.ok = 42;
- }
- get hello() {
- return this.ok;
- }
- get [name]() {
- }
- }
-
- let object = new Cocoa();
- testAttribute(object.__proto__, 'hello', 'get');
- testAttribute(object.__proto__, 'dummy', 'get');
- return object.hello;
-}
-noInline(getter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(getter('dummy'), 42);
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputgetterbyidjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-id.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,39 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, true);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function getter(name)
-{
- var object = {
- get hello() {
- return this.ok;
- },
- [name]: 42
- };
-
- testAttribute(object, 'hello', 'get');
- return object.hello;
-}
-noInline(getter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(getter('ok'), 42);
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputgetterbyvalclassjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val-class.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val-class.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val-class.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,42 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, false);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function getter(name)
-{
- class Cocoa {
- constructor() {
- this.ok = 42;
- }
- get [name]() {
- return this.ok;
- }
- }
-
- let object = new Cocoa();
- testAttribute(object.__proto__, 'hello', 'get');
- return object.hello;
-}
-noInline(getter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(getter('hello'), 42);
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputgetterbyvaljs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-getter-by-val.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,39 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, true);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function getter(name)
-{
- var object = {
- ok: 42,
- get [name]() {
- return this.ok;
- }
- };
-
- testAttribute(object, 'hello', 'get');
- return object.hello;
-}
-noInline(getter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(getter('hello'), 42);
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputsetterbyidclassjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id-class.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id-class.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id-class.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,46 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, false);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function getter(name)
-{
- class Cocoa {
- constructor() {
- this.ok = 0;
- }
- set hello(value) {
- this.ok = value;
- }
- get [name]() {
- }
- }
-
- let object = new Cocoa();
- testAttribute(object.__proto__, 'hello', 'set');
- testAttribute(object.__proto__, 'dummy', 'get');
- object.hello = 42;
- return object.ok;
-}
-noInline(getter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(getter('dummy'), 42);
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputsetterbyidjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-id.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,41 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, true);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function setter(name)
-{
- var object = {
- set hello(value) {
- this.ok = value;
- },
- [name]: 0
- };
-
- testAttribute(object, 'hello', 'set');
- object.hello = 42;
- return object.ok;
-
-}
-noInline(setter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(setter('ok'), 42);
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputsetterbyvalclassjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val-class.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val-class.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val-class.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,44 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, false);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function setter(name)
-{
- class Cocoa {
- constructor() {
- this.ok = 0;
- }
- set [name](value) {
- this.ok = value;
- }
- }
-
- let object = new Cocoa();
- testAttribute(object.__proto__, 'hello', 'set');
- object.hello = 42;
- return object.ok;
-
-}
-noInline(setter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(setter('hello'), 42);
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgputsetterbyvaljs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val.js (191528 => 191529)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val.js 2015-10-24 01:11:36 UTC (rev 191528)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-put-setter-by-val.js 2015-10-24 01:26:22 UTC (rev 191529)
</span><span class="lines">@@ -1,41 +0,0 @@
</span><del>-function shouldBe(actual, expected) {
- if (actual !== expected)
- throw new Error('bad value: ' + actual);
-}
-
-function testAttribute(object, name, type) {
- shouldBe(Reflect.has(object, name), true);
- let desc = Reflect.getOwnPropertyDescriptor(object, name);
- shouldBe(desc.configurable, true);
- shouldBe(desc.enumerable, true);
- if (type === 'get') {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'undefined');
- } else if (type === 'set') {
- shouldBe(typeof desc.get, 'undefined');
- shouldBe(typeof desc.set, 'function');
- } else {
- shouldBe(typeof desc.get, 'function');
- shouldBe(typeof desc.set, 'function');
- }
-}
-noInline(testAttribute);
-
-function setter(name)
-{
- var object = {
- ok: 0,
- set [name](value) {
- this.ok = value;
- }
- };
-
- testAttribute(object, 'hello', 'set');
- object.hello = 42;
- return object.ok;
-
-}
-noInline(setter);
-
-for (var i = 0; i < 10000; ++i)
- shouldBe(setter('hello'), 42);
</del></span></pre>
</div>
</div>
</body>
</html>