<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191524] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191524">191524</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-23 17:46:06 -0700 (Fri, 23 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unnecessary details from Other Crashes section
https://bugs.webkit.org/show_bug.cgi?id=150514
<rdar://problem/23235458>
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-23
Reviewed by Alexey Proskuryakov.
* fast/harness/results.html: Create separate other-crash-tests-table.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastharnessresultshtml">trunk/LayoutTests/fast/harness/results.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (191523 => 191524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-24 00:44:23 UTC (rev 191523)
+++ trunk/LayoutTests/ChangeLog 2015-10-24 00:46:06 UTC (rev 191524)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-10-23 Aakash Jain <aakash_jain@apple.com>
+
+ Remove unnecessary details from Other Crashes section
+ https://bugs.webkit.org/show_bug.cgi?id=150514
+ <rdar://problem/23235458>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * fast/harness/results.html: Create separate other-crash-tests-table.
+
</ins><span class="cx"> 2015-10-23 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking more http/tests/xmlhttprequest/timeout/ tests as flaky, removing Yosemite-only flag
</span></span></pre></div>
<a id="trunkLayoutTestsfastharnessresultshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/harness/results.html (191523 => 191524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/harness/results.html 2015-10-24 00:44:23 UTC (rev 191523)
+++ trunk/LayoutTests/fast/harness/results.html 2015-10-24 00:46:06 UTC (rev 191524)
</span><span class="lines">@@ -494,6 +494,11 @@
</span><span class="cx"> return '<span class=expand-button onclick="toggleExpectations(this)"><span class=expand-button-text>+</span></span>' + testLink(test);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function testWithExpandButton(test)
+{
+ return '<span class=expand-button onclick="toggleExpectations(this)"><span class=expand-button-text>+</span></span>' + test;
+}
+
</ins><span class="cx"> function resultLink(testPrefix, suffix, contents)
</span><span class="cx"> {
</span><span class="cx"> return '<a class=result-link href="' + testPrefix + suffix + '" data-prefix="' + testPrefix + '">' + contents + '</a> ';
</span><span class="lines">@@ -769,13 +774,21 @@
</span><span class="cx"> if (globalState().results.uses_expectations_file)
</span><span class="cx"> html += ' class="' + ((testObject.isExpected && tableId != 'stderr-table') ? 'expected' : '') + '"';
</span><span class="cx"> html += '><tr><td>';
</span><del>- html += (tableId == 'passes-table') ? testLink(test) : testLinkWithExpandButton(test);
</del><ins>+ if (tableId == 'passes-table')
+ html += testLink(test);
+ else if (tableId == 'other-crash-tests-table')
+ html += testWithExpandButton(test);
+ else
+ html += testLinkWithExpandButton(test);
+
</ins><span class="cx"> html += '</td><td>';
</span><span class="cx">
</span><span class="cx"> if (tableId == 'stderr-table')
</span><span class="cx"> html += resultLink(stripExtension(test), '-stderr.txt', 'stderr');
</span><span class="cx"> else if (tableId == 'passes-table')
</span><span class="cx"> html += testObject.expected;
</span><ins>+ else if (tableId == 'other-crash-tests-table')
+ html += resultLink(stripExtension(test), '-crash-log.txt', 'crash log');
</ins><span class="cx"> else if (tableId == 'crash-tests-table') {
</span><span class="cx"> html += resultLink(stripExtension(test), '-crash-log.txt', 'crash log');
</span><span class="cx"> html += resultLink(stripExtension(test), '-sample.txt', 'sample');
</span><span class="lines">@@ -784,7 +797,8 @@
</span><span class="cx"> html += textResultLinks(stripExtension(test));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- html += '</td><td><a href="' + flakinessDashboardURLForTests([testObject]) + '">history</a></td>';
</del><ins>+ if (tableId != 'other-crash-tests-table')
+ html += '</td><td><a href="' + flakinessDashboardURLForTests([testObject]) + '">history</a></td>';
</ins><span class="cx">
</span><span class="cx"> html += '</tr></tbody>';
</span><span class="cx"> }
</span><span class="lines">@@ -1386,7 +1400,7 @@
</span><span class="cx"> html += testList(globalState().crashTests, 'Tests that crashed', 'crash-tests-table');
</span><span class="cx">
</span><span class="cx"> if (globalState().crashOther.length)
</span><del>- html += testList(globalState().crashOther, 'Other Crashes', 'crash-tests-table');
</del><ins>+ html += testList(globalState().crashOther, 'Other Crashes', 'other-crash-tests-table');
</ins><span class="cx">
</span><span class="cx"> html += failingTestsTable(globalState().failingTests,
</span><span class="cx"> 'Tests that failed text/pixel/audio diff', 'results-table');
</span></span></pre>
</div>
</div>
</body>
</html>