<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191398] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191398">191398</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-10-21 13:04:12 -0700 (Wed, 21 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>bgsound should use HTMLUnknownElement interface
https://bugs.webkit.org/show_bug.cgi?id=148857
<rdar://problem/22589036>
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline a couple of W3C HTML tests now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
The blink, bgsound, isindex, multicol, nextid, and spacer elements must
use the HTMLUnknownElement interface, as per the HTML specification:
https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis
WebKit was using HTMLUnknownElement for all of them except bgsound.
This patch fixes the issue and aligns our behavior with Chrome and
Firefox.
No new tests, already covered by existing tests.
* html/HTMLTagNames.in:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsinterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTagNamesin">trunk/Source/WebCore/html/HTMLTagNames.in</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (191397 => 191398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-10-21 20:04:12 UTC (rev 191398)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-10-21 Chris Dumez <cdumez@apple.com>
+
+ bgsound should use HTMLUnknownElement interface
+ https://bugs.webkit.org/show_bug.cgi?id=148857
+ <rdar://problem/22589036>
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline a couple of W3C HTML tests now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+ * web-platform-tests/html/semantics/interfaces-expected.txt:
+
</ins><span class="cx"> 2015-10-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> W3C test importer should not import reference files as regular tests
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (191397 => 191398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-10-21 20:04:12 UTC (rev 191398)
</span><span class="lines">@@ -148,10 +148,6 @@
</span><span class="cx"> CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
</span><span class="cx"> CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
</span><span class="cx"> CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
</span><del>-CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
</del><span class="cx"> CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'version' on a non-HTMLHtmlElement object.
</span><span class="cx"> CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'text' on a non-HTMLTitleElement object.
</span><span class="cx"> CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'href' on a non-HTMLBaseElement object.
</span><span class="lines">@@ -2230,8 +2226,8 @@
</span><span class="cx"> PASS Stringification of document.createElement("blink")
</span><span class="cx"> PASS HTMLUnknownElement must be primary interface of document.createElement("quasit")
</span><span class="cx"> PASS Stringification of document.createElement("quasit")
</span><del>-FAIL HTMLUnknownElement must be primary interface of document.createElement("bgsound") assert_equals: document.createElement("bgsound")'s prototype is not HTMLUnknownElement.prototype expected Node object of unknown type but got Node object of unknown type
-FAIL Stringification of document.createElement("bgsound") assert_equals: class string of document.createElement("bgsound") expected "[object HTMLUnknownElement]" but got "[object HTMLElement]"
</del><ins>+PASS HTMLUnknownElement must be primary interface of document.createElement("bgsound")
+PASS Stringification of document.createElement("bgsound")
</ins><span class="cx"> PASS HTMLUnknownElement must be primary interface of document.createElement("isindex")
</span><span class="cx"> PASS Stringification of document.createElement("isindex")
</span><span class="cx"> PASS HTMLUnknownElement must be primary interface of document.createElement("multicol")
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsinterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt (191397 => 191398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt 2015-10-21 20:04:12 UTC (rev 191398)
</span><span class="lines">@@ -17,8 +17,8 @@
</span><span class="cx"> FAIL Interfaces for BASEFONT assert_equals: Element BASEFONT should have HTMLUnknownElement as its primary interface. expected "[object HTMLUnknownElement]" but got "[object HTMLBaseFontElement]"
</span><span class="cx"> PASS Interfaces for bdo
</span><span class="cx"> PASS Interfaces for BDO
</span><del>-FAIL Interfaces for bgsound assert_equals: Element bgsound should have HTMLUnknownElement as its primary interface. expected "[object HTMLUnknownElement]" but got "[object HTMLElement]"
-FAIL Interfaces for BGSOUND assert_equals: Element BGSOUND should have HTMLUnknownElement as its primary interface. expected "[object HTMLUnknownElement]" but got "[object HTMLElement]"
</del><ins>+PASS Interfaces for bgsound
+PASS Interfaces for BGSOUND
</ins><span class="cx"> PASS Interfaces for big
</span><span class="cx"> PASS Interfaces for BIG
</span><span class="cx"> PASS Interfaces for blink
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191397 => 191398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/Source/WebCore/ChangeLog 2015-10-21 20:04:12 UTC (rev 191398)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-10-21 Chris Dumez <cdumez@apple.com>
+
+ bgsound should use HTMLUnknownElement interface
+ https://bugs.webkit.org/show_bug.cgi?id=148857
+ <rdar://problem/22589036>
+
+ Reviewed by Sam Weinig.
+
+ The blink, bgsound, isindex, multicol, nextid, and spacer elements must
+ use the HTMLUnknownElement interface, as per the HTML specification:
+ https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis
+
+ WebKit was using HTMLUnknownElement for all of them except bgsound.
+ This patch fixes the issue and aligns our behavior with Chrome and
+ Firefox.
+
+ No new tests, already covered by existing tests.
+
+ * html/HTMLTagNames.in:
+
</ins><span class="cx"> 2015-10-21 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> Support for the SVG `onend` attribute
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTagNamesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTagNames.in (191397 => 191398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTagNames.in 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/Source/WebCore/html/HTMLTagNames.in 2015-10-21 20:04:12 UTC (rev 191398)
</span><span class="lines">@@ -18,7 +18,7 @@
</span><span class="cx"> basefont interfaceName=HTMLBaseFontElement
</span><span class="cx"> bdi interfaceName=HTMLBDIElement, JSInterfaceName=HTMLElement
</span><span class="cx"> bdo interfaceName=HTMLElement
</span><del>-bgsound interfaceName=HTMLElement
</del><ins>+bgsound interfaceName=HTMLUnknownElement
</ins><span class="cx"> big interfaceName=HTMLElement
</span><span class="cx"> blockquote interfaceName=HTMLQuoteElement
</span><span class="cx"> body
</span></span></pre>
</div>
</div>
</body>
</html>