<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191392] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191392">191392</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-21 11:29:39 -0700 (Wed, 21 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Support for the SVG `onend` attribute
https://bugs.webkit.org/show_bug.cgi?id=150393
Patch by Antoine Quint <graouts@apple.com> on 2015-10-21
Reviewed by Dean Jackson.
Source/WebCore:
Add support for the SVG `onend` attribute to SVG timing and animation elements, which allow the definition
of a JS event listener declaratively for the SVG `endEvent` event.
Tests: svg/animations/end-event-attribute-expected.svg
svg/animations/end-event-attribute.svg
svg/animations/end-event-syncbase-expected.svg
svg/animations/end-event-syncbase.svg
* dom/EventNames.h:
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseAttribute):
* svg/svgattrs.in:
LayoutTests:
Create a new test for the `onend` attribute and rename the previously-named "end-event-declarative.svg" test to
"end-event-syncbase.svg" since the term "declarative" was a little loose.
* svg/animations/end-event-attribute-expected.svg: Copied from LayoutTests/svg/animations/end-event-declarative-expected.svg.
* svg/animations/end-event-attribute.svg: Copied from LayoutTests/svg/animations/end-event-declarative.svg.
* svg/animations/end-event-syncbase-expected.svg: Renamed from LayoutTests/svg/animations/end-event-declarative-expected.svg.
* svg/animations/end-event-syncbase.svg: Renamed from LayoutTests/svg/animations/end-event-declarative.svg.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventNamesh">trunk/Source/WebCore/dom/EventNames.h</a></li>
<li><a href="#trunkSourceWebCoresvganimationSVGSMILElementcpp">trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgsvgattrsin">trunk/Source/WebCore/svg/svgattrs.in</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvganimationsendeventattributeexpectedsvg">trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg</a></li>
<li><a href="#trunkLayoutTestssvganimationsendeventattributesvg">trunk/LayoutTests/svg/animations/end-event-attribute.svg</a></li>
<li><a href="#trunkLayoutTestssvganimationsendeventsyncbaseexpectedsvg">trunk/LayoutTests/svg/animations/end-event-syncbase-expected.svg</a></li>
<li><a href="#trunkLayoutTestssvganimationsendeventsyncbasesvg">trunk/LayoutTests/svg/animations/end-event-syncbase.svg</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvganimationsendeventdeclarativeexpectedsvg">trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg</a></li>
<li><a href="#trunkLayoutTestssvganimationsendeventdeclarativesvg">trunk/LayoutTests/svg/animations/end-event-declarative.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (191391 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/LayoutTests/ChangeLog 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-10-21 Antoine Quint <graouts@apple.com>
+
+ Support for the SVG `onend` attribute
+ https://bugs.webkit.org/show_bug.cgi?id=150393
+
+ Reviewed by Dean Jackson.
+
+ Create a new test for the `onend` attribute and rename the previously-named "end-event-declarative.svg" test to
+ "end-event-syncbase.svg" since the term "declarative" was a little loose.
+
+ * svg/animations/end-event-attribute-expected.svg: Copied from LayoutTests/svg/animations/end-event-declarative-expected.svg.
+ * svg/animations/end-event-attribute.svg: Copied from LayoutTests/svg/animations/end-event-declarative.svg.
+ * svg/animations/end-event-syncbase-expected.svg: Renamed from LayoutTests/svg/animations/end-event-declarative-expected.svg.
+ * svg/animations/end-event-syncbase.svg: Renamed from LayoutTests/svg/animations/end-event-declarative.svg.
+
</ins><span class="cx"> 2015-10-21 Nan Wang <n_wang@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Expose table size and cell indexes on iOS
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsendeventattributeexpectedsvgfromrev191391trunkLayoutTestssvganimationsendeventdeclarativeexpectedsvg"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg (from rev 191391, trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg) (0 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-attribute-expected.svg 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd">
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <rect x="0" y="0" width="50" height="50" fill="green" />
+</svg>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsendeventattributesvgfromrev191391trunkLayoutTestssvganimationsendeventdeclarativesvg"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/svg/animations/end-event-attribute.svg (from rev 191391, trunk/LayoutTests/svg/animations/end-event-declarative.svg) (0 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/end-event-attribute.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-attribute.svg 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd">
+<svg onload="loaded()" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+<rect id="rect" x="0" y="0" width="50" height="50" fill="red">
+ <animate id="anim" attributeName="visibility" to="visible" begin="0s" end="2s" onend="handleEndEvent()" />
+</rect>
+<script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function handleEndEvent(event) {
+ document.getElementById("rect").setAttribute("fill", "green");
+ testRunner.notifyDone();
+ }
+
+ function loaded() {
+ document.documentElement.setCurrentTime(2);
+ }
+
+</script>
+</svg>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsendeventdeclarativeexpectedsvg"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg (191391 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg 2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -1,5 +0,0 @@
</span><del>-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd">
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
- <rect x="0" y="0" width="50" height="50" fill="green" />
-</svg>
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsendeventdeclarativesvg"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/svg/animations/end-event-declarative.svg (191391 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/end-event-declarative.svg 2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/LayoutTests/svg/animations/end-event-declarative.svg 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -1,19 +0,0 @@
</span><del>-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd">
-<svg onload="loaded()" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
-<rect x="0" y="0" width="50" height="50" fill="red">
- <animate id="anim" attributeName="visibility" to="visible" begin="0s" end="2s" />
- <set attributeName="fill" to="green" begin="anim.endEvent" />
-</rect>
-<script>
- if (window.testRunner)
- testRunner.waitUntilDone();
-
- function loaded() {
- document.documentElement.setCurrentTime(2);
-
- if (window.testRunner)
- setTimeout(function() {testRunner.notifyDone();}, 100);
- }
-</script>
-</svg>
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsendeventsyncbaseexpectedsvgfromrev191391trunkLayoutTestssvganimationsendeventdeclarativeexpectedsvg"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/svg/animations/end-event-syncbase-expected.svg (from rev 191391, trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg) (0 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/end-event-syncbase-expected.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-syncbase-expected.svg 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd">
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <rect x="0" y="0" width="50" height="50" fill="green" />
+</svg>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestssvganimationsendeventsyncbasesvgfromrev191391trunkLayoutTestssvganimationsendeventdeclarativesvg"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/svg/animations/end-event-syncbase.svg (from rev 191391, trunk/LayoutTests/svg/animations/end-event-declarative.svg) (0 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/animations/end-event-syncbase.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-syncbase.svg 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd">
+<svg onload="loaded()" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+<rect x="0" y="0" width="50" height="50" fill="red">
+ <animate id="anim" attributeName="visibility" to="visible" begin="0s" end="2s" />
+ <set attributeName="fill" to="green" begin="anim.endEvent" />
+</rect>
+<script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function loaded() {
+ document.documentElement.setCurrentTime(2);
+
+ if (window.testRunner)
+ setTimeout(function() {testRunner.notifyDone();}, 100);
+ }
+</script>
+</svg>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191391 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/Source/WebCore/ChangeLog 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-10-21 Antoine Quint <graouts@apple.com>
+
+ Support for the SVG `onend` attribute
+ https://bugs.webkit.org/show_bug.cgi?id=150393
+
+ Reviewed by Dean Jackson.
+
+ Add support for the SVG `onend` attribute to SVG timing and animation elements, which allow the definition
+ of a JS event listener declaratively for the SVG `endEvent` event.
+
+ Tests: svg/animations/end-event-attribute-expected.svg
+ svg/animations/end-event-attribute.svg
+ svg/animations/end-event-syncbase-expected.svg
+ svg/animations/end-event-syncbase.svg
+
+ * dom/EventNames.h:
+ * svg/animation/SVGSMILElement.cpp:
+ (WebCore::SVGSMILElement::parseAttribute):
+ * svg/svgattrs.in:
+
</ins><span class="cx"> 2015-10-21 Nan Wang <n_wang@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Expose table size and cell indexes on iOS
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventNamesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventNames.h (191391 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventNames.h 2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/Source/WebCore/dom/EventNames.h 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -96,6 +96,7 @@
</span><span class="cx"> macro(durationchange) \
</span><span class="cx"> macro(emptied) \
</span><span class="cx"> macro(end) \
</span><ins>+ macro(endEvent) \
</ins><span class="cx"> macro(ended) \
</span><span class="cx"> macro(enter) \
</span><span class="cx"> macro(error) \
</span></span></pre></div>
<a id="trunkSourceWebCoresvganimationSVGSMILElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp (191391 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -480,6 +480,8 @@
</span><span class="cx"> parseBeginOrEnd(value.string(), End);
</span><span class="cx"> if (inDocument())
</span><span class="cx"> connectConditions();
</span><ins>+ } else if (name == SVGNames::onendAttr) {
+ setAttributeEventListener(eventNames().endEventEvent, name, value);
</ins><span class="cx"> } else
</span><span class="cx"> SVGElement::parseAttribute(name, value);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgsvgattrsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/svgattrs.in (191391 => 191392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/svgattrs.in 2015-10-21 17:46:40 UTC (rev 191391)
+++ trunk/Source/WebCore/svg/svgattrs.in 2015-10-21 18:29:39 UTC (rev 191392)
</span><span class="lines">@@ -128,6 +128,7 @@
</span><span class="cx"> name
</span><span class="cx"> numOctaves
</span><span class="cx"> offset
</span><ins>+onend
</ins><span class="cx"> onzoom
</span><span class="cx"> opacity
</span><span class="cx"> operator
</span></span></pre>
</div>
</div>
</body>
</html>