<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191332] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191332">191332</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-19 23:18:15 -0700 (Mon, 19 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>ASSERTION FAILED: m_state == Initialized in SubresourceLoader::didReceiveResponse()
https://bugs.webkit.org/show_bug.cgi?id=150327
Reviewed by Antti Koivisto.
This is how it happens:
1. print() is called while the document is still loading, so
m_shouldPrintWhenFinishedLoading is set to true
2. DataURLDecoder::decode() finishes in the work queue thread,
the completion handler is scheduled in the main thread
3. The load is cancelled
3.1. SubresourceLoader::willCancel sets m_state = Finishing
3.2. DOMWindow::finishedLoading() is called, and since
m_shouldPrintWhenFinishedLoading is true, it does the print.
3.3. Cancellation finishes and ResourceLoader::releaseResources()
is called that sets m_reachedTerminalState = true
So, between 3.1 and 3.3, the state is Finishing, but
m_reachedTerminalState is false. What happens, in the GTK+ port at
least, is that the nested main loop used to make print()
synchronous, processes the DataURLDecoder::decode() completion
handler that was pending. The completion handler returns early if
m_reachedTerminalState is true, but it's not yet in this
particular case. So, it ends up calling didReceiveResponse,
because the decode didn't fail, when the subresource loader state
is Finishing.
I think there are two things here. One is that we shouldn't start
a print that was waiting for the load to finish when it
failed. That would fix the problem. But it's probably a good idea
to also check for cancellation in the DataURLDecoder::decode()
completion handler.
Fixes printing/print-close-crash.html in GTK+ Debug.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL): Return early from
DataURLDecoder::decode() completion handler if the load was cancelled.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::finishedLoading): Do not start a print that
was witing for the load to finish when it failed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderResourceLoadercpp">trunk/Source/WebCore/loader/ResourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191331 => 191332)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-20 04:55:27 UTC (rev 191331)
+++ trunk/Source/WebCore/ChangeLog 2015-10-20 06:18:15 UTC (rev 191332)
</span><span class="lines">@@ -1,3 +1,48 @@
</span><ins>+2015-10-19 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ ASSERTION FAILED: m_state == Initialized in SubresourceLoader::didReceiveResponse()
+ https://bugs.webkit.org/show_bug.cgi?id=150327
+
+ Reviewed by Antti Koivisto.
+
+ This is how it happens:
+
+ 1. print() is called while the document is still loading, so
+ m_shouldPrintWhenFinishedLoading is set to true
+ 2. DataURLDecoder::decode() finishes in the work queue thread,
+ the completion handler is scheduled in the main thread
+ 3. The load is cancelled
+ 3.1. SubresourceLoader::willCancel sets m_state = Finishing
+ 3.2. DOMWindow::finishedLoading() is called, and since
+ m_shouldPrintWhenFinishedLoading is true, it does the print.
+ 3.3. Cancellation finishes and ResourceLoader::releaseResources()
+ is called that sets m_reachedTerminalState = true
+
+ So, between 3.1 and 3.3, the state is Finishing, but
+ m_reachedTerminalState is false. What happens, in the GTK+ port at
+ least, is that the nested main loop used to make print()
+ synchronous, processes the DataURLDecoder::decode() completion
+ handler that was pending. The completion handler returns early if
+ m_reachedTerminalState is true, but it's not yet in this
+ particular case. So, it ends up calling didReceiveResponse,
+ because the decode didn't fail, when the subresource loader state
+ is Finishing.
+
+ I think there are two things here. One is that we shouldn't start
+ a print that was waiting for the load to finish when it
+ failed. That would fix the problem. But it's probably a good idea
+ to also check for cancellation in the DataURLDecoder::decode()
+ completion handler.
+
+ Fixes printing/print-close-crash.html in GTK+ Debug.
+
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::loadDataURL): Return early from
+ DataURLDecoder::decode() completion handler if the load was cancelled.
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::finishedLoading): Do not start a print that
+ was witing for the load to finish when it failed.
+
</ins><span class="cx"> 2015-10-19 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> FontCascade::typesettingFeatures() is not privy to font-variant-* nor font-feature-settings
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderResourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (191331 => 191332)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ResourceLoader.cpp 2015-10-20 04:55:27 UTC (rev 191331)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2015-10-20 06:18:15 UTC (rev 191332)
</span><span class="lines">@@ -256,6 +256,8 @@
</span><span class="cx"> loader->didFail(ResourceError(errorDomainWebKitInternal, 0, url.string(), "Data URL decoding failed"));
</span><span class="cx"> return;
</span><span class="cx"> }
</span><ins>+ if (loader->wasCancelled())
+ return;
</ins><span class="cx"> auto& result = decodeResult.value();
</span><span class="cx"> auto dataSize = result.data->size();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (191331 => 191332)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp 2015-10-20 04:55:27 UTC (rev 191331)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2015-10-20 06:18:15 UTC (rev 191332)
</span><span class="lines">@@ -1987,7 +1987,8 @@
</span><span class="cx"> {
</span><span class="cx"> if (m_shouldPrintWhenFinishedLoading) {
</span><span class="cx"> m_shouldPrintWhenFinishedLoading = false;
</span><del>- print();
</del><ins>+ if (m_frame->loader().activeDocumentLoader()->mainDocumentError().isNull())
+ print();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>