<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191175] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191175">191175</a></dd>
<dt>Author</dt> <dd>msaboff@apple.com</dd>
<dt>Date</dt> <dd>2015-10-16 07:43:02 -0700 (Fri, 16 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/190289">r190289</a>): Repro crash clicking back button on netflix.com
https://bugs.webkit.org/show_bug.cgi?id=150220
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Since constructors check for a valid new "this" object and return it, we can't make
a tail call to another function from within a constructor.
Re-enabled the tail calls and the related tail call tests.
Did some other miscellaneous clean up in the tail call code as part of the debugging.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):
* interpreter/Interpreter.h:
(JSC::calleeFrameForVarargs):
* runtime/Options.h:
* tests/es6.yaml:
* tests/stress/dfg-tail-calls.js:
(nonInlinedTailCall.callee):
* tests/stress/mutual-tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-in-inline-cache.js:
(tail):
* tests/stress/tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-recognize.js:
(callerMustBeRun):
* tests/stress/tail-call-varargs-no-stack-overflow.js:
(shouldThrow):
LayoutTests:
Added a new regression test. Changed the expected output of caller-property
to correspond with tail calls enabled.
* js/caller-property-expected.txt:
* js/regress-150220-expected.tx: Added.
* js/regress-150220.html: Added.
* js/script-tests/regress-150220.js: Added.
(Obj):
(SubObj):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjscallerpropertyexpectedtxt">trunk/LayoutTests/js/caller-property-expected.txt</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecompilerBytecodeGeneratorcpp">trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreftlFTLLowerDFGToLLVMcpp">trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreinterpreterInterpreterh">trunk/Source/JavaScriptCore/interpreter/Interpreter.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsh">trunk/Source/JavaScriptCore/runtime/Options.h</a></li>
<li><a href="#trunkSourceJavaScriptCoretestses6yaml">trunk/Source/JavaScriptCore/tests/es6.yaml</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressdfgtailcallsjs">trunk/Source/JavaScriptCore/tests/stress/dfg-tail-calls.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressmutualtailcallnostackoverflowjs">trunk/Source/JavaScriptCore/tests/stress/mutual-tail-call-no-stack-overflow.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstresstailcallininlinecachejs">trunk/Source/JavaScriptCore/tests/stress/tail-call-in-inline-cache.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstresstailcallnostackoverflowjs">trunk/Source/JavaScriptCore/tests/stress/tail-call-no-stack-overflow.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstresstailcallrecognizejs">trunk/Source/JavaScriptCore/tests/stress/tail-call-recognize.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstresstailcallvarargsnostackoverflowjs">trunk/Source/JavaScriptCore/tests/stress/tail-call-varargs-no-stack-overflow.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsregress150220html">trunk/LayoutTests/js/regress-150220.html</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsregress150220js">trunk/LayoutTests/js/script-tests/regress-150220.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/LayoutTests/ChangeLog 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-10-15 Michael Saboff <msaboff@apple.com>
+
+ REGRESSION (r190289): Repro crash clicking back button on netflix.com
+ https://bugs.webkit.org/show_bug.cgi?id=150220
+
+ Reviewed by Geoffrey Garen.
+
+ Added a new regression test. Changed the expected output of caller-property
+ to correspond with tail calls enabled.
+
+ * js/caller-property-expected.txt:
+ * js/regress-150220-expected.tx: Added.
+ * js/regress-150220.html: Added.
+ * js/script-tests/regress-150220.js: Added.
+ (Obj):
+ (SubObj):
+
</ins><span class="cx"> 2015-10-16 Hunseop Jeong <hs85.jeong@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed EFL Gardening on 15th Oct.
</span></span></pre></div>
<a id="trunkLayoutTestsjscallerpropertyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/caller-property-expected.txt (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/caller-property-expected.txt 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/LayoutTests/js/caller-property-expected.txt 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -10,13 +10,13 @@
</span><span class="cx"> PASS nonStrictCaller(strictCallee) threw exception TypeError: Type error.
</span><span class="cx"> PASS strictCaller(nonStrictCallee) threw exception TypeError: Function.caller used to retrieve strict caller.
</span><span class="cx"> PASS strictCaller(strictCallee) threw exception TypeError: Type error.
</span><del>-FAIL strictTailCaller(nonStrictCallee) should be null. Threw exception TypeError: Function.caller used to retrieve strict caller
</del><ins>+PASS strictTailCaller(nonStrictCallee) is null
</ins><span class="cx"> PASS strictTailCaller(strictCallee) threw exception TypeError: Type error.
</span><span class="cx"> PASS nonStrictCaller(boundNonStrictCallee) is nonStrictCaller
</span><span class="cx"> PASS nonStrictCaller(boundStrictCallee) threw exception TypeError: Type error.
</span><span class="cx"> PASS strictCaller(boundNonStrictCallee) threw exception TypeError: Function.caller used to retrieve strict caller.
</span><span class="cx"> PASS strictCaller(boundStrictCallee) threw exception TypeError: Type error.
</span><del>-FAIL strictTailCaller(boundNonStrictCallee) should be null. Threw exception TypeError: Function.caller used to retrieve strict caller
</del><ins>+PASS strictTailCaller(boundNonStrictCallee) is null
</ins><span class="cx"> PASS strictTailCaller(boundStrictCallee) threw exception TypeError: Type error.
</span><span class="cx"> PASS nonStrictGetter(nonStrictAccessor) is nonStrictGetter
</span><span class="cx"> PASS nonStrictSetter(nonStrictAccessor) is true
</span></span></pre></div>
<a id="trunkLayoutTestsjsregress150220html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/regress-150220.html (0 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regress-150220.html (rev 0)
+++ trunk/LayoutTests/js/regress-150220.html 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="script-tests/regress-150220.js"></script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsregress150220js"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/script-tests/regress-150220.js (0 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/regress-150220.js (rev 0)
+++ trunk/LayoutTests/js/script-tests/regress-150220.js 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+description("Regression test for https://webkit.org/b/150220.");
+
+// This test verifies that a tail call from a constructor doesn't crash and works correctly.
+
+function Obj(name) {
+ "use strict";
+ this.name = name;
+}
+
+function SubObj(name) {
+ "use strict";
+ return Obj.apply(this, arguments);
+}
+
+for (var i = 0; i < 10000; i++) {
+ if (new SubObj("Test").name != "Test")
+ testFailed("Object doesn't have property \"name\" with value of \"Test\"");
+}
+
+testPassed("Properly handled a tail call from a constructor.");
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2015-10-15 Michael Saboff <msaboff@apple.com>
+
+ REGRESSION (r190289): Repro crash clicking back button on netflix.com
+ https://bugs.webkit.org/show_bug.cgi?id=150220
+
+ Reviewed by Geoffrey Garen.
+
+ Since constructors check for a valid new "this" object and return it, we can't make
+ a tail call to another function from within a constructor.
+
+ Re-enabled the tail calls and the related tail call tests.
+
+ Did some other miscellaneous clean up in the tail call code as part of the debugging.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ * ftl/FTLLowerDFGToLLVM.cpp:
+ (JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):
+ * interpreter/Interpreter.h:
+ (JSC::calleeFrameForVarargs):
+ * runtime/Options.h:
+ * tests/es6.yaml:
+ * tests/stress/dfg-tail-calls.js:
+ (nonInlinedTailCall.callee):
+ * tests/stress/mutual-tail-call-no-stack-overflow.js:
+ (shouldThrow):
+ * tests/stress/tail-call-in-inline-cache.js:
+ (tail):
+ * tests/stress/tail-call-no-stack-overflow.js:
+ (shouldThrow):
+ * tests/stress/tail-call-recognize.js:
+ (callerMustBeRun):
+ * tests/stress/tail-call-varargs-no-stack-overflow.js:
+ (shouldThrow):
+
</ins><span class="cx"> 2015-10-15 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. Attempted EFL build fix 2 after r191159.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecompilerBytecodeGeneratorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -198,7 +198,7 @@
</span><span class="cx"> // op_will_call / op_did_call pairs before and after a call, which are not
</span><span class="cx"> // compatible with tail calls (we have no way of emitting op_did_call).
</span><span class="cx"> // https://bugs.webkit.org/show_bug.cgi?id=148819
</span><del>- , m_inTailPosition(Options::useTailCalls() && constructorKind() == ConstructorKind::None && isStrictMode() && !m_shouldEmitProfileHooks)
</del><ins>+ , m_inTailPosition(Options::useTailCalls() && !isConstructor() && constructorKind() == ConstructorKind::None && isStrictMode() && !m_shouldEmitProfileHooks)
</ins><span class="cx"> {
</span><span class="cx"> for (auto& constantRegister : m_linkTimeConstantRegisters)
</span><span class="cx"> constantRegister = nullptr;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreftlFTLLowerDFGToLLVMcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -8616,7 +8616,7 @@
</span><span class="cx"> if (m_node->op() == TailCallInlinedCaller
</span><span class="cx"> || m_node->op() == TailCallVarargsInlinedCaller
</span><span class="cx"> || m_node->op() == TailCallForwardVarargsInlinedCaller)
</span><del>- codeOrigin =*codeOrigin.inlineCallFrame->getCallerSkippingDeadFrames();
</del><ins>+ codeOrigin = *codeOrigin.inlineCallFrame->getCallerSkippingDeadFrames();
</ins><span class="cx">
</span><span class="cx"> callPreflight(codeOrigin);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinterpreterInterpreterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/interpreter/Interpreter.h (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/interpreter/Interpreter.h 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/interpreter/Interpreter.h 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -278,7 +278,6 @@
</span><span class="cx">
</span><span class="cx"> inline CallFrame* calleeFrameForVarargs(CallFrame* callFrame, unsigned numUsedStackSlots, unsigned argumentCountIncludingThis)
</span><span class="cx"> {
</span><del>-#if 1
</del><span class="cx"> // We want the new frame to be allocated on a stack aligned offset with a stack
</span><span class="cx"> // aligned size. Align the size here.
</span><span class="cx"> argumentCountIncludingThis = WTF::roundUpToMultipleOf(
</span><span class="lines">@@ -286,7 +285,6 @@
</span><span class="cx"> argumentCountIncludingThis + JSStack::CallFrameHeaderSize) - JSStack::CallFrameHeaderSize;
</span><span class="cx">
</span><span class="cx"> // Align the frame offset here.
</span><del>-#endif
</del><span class="cx"> unsigned paddedCalleeFrameOffset = WTF::roundUpToMultipleOf(
</span><span class="cx"> stackAlignmentRegisters(),
</span><span class="cx"> numUsedStackSlots + argumentCountIncludingThis + JSStack::CallFrameHeaderSize);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Options.h (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Options.h 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/runtime/Options.h 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -131,7 +131,7 @@
</span><span class="cx"> v(bool, forceProfilerBytecodeGeneration, false, nullptr) \
</span><span class="cx"> \
</span><span class="cx"> v(bool, useFunctionDotArguments, true, nullptr) \
</span><del>- v(bool, useTailCalls, false, nullptr) \
</del><ins>+ v(bool, useTailCalls, true, nullptr) \
</ins><span class="cx"> \
</span><span class="cx"> /* dumpDisassembly implies dumpDFGDisassembly. */ \
</span><span class="cx"> v(bool, dumpDisassembly, false, "dumps disassembly of all JIT compiled code upon compilation") \
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestses6yaml"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/es6.yaml (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/es6.yaml 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/tests/es6.yaml 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -877,9 +877,9 @@
</span><span class="cx"> - path: es6/Promise_Promise[Symbol.species].js
</span><span class="cx"> cmd: runES6 :fail
</span><span class="cx"> - path: es6/proper_tail_calls_tail_call_optimisation_direct_recursion.js
</span><del>- cmd: runES6 :fail
</del><ins>+ cmd: runES6 :normal
</ins><span class="cx"> - path: es6/proper_tail_calls_tail_call_optimisation_mutual_recursion.js
</span><del>- cmd: runES6 :fail
</del><ins>+ cmd: runES6 :normal
</ins><span class="cx"> - path: es6/prototype_of_bound_functions_arrow_functions.js
</span><span class="cx"> cmd: runES6 :fail
</span><span class="cx"> - path: es6/prototype_of_bound_functions_basic_functions.js
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressdfgtailcallsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/dfg-tail-calls.js (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/dfg-tail-calls.js 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/tests/stress/dfg-tail-calls.js 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-//@ skip
</del><span class="cx"> (function nonInlinedTailCall() {
</span><span class="cx"> function callee() { if (callee.caller != nonInlinedTailCall) throw new Error(); }
</span><span class="cx"> noInline(callee);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressmutualtailcallnostackoverflowjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/mutual-tail-call-no-stack-overflow.js (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/mutual-tail-call-no-stack-overflow.js 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/tests/stress/mutual-tail-call-no-stack-overflow.js 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-//@ skip
</del><span class="cx"> function shouldThrow(func, errorMessage) {
</span><span class="cx"> var errorThrown = false;
</span><span class="cx"> var error = null;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstresstailcallininlinecachejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/tail-call-in-inline-cache.js (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/tail-call-in-inline-cache.js 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/tests/stress/tail-call-in-inline-cache.js 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-//@ skip
</del><span class="cx"> "use strict";
</span><span class="cx">
</span><span class="cx"> function tail() { }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstresstailcallnostackoverflowjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/tail-call-no-stack-overflow.js (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/tail-call-no-stack-overflow.js 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/tests/stress/tail-call-no-stack-overflow.js 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-//@ skip
</del><span class="cx"> function shouldThrow(func, errorMessage) {
</span><span class="cx"> var errorThrown = false;
</span><span class="cx"> var error = null;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstresstailcallrecognizejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/tail-call-recognize.js (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/tail-call-recognize.js 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/tests/stress/tail-call-recognize.js 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-//@ skip
</del><span class="cx"> function callerMustBeRun() {
</span><span class="cx"> if (!Object.is(callerMustBeRun.caller, runTests))
</span><span class="cx"> throw Error("Wrong caller, expected run but got ", callerMustBeRun.caller);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstresstailcallvarargsnostackoverflowjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/tail-call-varargs-no-stack-overflow.js (191174 => 191175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/tail-call-varargs-no-stack-overflow.js 2015-10-16 10:47:31 UTC (rev 191174)
+++ trunk/Source/JavaScriptCore/tests/stress/tail-call-varargs-no-stack-overflow.js 2015-10-16 14:43:02 UTC (rev 191175)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-//@ skip
</del><span class="cx"> function shouldThrow(func, errorMessage) {
</span><span class="cx"> var errorThrown = false;
</span><span class="cx"> var error = null;
</span></span></pre>
</div>
</div>
</body>
</html>